[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. In D36850#2958594 , @modimo wrote: > @tejohnson Indirect calls are not captured in FunctionSummaries in CallGraph > or in a flag form saying they exist. Also looks like >

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

tejohnson closed this revision. tejohnson added a comment. This was committed awhile back (d3f1f588f902a968f102d6cdaf052674efc257aa ), manually closing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

tejohnson added a comment. In D108881#2971651 , @tbaeder wrote: > That code has changed quite a bit since I've worked on it. > > The only problem I could see is that passing `-flto=thin -flto` and choosing > thin LTO kinda makes sense if you interpret `-

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

tejohnson added a comment. In D108881#2973516 , @steven_wu wrote: > I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` > parameter anymore. There are few minor places references `OPT_flto` or > `OPT_foffload_lto` can be cleane

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:25 // Checks if loop unroll is invoked by normal compile, but not thinlto compile. // SAMPLEPGO-LABEL: define {{(dso_local )?}}void @unroll It seems this test is expl

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

tejohnson added a comment. In D108881#2988016 , @steven_wu wrote: > In D108881#2987990 , @mnadeem wrote: > >> In D108881#2973735 , @steven_wu >> wrote: >> >>> In D108881#

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. In D36850#2968536 , @modimo wrote: > In D36850#2964293 , @tejohnson wrote: > >> Good point on indirect calls. Rather than add a bit to the summary, can the >> flags just be set conservati

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. In D36850#2990847 , @modimo wrote: > In D36850#2990771 , @tejohnson wrote: > >> In D36850#2968536 , @modimo wrote: >> >>> In D36850#2964293

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:28 +// The first Unroll loop pass is the createSimpleLoopUnrollPass that unrolls and peels +// loops with small constant trip counts. Only the second one is handled by ThinLTO. +// THIN

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234

<    2   3   4   5   6   7