[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille added a comment. Compile time tracker record : https://llvm-compile-time-tracker.com/compare.php?from=f71d32a0eea47b3d2bb43d6be15cf09d47ef6971&to=b4df7d2a01aacd29ae539b04e72b3667e2362aa1&stat=instructions:u The cost of preprocessing is hidden by the optimization time, but -O0 gi

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille updated this revision to Diff 475699. serge-sans-paille added a comment. Add extra assert to ensure we start lexing in a clean state CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137960/new/ https://reviews.llvm.org/D137960 Files: clang/include/clang/Lex/Token.h c

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3f8d53e6c3: [Lexer] Speedup LexTokenInternal (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D137960?vs=475699&id=475818#toc Repository: rG LLVM Github Monorepo

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3520-3521 +LexStart: + assert(!Result.needsCleaning() && "Result doesn't need cleaning"); + assert(!Result.hasPtrData() && "Result has been reset"); foad wrote: > Messages are backwa

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille created this revision. Herald added subscribers: kosarev, kerbowa, jvesely, emaste. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Cuda and rocm toolchain detectors a

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille added a comment. In D142606#4082753 , @tstellar wrote: > Does this mean that clang will no longer search for the ROCM and CUDA library > paths for every C compile? That's the goal, yes. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Can you take a shot against https://llvm-compile-time-tracker.com/ so that we get an hint of the practical speedup? Looks like xxhash.h is missing from the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Do you intend to (optionnaly) provide XXH3 as described in https://github.com/Cyan4973/xxHash ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. https://llvm-compile-time-tracker.com/compare.php?from=1a17739d3aa78599c32f6106e05dcfa7f3f9e823&to=9c1adc5fcca177d6628bdb22c72e7546c7b691aa&stat=instructions:u looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + zero9178 wrote: > Any reason this is `mutable`? I don't see it being used a non-const way in a > const method yeah, `T const

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142181/new/ https://reviews.llvm.org/D142181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille updated this revision to Diff 494877. serge-sans-paille added a comment. remove mutable qualifier CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142606/new/ https://reviews.llvm.org/D142606 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/A

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + zero9178 wrote: > serge-sans-paille wrote: > > zero9178 wrote: > > > Any reason this is `mutable`? I don't see it being used

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille updated this revision to Diff 494927. serge-sans-paille added a comment. Address @tbader's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142606/new/ https://reviews.llvm.org/D142606 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa2abf90886: Lazyly initialize uncommon toolchain detector (autho

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffaffcaac97: Reapply 6fa2abf90886f18472c87bc9bffbcdf4f73c465e (authored by serge-sans-paille). Repository: rG LLVM Git

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 488344. serge-sans-paille added a comment. Nits + rebase on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 Files: clang/lib/Driver/DriverOptions.cpp clang/lib/Driver/ToolChains/G

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added a comment. In D140800#4043723 , @nikic wrote: > Just to check, this isn't going to cause some warning spew about all those > OptTable implementations being non-final? nope. Why

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

serge-sans-paille updated this revision to Diff 488348. serge-sans-paille added a comment. nits + rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140699/new/ https://reviews.llvm.org/D140699 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/DriverOptions.c

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbe463d6ba26: [OptTable] Make ValuesCode initialisation of Options constexpr (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07bb29d8ffc3: [OptTable] Precompute OptTable prefixes union table through tablegen (authored by serge-sans-paille). Repository: rG LLVM Github Mon

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

serge-sans-paille added a comment. LGTM Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); random nit: This could be rewritten as ``` llvm::MutableArrayRef data(static_

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, nikic. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald a

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

serge-sans-paille updated this revision to Diff 490412. serge-sans-paille added a comment. Thanks @nikic for the review. Remarks taken into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142026/new/ https://reviews.llvm.org/D142026 Files: clang/lib/Driver/Driver.cpp llvm/in

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ad1b4095172: Optimize OptTable::findNearest implementation and usage (authored by serge-sans-paille). Changed prior to commit: https://reviews.ll

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille updated this revision to Diff 490804. serge-sans-paille added a comment. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang-tools-extra. Fix build + make StringLiteral initialization constexpr. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille added a comment. @nikic : I thought I fixed that with e8a163dc03e6913360beb305620104ba129c081c ... is it included in your build? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142181/new/ https://re

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

serge-sans-paille added a comment. > Plausibly caused by this change -- I'm thinking that `MaximumDistance` is > initialized to `UINT_MAX - 1`, but then we cast that to a signed integer and > compare that, so it wraps to a large negative number. @nikic : I thought I fixed that with e8a163dc03

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille added a comment. In D142181#4070881 , @nikic wrote: > In D142181#4070868 , > @serge-sans-paille wrote: > >> @nikic : I thought I fixed that with >> e8a163dc03e6913360beb305620104ba129c081c >>

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille updated this revision to Diff 491400. serge-sans-paille added a comment. Do not enfore StringLiteral parameter. This is too invasive on the code base. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142181/new/ https://reviews.llvm.org/D142181 Files: clang-tools-extra

[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

serge-sans-paille added a comment. This got fixed in d1f313e73a1b33d662dbab54be76720b9c875645 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142024/new/ https://reviews.llvm.org

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 435900. serge-sans-paille added a comment. Cleanup testcase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille marked 4 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/object-size-flex-array.c:34 + // CHECK: ret i32 % + // CHECK-STRICT: ret i32 % + return OBJECT_SIZE_BUILTIN(f->c, 1); kees wrote: > Shou

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Looks good on my side, waiting for feedback ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 436399. serge-sans-paille added a comment. - quiet output of the table conversion program when everything goes well - cross-compilation support (untested) - fix identifier retrieving CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille reopened this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. cc @thakis CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cfe-commit

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

serge-sans-paille updated this revision to Diff 436506. serge-sans-paille retitled this revision from "Confusable identifiers detection" to "[clang-tidy] Confusable identifiers detection". serge-sans-paille added a comment. Herald added a subscriber: xazax.hun. Address reviews CHANGES SINCE LAS

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

serge-sans-paille updated this revision to Diff 436739. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Take into account @aaron.ballman review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: cla

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille added a comment. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 does toward `-fstrict-flex-arrays=` with - `n=0` ⇒ `-fno-strict-flex-arrays`, current state (the default) - `n=1` ⇒ only consider `[ 0]`, `[1}` and `[ ]` as flex array member - `n=2` ⇒ only consider `[ 0]` and

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 437582. serge-sans-paille retitled this revision from "[clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays" to "[clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays". serge-sans-paille edited t

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, tbaeder. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #55560 Repository: rG LLVM Github Mon

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille added a comment. I"m not 100% sure of the fix but it fixes bug #55560 and does not introduce regression :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 _

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille updated this revision to Diff 438114. serge-sans-paille added a comment. (rebased on main branch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/SemaCXX/co

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille added a comment. This also seems to fix https://github.com/llvm/llvm-project/issues/37522 and https://github.com/llvm/llvm-project/issues/55315 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

serge-sans-paille updated this revision to Diff 438592. serge-sans-paille added a comment. Address most reviewers comment: - formatting style - reduced memory consumption - be clear about TR39 divergence - class and option renaming - getName() usage CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. @kees does the new version looks good to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D122677: [prototype] include-cleaner library

serge-sans-paille added a comment. Hey Sam, any update on this one? How can I help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122677/new/ https://reviews.llvm.org/D122677 ___ cfe-commits mailing list

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3574ef739fb: [clang-tidy] Confusable identifiers detection (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille updated this revision to Diff 439022. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/SemaCXX/constexpr-late-instantiation.cpp Index: clang/test/SemaCXX/con

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, aaron.ballman, tstellar. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This warning exist in GCC[0] and wa

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 439435. serge-sans-paille added a comment. Activate `-Warray-parameter` on `-Wmost` but disable it by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 439718. serge-sans-paille added a comment. Take review into account : rework indentation, style cleaning and be more accurate about bounds reporting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D12844

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. Thanks @MaskRay for the quick patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

serge-sans-paille updated this revision to Diff 433063. serge-sans-paille added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Updating test case / sorry for the delay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120484/new/ https://reviews.llvm.org/D120484

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1b86b639433: [Clang][Driver] More explicit message when failing to find sanitizer resource… (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D120484?vs=433063&id=43332

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille created this revision. serge-sans-paille added reviewers: george.burgess.iv, kees. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald a

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille added a comment. Note: I named the option `-fstrict-flex-arrays` and not `-fstrict-flex-array` because we already have `-fstrict-enums`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864

[PATCH] D112916: Confusable identifiers detection

This revision was automatically updated to reflect the committed changes. Closed by commit rGb94db7ed7eaf: [clang-tidy] Confusable identifiers detection (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D112916?vs=410776&id=433991#toc Repository: rG LLVM Gith

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 434040. serge-sans-paille added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang/include

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added a comment. Thanks @thakis for the post-commit review. I'll give it another try next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 __

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 435520. serge-sans-paille added a comment. Herald added a subscriber: martong. Take into account @efriedma and @kees review, plus adding a bunch of extra test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 435899. serge-sans-paille added a comment. Update changelog entry CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille created this revision. serge-sans-paille added reviewers: nickdesaulniers, jfb, aaron.ballman. Herald added a subscriber: kristof.beyls. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille added a comment. Comparison with GCC behavior here: https://godbolt.org/z/xc3j9jEsf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155580/new/ https://reviews.llvm.org/D155580 ___ cfe-co

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille updated this revision to Diff 541475. serge-sans-paille added a comment. switch from cascading ternary operator to cascading if for readability. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155580/new/ https://reviews.llvm.org/D155580 Files: clang/lib/CodeGen/CGDec

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille added a subscriber: jakubjelinek. serge-sans-paille added a comment. @jfb ok, makes sense. For the record it does show up in our profile but I have been able to workaround it without touching the compiler. This probably mean that the GCC implementation is having a small hole, @

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. gcc bug filled as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110816 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155580/new/ https://reviews.llvm.org/D155580 ___

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille created this revision. serge-sans-paille added reviewers: jfb, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This attrib

[PATCH] D157775: [clang] Add aliasee field to AliasAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposit

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157783: [clang] Add reason and replacement fields to DeprecatedAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille updated this revision to Diff 549644. serge-sans-paille retitled this revision from "[clang] Add reason and replacement fields to DeprecatedAttr json AST dump" to "[clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump". serge-sans-paille added a comment

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille updated this revision to Diff 549645. serge-sans-paille added a comment. + test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783 Files: clang/include/clang/AST/JSONNodeDumper.h clang/lib/AST/JSONNodeDumper.cpp clang

[PATCH] D157795: [clang] Add missing field to SectionAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

serge-sans-paille updated this revision to Diff 549717. serge-sans-paille added a comment. Fix typo in example CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157808/new/ https://reviews.llvm.org/D157808 Files: clang/include/clang/AST/JSONNodeDumper.h clang/lib/AST/JSONNodeDumper.cpp

[PATCH] D157814: [clang] Add missing field to TLSModelAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille updated this revision to Diff 549929. serge-sans-paille added a comment. Only output extra fields if they are not empty CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783 Files: clang/include/clang/AST/JSONNodeDumper.h clang

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Review taken into account. Thanks for handling this batch of patches o/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783

[PATCH] D157775: [clang] Add aliasee field to AliasAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11f3286585ce: [clang] Add aliasee field to AliasAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG903e530bb898: [clang] Add cleanup_function field to CleanupAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dadc290b210: [clang] Add missing fields to DeprecatedAttr and Unavailable json AST dump (authored by serge-sans-paille). Repository: rG LLVM Gith

[PATCH] D157795: [clang] Add missing field to SectionAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf7666b8f09: [clang] Add missing field to SectionAttr json AST dump (authored by serge-sans-paille). Changed prior to commit: https://reviews.llv

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2107d87c5a91: [clang] Add missing field to VisibilityAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D157814: [clang] Add missing field to TLSModelAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2105c32b32bf: [clang] Add missing field to TLSModelAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a side effect, introduce AtomicExpr::getOpAsString

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille updated this revision to Diff 545060. serge-sans-paille added a comment. Take reviewers comment into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille updated this revision to Diff 545074. serge-sans-paille added a comment. (rebased on `main`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

serge-sans-paille added inline comments. Comment at: clang/docs/ReleaseNotes.rst:125 * ``-Woverriding-t-option`` is renamed to ``-Woverriding-option``. * ``-Winterrupt-service-routine`` is renamed to ``-Wexcessive-regsave`` as a generalization ?? =

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. I don't have a strong opinion on the synchronization with `TextNodeDumper`. I'm pretty sure I didn't update it while adding fields for the Attribute nodes though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbccf3c6f13d: [clang] - Add missing builtin name to AtomicExpr JSON dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHA

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. In D158558#4616275 , @efocht wrote: > Can somebody please revert this patch? It kills all builds on > https://lab.llvm.org/buildbot/#/builders/91 since yesterday. > @serge-sans-paille ? This got reverted by https://r

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

serge-sans-paille added a comment. Jumping a bit late in the thread, apologize in advance if I missed something. The GCC version of the attributes seems to be `element_count` (as found in the link https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896 mentionned by @kees) I guess we could align (I

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:966 +// size. e.g.(("%#3x", 0xf) is "0xf") + +// If the result is zero, o, b, x, X adds nothing. Then couldn't we increase the Size if the `FieldWidth` is unspeci

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille added a comment. In D156337#4558410 , @aaron.ballman wrote: > Was there an RFC for this extension to the attribute? (There doesn't need to > be one, I'm just wondering if there's more background info on what's driving > this patch for

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, nikic, lattner. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LineOffsetMapping::get is a critical f

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

serge-sans-paille added a comment. Gentle ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138474/new/ https://reviews.llvm.org/D138474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

This revision was automatically updated to reflect the committed changes. Closed by commit rGf607884a04b0: [clang] Speedup LineOffsetMapping::get (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138474/new/ https://revi

[PATCH] D139188: [Draft] Sanitize clang target triple

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Warn when meeting an unknown vendor / os / environmen

[PATCH] D139188: [Draft] Sanitize clang target triple

serge-sans-paille added a comment. This is a tentative patch for https://discourse.llvm.org/t/linking-without-gcc-on-gnu-linux/66428/3 unfortunately it appears that many triples are not recognized while widely used (at least in the CI) for instance `aarch64-arm-none-eabi` is used a lot in the

<    1   2   3   4   5   6   7   8   9   >