[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191192. akhuang added a comment. Modify interestingness test to take file as input CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clan

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191199. akhuang marked an inline comment as done. akhuang added a comment. fixed array copy mistake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/u

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191217. akhuang marked 2 inline comments as done. akhuang added a comment. Fixed typo where it was writing the abspath of the file to the interestingness test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:106-117 + # Check that an empty file is not interesting + # file_to_reduce is hardcoded into the test, so this is a roundabout + # way to run it on an empty

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191409. akhuang added a comment. style things CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py ==

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191598. akhuang added a comment. style nits, fixed thing in getting path to clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang added a comment. @arichardson Will add you next time, sorry I didn't do so on this one! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 ___ cfe-commits mailing list cf

[PATCH] D59725: Additions to creduce script

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv, arichardson. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some more additions to the script - mainly reducing the clang args after the creduce run

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192145. akhuang added a comment. Fix some typos, pass --tidy flag to creduce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-cras

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192149. akhuang added a comment. reuploaded diff with full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py =

[PATCH] D59725: Additions to creduce script

akhuang marked 15 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:137 + +# If no message was found, use the top five stack trace functions, +# ignoring some common functions george.burgess.iv wrote: >

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192218. akhuang marked an inline comment as done. akhuang added a comment. Style nits, added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang

[PATCH] D59725: Additions to creduce script

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:223 + if len(x) > 0 and x[-1].startswith('-') and not y.startswith('-'): +x[-1] += ' ' + y +return x george.burgess.iv wro

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192230. akhuang added a comment. fix issue with grouping two command line args together CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce

[PATCH] D59725: Additions to creduce script

akhuang marked 8 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:145 + matches = re.findall(stacktrace_re, crash_output) + result = filter(lambda x: x and x.strip() not in filters, matches)[:5] + for msg in res

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192350. akhuang marked 2 inline comments as done. akhuang added a comment. Herald added a subscriber: jdoerfert. added to error message regexes and command line flags CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd. This will allow selecting the MS C runtime library without having to use cc1 flags.

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133457 Files: clang/include/clang/Driver/Options

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 459577. akhuang marked 2 inline comments as done. akhuang added a comment. Clean up test, add doc brief to new flag, try to put the flag logic in a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6480 + // Process Windows runtime flags (equivalent to cl flags /MD, /MDd, /MT, /MTd) + if (Triple.isOSWindows()) { hans wrote: > Could we somehow re-use the logic in Clang::Add

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang marked 3 inline comments as done. akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4442 +bool IsClangCL) { + unsigned RTOptionID = 0; // MT=0, MTd=1, MD=2, MDd=3 + bool HasLDdFlag = IsClangCL && Args.ha

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460154. akhuang marked an inline comment as done. akhuang added a comment. Address comments, more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files: cla

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460271. akhuang marked 3 inline comments as done. akhuang added a comment. more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files: clang/include/clang/

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4493 + + if (Args.hasArg(options::OPT__SLASH_Zl)) { +CmdArgs.push_back("-D_VC_NODEFAULTLIB"); mstorsjo wrote: > If I understand correctly, we still don't have any corresponding

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460456. akhuang added a comment. ran clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/To

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda44bedd64d: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang created this revision. akhuang added reviewers: mstorsjo, hans. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The /Zl flag omits default C runtime library name from obj files. This patc

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang added a comment. In D133959#3793283 , @hans wrote: > Could the new flag be marked as an Alias in the tablegen, so that we don't > need to do any code changes for it? It appears before _SLASH_Zl in the file so we'd have to move it out of place.

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462042. akhuang marked an inline comment as done. akhuang added a comment. Change name of flag, and alias /Zl to this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D13

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462230. akhuang marked an inline comment as done. akhuang added a comment. Fix flag name in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959 Files: clang/i

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG3283f71069a0: Add clang flag equivalent to clang-cl /Zl flag (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://review

[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

akhuang added a comment. We're seeing this warning in code with global constants, e.g. const Enum x = static_cast(-1); is this intended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131704/new/ https://reviews.llvm.org/D131704 ___

[PATCH] D130123: [Phabricator] extend ptr32 support to be applied on typedef

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 __

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. This patch adds an option to limit debug info by only emitting complete class type information when its constructor is emitted. This applies to clas

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang added a comment. > What's the plan for this? Is it still in an experimental stage, with the > intent to investigate the types that are no longer emitted unedr the flag & > explain why they're missing (& either have a justification for why that's > acceptable, or work on additional heuri

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.g

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 5 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.g

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237411. akhuang added a comment. Address comments - Removed driver option - Simplified test cases - Changed name of limited debug info from isFullDebug to hasReducedDebugInfo, which is maybe slightly less misleading Repository: rG LLVM Github Monorepo

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

akhuang added a comment. Looks like the first commit c958639098a8 is also causing a crash in chromium code, so I will revert that as well. I got a reduced test case: typedef void voidtype; struct S { voidtype a();

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG53539bb032d1: [DebugInfo] Add another level to DebugInfoKind called Constructor (authored by akhuang). Changed prior to c

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang added a comment. Committed debug info kind refactoring bit in fe7cda2e. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 ___ cfe-commits mailing list cfe

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237811. akhuang added a comment. -Remove redundant test case -Committed refactoring part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 Files: clang/lib/CodeGen/CGDe

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG651128f55722: [DebugInfo] Add option to clang to limit debug info that is emitted for classes. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D72427?vs=237811&id=238077#toc Re

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. This caused a linker error in chromium: ld.lld: error: undefined symbol: __warn_memset_zero_len Apparently now that the glibc memset is being used, __warn_memset_zero_len gets called from libc++ code (https://github.com/llvm/llvm-project/blob/b72a8c65e4e34779b6bc9e46

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. Reverted in 3d210ed3d1880c615776b07d1916edb400c245a6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

akhuang added a comment. In D72869#1824927 , @serge-sans-paille wrote: > @akhuang can you confirm this fixes your issue? I've tested locally and it > works fine on my side. Yes, this fixes the __warn_memset_zero_len issue, thanks! Repository: rG LL

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip literal types

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. In constructor type homing mode sometimes complete debug info for constexpr types was missing, because there was not a constructor emitted. This cha

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds DIFlagNonTrivial to forward declarations of DICompositeType. It adds the flag to nontrivial types and types with unknown trivialit

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang updated this revision to Diff 254942. akhuang added a comment. Change check to hasConstexprNonCopyMoveConstructor() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77432/new/ https://reviews.llvm.org/D77432 Files: clang/lib/CodeGen/CGDebug

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2263 if (DebugKind == codegenoptions::DebugInfoConstructor && - !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { -for (const auto *Ctor

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

This revision was automatically updated to reflect the committed changes. Closed by commit rG11a04a64aaa3: [DebugInfo] Change to constructor homing debug info mode: skip literal types (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcf66084eddd: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang closed this revision. akhuang added a comment. Committed in 9d070b2f4889887f9ce497592ef01df7b9601a1c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://re

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added a comment. yep, I'll look into it, probably sometime tomorrow-- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 ___ cfe-commits mailing list cfe-c

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:857-858 + OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false, +Binary ? llvm::sys::fs::OF_None +

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang created this revision. Herald added subscribers: dexonsmith, fedor.sergeev. akhuang requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Constructor homing reduces the amount of class type info that is emitted by emitti

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360621. akhuang added a comment. Herald added a subscriber: dang. Add an opt out flag: fno-use-ctor-homing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: cl

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. Realized it's probably a good idea to add an opt out flag (counterpart to fuse-ctor-homing). Also, maybe in a separate patch, maybe should make these clang flags instead of cc1 flags- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 +if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); probinson wrote: > No... you want to chec

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360918. akhuang added a comment. Remove fno-use-ctor-homing flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: clang/include/clang/Basic/DebugInfoOptions.h

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang created this revision. akhuang added reviewers: dblaikie, probinson. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an opt out flag for constructor homing. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without debug

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang updated this revision to Diff 360926. akhuang added a comment. Herald added a subscriber: dang. add actual flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106582/new/ https://reviews.llvm.org/D106582 Files: clang/docs/UsersManual.rst

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a comment. In D106582#2897599 , @dblaikie wrote: > Looks alright to me. (bit awkward having a documented cc1 option - since the > cc1 options aren't meant to be user facing - hadn't really thought > about/noticed that when reviewing the do

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a subscriber: jmorse. akhuang added a comment. In D106582#2897815 , @dblaikie wrote: > In D106582#2897678 , @akhuang wrote: > >> In D106582#2897599 , @dblaik

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e2ad26b08a2: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. yep, should be good now - I'll commit it soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 ___ cfe-commits mailing list cfe-commits@

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a3bf2953a92: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor)… (authored by akhuang). Repository: rG LLVM Github Mon

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang created this revision. akhuang added a reviewer: aaron.ballman. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're currently using address spaces to implement __ptr32/__ptr64 attributes; this patch fixes a bug where clang

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682 + isPtrSizeAddressSpace(Q2.getAddressSpace())) +MaybeQ1 = true; + else aaron.ballman wrote: > I'm pretty sure this is correct based on my inspection o

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

akhuang added a comment. Seems like there are also errors in chrome builds and the llvm compiler-rt build, will just revert it for now -- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 _

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682 + isPtrSizeAddressSpace(Q2.getAddressSpace())) +MaybeQ1 = true; + else aaron.ballman wrote: > akhuang wrote: > > aaron.ballman wrote: > > > I'm pretty

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang updated this revision to Diff 376936. akhuang added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110670/new/ https://reviews.llvm.org/D110670 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/CodeGen/ms-mixed-ptr-si

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7104e506619: [Sema] Allow comparisons between different ms ptr size address space types. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang created this revision. akhuang added reviewers: rnk, aganea, amccarth. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first wri

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:872 // using stdin. + void *FileHandle = nullptr; +#ifdef _WIN32 I'm saving the windows HANDLE here instead of using `fd` because for some reason calling `_get_osfhandle(fd)`

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added a comment. In D102736#2769358 , @amccarth wrote: > At some point, the duplicate handle must be closed. I don't see that > happening. I've added an inline comment where I think it should be done. > > (I find it weird that duplicating the h

[PATCH] D102876: Fix tmp files being left on Windows builds.

akhuang created this revision. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first writing to a .tmp file and then renaming to the fi

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang marked 2 inline comments as done. akhuang added a comment. In D102736#2769747 , @akhuang wrote: > In D102736#2769358 , @amccarth > wrote: > >> At some point, the duplicate handle must be closed. I don't

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 346882. akhuang added a comment. Change to using TempFiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 Files: clang/include/clang/Frontend/CompilerInstance.h

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang marked 2 inline comments as done. akhuang added a comment. In D102736#2767432 , @aganea wrote: > Do you think the existing crash tests can be modified to validate that .tmp > files are deleted indeed? Looks like the existing crash tests use `#pr

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 347090. akhuang marked an inline comment as done. akhuang added a comment. Use TempFile on both linux and windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 File

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: llvm/lib/Support/Path.cpp:1237 RenameEC = copy_file(TmpName, Name); setDeleteDisposition(H, true); } amccarth wrote: > I'm curious if this path has ever been exercised. > > I see that rename_handle is

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 347802. akhuang marked 5 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 Files: clang/include/cla

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang created this revision. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when searching for header files (with relative paths) we concatenate the path to the module map with the header filename. However when searchin

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang updated this revision to Diff 366153. akhuang added a comment. add case for include_nexts; I don't entirely understand this part of the code so not sure if it's what we want, but it seems to make building with -no-canonical-prefixes happier Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang updated this revision to Diff 366344. akhuang added a comment. undo previous change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107921/new/ https://reviews.llvm.org/D107921 Files: clang/lib/Lex/HeaderSearch.cpp Index: clang/lib/Lex/H

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, asmith. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This change checks for the return type in the frontend and adds a flag to the DISubroutineType to indicate that the option should

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:992 getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, Size, Align, llvm::DINode::FlagFwdDecl, Identifier); if (CGM.getCodeGenOpts().DebugFwdTe

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247104. akhuang added a comment. Just change CodeViewDebug to add CxxReturnUdt to all methods that return a record type, which appears to be consistent with what msvc does and avoids emitting two versions of the method in the pdb file. Repository: rG LLV

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang added a comment. In D75215#1899224 , @rnk wrote: > Now that I've gone this far... maybe we should just say `isNonTrivial() || > isFwdDecl()` -> mark it CxxReturnUdt. Something like that. I just tried this but apparently it ends up marking things

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247774. akhuang added a comment. Add FlagNonTrivial to fwd declared records in CGDebugInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/lib/CodeGen/CG

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247937. akhuang added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-i

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang added a comment. In D75215#1901961 , @rnk wrote: > BTW, I am curious to know if this helps V8 PDB size. IIRC you said there were > some PDBs in Chrome that have this problem a lot. I think I just noticed that the PDB size increased after enablin

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248003. akhuang added a comment. add back line in test that accidentally got deleted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/test/CodeGenCXX/debu

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248001. akhuang added a comment. Splitting the forward declaration flag into a different review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/test/Cod

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:989 + llvm::DINode::DIFlags Flags = llvm::DINode::FlagFwdDecl; + if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) +if (!CXXRD->hasDefinition() || ---

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248025. akhuang added a comment. remove tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp llvm/test/DebugIn

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3b21f02588: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) rnk wrote: > aprantl wrote: > > dblaikie wrote

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done and an inline comment as not done. akhuang added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) akhuang wrot

<    1   2   3   4   5   >