[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae6523cd62a4: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing… (authored by akhuang). Changed prior to commit: htt

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. For some reason the ctor homing case was before the template specialization case, and could have returned false too e

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ce5f7050d: [DebugInfo] Move constructor homing case in shouldOmitDefinition. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. In D86491#2235206 , @MaskRay wrote: > Note that Harbormaster actually reported the check-clang-codegencxx issues > B69369 .. Definitely my bad; I thought I had run check-clang locally before commi

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. just reopening to update the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 _

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang updated this revision to Diff 287748. akhuang added a comment. Fix errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-in

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang closed this revision. akhuang added a comment. ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8649

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang created this revision. akhuang added reviewers: aprantl, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. Herald added a subscriber: ormris. This adds the size to forward declared class

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035 + const RecordDecl *D = RD->getDefinition(); + if (D && D->isCompleteDefinition()) +Size = CGM.getContext().getTypeSize(Ty); dblaikie wrote: > When is a definition not a compl

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang updated this revision to Diff 289602. akhuang marked an inline comment as done. akhuang added a comment. remove assert; edit test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062 Files: clang/

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang updated this revision to Diff 289768. akhuang added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-cl

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035 + const RecordDecl *D = RD->getDefinition(); + if (D && D->isCompleteDefinition()) +Size = CGM.getContext().getTypeSize(Ty); akhuang wrote: > dblaikie wrote: > > When is a def

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf1a96408b1: [DebugInfo] Add size to class declarations in debug info. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. akhuang requested review of this revision. Previously ctor homing was omitting debug info for classes if they have both trival and nontrivial constructo

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

akhuang added a comment. In D84870#2182463 , @dblaikie wrote: > I think it'd be good to separate these two issues/patches. > > In part because I'm curious whether, even with a trivial ctor - if we did the > retained types thing - would that be enough? I

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

akhuang updated this revision to Diff 281722. akhuang added a comment. remove change to add class types to retained types list, also fix the test case to be a struct that previously didn't get complete debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf71deb43abea: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D84870?vs=281722&id=281785#toc Repository:

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang created this revision. akhuang added reviewers: dblaikie, aprantl, MaskRay. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. akhuang requested review of this revision. This adds a cc1 flag to enable constructor homing but doesn't turn on debug info if it wasn't e

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang updated this revision to Diff 285203. akhuang added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Comp

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang added a comment. Yep, just added a line to the existing ctor homing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 ___ cfe-commits mailing lis

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang added a comment. In D85799#2214330 , @dblaikie wrote: > If possible, could you test the negative cases too? That -fuse-ctor-homing > doesn't override -debug-info-kind=line-tables-only or no -debug-info-kind at > all? Oh, good point. Repository

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang updated this revision to Diff 285214. akhuang added a comment. Add more extensive check that -fuse-ctor-homing only does something when -debug-info-kind=limited Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.

[PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang updated this revision to Diff 276252. akhuang added a comment. Herald added a subscriber: fedor.sergeev. Instead of merging =constructor and =limited, change the default to use =constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7914

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

akhuang updated this revision to Diff 276778. akhuang added a comment. fix one more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79147/new/ https://reviews.llvm.org/D79147 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

This revision was automatically updated to reflect the committed changes. Closed by commit rG227db86a1b7d: Switch to using -debug-info-kind=constructor as default (from =limited) (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. This is causing a link error in the windows chromium build: lld-link: error: undefined symbol: _WinMain@16 >>> referenced by >>> D:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:102 >>> >>> msvcrtd.lib(exe_winmain.obj):(int __cdecl invoke_main(v

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. whoops, sorry for weird formatting in the previous comment. I'll revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___ cfe

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Basically, the code was checking if there were no constructors at all, but didn't check that there were any non copy/

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added a comment. In D87808#2282223 , @rnk wrote: > In D87808#2280197 , @dblaikie wrote: > >> @rsmith What's the deal with these anonymous structs/unions? Why do they >> have copy/move constructors (are thos

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2292-2300 + bool hasCtor = false; + for (const auto *Ctor : RD->ctors()) { if (Ctor->isTrivial() && !Ctor->isCopyOrMoveConstructor()) return false; +if (!Ctor->isCopyOrMoveConstructor()

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293579. akhuang added a comment. Update ctor homing check, and add some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files: clang/lib/CodeGen/CGDebugIn

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293817. akhuang marked an inline comment as done. akhuang added a comment. Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 294149. akhuang added a comment. Add to comment for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Cod

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8df781e54a4: [DebugInfo] Fix bug in constructor homing with classes with trivial (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Add class types to the retained types list to make sure they don't get dropped if the constructor is optimized out la

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4fc581d5fe: [DebugInfo] Add types from constructor homing to the retained types list. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. We used to only emit static const data members in CodeView as S_CONSTANTS when they

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. In D89072#2320209 , @dblaikie wrote: > I'll probably leave the llvm/CodeView parts of this for @rnk - but for the > clang parts, they should have corresponding clang test coverage & I'd be > curious to see the test for that to un

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 297068. akhuang added a comment. Update clang test for static data members, and make it test the general cases on the windows target as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://rev

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Debug info for inline static data members was missing the constant value, because the initializer for these static da

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang added a subscriber: rsmith. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1421-1425 + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { +// Inline static data members might not have an initialization. +if (

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang updated this revision to Diff 298243. akhuang added a comment. update test case and add check for dependent values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89286/new/ https://reviews.llvm.org/D89286 Files: clang/lib/CodeGen/CGDebugI

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 298258. akhuang marked an inline comment as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/C

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +//

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

akhuang added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); arichardson wrote: > arsenm

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added a comment. Whoops, forgot to check the tests. Apparently `mapEncodedInteger` asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 300438. akhuang added a comment. Fix test failures; remove assert for signed APSInts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/CGDebug

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG515973222ed2: [CodeView] Emit static data members as S_CONSTANTs. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. Patch to emit signed ints for other S_CONSTANTs: https://reviews.llvm.org/D90199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 ___ cfe-

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. Reverted because my copied `isUnsignedDIType` function had problems (guess I copied it at first but then was messing with the code); I moved it to DebugHandlerBase.h so it doesn't need to be

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 301080. akhuang added a comment. Herald added a subscriber: jfb. Moved isUnsignedDIType to DebugHandlerBase to avoid copying it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7669f3c0f69d: Recommit "[CodeView] Emit static data members as S_CONSTANTs." (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. There are some types in libcxx that are used but their constructors are not called (__hash_node, __hash_value_typ

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. No, chromium doesn't need this fixed in clang, but I didn't see a clear way to fix this in libc++. Do you think it should be fixed as a bug in libc++? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90719/new/ https://review

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang created this revision. akhuang added reviewers: hans, thakis. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make clang-cl error when a function definition is missing 'noexcept', and succeed without warnings when missing '_

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang updated this revision to Diff 397760. akhuang marked an inline comment as done. akhuang added a comment. Fix warning behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116256/new/ https://reviews.llvm.org/D116256 Files: clang/include

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang added a comment. In D116256#3215801 , @thakis wrote: > Thanks for the patch! This looks roughly right to me. > > Maybe the list of ESTs that are allowed to be mismatched should be opt-in > instead of opt-out? (i.e. instead of checking for "not ES

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang updated this revision to Diff 397930. akhuang marked an inline comment as done. akhuang added a comment. Add std=c++17 to the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116256/new/ https://reviews.llvm.org/D116256 Files: clang/i

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28d2977ff236: [-fms-extensions] Make some exception specification warnings/errors compatible… (authored by akhuang). Repository: rG LLVM Github Mo

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319668. akhuang added a comment. make function return lambda string, and add test for lambda in function parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Fil

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd73564c51003: [DebugInfo][CodeView] Use as the display name for lambdas. (authored by akhuang). Changed prior to commit: https://review

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 320020. akhuang added a comment. Fix test / string code after test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clang/AST/Mangle.h

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5f5deee9ee9: Reland "[DebugInfo][CodeView] Use as the display name for lambdas" (authored by akhuang). Repository: rG LLVM Github Mono

[PATCH] D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding this, since there's currently no documentation about this. Repository: rG LLVM Github Monorepo https:

[PATCH] D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26e9c99010b6: [Docs] Add some documentation for constructor homing, a debug info optimization… (authored by akhuang). Repository: rG LLVM Github M

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

akhuang added a comment. In Chrome we noticed that plugin flags are not being roundtripped (and build fails with `error: Generated arguments do not match in round-trip`): example of the differing args: "-plugin-arg-blink-gc-plugin" "no-members-in-stack-allocated" "-plugin-arg-find-bad-con

[PATCH] D99879: [clang][cli] Ensure plugin args are generated in deterministic order

akhuang added a comment. also just confirming that this fixes the issue we were seeing in Chrome Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99879/new/ https://reviews.llvm.org/D99879 ___ cfe-commits m

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

akhuang added a comment. think this looks good overall; maybe it should also have an IR to codeview test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 ___ cfe-

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, rsmith. Herald added a reviewer: aaron.ballman. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was motivated by the fact that constructor type homing (debu

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang marked an inline comment as done. akhuang added a comment. In D97411#2586201 , @dblaikie wrote: > Oh, that might be a bit different again - if the type isn't required to be > complete in this translation unit, should this attribute override the >

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1665 + let Spellings = [Clang<"force_debug_if_required_type">]; + let Subjects = SubjectList<[CXXRecord]>; + let Documentation = [Undocumented]; dblaikie wrote: > aaron.ballman wrote:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a subscriber: ldionne. akhuang added a comment. @ldionne Do you think it'd be reasonable to add this debug info attribute to some types in libc++? (For types that have constructors but don't call them; some previous discussion in https://reviews.llvm.org/D90719). Repository: rG

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326438. akhuang marked an inline comment as done. akhuang added a comment. -Add LangOpts[CPlusPlus] to the attribute -Maybe change the attribute to also override required complete types and change name to standalone_debug Repository: rG LLVM Github Monore

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326738. akhuang marked an inline comment as done. akhuang added a comment. -Add documentation -Add more test cases and semantics tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.ll

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2591030 , @aaron.ballman wrote: > Thanks! I am still curious about the forward declare/redeclaration behavior > and whether that is a situation that makes sense or not. I suspect this case > may make sense (and likely

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326787. akhuang marked 3 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2594345 , @ldionne wrote: > I don't have an opinion about the attribute itself. I do have an opinion > about using that attribute in libc++ instead of fixing the underlying issue > (I think we shouldn't do it). Can you

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2595155 , @dblaikie wrote: > In D97411#2595049 , @akhuang wrote: > >> In D97411#2594345 , @ldionne wrote: >> >>> I don't have an opinion ab

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. I think they're all singular types, like __hash_node . Actually, `__tree_node` might not be problematic. I could look more at the types if it's helpful; I

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. In D90719#2377485 , @dblaikie wrote: > In D90719#2377324 , @rnk wrote: > >> I had another thought, which is that even if it is UB, perhaps we really >> shouldn't be using UB as the basis fo

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a subscriber: ldionne. akhuang added a comment. + @ldionne for libc++ input? To summarize, this constructor homing debug info optimization makes the assumption that if a class is being used then its constructor must have been called at some point. We noticed that some libc++ types

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. This was motivated by changes to llvm's `not --crash` disabling symbolization but I ended up removing `not` from the script entirely because it returns d

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang updated this revision to Diff 304964. akhuang marked an inline comment as done. akhuang added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91372/new/ https://reviews.llvm.org/D91372 Files: clang/utils/creduce-

[PATCH] D91372: Some updates/fixes to the creduce script.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c80b542d38b: Some updates/fixes to the creduce script. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. Ok, it seems like the general opinion here is that libc++ should be changed in some way and not ctor homing. I don't know who'd be responsible for changing the libc++ code, though. Maybe I should file a bug for libc++? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. Thanks, looks like I'll try to see if libcxx code can be changed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90719/new/ https://reviews.llvm.org/D90719 ___ cfe-commits ma

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a reviewer: EricWF. akhuang added a subscriber: EricWF. akhuang added a comment. @EricWF, comments on using this attribute in libc++ vs fixing the code otherwise? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://revie

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

akhuang created this revision. akhuang added a reviewer: rnk. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The MSVC runtime library doesn't have a definition for wmemchr, so provide an inline implementation. Repository: rG LL

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 330316. akhuang added a comment. Herald added a subscriber: jdoerfert. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang/Bas

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 330344. akhuang added a comment. add allowInC to attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cd208f08af: [DebugInfo] Add an attribute to force type info to be emitted for types that… (authored by akhuang). Repository: rG LLVM Github Mono

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

akhuang updated this revision to Diff 330826. akhuang marked an inline comment as done. akhuang added a comment. add CHECK line to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98472/new/ https://reviews.llvm.org/D98472 Files: clang/lib/Cod

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5352dd9dab1: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms. (authored by akhuang). Repository: rG LLVM Github Monorepo CH

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2611142 , @probinson wrote: > In D97411#2598625 , @akhuang wrote: > >> I started looking into some diffs of debug info in libc++ tests, but it's >> pretty hard to tell what's diff

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. > Hmm - is that type used in a way that invokes Undefined Behavior? Or is this > a gap/bug in the ctor homing? I thought there was already a special case for > constexpr ctors that opted them out of ctor homing. Right, I think the constexpr is only used in >c++17 for so

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2642782 , @dblaikie wrote: > In D97411#2642194 , @akhuang wrote: > >>> Hmm - is that type used in a way that invokes Undefined Behavior? Or is >>> this a gap/bug in the ctor homin

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

akhuang added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:886 + } // FIXME: Path to compiler and command line. PDB is intentionally blank unless // we implement /Zi type servers. Can the 'path to compiler and command line' p

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/ https://reviews.llvm.org/D81481

[PATCH] D94325: [DebugInfo][CodeView] Use a fancier function display name when using line tables only to better differentiate between functions.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added a subscriber: hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously we emitted the fully qualified name when using

<    1   2   3   4   5   >