[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This adds a clang option to disable inline line tables. When it is used, the inliner uses the call site as the location of the inlined f

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 220756. akhuang marked 3 inline comments as done. akhuang added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files: clang/include/cla

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid parsing __pragma into an annotation token when macro arguments are pre-expanded. This is what clang currently does when parsing _Pragmas. Fixes https://bugs.llvm.org/show_bug.cgi?id=41128,

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang updated this revision to Diff 222464. akhuang added a comment. comments/whitespace/test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews.llvm.org/D68114 Files: clang/lib/Lex/Pragma.cpp clang/test/Preprocessor/pr

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang updated this revision to Diff 223255. akhuang added a comment. - move TokenCollector out of function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews.llvm.org/D68114 Files: clang/lib/Lex/Pragma.cpp clang/test/Pr

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL373950: Fix for expanding __pragmas in macro arguments (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 224681. akhuang marked 2 inline comments as done. akhuang added a comment. Herald added a subscriber: ormris. -Remove intrinsics debug info -Add inliner test -Add to function attribute description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 224687. akhuang added a comment. - Remove extra ifs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files: clang/include/clang/Basic/CodeGenOptions.def clang/inclu

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224697. akhuang marked an inline comment as done. akhuang added a comment. Fix code so that -gno-inline-line-tables works when not codeview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://revie

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224711. akhuang added a comment. - Set location to line 0 with getMergedLocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files: clang/include/clang/Basic/Code

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224888. akhuang added a comment. - Set inlined locations to line 0 - Fix to remove all debug info intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files: cl

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224909. akhuang added a comment. - Fixes for DbgInfoIntrinsic type and change test cmd Reverted the line 0 change - I wasn't sure if it would be an issue since the debugger doesn't step through those lines. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 225104. akhuang marked an inline comment as done. akhuang added a comment. Address comment about bad decrementing iterator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D677

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added a comment. @DarkShadow44 Thanks for finding this bug! I haven't had time to look at this for a while but will start working on it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66827/new/ https://reviews.llvm.org/D66827 _

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

akhuang added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:886 + } // FIXME: Path to compiler and command line. PDB is intentionally blank unless // we implement /Zi type servers. Can the 'path to compiler and command line' p

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

akhuang added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); arichardson wrote: > arsenm

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. akhuang requested review of this revision. Previously ctor homing was omitting debug info for classes if they have both trival and nontrivial constructo

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

akhuang added a comment. In D84870#2182463 , @dblaikie wrote: > I think it'd be good to separate these two issues/patches. > > In part because I'm curious whether, even with a trivial ctor - if we did the > retained types thing - would that be enough? I

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

akhuang updated this revision to Diff 281722. akhuang added a comment. remove change to add class types to retained types list, also fix the test case to be a struct that previously didn't get complete debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf71deb43abea: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D84870?vs=281722&id=281785#toc Repository:

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip literal types

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. In constructor type homing mode sometimes complete debug info for constexpr types was missing, because there was not a constructor emitted. This cha

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds DIFlagNonTrivial to forward declarations of DICompositeType. It adds the flag to nontrivial types and types with unknown trivialit

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang updated this revision to Diff 254942. akhuang added a comment. Change check to hasConstexprNonCopyMoveConstructor() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77432/new/ https://reviews.llvm.org/D77432 Files: clang/lib/CodeGen/CGDebug

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2263 if (DebugKind == codegenoptions::DebugInfoConstructor && - !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { -for (const auto *Ctor

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

This revision was automatically updated to reflect the committed changes. Closed by commit rG11a04a64aaa3: [DebugInfo] Change to constructor homing debug info mode: skip literal types (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcf66084eddd: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/ https://reviews.llvm.org/D81481

[PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang updated this revision to Diff 276252. akhuang added a comment. Herald added a subscriber: fedor.sergeev. Instead of merging =constructor and =limited, change the default to use =constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7914

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

akhuang updated this revision to Diff 276778. akhuang added a comment. fix one more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79147/new/ https://reviews.llvm.org/D79147 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

This revision was automatically updated to reflect the committed changes. Closed by commit rG227db86a1b7d: Switch to using -debug-info-kind=constructor as default (from =limited) (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang created this revision. Herald added subscribers: lldb-commits, cfe-commits, aprantl. Herald added projects: clang, LLDB. There will be an RFC for this in cfe-dev. This reduces the amount of class debug info emitted in Limited debug info mode. Repository: rG LLVM Github Monorepo https:

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang created this revision. akhuang added reviewers: dblaikie, aprantl, MaskRay. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. akhuang requested review of this revision. This adds a cc1 flag to enable constructor homing but doesn't turn on debug info if it wasn't e

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang updated this revision to Diff 285203. akhuang added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Comp

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang added a comment. Yep, just added a line to the existing ctor homing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 ___ cfe-commits mailing lis

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang added a comment. In D85799#2214330 , @dblaikie wrote: > If possible, could you test the negative cases too? That -fuse-ctor-homing > doesn't override -debug-info-kind=line-tables-only or no -debug-info-kind at > all? Oh, good point. Repository

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang updated this revision to Diff 285214. akhuang added a comment. Add more extensive check that -fuse-ctor-homing only does something when -debug-info-kind=limited Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae6523cd62a4: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing… (authored by akhuang). Changed prior to commit: htt

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd. This will allow selecting the MS C runtime library without having to use cc1 flags.

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133457 Files: clang/include/clang/Driver/Options

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 459577. akhuang marked 2 inline comments as done. akhuang added a comment. Clean up test, add doc brief to new flag, try to put the flag logic in a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6480 + // Process Windows runtime flags (equivalent to cl flags /MD, /MDd, /MT, /MTd) + if (Triple.isOSWindows()) { hans wrote: > Could we somehow re-use the logic in Clang::Add

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang marked 3 inline comments as done. akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4442 +bool IsClangCL) { + unsigned RTOptionID = 0; // MT=0, MTd=1, MD=2, MDd=3 + bool HasLDdFlag = IsClangCL && Args.ha

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460154. akhuang marked an inline comment as done. akhuang added a comment. Address comments, more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files: cla

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460271. akhuang marked 3 inline comments as done. akhuang added a comment. more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files: clang/include/clang/

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4493 + + if (Args.hasArg(options::OPT__SLASH_Zl)) { +CmdArgs.push_back("-D_VC_NODEFAULTLIB"); mstorsjo wrote: > If I understand correctly, we still don't have any corresponding

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460456. akhuang added a comment. ran clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/To

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda44bedd64d: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang created this revision. akhuang added reviewers: mstorsjo, hans. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The /Zl flag omits default C runtime library name from obj files. This patc

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang created this revision. Herald added subscribers: dexonsmith, fedor.sergeev. akhuang requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Constructor homing reduces the amount of class type info that is emitted by emitti

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360621. akhuang added a comment. Herald added a subscriber: dang. Add an opt out flag: fno-use-ctor-homing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: cl

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. Realized it's probably a good idea to add an opt out flag (counterpart to fuse-ctor-homing). Also, maybe in a separate patch, maybe should make these clang flags instead of cc1 flags- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 +if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); probinson wrote: > No... you want to chec

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360918. akhuang added a comment. Remove fno-use-ctor-homing flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: clang/include/clang/Basic/DebugInfoOptions.h

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang created this revision. akhuang added reviewers: dblaikie, probinson. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an opt out flag for constructor homing. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without debug

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang updated this revision to Diff 360926. akhuang added a comment. Herald added a subscriber: dang. add actual flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106582/new/ https://reviews.llvm.org/D106582 Files: clang/docs/UsersManual.rst

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a comment. In D106582#2897599 , @dblaikie wrote: > Looks alright to me. (bit awkward having a documented cc1 option - since the > cc1 options aren't meant to be user facing - hadn't really thought > about/noticed that when reviewing the do

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a subscriber: jmorse. akhuang added a comment. In D106582#2897815 , @dblaikie wrote: > In D106582#2897678 , @akhuang wrote: > >> In D106582#2897599 , @dblaik

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e2ad26b08a2: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. yep, should be good now - I'll commit it soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 ___ cfe-commits mailing list cfe-commits@

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a3bf2953a92: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor)… (authored by akhuang). Repository: rG LLVM Github Mon

[PATCH] D130123: [Phabricator] extend ptr32 support to be applied on typedef

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 __

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. Pinging reviewers -- are there any other concerns on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 ___ cfe-commits mailin

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang closed this revision. akhuang added a comment. Commited in r370083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 ___ cfe-commits mailing list cfe-comm

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang created this revision. akhuang added reviewers: rnk, rsmith. Herald added subscribers: llvm-commits, cfe-commits, erik.pilkington, hiraditya, nhaehnle, jvesely, jholewinski. Herald added projects: clang, LLVM. Previously, these qualifiers were being parsed but otherwise ignored. This chan

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 217940. akhuang marked 4 inline comments as done. akhuang added a comment. - Test that codegen adds the correct address spaces - Modify microsoft mangling to match microsoft mangling. - add comment for overloading Repository: rG LLVM Github Monorepo CHANG

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1874 +case LangAS::ptr32_sptr: + Extra.mangleSourceName("_ASPtr32_sptr"); + break; rnk wrote: > Hm, we should actually mangle thes

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

akhuang added a comment. What is the reason for this change? The test case and comment changes don't seem related to the actual code change, which would affect `DIGlobalVariable`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://r

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 218795. akhuang added a comment. - Change existing tests so they still pass - Fix so that it parses all the __ptr32/64 attributes instead of just the last one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66827

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. This patch adds an option to limit debug info by only emitting complete class type information when its constructor is emitted. This applies to clas

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang added a comment. > What's the plan for this? Is it still in an experimental stage, with the > intent to investigate the types that are no longer emitted unedr the flag & > explain why they're missing (& either have a justification for why that's > acceptable, or work on additional heuri

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.g

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 5 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.g

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237411. akhuang added a comment. Address comments - Removed driver option - Simplified test cases - Changed name of limited debug info from isFullDebug to hasReducedDebugInfo, which is maybe slightly less misleading Repository: rG LLVM Github Monorepo

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

akhuang added a comment. Looks like the first commit c958639098a8 is also causing a crash in chromium code, so I will revert that as well. I got a reduced test case: typedef void voidtype; struct S { voidtype a();

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG53539bb032d1: [DebugInfo] Add another level to DebugInfoKind called Constructor (authored by akhuang). Changed prior to c

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang added a comment. Committed debug info kind refactoring bit in fe7cda2e. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 ___ cfe-commits mailing list cfe

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237811. akhuang added a comment. -Remove redundant test case -Committed refactoring part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 Files: clang/lib/CodeGen/CGDe

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG651128f55722: [DebugInfo] Add option to clang to limit debug info that is emitted for classes. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D72427?vs=237811&id=238077#toc Re

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. This caused a linker error in chromium: ld.lld: error: undefined symbol: __warn_memset_zero_len Apparently now that the glibc memset is being used, __warn_memset_zero_len gets called from libc++ code (https://github.com/llvm/llvm-project/blob/b72a8c65e4e34779b6bc9e46

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. Reverted in 3d210ed3d1880c615776b07d1916edb400c245a6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. This is causing a link error in the windows chromium build: lld-link: error: undefined symbol: _WinMain@16 >>> referenced by >>> D:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:102 >>> >>> msvcrtd.lib(exe_winmain.obj):(int __cdecl invoke_main(v

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. whoops, sorry for weird formatting in the previous comment. I'll revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___ cfe

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Basically, the code was checking if there were no constructors at all, but didn't check that there were any non copy/

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added a comment. In D87808#2282223 , @rnk wrote: > In D87808#2280197 , @dblaikie wrote: > >> @rsmith What's the deal with these anonymous structs/unions? Why do they >> have copy/move constructors (are thos

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2292-2300 + bool hasCtor = false; + for (const auto *Ctor : RD->ctors()) { if (Ctor->isTrivial() && !Ctor->isCopyOrMoveConstructor()) return false; +if (!Ctor->isCopyOrMoveConstructor()

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293579. akhuang added a comment. Update ctor homing check, and add some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files: clang/lib/CodeGen/CGDebugIn

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293817. akhuang marked an inline comment as done. akhuang added a comment. Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 294149. akhuang added a comment. Add to comment for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Cod

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8df781e54a4: [DebugInfo] Fix bug in constructor homing with classes with trivial (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. For some reason the ctor homing case was before the template specialization case, and could have returned false too e

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ce5f7050d: [DebugInfo] Move constructor homing case in shouldOmitDefinition. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. In D86491#2235206 , @MaskRay wrote: > Note that Harbormaster actually reported the check-clang-codegencxx issues > B69369 .. Definitely my bad; I thought I had run check-clang locally before commi

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. just reopening to update the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 _

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang updated this revision to Diff 287748. akhuang added a comment. Fix errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-in

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang closed this revision. akhuang added a comment. ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8649

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang created this revision. akhuang added reviewers: aprantl, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. Herald added a subscriber: ormris. This adds the size to forward declared class

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035 + const RecordDecl *D = RD->getDefinition(); + if (D && D->isCompleteDefinition()) +Size = CGM.getContext().getTypeSize(Ty); dblaikie wrote: > When is a definition not a compl

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang updated this revision to Diff 289602. akhuang marked an inline comment as done. akhuang added a comment. remove assert; edit test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062 Files: clang/

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang updated this revision to Diff 289768. akhuang added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-cl

<    1   2   3   4   5   >