[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

akhuang added a comment. What is the reason for this change? The test case and comment changes don't seem related to the actual code change, which would affect `DIGlobalVariable`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 218795. akhuang added a comment. - Change existing tests so they still pass - Fix so that it parses all the __ptr32/64 attributes instead of just the last one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This adds a clang option to disable inline line tables. When it is used, the inliner uses the call site as the location of the inlined

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 220756. akhuang marked 3 inline comments as done. akhuang added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files:

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. The llvm-dev discussion is here http://lists.llvm.org/pipermail/llvm-dev/2019-July/134035.html I think the consensus is that it should be fine to change the data layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. For some reason the tests were failing before without the datalayout change? I'm not sure why, but I changed them back and they're fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang updated this revision to Diff 214202. akhuang added a comment. Remove test case changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. @lebedev.ri The test case datalayout strings were changed because somewhere llvm asserts that the string in the IR matches the backend datalayout. I don't know why I wasn't getting the assert error now, but I think they'll all have to be changed if we change the X86

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. > Can you post a reproducer? Turns out I just didn't have assertions enabled. With assertions the changed test cases should fail. > I think this is precisely what was discussed in replies to RFC - this > hardcodes these address spaces, and thus either makes them

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid parsing __pragma into an annotation token when macro arguments are pre-expanded. This is what clang currently does when parsing _Pragmas. Fixes

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang updated this revision to Diff 222464. akhuang added a comment. comments/whitespace/test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews.llvm.org/D68114 Files: clang/lib/Lex/Pragma.cpp

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added a comment. I split off the backend changes into a separate patch -> https://reviews.llvm.org/D69639 The issue with passing 0 for a pointer should be fixed there. @DarkShadow44 Some of the differences come from the fact that we're implementing the mixed pointer sizes with three

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d0389038451: [CodeView] Add option to disable inline line tables. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang added a comment. Seems like this is good to be committed then. And it sounds like implementing more thresholds would be useful to do in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang created this revision. akhuang added reviewers: rnk, rsmith. Herald added subscribers: cfe-commits, nhaehnle, jvesely, jholewinski. Herald added a project: clang. This adds parsing of the qualifiers __ptr32, __ptr64, __sptr, and __uptr and lowers them to the corresponding address space

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang abandoned this revision. akhuang added a comment. I split this into two reviews-- the backend part is landed and the frontend part is at https://reviews.llvm.org/D71039. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71098: Handle two corner cases in creduce-clang-crash.py

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71098/new/ https://reviews.llvm.org/D71098

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 234125. akhuang marked 8 inline comments as done. akhuang added a comment. - Added docs for __ptr32, __ptr64, __sptr, __utr - Moved some functions into ASTContext - and addressed other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added inline comments. Comment at: clang/include/clang/AST/Type.h:477-479 + ((isPtrSizeAddressSpace(A) && B == LangAS::Default) || +(isPtrSizeAddressSpace(B) && A == LangAS::Default) || +(isPtrSizeAddressSpace(A) &&

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 225104. akhuang marked an inline comment as done. akhuang added a comment. Address comment about bad decrementing iterator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224909. akhuang added a comment. - Fixes for DbgInfoIntrinsic type and change test cmd Reverted the line 0 change - I wasn't sure if it would be an issue since the debugger doesn't step through those lines. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added a comment. @DarkShadow44 Thanks for finding this bug! I haven't had time to look at this for a while but will start working on it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66827/new/ https://reviews.llvm.org/D66827

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL373950: Fix for expanding __pragmas in macro arguments (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang updated this revision to Diff 223255. akhuang added a comment. - move TokenCollector out of function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews.llvm.org/D68114 Files: clang/lib/Lex/Pragma.cpp

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 224687. akhuang added a comment. - Remove extra ifs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 224681. akhuang marked 2 inline comments as done. akhuang added a comment. Herald added a subscriber: ormris. -Remove intrinsics debug info -Add inliner test -Add to function attribute description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224697. akhuang marked an inline comment as done. akhuang added a comment. Fix code so that -gno-inline-line-tables works when not codeview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224711. akhuang added a comment. - Set location to line 0 with getMergedLocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files:

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224888. akhuang added a comment. - Set inlined locations to line 0 - Fix to remove all debug info intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files:

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa85f5efd9597: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, asmith. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This change checks for the return type in the frontend and adds a flag to the DISubroutineType to indicate that the option

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang added a comment. In D75215#1901961 , @rnk wrote: > BTW, I am curious to know if this helps V8 PDB size. IIRC you said there were > some PDBs in Chrome that have this problem a lot. I think I just noticed that the PDB size increased after

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247937. akhuang added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3b21f02588: [DebugInfo] Fix for adding returns cxx udt option to functions in CodeView. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248001. akhuang added a comment. Splitting the forward declaration flag into a different review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:989 + llvm::DINode::DIFlags Flags = llvm::DINode::FlagFwdDecl; + if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) +if (!CXXRD->hasDefinition() ||

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248003. akhuang added a comment. add back line in test that accidentally got deleted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248025. akhuang added a comment. remove tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:992 getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, Size, Align, llvm::DINode::FlagFwdDecl, Identifier); if

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done and an inline comment as not done. akhuang added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) akhuang

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247774. akhuang added a comment. Add FlagNonTrivial to fwd declared records in CGDebugInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang added a comment. In D75215#1899224 , @rnk wrote: > Now that I've gone this far... maybe we should just say `isNonTrivial() || > isFwdDecl()` -> mark it CxxReturnUdt. Something like that. I just tried this but apparently it ends up marking

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247104. akhuang added a comment. Just change CodeViewDebug to add CxxReturnUdt to all methods that return a record type, which appears to be consistent with what msvc does and avoids emitting two versions of the method in the pdb file. Repository: rG

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. This patch adds an option to limit debug info by only emitting complete class type information when its constructor is emitted. This applies to

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237411. akhuang added a comment. Address comments - Removed driver option - Simplified test cases - Changed name of limited debug info from isFullDebug to hasReducedDebugInfo, which is maybe slightly less misleading Repository: rG LLVM Github Monorepo

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 5 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue ) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); +

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. This caused a linker error in chromium: ld.lld: error: undefined symbol: __warn_memset_zero_len Apparently now that the glibc memset is being used, __warn_memset_zero_len gets called from libc++ code

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. Reverted in 3d210ed3d1880c615776b07d1916edb400c245a6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

akhuang added a comment. Looks like the first commit c958639098a8 is also causing a crash in chromium code, so I will revert that as well. I got a reduced test case: typedef void voidtype; struct S { voidtype a();

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG651128f55722: [DebugInfo] Add option to clang to limit debug info that is emitted for classes. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D72427?vs=237811=238077#toc

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237811. akhuang added a comment. -Remove redundant test case -Committed refactoring part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 Files:

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG53539bb032d1: [DebugInfo] Add another level to DebugInfoKind called Constructor (authored by akhuang). Changed prior to

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

akhuang added a comment. In D72869#1824927 , @serge-sans-paille wrote: > @akhuang can you confirm this fixes your issue? I've tested locally and it > works fine on my side. Yes, this fixes the __warn_memset_zero_len issue, thanks! Repository: rG

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang added a comment. > What's the plan for this? Is it still in an experimental stage, with the > intent to investigate the types that are no longer emitted unedr the flag & > explain why they're missing (& either have a justification for why that's > acceptable, or work on additional

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue ) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); +

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang added a comment. Committed debug info kind refactoring bit in fe7cda2e. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 ___ cfe-commits mailing list

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) rnk wrote: > aprantl wrote: > > dblaikie

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcf66084eddd: [DebugInfo] Fix for adding returns cxx udt option to functions in CodeView. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

This revision was automatically updated to reflect the committed changes. Closed by commit rG11a04a64aaa3: [DebugInfo] Change to constructor homing debug info mode: skip literal types (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip literal types

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. In constructor type homing mode sometimes complete debug info for constexpr types was missing, because there was not a constructor emitted. This

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang updated this revision to Diff 254942. akhuang added a comment. Change check to hasConstexprNonCopyMoveConstructor() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77432/new/ https://reviews.llvm.org/D77432 Files:

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds DIFlagNonTrivial to forward declarations of DICompositeType. It adds the flag to nontrivial types and types with unknown

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2263 if (DebugKind == codegenoptions::DebugInfoConstructor && - !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { -for (const auto *Ctor

[PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang created this revision. Herald added subscribers: lldb-commits, cfe-commits, aprantl. Herald added projects: clang, LLDB. There will be an RFC for this in cfe-dev. This reduces the amount of class debug info emitted in Limited debug info mode. Repository: rG LLVM Github Monorepo

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang updated this revision to Diff 289768. akhuang added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf1a96408b1: [DebugInfo] Add size to class declarations in debug info. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035 + const RecordDecl *D = RD->getDefinition(); + if (D && D->isCompleteDefinition()) +Size = CGM.getContext().getTypeSize(Ty); akhuang wrote: > dblaikie wrote: > > When is a

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang created this revision. akhuang added reviewers: aprantl, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. Herald added a subscriber: ormris. This adds the size to forward declared class

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang updated this revision to Diff 289602. akhuang marked an inline comment as done. akhuang added a comment. remove assert; edit test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062 Files:

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035 + const RecordDecl *D = RD->getDefinition(); + if (D && D->isCompleteDefinition()) +Size = CGM.getContext().getTypeSize(Ty); dblaikie wrote: > When is a definition not a

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang closed this revision. akhuang added a comment. ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. We used to only emit static const data members in CodeView as S_CONSTANTS when they

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. In D89072#2320209 , @dblaikie wrote: > I'll probably leave the llvm/CodeView parts of this for @rnk - but for the > clang parts, they should have corresponding clang test coverage & I'd be > curious to see the test for that to

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 297068. akhuang added a comment. Update clang test for static data members, and make it test the general cases on the windows target as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 298258. akhuang marked an inline comment as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files:

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va",

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang added a subscriber: rsmith. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1421-1425 + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { +// Inline static data members might not have an initialization. +if

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang updated this revision to Diff 298243. akhuang added a comment. update test case and add check for dependent values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89286/new/ https://reviews.llvm.org/D89286 Files:

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Debug info for inline static data members was missing the constant value, because the initializer for these static

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. In D86491#2235206 , @MaskRay wrote: > Note that Harbormaster actually reported the check-clang-codegencxx issues > B69369 .. Definitely my bad; I thought I had run check-clang locally before

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang updated this revision to Diff 287748. akhuang added a comment. Fix errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. just reopening to update the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. For some reason the ctor homing case was before the template specialization case, and could have returned false too

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ce5f7050d: [DebugInfo] Move constructor homing case in shouldOmitDefinition. (authored by akhuang). Repository: rG LLVM Github Monorepo

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 294149. akhuang added a comment. Add to comment for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4fc581d5fe: [DebugInfo] Add types from constructor homing to the retained types list. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Add class types to the retained types list to make sure they don't get dropped if the constructor is optimized out

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added a comment. In D87808#2282223 , @rnk wrote: > In D87808#2280197 , @dblaikie wrote: > >> @rsmith What's the deal with these anonymous structs/unions? Why do they >> have copy/move constructors (are

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293817. akhuang marked an inline comment as done. akhuang added a comment. Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8df781e54a4: [DebugInfo] Fix bug in constructor homing with classes with trivial (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2292-2300 + bool hasCtor = false; + for (const auto *Ctor : RD->ctors()) { if (Ctor->isTrivial() && !Ctor->isCopyOrMoveConstructor()) return false; +if

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293579. akhuang added a comment. Update ctor homing check, and add some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files:

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

akhuang added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:886 + } // FIXME: Path to compiler and command line. PDB is intentionally blank unless // we implement /Zi type servers. Can the 'path to compiler and command line'

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. whoops, sorry for weird formatting in the previous comment. I'll revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Basically, the code was checking if there were no constructors at all, but didn't check that there were any non

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. This is causing a link error in the windows chromium build: lld-link: error: undefined symbol: _WinMain@16 >>> referenced by >>> D:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:102 >>> >>> msvcrtd.lib(exe_winmain.obj):(int __cdecl

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 300438. akhuang added a comment. Fix test failures; remove assert for signed APSInts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files:

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added a comment. Whoops, forgot to check the tests. Apparently `mapEncodedInteger` asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 301080. akhuang added a comment. Herald added a subscriber: jfb. Moved isUnsignedDIType to DebugHandlerBase to avoid copying it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/

<    1   2   3   4   5   >