[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. One last nit, otherwise lgtm. But I'm not super familiar with this area, it'd be good to get another review from somebody more familiar. Comment at: clang/lib/Sema/Analy

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. aeubanks added reviewers: vitalybuka, leonardchan. This was attempted once before in https://reviews.llvm.org/D79698, but was reverted due to the coverage pass runnin

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks marked 2 inline comments as done. aeubanks added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:597-598 /// /// This extension point allows adding optimizations at the very end of the /// function optimization pipeline. A key difference betw

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks added a comment. In D80692#2061219 , @leonardchan wrote: > Would be worthwhile to write a small test that asserts Sancov runs before the > other sanitizers under the new PM? > > Aside from this, LGTM. Asserting that sancov runs before other san

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG922fa2fce38b: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267073. aeubanks added a comment. I foolishly submitted without running check-all, and it turns out this broke a test under check-clang. Looks like https://reviews.llvm.org/D62888 added tests in sancov-new-pm.c to make sure that sancov + LTO work together,

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267087. aeubanks added a comment. Update some CHECKs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80692/new/ https://reviews.llvm.org/D80692 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/sa

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG1285e8bcac2c: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 278871. aeubanks added a comment. Remove required passes part Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks added a comment. In D83519#2158938 , @ychen wrote: > In D83519#2144616 , @aeubanks wrote: > > > In D83519#2144463 , @aeubanks > > wrote: > > > > > In D83519#2144403

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 279313. aeubanks marked 4 inline comments as done. aeubanks added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGe

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 279563. aeubanks added a comment. Rename OptNoneInstrumentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/inclu

[PATCH] D83519: [NewPM] Support optnone under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13b85818218: [NewPM] Support optnone under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://review

[Differential] D83519: [NewPM] Support optnone under new pass manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb13b85818218: [NewPM] Support optnone under new pass manager (auth

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, aaron.ballman, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84707 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/bindings/go/llvm/Instrumentat

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks updated this revision to Diff 281109. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84707/new/ https://reviews.llvm.org/D84707 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/bindings/go

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/DataFlowSanitizer.h:11 + +#include "llvm/IR/Function.h" +#include "llvm/IR/Module.h" ychen wrote: > Is Function.h needed? Nope, rem

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

aeubanks accepted this revision. aeubanks added a comment. Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84774/new/ https://reviews.llvm.org/D84774 ___ cfe-commits mailing list cfe

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassRegistry.def:92 MODULE_PASS("verify", VerifierPass()) +MODULE_PASS("dfsan", DataFlowSanitizerPass()) MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false))

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71d0a2b8a313: [DFSan][NewPM] Port DataFlowSanitizer to NewPM (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

aeubanks added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3949 + // Special-case reading from __uuidof expressions so we don't have to + // construct an APValue for the whole uuid. + if (LVal.Designator.isOnePastTheEnd()) { For my

[PATCH] D81273: [WIP] Enable new pass manager as default DO NOT SUBMIT

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Just for bot testing Depends on D81175 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81273 Files: clang/CMake

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks created this revision. aeubanks added reviewers: leonardchan, vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes pr33372.cpp under the new pass manager. ASan adds padding to globals. For example, it will change a {i32, i32, i32} to a {{i32, i32

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. This is causing some tests under check-clang to fail, taking a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 ___ cfe-commits m

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks updated this revision to Diff 268993. aeubanks added a comment. Update some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/asa

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. Could you take a look again at the test changes? LTO + sanitizers doesn't work under NPM because [1] never ends up calling the passes registered via registerOptimizerLastEPCallback(). [1] https://github.com/llvm/llvm-project/blob/e429cffd4f228f70c1d9df0e5d77c08590dd976

[PATCH] D81323: Move *San module passes later in the NPM pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rGc07339c6754e: Move *San module passes later in the NPM pipeline (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://rev

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

aeubanks created this revision. aeubanks added a reviewer: akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move check inside of addHeapAllocSiteMetadata(). Change check to DebugInfo <= DebugLineTablesOnly. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc38793852c0: Change debuginfo check for addHeapAllocSiteMetadata (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/ https://r

[PATCH] D81422: Change filecheck default to dump input on failure

aeubanks added a comment. FWIW I didn't see this change initially but was pleasantly surprised with the extra output when debugging a newly added (relatively small) test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://reviews.llv

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

aeubanks added a comment. In D83013#2132070 , @echristo wrote: > Adding Chandler and Alina here as well. > > In general, I don't think that this is such a great idea. Being able to have > this sort of thing work more reliably is one of the reasons for the

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks created this revision. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. This uses pass instrumentation callbacks to skip optional passes. PassInfoMixin now declares that passes

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added a comment. In D83519#2144403 , @ychen wrote: > High-level request: how about split this patch into two, the first for the > `require` pass part; the second for the PassInstrument callback. Then we

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks added a comment. In D83519#2144463 , @aeubanks wrote: > In D83519#2144403 , @ychen wrote: > > > High-level request: how about split this patch into two, the first for the > > `require` pass part; the secon

[PATCH] D82231: [NFC] Remove unused pass name parser classes

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. aeubanks added a reviewer: echristo. aeubanks updated this revision to Diff 272166. aeubanks added a comment. Unintended change Looks like these were for the most part

[PATCH] D82231: [NFC] Remove unused pass name parser classes

aeubanks updated this revision to Diff 272166. aeubanks added a comment. Unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82231/new/ https://reviews.llvm.org/D82231 Files: llvm/include/llvm/IR/LegacyPassNameParser.h Index: llvm/

[PATCH] D82231: [NFC] Remove unused pass name parser classes

This revision was automatically updated to reflect the committed changes. Closed by commit rG2565581e3704: [NFC] Remove unused pass name parser classes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82231/new/ https://reviews.

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added a comment. In D79895#2107796 , @nick wrote: > > This warning can be turned off by the flag > > `-Wno-uninitialized-const-reference`. > > Suggesting to turn off the warning should be the last resort. I am pointing > to the false positives f

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added a comment. In D79895#2110345 , @nick wrote: > > We didn't see it in the code bases I work with, so is boost a special case, > > or an example of a common practice? > > I do not have resources to make such statistics, but there are compilers

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commandsIn command lines with /showIncludes, clangd would output includes to stdout, breaking clients.

aeubanks created this revision. aeubanks added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/322. Repository: rG LLVM Github Monorepo ht

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. Herald added a subscriber: ormris. I did verify that clangd on vscode now works on Windows on the LLVM codebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 _

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:82 +TEST(CommandMangler, StripShowIncludes) { + auto Mangler = CommandMangler::forTests(); sammccall wrote: > It'

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260040. aeubanks added a comment. Add test in ToolingTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files: clang-tools-extra/clangd/unittests/CompileCommandsTe

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260103. aeubanks added a comment. Handle /showIncludes:user Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files: clang-tools-extra/clangd/unittests/CompileCommands

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") {

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. In D78836#2003696 , @kadircet wrote: > thanks, lgtm. do you have commit access? Yep :) Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://r

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG8000d506afcd: [clangd] Strip /showIncludes in clangd compile commands (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https

[PATCH] D78939: Strip -showIncludes in getClangStripDependencyFileAdjuster()

aeubanks created this revision. aeubanks added a reviewer: thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up to https://reviews.llvm.org/D78836. Also consolidate some test cases. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78939 Files

[PATCH] D78939: Strip -showIncludes in getClangStripDependencyFileAdjuster()

This revision was automatically updated to reflect the committed changes. Closed by commit rGdab1326a5ae3: Strip -showIncludes in getClangStripDependencyFileAdjuster() (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78939/new/

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

aeubanks added a comment. I'm looking at enabling the -enable-npm-optnone flag and FullUnroll.ll fails. I understand that loop unrolling should be forced when some metadata is present, but the FullUnroll.ll test seems to check for a lot more than that. It checks for (roughly) two unconditional

[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl

aeubanks created this revision. aeubanks added reviewers: hans, thakis. Herald added subscribers: cfe-commits, dang, dexonsmith, inglorion. Herald added a project: clang. aeubanks requested review of this revision. Some compiler-rt tests check for the presence of the compiler accepting -fno-lto to

[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc43852e4a8: [Driver] Accept -fno-lto in clang-cl (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85252/new/ https://reviews.llvm.org

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 284093. aeubanks added a comment. Herald added subscribers: cfe-commits, jfb, eraman. Herald added a project: clang. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. In D85545#2208266 , @arthur.j.odwyer wrote: > To decrease the number of false-positives, you could emit the warning only > if *exactly one* comma was missing. > > const char *likely_a_bug[] = { "a", "b", "c" "d", "e", "f", "g",

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. After not warning on structs, this did find a real missing comma in the Chromium codebase, so thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 _

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. Actually sorry, it does still seem like there are false positives on structs. Reduced: $ cat /tmp/a.cpp struct A { const char* a; const char* b; const char* c; }; static constexpr A foo2 = A{"", ""

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. In D85545#2211070 , @xbolva00 wrote: > I check if all elements of init list are strings, so this is not > exactly true "struct checker" (I have no such info in that part of > code..) but I consider it good enough. Your test case i

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 284875. aeubanks added a comment. Specify target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D85457 Files: clang/test/CodeGen/O0-no-skipped-passes.c llvm/include/llvm

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. It still seems to trigger on structs at head: $ cat /tmp/a.cc struct A { const char *a; const char *b; const char *c; }; static A a = {"", "" "", ""}; $ ./build/bin/clang++ -Wstring-concatenation -o /dev/null -c /tmp/a.cc C:/src/tmp/a.cc:10:15: warning:

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 285752. aeubanks added a comment. -target -> -triple rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D85457 Files: clang/test/CodeGen/O0-no-skipped-passes.c llvm/i

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ea8779c2e0: [NewPM][optnone] Mark various passes as required (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://revi

[PATCH] D86008: [NewPM][optnone] Fix clang tests in preparation for -enable-npm-optnone

aeubanks created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. aeubanks requested review of this revision. These are the last clang tests failing before being able to turn on -enable-npm-optnone. Repository: rG LLVM Gith

[PATCH] D86008: [NewPM][optnone] Fix clang tests in preparation for -enable-npm-optnone

aeubanks updated this revision to Diff 285797. aeubanks added a comment. Split out other test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86008/new/ https://reviews.llvm.org/D86008 Files: clang/test/CodeGen/aggregate-assign-call.c Index: cla

[PATCH] D86011: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone

aeubanks created this revision. aeubanks added reviewers: asbirlea, ychen. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. aeubanks requested review of this revision. This fails due to the clang invocation running at -O0, producin

[PATCH] D86011: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3973195095e: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8601

[PATCH] D86008: [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0ceff94d663: [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aeubanks added a comment. This seems to be breaking determinism on Windows builds, see https://crbug.com/1117026. Can this be reverted and fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 ___

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks created this revision. aeubanks added reviewers: nemanjai, vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Properly forward TrackOrigins and Recover user options to the MSan pass under the new pass manager. This makes the number of check-ms

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks updated this revision to Diff 262248. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks added a comment. In D79445#2021311 , @leonardchan wrote: > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` > lambda for the MSan passes and also apply it when adding kernel MSan? It ends up calling an extra `MPM.addPa

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks updated this revision to Diff 262426. aeubanks added a comment. Revert back to initial patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clan

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG48451ee6a7ee: [MSan] Pass MSan command line options under new pass manager (authored by aeubanks). Repository: rG LLVM

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks created this revision. aeubanks added reviewers: vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes compiler-rt/test/msan/coverage-levels.cpp under the new pass manager (final check-msan test!). Under the old pass manager, the cover

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d5bb94d7838: Run Coverage pass before other *San passes under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79698/n

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks added a comment. In D79698#2037305 , @leonardchan wrote: > Just to followup on this: We believe the root cause of the error we're > running into is that some sancov guards in one comdat are being referenced by > symbols in another comdat, so due

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

aeubanks added a comment. The summary of this change should be "add warning..." not "fix warning..." Could you add more detail into the commit description? About newly introduced diagnostic groups, etc. Also, I thought I saw tests in a previous revision but now they seem to be gone? CHANGES S

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2110 +def warn_uninit_const_reference : Warning< + "variable %0 is uninitialized when passes as a const reference parameter " + "here">, InGroup, DefaultIgnore; s/passe

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. I've run into https://github.com/llvm/llvm-project/issues/56503 after this patch so I've reverted this for now while I'm fixing that. Sorry for this patch exposing so many pre-existing issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 457383. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D13303

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc911befaec49: [InstCombine] Treat passing undef to noundef params as UB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D133587: Loop names used in reporting can grow very large

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. this is something I've wanted to do for a while but never got around to thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133587/new/ ht

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lg with comments addressed title needs update Comment at: clang/lib/CodeGen/BackendUtil.cpp:443 Options.EmulatedTLS = CodeGenOpts.EmulatedTLS; - Options.ExplicitEmul

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. Heads up, we're seeing issues from this in Chrome again, will try to post a reduced repro (https://crbug.com/1500022) The reduced repro I found crashed very far back, so I'm guessing this patch caused bad debug info which caused an existing issue that doesn't handle ba

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. `../../llvm/lib/CodeGen/AsmPrinter/DwarfFile.cpp:110: void llvm::DwarfFile::addScopeVariable(LexicalScope *, DbgVariable *): Assertion 'Ret.second' failed.` is the crash btw Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. Is there any issue with mixing IR built with `LLVMContext::enableDebugTypeODRUniquing()` and without? I'm suspecting that ThinLTO is mixing Rust and Clang IR which set that differently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. another observation, `opt` complained about some debug info due to setting `LLVMContext::enableDebugTypeODRUniquing()` and stripped it away, but `llc` happily accepted the debug info and crashed with the assertion above when emitting assembly. Repository: rG LLVM G

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. F30438826: i.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 ___ cfe-commits mailing list cfe-

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. In D144006#4656383 , @dzhidzhoev wrote: > In D144006#4656371 , @aeubanks > wrote: > >> Is there any issue with mixing IR built with >> `LLVMContext::enableDebugTypeODRUniquing()` and w

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for publicly visible classes

aeubanks created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. moving DAE after the function simplification pipeline makes sense In D128830#3622736 , @psamolysov wrote: > In D128830#3622467 , @fhahn wrote: > >> Do we need to retain the run of `Dead

[PATCH] D122275: [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bd66b312c3e: [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE (authored by aeubanks). Herald added subscribers: cfe-com

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added a comment. thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2eade1dba4a8: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible… (authored by aeubanks). Repository: rG LLVM Github M

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

aeubanks added a comment. polly and clang-fuzzer both call `populateModulePassManager` just to optimize IR, they should be easily migrated to use the new PM bugpoint is still an issue, I just haven't found time to work on it yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

aeubanks added a comment. in the commit message In addition, capturing an anonymous union member, a bitfield, or a structured binding thereof now has a better diagnostic. "better diagnostic" implies there was already a diagnostic, but we're seeing new errors pop up. is this just a not pre

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

aeubanks added a comment. In D122768#3700486 , @cor3ntin wrote: > In D122768#3700451 , @aeubanks > wrote: > >> in the commit message >> >> In addition, capturing an anonymous union member, >> a bitfield, or a

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

  1   2   3   4   5   6   7   8   >