Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

Merged in r278376. Thanks, Hans On Thu, Aug 11, 2016 at 11:13 AM, Richard Smith wrote: > Well, the whole approach here is still wrong (per the FIXME in > CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent. > Let's take this for 3.9 to at least stem

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Merged in r278374. Thanks, Hans On Thu, Aug 11, 2016 at 11:07 AM, Richard Smith wrote: > Yes, this should be merged. It's not quite right, but it's certainly better > than what we had before. > > On Mon, Aug 8, 2016 at 1:34 PM, Hans Wennborg wrote: >>

Re: [libcxx] r278387 - Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal. Fixes bug 28936

Merged to 3.9 in r278425, as the PR was marked as a release blocker. On Thu, Aug 11, 2016 at 11:46 AM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Thu Aug 11 13:46:24 2016 > New Revision: 278387 > > URL:

[libcxx] r278425 - Merging r278387:

Author: hans Date: Thu Aug 11 16:47:28 2016 New Revision: 278425 URL: http://llvm.org/viewvc/llvm-project?rev=278425=rev Log: Merging r278387: r278387 | marshall | 2016-08-11 11:46:24 -0700 (Thu, 11 Aug 2016) | 1 line

[libcxx] r278426 - Merging r278282:

Author: hans Date: Thu Aug 11 16:48:37 2016 New Revision: 278426 URL: http://llvm.org/viewvc/llvm-project?rev=278426=rev Log: Merging r278282: r278282 | marshall | 2016-08-10 13:04:46 -0700 (Wed, 10 Aug 2016) | 1 line std::

Re: [libcxx] r278282 - std:: quailfy the calls for cend/crend/cbegin/cend. Fixes bug 28927.

I've gone ahead and merged it in r278426. On Wed, Aug 10, 2016 at 5:19 PM, Eric Fiselier <e...@efcs.ca> wrote: > I would support merging this change. > > /Eric > > On Wed, Aug 10, 2016 at 3:20 PM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org>

Re: [libcxx] r278282 - std:: quailfy the calls for cend/crend/cbegin/cend. Fixes bug 28927.

Should we merge this to 3.9? Looks like a straight-forward fix for something that was hit by real code. Thanks, Hans On Wed, Aug 10, 2016 at 1:04 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Wed Aug 10 15:04:46 2016 > New Revision: 278282 > >

Re: [libcxx] r278357 - test: relax the FS test a slight bit to be more reliable

On Thu, Aug 11, 2016 at 8:50 PM, Saleem Abdulrasool wrote: > On Thu, Aug 11, 2016 at 9:58 AM, Saleem Abdulrasool via cfe-commits > wrote: >> >> Author: compnerd >> Date: Thu Aug 11 11:58:12 2016 >> New Revision: 278357 >> >> URL:

[libcxx] r278538 - Merging r278357:

Author: hans Date: Fri Aug 12 12:59:24 2016 New Revision: 278538 URL: http://llvm.org/viewvc/llvm-project?rev=278538=rev Log: Merging r278357: r278357 | compnerd | 2016-08-11 09:58:12 -0700 (Thu, 11 Aug 2016) | 6 lines

Re: [PATCH] D23452: [OpenCL] Release 3.9 notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm! Please commit to https://llvm.org/svn/llvm-project/cfe/branches/release_39 or let me know if you'd prefer me to do it. Comment at: docs/ReleaseNotes.rst:206 @@ +205,3 @@

Re: [PATCH] D23452: [OpenCL] Release 3.9 notes

hans added a comment. In https://reviews.llvm.org/D23452#514110, @Anastasia wrote: > Thanks! Is there a way to check the doc before committing? I am not sure how > to make the html generated out of this. I build the docs like this: cmake -GNinja -DLLVM_ENABLE_SPHINX=ON -DLLVM_BUILD_DOCS=ON

[clang-tools-extra] r275846 - Trunk release notes are now for 4.0.0

Author: hans Date: Mon Jul 18 13:08:59 2016 New Revision: 275846 URL: http://llvm.org/viewvc/llvm-project?rev=275846=rev Log: Trunk release notes are now for 4.0.0 The 3.9 release are on the 3.9 branch. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

It seems to have broken this buildbot: http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/ I'm just about to create the 3.9 release branch, so it would be great if this could fixed/figured out soon. Thanks, Hans On Mon, Jul 18, 2016 at 10:23 AM, Devin Coughlin via cfe-commits

[libunwind] r275841 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:53:22 2016 New Revision: 275841 URL: http://llvm.org/viewvc/llvm-project?rev=275841=rev Log: Creating release_39 branch off revision 275826 Added: libunwind/branches/release_39/ - copied from r275826, libunwind/trunk/

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, and feel free to move to before the "no longer passes --build-id" item above. https://reviews.llvm.org/D21970 ___ cfe-commits mailing list

[libcxx] r275832 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:52:56 2016 New Revision: 275832 URL: http://llvm.org/viewvc/llvm-project?rev=275832=rev Log: Creating release_39 branch off revision 275826 Added: libcxx/branches/release_39/ (props changed) - copied from r275826, libcxx/trunk/ Propchange:

[libcxxabi] r275833 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:52:59 2016 New Revision: 275833 URL: http://llvm.org/viewvc/llvm-project?rev=275833=rev Log: Creating release_39 branch off revision 275826 Added: libcxxabi/branches/release_39/ - copied from r275826, libcxxabi/trunk/

r275844 - Trunk release notes are now for 4.0.0

Author: hans Date: Mon Jul 18 13:05:19 2016 New Revision: 275844 URL: http://llvm.org/viewvc/llvm-project?rev=275844=rev Log: Trunk release notes are now for 4.0.0 The 3.9 release are on the 3.9 branch. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst

r275848 - docs/conf.py: update version to 4.0

Author: hans Date: Mon Jul 18 13:13:08 2016 New Revision: 275848 URL: http://llvm.org/viewvc/llvm-project?rev=275848=rev Log: docs/conf.py: update version to 4.0 Modified: cfe/trunk/docs/analyzer/conf.py cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/analyzer/conf.py URL:

[clang-tools-extra] r275849 - docs/conf.py: update version to 4.0

Author: hans Date: Mon Jul 18 13:13:46 2016 New Revision: 275849 URL: http://llvm.org/viewvc/llvm-project?rev=275849=rev Log: docs/conf.py: update version to 4.0 Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL:

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Oops, as you suspected I failed at copy/paste. This is the bot that's broken: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780 On Mon, Jul 18, 2016 at 10:57 AM, Devin Coughlin wrote: > Hans, > > I’m happy to revert — but I think r275820 is very unlikely to

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Thanks, I've merged the revert in r275902. Cheers, Hans On Mon, Jul 18, 2016 at 12:06 PM, Devin Coughlin wrote: > Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t > get an email from the bot about the failure. > > Thanks > Devin > > On Jul 18,

Re: [clang-tools-extra] r275943 - clang-rename: fix referenced variable in vim-script

Sure, r276115. Thanks, Hans On Mon, Jul 18, 2016 at 10:22 PM, Saleem Abdulrasool wrote: > Hey Hans, > > I think that we should get this merged into 3.9. Its a trivial fix and > makes the script usable if you set g:clang_rename_path. > > Thanks! > > On Mon, Jul 18, 2016

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

hans added a comment. Committed r276113. Thanks! Repository: rL LLVM https://reviews.llvm.org/D21970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL276113: Add attribute abi_tag to the release notes (authored by hans). Changed prior to commit: https://reviews.llvm.org/D21970?vs=62673=64678#toc Repository: rL LLVM

Re: [libcxx] r276003 - Fix undefined behavior in __tree

On Wed, Jul 20, 2016 at 1:42 AM, Marshall Clow wrote: > > > On Tue, Jul 19, 2016 at 11:06 AM, Eric Fiselier wrote: >> >> @Hans. This needs to be merged into 3.9. It fixes PR28469 which is a >> release blocker. > > > I'm fine with this. Thanks! Eric, go ahead

Re: r273911 - [ExprConstant] Fix PR28314 - crash while evluating objectsize.

+Tom who does the "dot" releases. I don't know if he's planning for a 3.8.2, but just in case, I suppose it's on the radar now :-) Thanks, Hans On Mon, Jun 27, 2016 at 11:21 PM, George Burgess IV wrote: > +Richard, Hans > > This patch fixes a crash that's also

Re: Diagnostics improvements for 3.9

These all sgtm for 3.9. Go ahead and merge with utils/release/merge.sh, or I'll do it when I get in on Monday. Cheers, Hans On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote: > Typos and unused test variables fixed in r277900 > > On Fri, Aug 5, 2016 at 6:46 PM, Richard

Re: r277743 - [OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.

Okay, merged in r278019. Cheers, Hans On Fri, Aug 5, 2016 at 9:36 AM, Anastasia Stulova wrote: > Hans, > > If still possible could we merge this into 3.9. It contains just a minor > renaming but it makes all those new OpenCL Builtins usable. > > Thanks, > Anastasia >

Re: Diagnostics improvements for 3.9

I've merged the lot in r278020. Thanks, Hans On Fri, Aug 5, 2016 at 7:43 PM, Hans Wennborg wrote: > These all sgtm for 3.9. Go ahead and merge with > utils/release/merge.sh, or I'll do it when I get in on Monday. > > Cheers, > Hans > > On Fri, Aug 5, 2016 at 6:52 PM, Richard

[libunwind] r278023 - Merging r277868:

Author: hans Date: Mon Aug 8 12:18:56 2016 New Revision: 278023 URL: http://llvm.org/viewvc/llvm-project?rev=278023=rev Log: Merging r277868: r277868 | compnerd | 2016-08-05 14:35:28 -0700 (Fri, 05 Aug 2016) | 4 lines

Re: [libunwind] r277868 - unwind: disable executable stacks

Okay, r278023. Thanks, Hans On Fri, Aug 5, 2016 at 2:46 PM, Saleem Abdulrasool wrote: > On Fri, Aug 5, 2016 at 2:35 PM, Saleem Abdulrasool via cfe-commits > wrote: >> >> Author: compnerd >> Date: Fri Aug 5 16:35:28 2016 >> New Revision:

Re: [libcxx] r278032 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

I didn't merge this one to 3.9 because the PACKAGE_VERSION seems to have always been trunk-svn, and it's at least not as misleading as having the wrong number. I wonder if PACKAGE_VERSION is actually important for anything in libcxx, libcxxabi and libunwind? At least for libcxx, the important

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Richard: ping? On Wed, Jul 27, 2016 at 4:46 PM, Hans Wennborg wrote: > Should this be merged to 3.9? > > Thanks, > Hans > > On Wed, Jul 27, 2016 at 11:25 AM, Erik Pilkington via cfe-commits > wrote: >> Author: epilk >> Date: Wed Jul 27 13:25:10

[libcxxabi] r278044 - Merging r278030 with version number adjusted:

Author: hans Date: Mon Aug 8 15:06:27 2016 New Revision: 278044 URL: http://llvm.org/viewvc/llvm-project?rev=278044=rev Log: Merging r278030 with version number adjusted: r278030 | eugenezelenko | 2016-08-08 10:59:02 -0700

Re: [libunwind] r278029 - CMakeLists.txt cleanups: synchronize version and CMake minimum required version with rest of LLVM, consistent spacing.

Merged to 3.9 in r278043 with the version number adjusted. On Mon, Aug 8, 2016 at 10:56 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Mon Aug 8 12:56:28 2016 > New Revision: 278029 > > URL:

[libunwind] r278043 - Merging r278029 with version number adjusted:

Author: hans Date: Mon Aug 8 15:04:18 2016 New Revision: 278043 URL: http://llvm.org/viewvc/llvm-project?rev=278043=rev Log: Merging r278029 with version number adjusted: r278029 | eugenezelenko | 2016-08-08 10:56:28 -0700

Re: [libcxxabi] r278030 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

Merged to 3.9 in r278044 with the version number adjusted. On Mon, Aug 8, 2016 at 10:59 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Mon Aug 8 12:59:02 2016 > New Revision: 278030 > > URL:

Re: r277095 - [Parser] Fix bug where delayed typo in conditional expression was corrected twice

Should we merge this to 3.9? Thanks, Hans On Thu, Jul 28, 2016 at 5:55 PM, Erik Pilkington via cfe-commits wrote: > Author: epilk > Date: Thu Jul 28 19:55:40 2016 > New Revision: 277095 > > URL: http://llvm.org/viewvc/llvm-project?rev=277095=rev > Log: > [Parser] Fix

Re: r277307 - Add more gcc compatibility names to clang's cpuid.h

Go ahead (or let me know if you'd prefer me to do it). Cheers, Hans On Sun, Jul 31, 2016 at 1:37 PM, Dimitry Andric wrote: > Hi Hans, > > I would like to merge this one to release_39, since it fixes a few third > party programs using cpuid.h, and expecting gcc-compatible

r277405 - Revert r276896 "Update Clang Parser test error message to match new parser errors"

Author: hans Date: Mon Aug 1 18:34:42 2016 New Revision: 277405 URL: http://llvm.org/viewvc/llvm-project?rev=277405=rev Log: Revert r276896 "Update Clang Parser test error message to match new parser errors" This depended on r276895, which was reverted in r277402. Modified:

Re: [Diffusion] rL277097: [clang-tidy] Fixes to modernize-use-emplace

Merged in r277385. Cheers, Hans On Fri, Jul 29, 2016 at 3:58 PM, Piotr Padlewski wrote: > It would be very good to import this patch to clang-tidy-3.9 > > > -- Forwarded message -- > From: Piotr Padlewski > Date: 2016-07-28

Re: r277221 - Remove unused variable.

Merged in r277384. Cheers, Hans On Fri, Jul 29, 2016 at 5:33 PM, Eric Christopher wrote: > Hi Hans, > > Can you make sure this makes it into 3.9 please? > > Thanks! > > -eric > > > On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits >

Re: [libunwind] r276215 - [libunwind] Properly align _Unwind_Exception.

I'm not sure we have an owner for libunwind, but things sounded positive on the code review, so go ahead and merge. Thanks, Hans On Wed, Jul 20, 2016 at 8:06 PM, Eric Fiselier wrote: > @Hans This should be merged into 3.9. > > Can a code owner give this the thumbs up? > > /Eric >

Re: r276102 - [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

On Thu, Jul 21, 2016 at 6:34 PM, Robinson, Paul via cfe-commits wrote: > > >> -Original Message- >> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of >> Simon Pilgrim via cfe-commits >> Sent: Wednesday, July 20, 2016 3:18 AM >> To:

Re: r274991 - [clang-cl] Add support for /Zd

On Fri, Jul 29, 2016 at 10:12 AM, Nico Weber wrote: > On Thu, Jul 28, 2016 at 9:03 PM, Hans Wennborg wrote: >> >> Sorry, I was supposed to chime in here. >> >> I don't have a strong opinion on this, but I don't think it's a >> problem for us to allow the

Re: r276979 - [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

The test was failing on 3.9 on my Mac, and I noticed there were some follow-up commits, so I've merged r276983, r277138, r277141 in r277193. On Thu, Jul 28, 2016 at 10:18 AM, Hans Wennborg wrote: > I've merged it in r277004. > > Cheers, > Hans > > On Thu, Jul 28, 2016 at 10:15

Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

For the record, this was for PR28666. Richard: what do you think about merging this to 3.9? On Tue, Aug 2, 2016 at 2:07 PM, Devin Coughlin via cfe-commits wrote: > Author: dcoughlin > Date: Tue Aug 2 16:07:23 2016 > New Revision: 277522 > > URL:

[libcxxabi] r278675 - Merging r278579:

Author: hans Date: Mon Aug 15 11:10:06 2016 New Revision: 278675 URL: http://llvm.org/viewvc/llvm-project?rev=278675=rev Log: Merging r278579: r278579 | mehdi_amini | 2016-08-12 17:02:33 -0700 (Fri, 12 Aug 2016) | 3 lines

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

Merged in r278675. Thanks! On Fri, Aug 12, 2016 at 5:54 PM, Mehdi Amini wrote: > CC hans. > > >> On Aug 12, 2016, at 5:50 PM, Duncan P. N. Exon Smith >> wrote: >> >> This seems like a good candidate to cherry-pick to 3.9. >> >>> On 2016-Aug-12, at

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

hans added a comment. > [This is my first time submitting 'pull requests' for a specific branch. I > checked-out the respective release branches for llvm and clang, and reverted > the above commit (resolved a conflict in the process) and created a patch. My > box is currently still compiling

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

hans added a comment. Faisal: go ahead and commit directly to the branch, or let me know if you'd like me to do it. https://reviews.llvm.org/D23485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r266775 - Pass dwarf-version to cc1as.

Looks like it was committed back in April, so unless I'm missing something it should already be in the branch (which was cut mid-July). Thanks, Hans On Tue, Aug 16, 2016 at 2:16 PM, Dimitry Andric wrote: > Hi Hans, > > Can we please merge this one to release_39 too? I

Re: r277852 - PR26423: Assert on valid use of using declaration of a function with an undeduced auto return type

On Fri, Aug 5, 2016 at 12:03 PM, David Blaikie via cfe-commits wrote: > Author: dblaikie > Date: Fri Aug 5 14:03:01 2016 > New Revision: 277852 > > URL: http://llvm.org/viewvc/llvm-project?rev=277852=rev > Log: > PR26423: Assert on valid use of using declaration of a

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

Merged this one in r293813. Cheers, Hans On Wed, Feb 1, 2017 at 1:16 PM, Renato Golin wrote: > Right, the other one was 292607 and has already been merged. Sorry for > the confusion. We just need to merge this one and we're done. > > --renato > > On 1 February 2017 at

[libcxxabi] r293813 - Merging r292638:

Author: hans Date: Wed Feb 1 15:30:36 2017 New Revision: 293813 URL: http://llvm.org/viewvc/llvm-project?rev=293813=rev Log: Merging r292638: r292638 | ericwf | 2017-01-20 11:34:19 -0800 (Fri, 20 Jan 2017) | 9 lines Fix

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

Ping? On Wed, Feb 1, 2017 at 11:00 AM, Hans Wennborg wrote: > If Anna is Ok with it, I'm fine with merging. > > Thanks, > Hans > > On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev wrote: >> Hans, >> >> This is a fixed and tested version of the

Re: r294008 - [Sema][ObjC++] Typo correction should handle ivars and properties

IIUC, this isn't strictly fixing a regression from 3.9, but it looks like a pretty small diff. Richard, what do you think? On Fri, Feb 3, 2017 at 6:37 AM, Alex L wrote: > Hi Hans, > > Is there any chance we can merge this for 4.0? It fixed a nasty bug where > clang didn't

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

r294050. Thanks, Hans On Fri, Feb 3, 2017 at 1:50 PM, Anna Zaks wrote: > Fine with merging. Thank you! > Anna. >> On Feb 1, 2017, at 11:00 AM, Hans Wennborg wrote: >> >> If Anna is Ok with it, I'm fine with merging. >> >> Thanks, >> Hans >> >> On Wed, Feb 1,

Re: r294008 - [Sema][ObjC++] Typo correction should handle ivars and properties

Thanks! r294059. On Fri, Feb 3, 2017 at 2:29 PM, Richard Smith wrote: > It looks like the only cases it should have any real impact on are those > where we would previously miscompile/crash, so this seems OK to me to merge > to Clang 4. > > > On 3 February 2017 at 13:45,

r293735 - Follow-up to r293732: add a proper triple to the test

Author: hans Date: Tue Jan 31 20:48:02 2017 New Revision: 293735 URL: http://llvm.org/viewvc/llvm-project?rev=293735=rev Log: Follow-up to r293732: add a proper triple to the test Modified: cfe/trunk/test/CodeGenCXX/initializer-list-ctor-order.cpp Modified:

r293732 - clang-cl: Evaluate arguments left-to-right in constructor call with initializer list (PR31831)

Author: hans Date: Tue Jan 31 20:21:07 2017 New Revision: 293732 URL: http://llvm.org/viewvc/llvm-project?rev=293732=rev Log: clang-cl: Evaluate arguments left-to-right in constructor call with initializer list (PR31831) clang-cl would evaluate the arguments right-to-left (see PR), and for

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

I'm Ok with taking the larger patch (r293360 + r293369) too. It's been in tree for a bit, there is still a number of weeks before the release, and IIUC the major risk is that diagnose_if itself turns out to be broken, not that we'd miscompile anything? On Tue, Jan 31, 2017 at 11:11 AM, Richard

Re: [libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"

Merged to 4.0 as discussed on PR31782. On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits wrote: > Author: bogner > Date: Mon Jan 30 19:26:09 2017 > New Revision: 293581 > > URL: http://llvm.org/viewvc/llvm-project?rev=293581=rev > Log: > Revert "Adorn

[libcxx] r293645 - Merging r293581:

Author: hans Date: Tue Jan 31 10:40:22 2017 New Revision: 293645 URL: http://llvm.org/viewvc/llvm-project?rev=293645=rev Log: Merging r293581: r293581 | bogner | 2017-01-30 17:26:09 -0800 (Mon, 30 Jan 2017) | 12 lines

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On Thu, Jan 26, 2017 at 10:23 AM, Hans Wennborg wrote: > On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: >> On 20 January 2017 at 19:46, Eric Fiselier wrote: >>> This patch fixes a libc++abi test failure when compiled with GCC 5, 6,

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Ping? On Thu, Jan 26, 2017 at 10:21 AM, Hans Wennborg wrote: > Ping? > > On Mon, Jan 23, 2017 at 4:27 PM, Hans Wennborg wrote: >> Ping? >> >> On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: >>> Richard, what do you think? >>> >>>

Re: r293416 - [c-index-test] Provide capability for 'c-index-test core' to dump symbol information from a PCH/module file.

Hi Argyrios, Can you provide more background on what this does. Is it fixing an existing issue or doing something new? r293461 is making changes beyond Index/ so I'd like Richard to take a look too. Thanks, Hans On Mon, Jan 30, 2017 at 8:18 AM, Argyrios Kyrtzidis wrote: >

Re: r293596 - Handle ObjCEncodeExpr in extractStringLiteralCharacter.

Merged in r293653. Thanks, Hans On Mon, Jan 30, 2017 at 7:16 PM, Akira Hatanaka wrote: > Hans, can this be merged to 4.0? This fixes a regression from 3.9 (the part I > touched was committed a few years ago, but didn’t cause an assert until > recently). > >> On Jan 30,

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

Ping? On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote: > Should we merge this to the release branch? > > On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits > wrote: >> Author: majnemer >> Date: Mon Jan 16 22:14:25 2017 >> New

Re: [PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

On Tue, Jan 31, 2017 at 3:23 PM, Richard Smith wrote: > On 31 January 2017 at 14:49, Hans Wennborg wrote: >> >> Richard, what do you think? I don't believe this fixes a 3.9 >> regression, but the fix looks small, so it might be worth it. > > > I think

Re: r293360 - Change how we handle diagnose_if attributes.

Merged in r293784, as discussed on the commit thread for r291963. Thanks, Hans On Sun, Jan 29, 2017 at 5:59 PM, George Burgess IV wrote: > Hi! > > Now that the buidbots seem content, I think that this (...along with the > minor fix to the test in r293369) should be

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Merged this (r291963) in r293783. And the others (r293360 + r293369) in r293784. Thanks, Hans On Tue, Jan 31, 2017 at 7:17 PM, Richard Smith wrote: > I'm fine with these patches being merged. Hopefully we still have plenty of > time to shake out any problems between

[libcxx] r294483 - Docs: drop minor version

Author: hans Date: Wed Feb 8 11:28:23 2017 New Revision: 294483 URL: http://llvm.org/viewvc/llvm-project?rev=294483=rev Log: Docs: drop minor version Modified: libcxx/branches/release_40/docs/conf.py Modified: libcxx/branches/release_40/docs/conf.py URL:

Re: [libcxx] r294138 - Adjust Linux ABI list after r294133

Ping? On Mon, Feb 6, 2017 at 2:15 PM, Hans Wennborg wrote: > The diff here is huge compared to the Apple one (r294139). > > Did the file format change and this file was previously not updated? > > This makes it hard to merge the change. Can you advise on how to > generate this

[libunwind] r294547 - Creating release candidate rc2 from release_400 branch

Author: hans Date: Wed Feb 8 18:14:34 2017 New Revision: 294547 URL: http://llvm.org/viewvc/llvm-project?rev=294547=rev Log: Creating release candidate rc2 from release_400 branch Added: libunwind/tags/RELEASE_400/rc2/ (props changed) - copied from r294546,

[libcxx] r294540 - Creating release candidate rc2 from release_400 branch

Author: hans Date: Wed Feb 8 18:14:12 2017 New Revision: 294540 URL: http://llvm.org/viewvc/llvm-project?rev=294540=rev Log: Creating release candidate rc2 from release_400 branch Added: libcxx/tags/RELEASE_400/rc2/ (props changed) - copied from r294539, libcxx/branches/release_40/

[libcxxabi] r294541 - Creating release candidate rc2 from release_400 branch

Author: hans Date: Wed Feb 8 18:14:16 2017 New Revision: 294541 URL: http://llvm.org/viewvc/llvm-project?rev=294541=rev Log: Creating release candidate rc2 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc2/ (props changed) - copied from r294540,

[libcxx] r294249 - Merging r294133 and r294142:

Author: hans Date: Mon Feb 6 15:59:19 2017 New Revision: 294249 URL: http://llvm.org/viewvc/llvm-project?rev=294249=rev Log: Merging r294133 and r294142: r294133 | marshall | 2017-02-05 12:06:38 -0800 (Sun, 05 Feb 2017) | 1

Re: [libcxx] r294133 - Change the base class of std::bad_optional_access. This is a (subtle) ABI change, and is in response to http://http://wg21.link/LWG2806, which I *expect* to be adopted in Kona.

I've merged this, together with your r294142, to 4.0 in r294249, as requested. If I understand correctly, we should also merge Eric's follow-ups r294138 and r294139, but I get merge conflicts for the Linux one so I've asked about how to handle that. Thanks, Hans On Sun, Feb 5, 2017 at 12:06 PM,

Re: [libcxx] r294138 - Adjust Linux ABI list after r294133

The diff here is huge compared to the Apple one (r294139). Did the file format change and this file was previously not updated? This makes it hard to merge the change. Can you advise on how to generate this file or how to do the same change on 4.0? On Sun, Feb 5, 2017 at 12:14 PM, Eric Fiselier

Re: r293787 - [CodeGen][ObjC] Avoid asserting on block pointer types in

OK. Merged in r293797. Thanks, Hans On Wed, Feb 1, 2017 at 9:50 AM, Alex L wrote: > Hi Hans, > > Would it be possible to merge this for 4.0? > > Cheers, > Alex > > On 1 February 2017 at 17:37, Alex Lorenz via cfe-commits > wrote: >> >> Author:

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

If Anna is Ok with it, I'm fine with merging. Thanks, Hans On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev wrote: > Hans, > > This is a fixed and tested version of the previously-merged-and-reverted > r292800, do we still have time to land this into 4.0? > > Thanks, >

r293800 - Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

Author: hans Date: Wed Feb 1 12:52:53 2017 New Revision: 293800 URL: http://llvm.org/viewvc/llvm-project?rev=293800=rev Log: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695) For non-template dllimport functions, MSVC allows providing an inline

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On Tue, Jan 31, 2017 at 11:40 AM, Renato Golin wrote: > On 31 January 2017 at 18:36, Hans Wennborg wrote: Can you attach all commits that need to be backported into a bug against PR31622? We should probably squash them all before

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

r293702. On Tue, Jan 31, 2017 at 11:12 AM, Richard Smith wrote: > Sure, let's take this for Clang 4. > > On 31 January 2017 at 10:39, Hans Wennborg wrote: >> >> Ping? >> >> On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote: >> >

Re: [PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

Richard, what do you think? I don't believe this fixes a 3.9 regression, but the fix looks small, so it might be worth it. On Tue, Jan 31, 2017 at 12:07 PM, Akira Hatanaka wrote: > Thanks for the review. r293678. > > Should this be merged to 4.0? > >> On Jan 31, 2017, at

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Thanks for letting me know! I've merged your revert to the branch in r292947. Please let me know if there is any more follow-up. On Mon, Jan 23, 2017 at 6:30 PM, Devin Coughlin wrote: > FYI, I reverted r292800 from trunk in r292874. It was causing our internal > validation

Re: [libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

Ok, go ahead. On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote: > This patch needs to get merged into 4.0 since the offending commit with the > misspelling is in the 4.0 branch. > > /Eric > > > On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits >

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Sounds good to me. Anna, you're the code owner here. Ok to merge this? Thanks, Hans On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev wrote: > Hans, > > Could we merge this one into the 4.0.0 release branch? It's a recent bugfix > for the analyzer. > > Thanks, > Artem. > >

r292856 - Re-commit "Don't inline dllimport functions referencing non-imported methods"

Author: hans Date: Mon Jan 23 17:57:50 2017 New Revision: 292856 URL: http://llvm.org/viewvc/llvm-project?rev=292856=rev Log: Re-commit "Don't inline dllimport functions referencing non-imported methods" This re-commits r292522 with the addition that it also handles calls through pointer to

Re: r292522 - Don't inline dllimport functions referencing non-imported methods

prit. I speculatively reverted it in r292643. > > On Thu, Jan 19, 2017 at 1:33 PM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: hans >> Date: Thu Jan 19 15:33:13 2017 >> New Revision: 292522 >> >> URL: http://llvm.o

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Ping? On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: > Richard, what do you think? > > On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: >> I would love to see this merged. It would make it easier to write libc++ >> tests if the tests didn't have to

Re: r292847 - PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted a (user-visible) error.

Thanks! r292859. On Mon, Jan 23, 2017 at 3:26 PM, Richard Smith wrote: > Hans, this should go into Clang 4. > > On 23 January 2017 at 15:14, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Mon Jan 23 17:14:23 2017 >> New

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Merged in r292858. Thanks, Hans On Mon, Jan 23, 2017 at 4:15 PM, Anna Zaks wrote: > Yes, ok to merge! > Thank you. > > Sent from my iPhone > >> On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote: >> >> Sounds good to me. >> >> Anna, you're the code owner here.

Re: [libcxx] r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.

Sounds good to me. On Mon, Jan 23, 2017 at 1:56 PM, Eric Fiselier wrote: > This patch should be merge into 4.0 since it is needed to fix compile time > regressions in when using Clang 3.4 and C++03. > > See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info. >

Re: [libcxx] r292830 - Fix GCC C++03 build by hiding default template argument in C++03

We merged the first one, so I suppose we better fix it :-) Sounds good to me. On Mon, Jan 23, 2017 at 1:37 PM, Eric Fiselier wrote: > This patch should be merge into the 4.0 branch. > > It fixes a bug introduced to the 4.0 branch in r292354 >

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: > On 20 January 2017 at 19:46, Eric Fiselier wrote: >> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. >> We should merge this into 4.0 to help get `check-all` clean. > > Hi

[libcxx] r293193 - Merging r293154:

Author: hans Date: Thu Jan 26 11:55:46 2017 New Revision: 293193 URL: http://llvm.org/viewvc/llvm-project?rev=293193=rev Log: Merging r293154: r293154 | marshall | 2017-01-25 22:58:29 -0800 (Wed, 25 Jan 2017) | 1 line Use

[libcxx] r293192 - Merging r292990:

Author: hans Date: Thu Jan 26 11:51:25 2017 New Revision: 293192 URL: http://llvm.org/viewvc/llvm-project?rev=293192=rev Log: Merging r292990: r292990 | marshall | 2017-01-24 15:09:12 -0800 (Tue, 24 Jan 2017) | 1 line

<    1   2   3   4   5   6   7   8   9   10   >