r360580 - Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant expression evaluation."

Author: hans Date: Mon May 13 06:19:09 2019 New Revision: 360580 URL: http://llvm.org/viewvc/llvm-project?rev=360580&view=rev Log: Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant expression evaluation." This caused Chromium builds to hit the new "can't handle virtual ca

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

This caused asserts in Chromium, so I've reverted in r360580. There's a repro at https://bugs.chromium.org/p/chromium/issues/detail?id=962458#c1, and I'm working on a reduced version. From: Richard Smith via cfe-commits Date: Mon, May 13, 2019 at 9:39 AM To: > Author: rsmith > Date: Mon May 13

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

Here's a creduced repro: -- class a {}; class b : virtual a { virtual bool c(const void *, int); }; class C : b { public: bool c(const void *, int); }; int d; bool e() { C f; if (f.c(&d, d)) ; } -- $ clang.bad -cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -std=c++14 a.cc The as

r360657 - Revert r360637 "PR41817: Fix regression in r359260 that caused the MS compatibility"

Author: hans Date: Tue May 14 03:11:33 2019 New Revision: 360657 URL: http://llvm.org/viewvc/llvm-project?rev=360657&view=rev Log: Revert r360637 "PR41817: Fix regression in r359260 that caused the MS compatibility" > extension allowing a "static" declaration to follow an "extern" > declaration

Re: r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

Actually, we didn't notice r359260 in Chromium, however this one (r360637) caused Clang to start asserting during our builds (https://bugs.chromium.org/p/chromium/issues/detail?id=962840), here's a reduced test case: -- extern int a; static int *use1 = &a; int **use2 = &use1; static int a = 0; --

Re: r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

On Tue, May 14, 2019 at 6:35 PM Richard Smith wrote: > > On Tue, 14 May 2019, 03:09 Hans Wennborg via cfe-commits, > wrote: >> >> Actually, we didn't notice r359260 in Chromium, however this one >> (r360637) caused Clang to start asserting during our builds

Re: r361518 - lld-link, clang: Treat non-existent input files as possible spellos for option flags

Want to put a note in ReleaseNotes.rst? This is fixing something that a lot of users have run in to, so seems worth mentioning :-) On Thu, May 23, 2019 at 7:55 PM Nico Weber via cfe-commits wrote: > > Author: nico > Date: Thu May 23 10:58:33 2019 > New Revision: 361518 > > URL: http://llvm.org/v

r361811 - Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

Author: hans Date: Tue May 28 05:19:38 2019 New Revision: 361811 URL: http://llvm.org/viewvc/llvm-project?rev=361811&view=rev Log: Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)" This was reverted in r360086 as it

[libclc] r371500 - Creating release candidate rc4 from release_900 branch

Author: hans Date: Tue Sep 10 02:05:55 2019 New Revision: 371500 URL: http://llvm.org/viewvc/llvm-project?rev=371500&view=rev Log: Creating release candidate rc4 from release_900 branch Added: libclc/tags/RELEASE_900/rc4/ - copied from r371499, libclc/branches/release_90/ _

[libunwind] r371500 - Creating release candidate rc4 from release_900 branch

Author: hans Date: Tue Sep 10 02:05:55 2019 New Revision: 371500 URL: http://llvm.org/viewvc/llvm-project?rev=371500&view=rev Log: Creating release candidate rc4 from release_900 branch Added: libunwind/tags/RELEASE_900/rc4/ - copied from r371499, libunwind/branches/release_90/ ___

Re: r371766 - [Clang][CodeGen] support alias attribute w/ gnu_inline

Merged to release_90 in r371821. On Thu, Sep 12, 2019 at 9:51 PM Nick Desaulniers via cfe-commits wrote: > > Author: nickdesaulniers > Date: Thu Sep 12 12:53:35 2019 > New Revision: 371766 > > URL: http://llvm.org/viewvc/llvm-project?rev=371766&view=rev > Log: > [Clang][CodeGen] support alias att

[libunwind] r371837 - Creating release candidate rc5 from release_900 branch

Author: hans Date: Fri Sep 13 03:45:50 2019 New Revision: 371837 URL: http://llvm.org/viewvc/llvm-project?rev=371837&view=rev Log: Creating release candidate rc5 from release_900 branch Added: libunwind/tags/RELEASE_900/rc5/ - copied from r371836, libunwind/branches/release_90/ ___

[libclc] r371837 - Creating release candidate rc5 from release_900 branch

Author: hans Date: Fri Sep 13 03:45:50 2019 New Revision: 371837 URL: http://llvm.org/viewvc/llvm-project?rev=371837&view=rev Log: Creating release candidate rc5 from release_900 branch Added: libclc/tags/RELEASE_900/rc5/ - copied from r371836, libclc/branches/release_90/ _

Re: r371969 - Change signature of __builtin_rotateright64 back to unsigned

Merged to release_90 in r372100. On Mon, Sep 16, 2019 at 11:50 AM Karl-Johan Karlsson via cfe-commits wrote: > > Author: karka > Date: Mon Sep 16 02:52:23 2019 > New Revision: 371969 > > URL: http://llvm.org/viewvc/llvm-project?rev=371969&view=rev > Log: > Change signature of __builtin_rotaterigh

[libunwind] r372115 - Creating release candidate rc6 from release_900 branch

Author: hans Date: Tue Sep 17 06:09:16 2019 New Revision: 372115 URL: http://llvm.org/viewvc/llvm-project?rev=372115&view=rev Log: Creating release candidate rc6 from release_900 branch Added: libunwind/tags/RELEASE_900/rc6/ - copied from r372114, libunwind/branches/release_90/ ___

[libclc] r372115 - Creating release candidate rc6 from release_900 branch

Author: hans Date: Tue Sep 17 06:09:16 2019 New Revision: 372115 URL: http://llvm.org/viewvc/llvm-project?rev=372115&view=rev Log: Creating release candidate rc6 from release_900 branch Added: libclc/tags/RELEASE_900/rc6/ - copied from r372114, libclc/branches/release_90/ _

r372225 - Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Author: hans Date: Wed Sep 18 06:41:51 2019 New Revision: 372225 URL: http://llvm.org/viewvc/llvm-project?rev=372225&view=rev Log: Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)" This broke the Chromium build. Consider the following code: float ScaleSumSamples_C(con

Re: r372082 - [Clang] Pragma vectorize_width() implies vectorize(enable)

I've reverted this in r372225 as it broke the Chromium build. It seems it doesn't actually manage to enable vectorization of a simple loop at -Oz, and at -Os it asserts. See details in my commit message. On Tue, Sep 17, 2019 at 10:41 AM Sjoerd Meijer via cfe-commits wrote: > > Author: sjoerdmeije

[libunwind] r372316 - Creating release candidate final from release_900 branch

Author: hans Date: Thu Sep 19 06:10:55 2019 New Revision: 372316 URL: http://llvm.org/viewvc/llvm-project?rev=372316&view=rev Log: Creating release candidate final from release_900 branch Added: libunwind/tags/RELEASE_900/final/ - copied from r372315, libunwind/branches/release_90/ ___

[libclc] r372316 - Creating release candidate final from release_900 branch

Author: hans Date: Thu Sep 19 06:10:55 2019 New Revision: 372316 URL: http://llvm.org/viewvc/llvm-project?rev=372316&view=rev Log: Creating release candidate final from release_900 branch Added: libclc/tags/RELEASE_900/final/ - copied from r372315, libclc/branches/release_90/ _

r372844 - Revert r370850 "Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline""

Author: hans Date: Wed Sep 25 04:09:46 2019 New Revision: 372844 URL: http://llvm.org/viewvc/llvm-project?rev=372844&view=rev Log: Revert r370850 "Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline"" This work-around was necessary to handle standard library he

r372846 - Add a release note for r372844

Author: hans Date: Wed Sep 25 04:53:17 2019 New Revision: 372846 URL: http://llvm.org/viewvc/llvm-project?rev=372846&view=rev Log: Add a release note for r372844 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

On Thu, Sep 26, 2019 at 12:55 PM Mikael Holmén via cfe-commits wrote: > > Hi Hans, > > I'm a bit suspicious against the part > > > This also revertes the part of r369938 which checked that > -working-directory works. > > in this revert. > > You do: > > > + SmallString<128> Buf; > > + if (!llv

r373049 - Fix the 'directory' field in DumpCompilationDatabase and add test

Author: hans Date: Fri Sep 27 01:14:45 2019 New Revision: 373049 URL: http://llvm.org/viewvc/llvm-project?rev=373049&view=rev Log: Fix the 'directory' field in DumpCompilationDatabase and add test This broke in r371027 due to a missing negation (llvm::sys::fs::current_path returns false on succes

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Committed a fix in r373049, and I'll ask to have it merged for 9.0.1 as well. Sorry again for the breakage. On Thu, Sep 26, 2019 at 7:09 PM Mikael Holmén wrote: > > Hi, > > As Karl-Johan said I'll be out of office for a few days so please submit a > fix if you can find the time. > > Thanks, > Mi

r330441 - Fix some tests that were failing on Windows

Author: hans Date: Fri Apr 20 08:33:44 2018 New Revision: 330441 URL: http://llvm.org/viewvc/llvm-project?rev=330441&view=rev Log: Fix some tests that were failing on Windows Modified: cfe/trunk/test/CodeGen/function-alignment.c cfe/trunk/test/CodeGenOpenCL/denorms-are-zero.cl cfe/tru

r331214 - clang-cl: Expose -fmerge-all-constants

Author: hans Date: Mon Apr 30 12:04:04 2018 New Revision: 331214 URL: http://llvm.org/viewvc/llvm-project?rev=331214&view=rev Log: clang-cl: Expose -fmerge-all-constants Now that constant merging is off by default, we'd like a way to enable it on Windows. Modified: cfe/trunk/include/clang/Dr

r335466 - [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801)

Author: hans Date: Mon Jun 25 06:23:49 2018 New Revision: 335466 URL: http://llvm.org/viewvc/llvm-project?rev=335466&view=rev Log: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801) With MSVC, PCH files are created along with an object file that needs to be linked into

Re: r335781 - DR1687: When overload resolution selects a built-in operator, implicit

On Wed, Jun 27, 2018 at 10:30 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jun 27 13:30:34 2018 > New Revision: 335781 > > URL: http://llvm.org/viewvc/llvm-project?rev=335781&view=rev > Log: > DR1687: When overload resolution selects a built-in operator, implicit > convers

Re: r336021 - PR33924: merge local declarations that have linkage of some kind within

Hi Richard, This introduced test failures on Windows, but for some reason only in 32-bit builds: https://bugs.llvm.org/show_bug.cgi?id=38015 I don't know what's going on yet, just finished the bisection. Maybe it reproduces in 32-bit linux builds too? - Hans On Fri, Jun 29, 2018 at 11:58 PM, R

r336175 - Revert r336021 "PR33924: merge local declarations that have linkage of some kind within"

Author: hans Date: Tue Jul 3 00:51:41 2018 New Revision: 336175 URL: http://llvm.org/viewvc/llvm-project?rev=336175&view=rev Log: Revert r336021 "PR33924: merge local declarations that have linkage of some kind within" This caused test failures in 32-bit builds (PR38015). > merged function def

Re: r336021 - PR33924: merge local declarations that have linkage of some kind within

I've reverted in r336175 in the meantime to green the tests. On Mon, Jul 2, 2018 at 5:21 PM, Hans Wennborg wrote: > Hi Richard, > > This introduced test failures on Windows, but for some reason only in > 32-bit builds: https://bugs.llvm.org/show_bug.cgi?id=38015 > > I don't know what's going on y

r336415 - [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal

Author: hans Date: Thu Jul 5 23:54:16 2018 New Revision: 336415 URL: http://llvm.org/viewvc/llvm-project?rev=336415&view=rev Log: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal A Chromium developer reported a bug which turned out to be a mangli

r373887 - clang-cl: Ignore the new /ZH options

Author: hans Date: Mon Oct 7 02:30:15 2019 New Revision: 373887 URL: http://llvm.org/viewvc/llvm-project?rev=373887&view=rev Log: clang-cl: Ignore the new /ZH options These were added to the MS docs in https://github.com/MicrosoftDocs/cpp-docs/commit/85b9b6967e58e485251450f7451673f6fc873e88 and

r374148 - Unify the two CRC implementations

Author: hans Date: Wed Oct 9 02:06:30 2019 New Revision: 374148 URL: http://llvm.org/viewvc/llvm-project?rev=374148&view=rev Log: Unify the two CRC implementations David added the JamCRC implementation in r246590. More recently, Eugene added a CRC-32 implementation in r357901, which falls back t

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

As expected, this broke the Chromium build again (but it seems only at -Oz this time). I'm still not a big fan of the warning: the #pragma tells the compiler to vectorize, and then vectorization doesn't happen -- that sounds like a compiler bug to me, and instead of pushing the problem on the deve

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

> On Mon, Oct 21, 2019 at 9:18 AM Hans Wennborg via cfe-commits > wrote: >> >> As expected, this broke the Chromium build again (but it seems only at >> -Oz this time). > > > To be clear, is the desired behavior that the vectorization is performed even > at -

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Hi Volodymyr, This broke the Chrome build in an interesting way. Here's a reduced repro: $ cat /tmp/a.mm #import void f(int width, int height) { FourCharCode best_fourcc = kCMPixelFormat_422YpCbCr8_yuvs; NSDictionary* videoSettingsDictionary = @{ (id)kCVPixelBufferPixelFormatTypeKey :

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Since it looks suspicious, can we revert your change in the meantime? We have a number of instances where this fires, so it's not just one place we'd need to work around it. On Mon, Oct 21, 2019 at 6:39 PM Volodymyr Sapsai wrote: > > That error looks strange and confusing to me too. My guess is t

[clang] 4c539e8 - Revert r374202"[ObjC generics] Fix not inheriting type bounds in categories/extensions."

Author: Hans Wennborg Date: 2019-10-22T22:39:01+02:00 New Revision: 4c539e8da1b3de38a53ef3f7497f5c45a3243b61 URL: https://github.com/llvm/llvm-project/commit/4c539e8da1b3de38a53ef3f7497f5c45a3243b61 DIFF: https://github.com/llvm/llvm-project/commit/4c539e8da1b3de38a53ef3f7497f5c45a3243b61.diff

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

I've gone ahead and reverted in 4c539e8. On Tue, Oct 22, 2019 at 10:43 AM Hans Wennborg wrote: > > Since it looks suspicious, can we revert your change in the meantime? > We have a number of instances where this fires, so it's not just one > place we'd need to work around it. > > On Mon, Oct 21,

Re: r375125 - [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object

Since we ran into a couple of errors in Chromium when rolling past this, would you like to add a note about it in the release notes since it's possible that others will be affected too? On Thu, Oct 17, 2019 at 5:24 PM James Y Knight via cfe-commits wrote: > > Author: jyknight > Date: Thu Oct 17 0

[clang] 8513a68 - [clang-cl] Allow a colon after the /Fe option (PR46720)

Author: Hans Wennborg Date: 2020-07-20T12:06:41+02:00 New Revision: 8513a681f7d8d1188706762e712168aebc3119dd URL: https://github.com/llvm/llvm-project/commit/8513a681f7d8d1188706762e712168aebc3119dd DIFF: https://github.com/llvm/llvm-project/commit/8513a681f7d8d1188706762e712168aebc3119dd.diff

[clang] 238bbd4 - Revert abd45154b "[Coverage] Add comment to skipped regions"

Author: Hans Wennborg Date: 2020-07-22T17:09:20+02:00 New Revision: 238bbd48c5a5f84deca36e5df980241578f7c1df URL: https://github.com/llvm/llvm-project/commit/238bbd48c5a5f84deca36e5df980241578f7c1df DIFF: https://github.com/llvm/llvm-project/commit/238bbd48c5a5f84deca36e5df980241578f7c1df.diff

[clang] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[clang-tools-extra] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[clang-tools-extra] 47a0254 - Speculative build fix for clangd/Features.inc.in

Author: Hans Wennborg Date: 2020-07-27T13:39:54+02:00 New Revision: 47a0254229ca425aa4e169c2db14e92b8db86784 URL: https://github.com/llvm/llvm-project/commit/47a0254229ca425aa4e169c2db14e92b8db86784 DIFF: https://github.com/llvm/llvm-project/commit/47a0254229ca425aa4e169c2db14e92b8db86784.diff

[clang-tools-extra] 40d11a8 - ClangdMain.cpp: this #ifdef should be an #if

Author: Hans Wennborg Date: 2020-07-27T14:05:02+02:00 New Revision: 40d11a878044711708fb6738e4b78a4c9ac3de7b URL: https://github.com/llvm/llvm-project/commit/40d11a878044711708fb6738e4b78a4c9ac3de7b DIFF: https://github.com/llvm/llvm-project/commit/40d11a878044711708fb6738e4b78a4c9ac3de7b.diff

[clang-tools-extra] 529441e - Fix another #ifdef CLANGD_ENABLE_REMOTE

Author: Hans Wennborg Date: 2020-07-27T14:11:29+02:00 New Revision: 529441e88e81a2e7dae6108e3d95e043c670e1a6 URL: https://github.com/llvm/llvm-project/commit/529441e88e81a2e7dae6108e3d95e043c670e1a6 DIFF: https://github.com/llvm/llvm-project/commit/529441e88e81a2e7dae6108e3d95e043c670e1a6.diff

[clang-tools-extra] 08e9556 - llvm_canonicalize_cmake_booleans(CLANGD_ENABLE_REMOTE)

Author: Hans Wennborg Date: 2020-07-27T14:42:04+02:00 New Revision: 08e9556d5d77fb424b8cb99fe16ffe2bc77f555e URL: https://github.com/llvm/llvm-project/commit/08e9556d5d77fb424b8cb99fe16ffe2bc77f555e DIFF: https://github.com/llvm/llvm-project/commit/08e9556d5d77fb424b8cb99fe16ffe2bc77f555e.diff

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

I'm seeing this failure when trying to build the Windows package for http://llvm.org/builds (yes, it's been a while). Not sure why it hasn't been on the bots (maybe the Windows bots don't build the nvptx target). Anyway, the error comes from "nocudalib" not being a valid clang-cl option. Is it supp

[clang] f8e1fc2 - Make clang/test/Driver/cl-options.cu pass in 32-bit builds

Author: Hans Wennborg Date: 2020-04-06T16:04:43+02:00 New Revision: f8e1fc20cb3984faf62cdd947e4d1a408a9000d8 URL: https://github.com/llvm/llvm-project/commit/f8e1fc20cb3984faf62cdd947e4d1a408a9000d8 DIFF: https://github.com/llvm/llvm-project/commit/f8e1fc20cb3984faf62cdd947e4d1a408a9000d8.diff

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

Oh no, the warning is a red herring. The problem is I'm doing a 32-bit build and the triple is nvptx-nvidia-cuda, not nvptx64-nvidia-cuda. f8e1fc20cb3 should fix. On Mon, Apr 6, 2020 at 3:54 PM Hans Wennborg wrote: > > I'm seeing this failure when trying to build the Windows package for > http:/

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

On Mon, Apr 6, 2020 at 7:36 PM Artem Belevich wrote: > > Yup 32-bit vis 64-bit does dis trip linux tests, too some time back. We ended > up passing explicit target triples to avoid host architecture leaking into > the test. > > On a side note, shouldn't we pass -nocudalib via /clang: ? Yes, tha

[clang] 767516c - Fix gcc5 build of ASTMatchersTest.h

Author: Hans Wennborg Date: 2020-06-05T10:38:03+02:00 New Revision: 767516c5463a58f64cc3e0e1125b761aedceecf5 URL: https://github.com/llvm/llvm-project/commit/767516c5463a58f64cc3e0e1125b761aedceecf5 DIFF: https://github.com/llvm/llvm-project/commit/767516c5463a58f64cc3e0e1125b761aedceecf5.diff

[clang] 108560e - Try to remove the acle_sve_adda.s file that's breaking tests

Author: Hans Wennborg Date: 2020-06-18T11:59:53+02:00 New Revision: 108560e58c41fc70341d763b941a0d6c24c4d3a9 URL: https://github.com/llvm/llvm-project/commit/108560e58c41fc70341d763b941a0d6c24c4d3a9 DIFF: https://github.com/llvm/llvm-project/commit/108560e58c41fc70341d763b941a0d6c24c4d3a9.diff

[clang] d8c612b - Make matrix-type-builtins.m pass also on platforms where the type is 'unsigned long long'

Author: Hans Wennborg Date: 2020-06-18T14:06:55+02:00 New Revision: d8c612b7eabcc7ec399fad533d5beefa4ae08ac9 URL: https://github.com/llvm/llvm-project/commit/d8c612b7eabcc7ec399fad533d5beefa4ae08ac9 DIFF: https://github.com/llvm/llvm-project/commit/d8c612b7eabcc7ec399fad533d5beefa4ae08ac9.diff

Re: [clang] dcd76c0 - [Lexer] Fix missing coverage line after #endif

Nice! On Fri, Jul 10, 2020 at 6:05 PM Zequan Wu via cfe-commits wrote: > > > Author: Zequan Wu > Date: 2020-07-10T09:05:20-07:00 > New Revision: dcd76c0c0716a4417110423718c7cae4b516b4d0 > > URL: > https://github.com/llvm/llvm-project/commit/dcd76c0c0716a4417110423718c7cae4b516b4d0 > DIFF: > htt

[clang-tools-extra] 7ab7b97 - Bump the trunk major version to 12

Author: Hans Wennborg Date: 2020-07-15T12:05:05+02:00 New Revision: 7ab7b979d29e1e43701cf690f5cf1903740f50e3 URL: https://github.com/llvm/llvm-project/commit/7ab7b979d29e1e43701cf690f5cf1903740f50e3 DIFF: https://github.com/llvm/llvm-project/commit/7ab7b979d29e1e43701cf690f5cf1903740f50e3.diff

Re: [clang] eb4c758 - [Matrix] Pass darwin tripe to SeamObjc test to fix windows bot failure.

Thanks! I see it also fails on ARM (http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/4438), so my sneaky change to fix the test (d8c612b7eabcc7ec399fad533d5beefa4ae08ac9) was not enough. On Thu, Jun 18, 2020 at 2:36 PM Florian Hahn via cfe-commits wrote: > > > Author: Florian Hahn >

[clang] b4c7a75 - Don't require shell in clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c

Author: Hans Wennborg Date: 2020-06-18T17:21:48+02:00 New Revision: b4c7a7542f482b4e1ac1d3936314fafd30b3b8db URL: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db DIFF: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db.diff

[clang] a8e582c - [ThinLTO] Always parse module level inline asm with At&t dialect (PR46503)

Author: Hans Wennborg Date: 2020-07-01T09:43:45+02:00 New Revision: a8e582c8307ba1d33c05d272b5c1b755fa809b51 URL: https://github.com/llvm/llvm-project/commit/a8e582c8307ba1d33c05d272b5c1b755fa809b51 DIFF: https://github.com/llvm/llvm-project/commit/a8e582c8307ba1d33c05d272b5c1b755fa809b51.diff

[clang] f03b505 - Revert f8990feb125a "[libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON"

Author: Hans Wennborg Date: 2020-04-28T10:10:33+02:00 New Revision: f03b505ee7f23018493b93e3828fc3672c6f903c URL: https://github.com/llvm/llvm-project/commit/f03b505ee7f23018493b93e3828fc3672c6f903c DIFF: https://github.com/llvm/llvm-project/commit/f03b505ee7f23018493b93e3828fc3672c6f903c.diff

[clang] 209ab6d - Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC"

Author: Hans Wennborg Date: 2020-04-29T15:12:43+02:00 New Revision: 209ab6d8835cd88320ceb814893759cfbda91d15 URL: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15 DIFF: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15.diff

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

On Sun, Apr 26, 2020 at 1:17 PM David Zarzycki via cfe-commits wrote: > > > Author: David Zarzycki > Date: 2020-04-26T07:16:42-04:00 > New Revision: 665471907a5c072c6653a38c35f35e5d54cef220 > > URL: > https://github.com/llvm/llvm-project/commit/665471907a5c072c6653a38c35f35e5d54cef220 > DIFF: >

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Your suggestion of > if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) sounds good to me. I don't know what the non-Windows non-PIC problem was exactly (your commit didn't mention it), so maybe it's best if you land that to verify it fixes the issue? Thanks, Hans On Wed, Apr 29, 2020

[clang-tools-extra] 3c2c776 - Fix building with GCC5 after e64f99c51a8e

Author: Hans Wennborg Date: 2020-05-04T11:12:39+02:00 New Revision: 3c2c7760d9eea0236c5c54e8939b3901f4208835 URL: https://github.com/llvm/llvm-project/commit/3c2c7760d9eea0236c5c54e8939b3901f4208835 DIFF: https://github.com/llvm/llvm-project/commit/3c2c7760d9eea0236c5c54e8939b3901f4208835.diff

[clang] 3ab0155 - Revert "[CMake] Simplify CMake handling for zlib"

Author: Hans Wennborg Date: 2020-08-05T12:31:44+02:00 New Revision: 3ab01550b632dad46f9595d74855749557ffd25c URL: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c DIFF: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c.diff

Re: [PATCH] D84782: [PGO] Include the mem ops into the function hash.

On Wed, Aug 5, 2020 at 6:26 PM Hiroshi Yamauchi via llvm-commits wrote: > > > > On Wed, Aug 5, 2020 at 8:30 AM Hans Wennborg via Phabricator > wrote: >> >> hans added a comment. >> >> In D84782#2191429 , @yamauchi wrote: >> >> > In D84782#2191243

[clang] 55b9b11 - Don't assert about missing profile info in createProfileWeightsForLoop

Author: Hans Wennborg Date: 2020-05-05T18:59:00+02:00 New Revision: 55b9b11fea3e18b6826c39842bc43877d9eb57fd URL: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd DIFF: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd.diff

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

On Sat, May 9, 2020 at 4:32 AM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-05-08T19:32:00-07:00 > New Revision: c90e198107431f64b73686bdce31c293e3380ac7 > > URL: > https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7 > DIFF: > htt

[clang] 87b235d - Turn -Wmax-tokens off by default

Author: Hans Wennborg Date: 2020-05-18T13:21:46+02:00 New Revision: 87b235db63a3d8d5b82d60ef6202b92b94a7d9d2 URL: https://github.com/llvm/llvm-project/commit/87b235db63a3d8d5b82d60ef6202b92b94a7d9d2 DIFF: https://github.com/llvm/llvm-project/commit/87b235db63a3d8d5b82d60ef6202b92b94a7d9d2.diff

Re: [PATCH] D79595: Fix bugs when an included file name is typo corrected.

+thakis who I think fell off the cc list On Thu, May 14, 2020 at 12:51 AM Abhinav Gaba via Phabricator wrote: > > abhinavgaba added inline comments. > > > > Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 > // RUN: touch %t.dir/foo.h > -// RUN: not %clang_cl /FI\\?

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm! https://reviews.llvm.org/D24775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D3771: clang-cl: Add support for -o

hans closed this revision. hans added a comment. Ehsan added support for -o with r217615. https://reviews.llvm.org/D3771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283256 - clang-cl: expose the -fuse-ld option

Author: hans Date: Tue Oct 4 16:01:00 2016 New Revision: 283256 URL: http://llvm.org/viewvc/llvm-project?rev=283256&view=rev Log: clang-cl: expose the -fuse-ld option Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Driver/cl-link.c Modified: cfe/trunk/include/clang/Dr

r283257 - clang-cl: Use the .obj file extension also in LTO mode

Author: hans Date: Tue Oct 4 16:01:02 2016 New Revision: 283257 URL: http://llvm.org/viewvc/llvm-project?rev=283257&view=rev Log: clang-cl: Use the .obj file extension also in LTO mode Modified: cfe/trunk/lib/Driver/Types.cpp cfe/trunk/test/Driver/cl-outputs.c Modified: cfe/trunk/lib/Dr

r283255 - clang-cl: Expose the -flto option

Author: hans Date: Tue Oct 4 16:00:57 2016 New Revision: 283255 URL: http://llvm.org/viewvc/llvm-project?rev=283255&view=rev Log: clang-cl: Expose the -flto option We could hook up /GL as an alias for -flto, but that might be confusing, as clang-cl in that mode would not be drop-in compatible wi

r283258 - clang-cl: Make /Fo apply also when using -flto

Author: hans Date: Tue Oct 4 16:01:04 2016 New Revision: 283258 URL: http://llvm.org/viewvc/llvm-project?rev=283258&view=rev Log: clang-cl: Make /Fo apply also when using -flto Modified: cfe/trunk/lib/Driver/Driver.cpp cfe/trunk/test/Driver/cl-outputs.c Modified: cfe/trunk/lib/Driver/Dr

[PATCH] D25334: Implement __stosb intrinsic as a volatile memset

hans added inline comments. > CGBuiltin.cpp:7604 > + case X86::BI__stosb: { > +// we treat __stosb as volatile memset - it may not generate "rep stosb" > +// instruction, but it will create a memset that won't be optimized away Nit: I'd suggest capital w for "We" and ending the sentenc

[PATCH] D25353: Implement __emul, __emulu, _mul128 and _umul128 MS intrinsics

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with some nits Comment at: lib/CodeGen/CGBuiltin.cpp:7592 Value *LHS = EmitScalarExpr(E->getArg(0)); Value *RHS = EmitScalarExpr(E->getArg(1)); llvm::Type *Re

[PATCH] D25540: Implement MS _ReturnAddress and _AddressOfReturnAddress intrinsics

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with a comment Comment at: test/CodeGen/ms-intrinsics.c:3 // RUN: -triple i686--windows -Oz -emit-llvm %s -o - \ -// RUN: | FileCheck %s -check-prefix=CHECK

r319386 - MS ABI: Treat explicit instantiation definitions of dllimport function templates as explicit instantiation decls (PR35435)

Author: hans Date: Wed Nov 29 15:44:11 2017 New Revision: 319386 URL: http://llvm.org/viewvc/llvm-project?rev=319386&view=rev Log: MS ABI: Treat explicit instantiation definitions of dllimport function templates as explicit instantiation decls (PR35435) This matches MSVC's behaviour, and we alre

[clang-tools-extra] r319690 - Fix build after r319688: s/CPlusPlus1z/CPlusPlus17/

Author: hans Date: Mon Dec 4 12:38:21 2017 New Revision: 319690 URL: http://llvm.org/viewvc/llvm-project?rev=319690&view=rev Log: Fix build after r319688: s/CPlusPlus1z/CPlusPlus17/ Modified: clang-tools-extra/trunk/clang-tidy/modernize/UnaryStaticAssertCheck.cpp Modified: clang-tools-extr

r319707 - Correctly handle line table entries without filenames during AST serialization

Author: hans Date: Mon Dec 4 14:28:45 2017 New Revision: 319707 URL: http://llvm.org/viewvc/llvm-project?rev=319707&view=rev Log: Correctly handle line table entries without filenames during AST serialization The current code would hit an assert in ASTWriter when trying to write out the filename

Re: r319875 - Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.

This made Clang start warning about unsigned vs enum compares on Windows. $ echo 'enum E { foo }; bool f(unsigned a, E b) { return a == b; }' | bin/clang -Wsign-compare -c -x c++ - -target i686-pc-win32 :1:52: warning: comparison of integers of different signs: 'unsigned int' and 'E' [-Wsign-compa

r320133 - Revert r320124 "Fold together the in-range and out-of-range portions of -Wtautological-compare."

Author: hans Date: Thu Dec 7 21:19:12 2017 New Revision: 320133 URL: http://llvm.org/viewvc/llvm-project?rev=320133&view=rev Log: Revert r320124 "Fold together the in-range and out-of-range portions of -Wtautological-compare." This broke Chromium: ../../base/trace_event/trace_log.cc:1545:29: e

Re: r320124 - Fold together the in-range and out-of-range portions of -Wtautological-compare.

I've reverted in r320133 since it caused new warnings in Chromium that I'm not sure were intentional. See comment on the revert. On Thu, Dec 7, 2017 at 5:00 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Dec 7 17:00:27 2017 > New Revision: 320124 > > URL: http://llvm.org/v

r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

Author: hans Date: Fri Dec 8 08:54:08 2017 New Revision: 320162 URL: http://llvm.org/viewvc/llvm-project?rev=320162&view=rev Log: Revert "Unify implementation of our two different flavours of -Wtautological-compare." > Unify implementation of our two different flavours of -Wtautological-compare

Re: r320124 - Fold together the in-range and out-of-range portions of -Wtautological-compare.

Sorry, it seems it was r320124 that caused this; I shouldn't be sheriffing after-hours. I've reverted that one in r320162. On Thu, Dec 7, 2017 at 9:20 PM, Hans Wennborg wrote: > I've reverted in r320133 since it caused new warnings in Chromium that > I'm not sure were intentional. See comment on

Re: r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

On Fri, Dec 8, 2017 at 9:30 AM, Richard Smith via cfe-commits wrote: > On 8 Dec 2017 08:54, "Hans Wennborg via cfe-commits" > wrote: > > Author: hans > Date: Fri Dec 8 08:54:08 2017 > New Revision: 320162 > > URL: http://llvm.org/viewvc/llvm-project?rev=3201

Re: r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

On Fri, Dec 8, 2017 at 11:10 AM, Hans Wennborg wrote: > On Fri, Dec 8, 2017 at 9:30 AM, Richard Smith via cfe-commits > wrote: >> On 8 Dec 2017 08:54, "Hans Wennborg via cfe-commits" >> wrote: >> >> Author: hans >> Date: Fri Dec 8 08:54:0

Re: r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

>> /home/seurer/llvm/llvm-test2/tools/clang/include/clang/AST/Expr.h:2745:17: >> warning: comparison of constant -1 with expression of type 'const >> clang::CastKind' is always true >> [-Wtautological-constant-out-of-range-compare] >> assert(kind != CK_Inv

Re: [PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

+Tom I expect it's too late since 5.0.1 is virtually out the door already. On Mon, Dec 11, 2017 at 2:35 AM, Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a comment. > > Can we still have it in 5.0? > > > Repository: > rL LLVM > > https://reviews.llvm.org/D40

r320405 - Fix warn-enum-compare.cpp on Windows

Author: hans Date: Mon Dec 11 10:58:18 2017 New Revision: 320405 URL: http://llvm.org/viewvc/llvm-project?rev=320405&view=rev Log: Fix warn-enum-compare.cpp on Windows It's been failing since r319875. Modified: cfe/trunk/test/SemaCXX/warn-enum-compare.cpp Modified: cfe/trunk/test/SemaCXX/wa

Re: r319875 - Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.

I've committed a fix to pacify the test in r320405. On Wed, Dec 6, 2017 at 12:27 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke the tests on the builder: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64- > expensive-checks-w

[clang] 49e7ef2 - [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

Author: Julius Date: 2022-09-14T19:48:08+02:00 New Revision: 49e7ef2c09facd722a29a5ad96a7f8f16e362b28 URL: https://github.com/llvm/llvm-project/commit/49e7ef2c09facd722a29a5ad96a7f8f16e362b28 DIFF: https://github.com/llvm/llvm-project/commit/49e7ef2c09facd722a29a5ad96a7f8f16e362b28.diff LOG: [

[clang] 066eea7 - Revert "Reland "clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (#70639)""

Author: Hans Wennborg Date: 2023-11-07T15:52:19+01:00 New Revision: 066eea75d38957353824b46474413ef2632d01a7 URL: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7 DIFF: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7.diff

[clang] a648f34 - [clang-cl] Expose -fmodules and related flags in the driver (PR43391)

Author: Hans Wennborg Date: 2021-07-27T11:27:16+02:00 New Revision: a648f34342740e3fe2ddf040d61909d53b09e323 URL: https://github.com/llvm/llvm-project/commit/a648f34342740e3fe2ddf040d61909d53b09e323 DIFF: https://github.com/llvm/llvm-project/commit/a648f34342740e3fe2ddf040d61909d53b09e323.diff

[clang] 973de71 - Revert "[clang][pp] adds '#pragma include_instead'"

Author: Hans Wennborg Date: 2021-07-27T17:29:48+02:00 New Revision: 973de7185606a21fd5e9d5e8c014fbf898c0e72f URL: https://github.com/llvm/llvm-project/commit/973de7185606a21fd5e9d5e8c014fbf898c0e72f DIFF: https://github.com/llvm/llvm-project/commit/973de7185606a21fd5e9d5e8c014fbf898c0e72f.diff

<    1   2   3   4   5   6   7   8   9   10   >