r317944 - Remove declaration of EmitMCountInstrumentation(). NFC

2017-11-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Nov 10 14:34:23 2017 New Revision: 317944 URL: http://llvm.org/viewvc/llvm-project?rev=317944&view=rev Log: Remove declaration of EmitMCountInstrumentation(). NFC The definition was removed in r280355. Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h Modified: cfe/tr

Re: r315614 - [Sema] Diagnose tautological comparison with type's min/max values

2017-11-13 Thread Hans Wennborg via cfe-commits
On Sat, Nov 11, 2017 at 4:18 AM, Roman Lebedev wrote: > On Fri, Nov 10, 2017 at 9:14 PM, Hans Wennborg wrote: >> On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits >> wrote: >>> On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote: Huh, I consider clang not warning on this a feat

r318109 - Update a link to the old code.google.com bug tracker

2017-11-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Nov 13 15:27:54 2017 New Revision: 318109 URL: http://llvm.org/viewvc/llvm-project?rev=318109&view=rev Log: Update a link to the old code.google.com bug tracker Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp URL: http

r318110 - Update link to protobuf

2017-11-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Nov 13 15:27:55 2017 New Revision: 318110 URL: http://llvm.org/viewvc/llvm-project?rev=318110&view=rev Log: Update link to protobuf Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp URL: http://llvm.org/viewvc/llvm-pro

r318108 - Update link to the Chromium Clang page

2017-11-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Nov 13 15:27:53 2017 New Revision: 318108 URL: http://llvm.org/viewvc/llvm-project?rev=318108&view=rev Log: Update link to the Chromium Clang page Modified: cfe/trunk/www/related.html Modified: cfe/trunk/www/related.html URL: http://llvm.org/viewvc/llvm-project/cfe/tr

r318199 - Switch -mcount and -finstrument-functions to emit EnterExitInstrumenter attributes

2017-11-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Nov 14 13:13:27 2017 New Revision: 318199 URL: http://llvm.org/viewvc/llvm-project?rev=318199&view=rev Log: Switch -mcount and -finstrument-functions to emit EnterExitInstrumenter attributes This updates -mcount to use the new attribute names (LLVM r318195), and switches o

r318214 - Try to fix the instrument-functions tests

2017-11-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Nov 14 15:10:04 2017 New Revision: 318214 URL: http://llvm.org/viewvc/llvm-project?rev=318214&view=rev Log: Try to fix the instrument-functions tests On e.g. PPC the return value and argument were marked 'signext'. This makes the test expectations a bit more flexible. Foll

r318309 - BuiltinOperatorOverloadBuilder: Don't consider types that are unavailable on the target (PR35174)

2017-11-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Nov 15 09:11:53 2017 New Revision: 318309 URL: http://llvm.org/viewvc/llvm-project?rev=318309&view=rev Log: BuiltinOperatorOverloadBuilder: Don't consider types that are unavailable on the target (PR35174) In the PR, Clang ended up in a situation where it tried to mangle t

r318314 - Try to fix test/SemaCXX/deleted-operator.cpp after r318309

2017-11-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Nov 15 09:47:58 2017 New Revision: 318314 URL: http://llvm.org/viewvc/llvm-project?rev=318314&view=rev Log: Try to fix test/SemaCXX/deleted-operator.cpp after r318309 The number of 'built-in candidate' notes now varies since __float128 may or may not be a candidate dependin

r318578 - Fix some -Wunused-variable warnings

2017-11-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Nov 17 16:49:18 2017 New Revision: 318578 URL: http://llvm.org/viewvc/llvm-project?rev=318578&view=rev Log: Fix some -Wunused-variable warnings Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/CodeGen/CGStmt.cpp cfe/trunk/lib/CodeGen/CGStmtOpenM

Re: r318536 - [OPENMP] Codegen for `target simd` construct.

2017-11-17 Thread Hans Wennborg via cfe-commits
I think this caused some unused variable warnings: ../tools/clang/lib/CodeGen/CGStmtOpenMP.cpp:360:25: warning: unused variable 'ExtInfo' [-Wunused-variable] FunctionType::ExtInfo ExtInfo; ^ 1 warning generated. [3049/3507] Building CXX object tools/clang/lib/CodeGen/CMak

Re: r318536 - [OPENMP] Codegen for `target simd` construct.

2017-11-17 Thread Hans Wennborg via cfe-commits
Ah ok. Thanks for checking! On Fri, Nov 17, 2017 at 4:59 PM, Alexey Bataev wrote: > No, it is caused by some other changes. Seems to me, somebody changed the > interface of functions, but forgot to remove the variables that are not used > anymore. > The changes look good to me, thanks. > > Best r

Re: r318556 - Loosen -Wempty-body warning

2017-11-18 Thread Hans Wennborg via cfe-commits
We're still seeing some in macro-related code. From Chromium: ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if statement has empty body [-Werror,-Wempty-body] ff_dlog(NULL, "new table index=%d size=%d\n", table_index, table_size); ^ ../../third_party/ffmpeg\libavutil/inte

r318665 - Revert r318556 "Loosen -Wempty-body warning"

2017-11-20 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Nov 20 09:38:16 2017 New Revision: 318665 URL: http://llvm.org/viewvc/llvm-project?rev=318665&view=rev Log: Revert r318556 "Loosen -Wempty-body warning" It seems this somehow made -Wempty-body fire in some macro cases where it didn't before, e.g. ../../third_party/ffmpeg

Re: r318556 - Loosen -Wempty-body warning

2017-11-20 Thread Hans Wennborg via cfe-commits
I've reverted in r318665 to get the buildbots green until this is figured out. On Sat, Nov 18, 2017 at 11:55 AM, Hans Wennborg wrote: > We're still seeing some in macro-related code. From Chromium: > > ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if > statement has empty body

r318667 - Revert r318456 "Issue -Wempty-body warnings for else blocks"

2017-11-20 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Nov 20 09:48:54 2017 New Revision: 318667 URL: http://llvm.org/viewvc/llvm-project?rev=318667&view=rev Log: Revert r318456 "Issue -Wempty-body warnings for else blocks" This caused warnings also when the if or else comes from macros. There was an attempt to fix this in r318

Re: r318556 - Loosen -Wempty-body warning

2017-11-20 Thread Hans Wennborg via cfe-commits
Reverted the original patch too, in r318667 since I assume that was breaking Ilya's build. Hopefully this is easy to fix and they can be re-landed together. On Mon, Nov 20, 2017 at 9:39 AM, Hans Wennborg wrote: > I've reverted in r318665 to get the buildbots green until this is figured out. > >

Re: r318456 - Issue -Wempty-body warnings for else blocks

2017-11-20 Thread Hans Wennborg via cfe-commits
Reverted in r318667. See coments on the r318556 thread. On Thu, Nov 16, 2017 at 3:32 PM, Richard Smith via cfe-commits wrote: > This is kicking up false positives on code that does the following: > > #define USED(x) if(x);else > // ... > assert(x); > USED(x); > > It's a bit of a weird pattern, b

r318785 - Add -finstrument-function-entry-bare flag

2017-11-21 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Nov 21 09:30:34 2017 New Revision: 318785 URL: http://llvm.org/viewvc/llvm-project?rev=318785&view=rev Log: Add -finstrument-function-entry-bare flag This is an instrumentation flag that's similar to -finstrument-functions, but it only inserts calls on function entry, the c

[clang] 7a85aa9 - Emit const globals with constexpr destructor as constant LLVM values

2023-03-16 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-03-16T11:02:27+01:00 New Revision: 7a85aa918ccd7bba0e3be94436c62432c08d357a URL: https://github.com/llvm/llvm-project/commit/7a85aa918ccd7bba0e3be94436c62432c08d357a DIFF: https://github.com/llvm/llvm-project/commit/7a85aa918ccd7bba0e3be94436c62432c08d357a.diff

[clang] 4a2757d - Make globals used for array initialization codegen constant

2023-03-17 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-03-17T09:23:34+01:00 New Revision: 4a2757d80f0af48e65d90e7eaf268f78bcfa997f URL: https://github.com/llvm/llvm-project/commit/4a2757d80f0af48e65d90e7eaf268f78bcfa997f DIFF: https://github.com/llvm/llvm-project/commit/4a2757d80f0af48e65d90e7eaf268f78bcfa997f.diff

[clang] e495eab - [clang] Include the error message in file reading error diagnostic

2023-03-17 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-03-17T13:47:02+01:00 New Revision: e495eabd326801c1e00508898dbcb04073a31014 URL: https://github.com/llvm/llvm-project/commit/e495eabd326801c1e00508898dbcb04073a31014 DIFF: https://github.com/llvm/llvm-project/commit/e495eabd326801c1e00508898dbcb04073a31014.diff

[clang] 0c545a4 - Revert "clang: Use new frexp intrinsic for builtins and add f16 version"

2023-06-30 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-06-30T13:26:25+02:00 New Revision: 0c545a441285a73e00b859dd52f1a85cb9fc URL: https://github.com/llvm/llvm-project/commit/0c545a441285a73e00b859dd52f1a85cb9fc DIFF: https://github.com/llvm/llvm-project/commit/0c545a441285a73e00b859dd52f1a85cb9fc.diff

[clang] 39938f2 - Fix warn-unsafe-buffer-usage-fixits-pre-increment.cpp for Windows

2023-04-13 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-04-13T10:21:15+02:00 New Revision: 39938f2d096ca9ed03ecc17ea169ed3195682f18 URL: https://github.com/llvm/llvm-project/commit/39938f2d096ca9ed03ecc17ea169ed3195682f18 DIFF: https://github.com/llvm/llvm-project/commit/39938f2d096ca9ed03ecc17ea169ed3195682f18.diff

[clang] b18ca72 - Revert "[Driver] Mark many target-specific driver-only options as TargetSpecific"

2023-06-12 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-06-12T17:18:09+02:00 New Revision: b18ca7296ef16700fadac98abe7fac8c8b44b4da URL: https://github.com/llvm/llvm-project/commit/b18ca7296ef16700fadac98abe7fac8c8b44b4da DIFF: https://github.com/llvm/llvm-project/commit/b18ca7296ef16700fadac98abe7fac8c8b44b4da.diff

[clang] 5160f6f - Revert "[Driver] Mark m_x86_Features_Group options as TargetSpecific"

2023-06-13 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-06-13T12:50:51+02:00 New Revision: 5160f6fefb0021a0b23e99c7cf621a330241c211 URL: https://github.com/llvm/llvm-project/commit/5160f6fefb0021a0b23e99c7cf621a330241c211 DIFF: https://github.com/llvm/llvm-project/commit/5160f6fefb0021a0b23e99c7cf621a330241c211.diff

[clang] cb3ea52 - Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

2022-12-07 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2022-12-07T16:12:38+01:00 New Revision: cb3ea52a5ae5178b8cd257bd61c6e05d9a186b4d URL: https://github.com/llvm/llvm-project/commit/cb3ea52a5ae5178b8cd257bd61c6e05d9a186b4d DIFF: https://github.com/llvm/llvm-project/commit/cb3ea52a5ae5178b8cd257bd61c6e05d9a186b4d.diff

Re: r278763 - PR28978: If we need overload resolution for the move constructor of an

2016-08-16 Thread Hans Wennborg via cfe-commits
r278817. Many thanks. On Mon, Aug 15, 2016 at 5:36 PM, Richard Smith wrote: > Hi Hans, Eric Fiselier requested that we fix this bug for 3.9 (it affects > libc++'s std::optional implementation), so this would be a good candidate > for the branch. > > On Mon, Aug 15, 2016 at 5:13 PM, Richard Smith

Re: Nomination for 3.9: r278786 - Left shifts of negative values are defined if -fwrapv is set

2016-08-16 Thread Hans Wennborg via cfe-commits
Seems reasonable to me if Richard agrees. On Tue, Aug 16, 2016 at 3:01 AM, James Molloy wrote: > Hi Hans, > > [cc. Richard as code owner] > > I'd like to nominate this commit for 3.9. The actual code churn is tiny, and > this fixes a problem noticed by and causing pain to the qemu project. > > Ch

Re: r266775 - Pass dwarf-version to cc1as.

2016-08-16 Thread Hans Wennborg via cfe-commits
Looks like it was committed back in April, so unless I'm missing something it should already be in the branch (which was cut mid-July). Thanks, Hans On Tue, Aug 16, 2016 at 2:16 PM, Dimitry Andric wrote: > Hi Hans, > > Can we please merge this one to release_39 too? I forgot all about it, sorry

Re: r277852 - PR26423: Assert on valid use of using declaration of a function with an undeduced auto return type

2016-08-16 Thread Hans Wennborg via cfe-commits
On Fri, Aug 5, 2016 at 12:03 PM, David Blaikie via cfe-commits wrote: > Author: dblaikie > Date: Fri Aug 5 14:03:01 2016 > New Revision: 277852 > > URL: http://llvm.org/viewvc/llvm-project?rev=277852&view=rev > Log: > PR26423: Assert on valid use of using declaration of a function with an > unde

Re: Nomination for 3.9: r278786 - Left shifts of negative values are defined if -fwrapv is set

2016-08-17 Thread Hans Wennborg via cfe-commits
ed to be a GCC-compatible > flag so behaving as they do seems reasonable.) > > > On Tue, Aug 16, 2016 at 9:38 AM, Aaron Ballman > wrote: >> >> I'm not Richard, but I agree with merging it into 3.9 nonetheless. :-) >> >> ~Aaron >> >> On

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

2016-08-17 Thread Hans Wennborg via cfe-commits
I'd rather not take this actually, as it looks like a large change, isn't fixing a regression, and it's time to start wrapping up the release. On Wed, Aug 17, 2016 at 3:46 AM, Dimitry Andric wrote: > Marshall, this is maybe a good candidate for merging to release_39? > > -Dimitry > >> On 17 Aug 2

Re: [clang-tools-extra] r278949 - [Include-fixer] Install executables and support scripts

2016-08-17 Thread Hans Wennborg via cfe-commits
On Wed, Aug 17, 2016 at 10:27 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Wed Aug 17 12:27:56 2016 > New Revision: 278949 > > URL: http://llvm.org/viewvc/llvm-project?rev=278949&view=rev > Log: > [Include-fixer] Install executables and support scripts > > Differential

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

2016-08-17 Thread Hans Wennborg via cfe-commits
On Wed, Aug 17, 2016 at 5:25 PM, Marshall Clow wrote: > On Wed, Aug 17, 2016 at 3:14 PM, Hans Wennborg wrote: >> >> I'd rather not take this actually, as it looks like a large change, >> isn't fixing a regression, and it's time to start wrapping up the >> release. >> > This is actually a pretty s

[libcxx] r279015 - Merging r278904:

2016-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 17 19:20:59 2016 New Revision: 279015 URL: http://llvm.org/viewvc/llvm-project?rev=279015&view=rev Log: Merging r278904: r278904 | marshall | 2016-08-16 22:58:40 -0700 (Tue, 16 Aug 2016) | 1 line S

[libcxx] r279017 - Merging r279008:

2016-08-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 17 19:23:33 2016 New Revision: 279017 URL: http://llvm.org/viewvc/llvm-project?rev=279017&view=rev Log: Merging r279008: r279008 | marshall | 2016-08-17 16:24:02 -0700 (Wed, 17 Aug 2016) | 1 line m

Re: Please take r279008 for the release

2016-08-17 Thread Hans Wennborg via cfe-commits
On Wed, Aug 17, 2016 at 5:27 PM, Marshall Clow wrote: > Unlike the #278904, this does fix a bug - and a non-trivial one at that. Thanks! I've merged it in r279017. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [libcxx] r279008 - make the associative containers do the right thing for propogate_on_container_assignment. Fixes bug #29001. Tests are only for right now - more complete tests will come wh

2016-08-17 Thread Hans Wennborg via cfe-commits
On Wed, Aug 17, 2016 at 4:24 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Wed Aug 17 18:24:02 2016 > New Revision: 279008 > > URL: http://llvm.org/viewvc/llvm-project?rev=279008&view=rev > Log: > make the associative containers do the right thing for > propogate_on_containe

Re: Upgrade and fix clang-format-vs

2016-08-18 Thread Hans Wennborg via cfe-commits
Hi Antonio, On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits wrote: > This patch for clang-format-vs includes the following: > > - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and > upgrading Microsoft.VisualStudio references to v14 versions > - Fix build

[libcxxabi] r279189 - Creating release candidate rc2 from release_390 branch

2016-08-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 18 20:42:38 2016 New Revision: 279189 URL: http://llvm.org/viewvc/llvm-project?rev=279189&view=rev Log: Creating release candidate rc2 from release_390 branch Added: libcxxabi/tags/RELEASE_390/rc2/ (props changed) - copied from r279188, libcxxabi/branches/re

[libcxx] r279188 - Creating release candidate rc2 from release_390 branch

2016-08-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 18 20:42:35 2016 New Revision: 279188 URL: http://llvm.org/viewvc/llvm-project?rev=279188&view=rev Log: Creating release candidate rc2 from release_390 branch Added: libcxx/tags/RELEASE_390/rc2/ (props changed) - copied from r279187, libcxx/branches/release_

[libunwind] r279195 - Creating release candidate rc2 from release_390 branch

2016-08-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 18 20:42:56 2016 New Revision: 279195 URL: http://llvm.org/viewvc/llvm-project?rev=279195&view=rev Log: Creating release candidate rc2 from release_390 branch Added: libunwind/tags/RELEASE_390/rc2/ (props changed) - copied from r279194, libunwind/branches/re

Re: [PATCH] D23807: clang-cl: Accept MSVC 2015's `/source-charset:utf-8` flag.

2016-08-23 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

2016-08-23 Thread Hans Wennborg via cfe-commits
hans created this revision. hans added reviewers: thakis, rsmith. hans added a subscriber: cfe-commits. It turns out several Chromium developers rely on this on Windows. I'm not sure about the internal flag name. And do we want to expose this in non-cl mode too? https://reviews.llvm.org/D23816

[libcxx] r279709 - Creating release candidate rc3 from release_390 branch

2016-08-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 24 22:32:22 2016 New Revision: 279709 URL: http://llvm.org/viewvc/llvm-project?rev=279709&view=rev Log: Creating release candidate rc3 from release_390 branch Added: libcxx/tags/RELEASE_390/rc3/ (props changed) - copied from r279708, libcxx/branches/release_

[libcxxabi] r279710 - Creating release candidate rc3 from release_390 branch

2016-08-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 24 22:32:25 2016 New Revision: 279710 URL: http://llvm.org/viewvc/llvm-project?rev=279710&view=rev Log: Creating release candidate rc3 from release_390 branch Added: libcxxabi/tags/RELEASE_390/rc3/ (props changed) - copied from r279709, libcxxabi/branches/re

[libunwind] r279716 - Creating release candidate rc3 from release_390 branch

2016-08-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 24 22:32:43 2016 New Revision: 279716 URL: http://llvm.org/viewvc/llvm-project?rev=279716&view=rev Log: Creating release candidate rc3 from release_390 branch Added: libunwind/tags/RELEASE_390/rc3/ (props changed) - copied from r279715, libunwind/branches/re

Re: [PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

2016-08-25 Thread Hans Wennborg via cfe-commits
hans added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias; thakis wrote: > Hm, I'm not sure this should affect __FILE__. It

Re: [PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

2016-08-25 Thread Hans Wennborg via cfe-commits
hans added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias; thakis wrote: > hans wrote: > > thakis wrote: > > > Hm, I'm not s

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

2016-08-25 Thread Hans Wennborg via cfe-commits
hans retitled this revision from "clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__" to "Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics". hans updated the summary for this revision. hans updated this revision to Diff 69300. hans added a comm

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

2016-08-25 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 69304. hans added a comment. Addressing Richard's comments. https://reviews.llvm.org/D23816 Files: include/clang/Basic/DiagnosticOptions.def include/clang/Driver/CLCompatOptions.td include/clang/Driver/Options.td include/clang/Frontend/TextDiagnostic.h

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

2016-08-25 Thread Hans Wennborg via cfe-commits
hans marked an inline comment as done. Comment at: include/clang/Driver/Options.td:994 @@ -993,1 +993,3 @@ Flags<[CC1Option]>, HelpText<"Do not include source location information with diagnostics">; +def fdiagnostics_abs_path : Flag<["-"], "fdiagnostics-abs-path">, Group, +

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

2016-08-25 Thread Hans Wennborg via cfe-commits
hans added inline comments. Comment at: lib/Frontend/TextDiagnostic.cpp:770-777 @@ +769,10 @@ + if (DiagOpts->AbsolutePath) { +const DirectoryEntry *Dir = SM.getFileManager().getDirectory( +llvm::sys::path::parent_path(Filename)); +if (Dir) { + StringRef DirN

r279827 - Add support for -fdiagnostics-absolute-paths: printing absolute paths in diagnostics

2016-08-26 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 26 10:45:36 2016 New Revision: 279827 URL: http://llvm.org/viewvc/llvm-project?rev=279827&view=rev Log: Add support for -fdiagnostics-absolute-paths: printing absolute paths in diagnostics Differential Revision: https://reviews.llvm.org/D23816 Added: cfe/trunk/tes

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

2016-08-26 Thread Hans Wennborg via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279827: Add support for -fdiagnostics-absolute-paths: printing absolute paths in… (authored by hans). Changed prior to commit: https://reviews.llvm.org/D23816?vs=69304&id=69384#toc Repository: rL LLV

Re: [PATCH] D23938: clang-cl: Accept MSVC 2015's `/execution-charset:utf-8` flag.

2016-08-26 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm majnemer's suggestion sounds good though, and for inputCharset too. https://reviews.llvm.org/D23938 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D23945: clang-cl: Support MSVC2015's /validate-charset flag.

2016-08-26 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[libcxxabi] r280318 - Creating release candidate final from release_390 branch

2016-08-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 31 18:31:22 2016 New Revision: 280318 URL: http://llvm.org/viewvc/llvm-project?rev=280318&view=rev Log: Creating release candidate final from release_390 branch Added: libcxxabi/tags/RELEASE_390/final/ (props changed) - copied from r280317, libcxxabi/branche

[libcxx] r280317 - Creating release candidate final from release_390 branch

2016-08-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 31 18:31:18 2016 New Revision: 280317 URL: http://llvm.org/viewvc/llvm-project?rev=280317&view=rev Log: Creating release candidate final from release_390 branch Added: libcxx/tags/RELEASE_390/final/ (props changed) - copied from r280316, libcxx/branches/rele

[libunwind] r280324 - Creating release candidate final from release_390 branch

2016-08-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 31 18:31:40 2016 New Revision: 280324 URL: http://llvm.org/viewvc/llvm-project?rev=280324&view=rev Log: Creating release candidate final from release_390 branch Added: libunwind/tags/RELEASE_390/final/ (props changed) - copied from r280323, libunwind/branche

Re: [PATCH] D24193: Allow variables with asm labels in naked functions

2016-09-02 Thread Hans Wennborg via cfe-commits
hans added a comment. I think this is reasonable. Just a few comments: Comment at: lib/Sema/SemaDecl.cpp:11796 @@ +11795,3 @@ +if (auto *DS = dyn_cast(S)) { + if (DS->isSingleDecl()) { +if (auto *Var = dyn_cast_or_null(DS->getSingleDecl())) { ---

[clang-tools-extra] r280539 - Remove link to clang's release notes; keeping it up-to-date is hard

2016-09-02 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Sep 2 15:39:46 2016 New Revision: 280539 URL: http://llvm.org/viewvc/llvm-project?rev=280539&view=rev Log: Remove link to clang's release notes; keeping it up-to-date is hard Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/doc

Re: [PATCH] D24193: Allow variables with asm labels in naked functions

2016-09-12 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm I'm a little bit worried that we've started down a slippery slope of deciding what is and isn't allowed in naked functions (for example, some initializers could be allowed if we're sure they

r281395 - Try harder to not inline dllimport functions referencing non-dllimport functions

2016-09-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Sep 13 16:08:20 2016 New Revision: 281395 URL: http://llvm.org/viewvc/llvm-project?rev=281395&view=rev Log: Try harder to not inline dllimport functions referencing non-dllimport functions In r246338, code was added to check for this, but it failed to take into account impl

Re: r281395 - Try harder to not inline dllimport functions referencing non-dllimport functions

2016-09-13 Thread Hans Wennborg via cfe-commits
be any problem with operator= though. On Tue, Sep 13, 2016 at 2:36 PM, Nico Weber via cfe-commits wrote: > Could other implicit functions (operator=, ctors) have similar issues? > > On Tue, Sep 13, 2016 at 5:08 PM, Hans Wennborg via cfe-commits > wrote: >> >> Author: h

r281413 - Also don't inline dllimport functions referring to non-dllimport constructors.

2016-09-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Sep 13 17:51:42 2016 New Revision: 281413 URL: http://llvm.org/viewvc/llvm-project?rev=281413&view=rev Log: Also don't inline dllimport functions referring to non-dllimport constructors. The AST walker wasn't visiting CXXConstructExprs before. This is a follow-up to r28139

Re: r281395 - Try harder to not inline dllimport functions referencing non-dllimport functions

2016-09-13 Thread Hans Wennborg via cfe-commits
ve similar issues? >> >> On Tue, Sep 13, 2016 at 5:08 PM, Hans Wennborg via cfe-commits >> wrote: >>> >>> Author: hans >>> Date: Tue Sep 13 16:08:20 2016 >>> New Revision: 281395 >>> >>> URL: http://llvm.org/viewvc/llvm-project?

r281648 - clang-format VS plugin: upgrade the project files to VS2015

2016-09-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Sep 15 14:44:49 2016 New Revision: 281648 URL: http://llvm.org/viewvc/llvm-project?rev=281648&view=rev Log: clang-format VS plugin: upgrade the project files to VS2015 The plugin itself runs on previous VS versions, but this enables it to be built with VS2015. Modified:

Re: Upgrade and fix clang-format-vs

2016-09-15 Thread Hans Wennborg via cfe-commits
Well, on my machine $(SDKToolsDir) doesn't work :-( I suspect the file will need manual tweaking by whoever is trying to build the plugin. Anyway, I've updated the solution to build with VS2015 in r281648 and confirmed that it can still be used with older VS versions too. Cheers, Hans On Thu, Au

Re: Upgrade and fix clang-format-vs

2016-09-15 Thread Hans Wennborg via cfe-commits
When I first opened the solution in VS it prompted me to install it and I did. On Thu, Sep 15, 2016 at 4:17 PM, Zachary Turner wrote: > You may need to install the Visual Studio SDK. Did you do that when you > initially installed VS 2015? > > On Thu, Sep 15, 2016 at 4:15 PM Hans Wennborg wrote:

r298538 - [X86] Implement __readgsqword (and the rest) as builtins (PR32373)

2017-03-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Mar 22 14:13:13 2017 New Revision: 298538 URL: http://llvm.org/viewvc/llvm-project?rev=298538&view=rev Log: [X86] Implement __readgsqword (and the rest) as builtins (PR32373) It seems MS headers have started using __readgsqword, and since it's used in a header that doesn't

r299210 - clang-format vs plugin support for Visual Studio 2017

2017-03-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Mar 31 07:50:42 2017 New Revision: 299210 URL: http://llvm.org/viewvc/llvm-project?rev=299210&view=rev Log: clang-format vs plugin support for Visual Studio 2017 With the release of Visual Studio 2017, we need to at the very least claim support for it in the current manifes

r299782 - Implement _interlockedbittestandset as a builtin

2017-04-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Apr 7 11:41:47 2017 New Revision: 299782 URL: http://llvm.org/viewvc/llvm-project?rev=299782&view=rev Log: Implement _interlockedbittestandset as a builtin It's used by MS headers in VS 2017 without including intrin.h, so we can't implement it in the header anymore. Diffe

r299785 - Attempt to fix ms-intrinsics.c test

2017-04-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Apr 7 12:01:56 2017 New Revision: 299785 URL: http://llvm.org/viewvc/llvm-project?rev=299785&view=rev Log: Attempt to fix ms-intrinsics.c test Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c URL: http://llvm.org/viewv

r300074 - Revert r300001 "Revert r298824 & r298816, recommit r298742 & r298754"

2017-04-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Apr 12 11:40:26 2017 New Revision: 300074 URL: http://llvm.org/viewvc/llvm-project?rev=300074&view=rev Log: Revert r31 "Revert r298824 & r298816, recommit r298742 & r298754" It caused PR32640. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td

r300223 - clang-format-vs: Use a separate license.txt copy

2017-04-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Apr 13 12:37:17 2017 New Revision: 300223 URL: http://llvm.org/viewvc/llvm-project?rev=300223&view=rev Log: clang-format-vs: Use a separate license.txt copy The regular file used to display very poorly in the VSIX installer due to long lines, wrapping etc. Added: cfe/t

r300225 - Warning-free clang-format plugin install for VS 15.0

2017-04-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Apr 13 12:42:45 2017 New Revision: 300225 URL: http://llvm.org/viewvc/llvm-project?rev=300225&view=rev Log: Warning-free clang-format plugin install for VS 15.0 With the new release of VS, it's required that all plugins migrate to the new VSIX manifest format. The new forma

r300226 - Follow-up to r300225: update ClangFormat.sln to VS2017

2017-04-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Apr 13 12:47:47 2017 New Revision: 300226 URL: http://llvm.org/viewvc/llvm-project?rev=300226&view=rev Log: Follow-up to r300225: update ClangFormat.sln to VS2017 This got lost in the previous patch somehow. Modified: cfe/trunk/tools/clang-format-vs/ClangFormat.sln Mo

r300231 - Follow-up to r300225: update ClangFormat.csproj too

2017-04-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Apr 13 13:15:00 2017 New Revision: 300231 URL: http://llvm.org/viewvc/llvm-project?rev=300231&view=rev Log: Follow-up to r300225: update ClangFormat.csproj too Modified: cfe/trunk/tools/clang-format-vs/ClangFormat/ClangFormat.csproj Modified: cfe/trunk/tools/clang-form

r300245 - clang-format-vs licence.txt: drop svn:executable

2017-04-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Apr 13 15:09:18 2017 New Revision: 300245 URL: http://llvm.org/viewvc/llvm-project?rev=300245&view=rev Log: clang-format-vs licence.txt: drop svn:executable Not sure how it ended up with that property in the first place. Modified: cfe/trunk/tools/clang-format-vs/ClangF

r300501 - clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680)

2017-04-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Apr 17 16:28:36 2017 New Revision: 300501 URL: http://llvm.org/viewvc/llvm-project?rev=300501&view=rev Log: clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680) It sounds like MSVC is adding support for two-phase name lookup in a future version, enabled by th

r291783 - UsersManual.rst: Update clang-cl options list

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 12:15:06 2017 New Revision: 291783 URL: http://llvm.org/viewvc/llvm-project?rev=291783&view=rev Log: UsersManual.rst: Update clang-cl options list Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/llvm

Re: r291783 - UsersManual.rst: Update clang-cl options list

2017-01-12 Thread Hans Wennborg via cfe-commits
rsing in /? output now? That's on by > default with clang-cl. > > On Thu, Jan 12, 2017 at 1:15 PM, Hans Wennborg via cfe-commits > wrote: >> >> Author: hans >> Date: Thu Jan 12 12:15:06 2017 >> New Revision: 291783 >> >> URL: http://llvm.org/viewv

r291798 - UsersManual.rst: Update clang-cl options list again

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 13:26:54 2017 New Revision: 291798 URL: http://llvm.org/viewvc/llvm-project?rev=291798&view=rev Log: UsersManual.rst: Update clang-cl options list again This time, make ignored options, such as /utf-8, show up as well if they have help text. Also, since we're now ex

Re: r291783 - UsersManual.rst: Update clang-cl options list

2017-01-12 Thread Hans Wennborg via cfe-commits
gt;> Why do we list fdelayed-template-parsing in /? output now? That's on by >> default with clang-cl. >> >> On Thu, Jan 12, 2017 at 1:15 PM, Hans Wennborg via cfe-commits >> wrote: >>> >>> Author: hans >>> Date: Thu Jan 12 12:15:06

[libcxx] r291820 - Creating release_40 branch off revision 291814

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:25:41 2017 New Revision: 291820 URL: http://llvm.org/viewvc/llvm-project?rev=291820&view=rev Log: Creating release_40 branch off revision 291814 Added: libcxx/branches/release_40/ (props changed) - copied from r291814, libcxx/trunk/ Propchange: libcxx

[libcxxabi] r291821 - Creating release_40 branch off revision 291814

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:25:46 2017 New Revision: 291821 URL: http://llvm.org/viewvc/llvm-project?rev=291821&view=rev Log: Creating release_40 branch off revision 291814 Added: libcxxabi/branches/release_40/ - copied from r291814, libcxxabi/trunk/ __

[libunwind] r291827 - Creating release_40 branch off revision 291814

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:26:18 2017 New Revision: 291827 URL: http://llvm.org/viewvc/llvm-project?rev=291827&view=rev Log: Creating release_40 branch off revision 291814 Added: libunwind/branches/release_40/ - copied from r291814, libunwind/trunk/ __

[libcxxabi] r291829 - Bump version to 5.0.0svn

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:36:22 2017 New Revision: 291829 URL: http://llvm.org/viewvc/llvm-project?rev=291829&view=rev Log: Bump version to 5.0.0svn Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libcxxabi/tr

[libunwind] r291830 - Bump version to 5.0.0svn

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:37:55 2017 New Revision: 291830 URL: http://llvm.org/viewvc/llvm-project?rev=291830&view=rev Log: Bump version to 5.0.0svn Modified: libunwind/trunk/CMakeLists.txt Modified: libunwind/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libunwind/tr

r291831 - Update docs/conf.py version

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:41:38 2017 New Revision: 291831 URL: http://llvm.org/viewvc/llvm-project?rev=291831&view=rev Log: Update docs/conf.py version Modified: cfe/trunk/docs/analyzer/conf.py cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/analyzer/conf.py URL: http://llvm.org/

[clang-tools-extra] r291832 - Update docs/conf.py version

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:42:38 2017 New Revision: 291832 URL: http://llvm.org/viewvc/llvm-project?rev=291832&view=rev Log: Update docs/conf.py version Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL: http://llvm.org/viewvc/llvm-proje

r291837 - Clear the release notes for 5.0.0

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:55:16 2017 New Revision: 291837 URL: http://llvm.org/viewvc/llvm-project?rev=291837&view=rev Log: Clear the release notes for 5.0.0 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/c

[clang-tools-extra] r291838 - Clear the release notes for 5.0.0

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 15:58:40 2017 New Revision: 291838 URL: http://llvm.org/viewvc/llvm-project?rev=291838&view=rev Log: Clear the release notes for 5.0.0 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL: http://ll

[libcxxabi] r291844 - Drop 'svn' suffix from version.

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 16:12:54 2017 New Revision: 291844 URL: http://llvm.org/viewvc/llvm-project?rev=291844&view=rev Log: Drop 'svn' suffix from version. Modified: libcxxabi/branches/release_40/CMakeLists.txt Modified: libcxxabi/branches/release_40/CMakeLists.txt URL: http://llvm.o

[libcxx] r291845 - Drop 'svn' suffix from version.

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 16:13:09 2017 New Revision: 291845 URL: http://llvm.org/viewvc/llvm-project?rev=291845&view=rev Log: Drop 'svn' suffix from version. Modified: libcxx/branches/release_40/CMakeLists.txt Modified: libcxx/branches/release_40/CMakeLists.txt URL: http://llvm.org/vie

[libunwind] r291846 - Drop 'svn' suffix from version.

2017-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 12 16:13:19 2017 New Revision: 291846 URL: http://llvm.org/viewvc/llvm-project?rev=291846&view=rev Log: Drop 'svn' suffix from version. Modified: libunwind/branches/release_40/CMakeLists.txt Modified: libunwind/branches/release_40/CMakeLists.txt URL: http://llvm.o

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

2017-01-12 Thread Hans Wennborg via cfe-commits
On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth wrote: >> This isn't quite right, it should either be left as-is or dropped >> completely. This path was allowing people to spell "-mllvm >> -disable-llvm-optzns" for legacy reasons, even though the correct >> spelling is "-Xclang -disable-llvm-opt

Re: r291865 - Improve handling of instantiated thread_local variables in Itanium C++ ABI.

2017-01-13 Thread Hans Wennborg via cfe-commits
Merged in r291912. Thanks, Hans On Thu, Jan 12, 2017 at 5:50 PM, Richard Smith wrote: > This should go onto the 4.0 branch. > > -- Forwarded message -- > From: Richard Smith via cfe-commits > Date: 12 January 2017 at 16:43 > Subject: r291865 - Improve handling of instantiated th

<    3   4   5   6   7   8   9   10   11   12   >