[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e41a688a5b1: [clang][cli] Port DependencyOutput option flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

jansvoboda11 added a comment. I'm seeing build failures that might be triggered by this patch: http://lab.llvm.org:8011/#/builders/109/builds/3714 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308573. jansvoboda11 added a comment. Remove unnecessary std namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 Files:

[PATCH] D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG398b729243b1: [clang][cli] Port HeaderSearch option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88ab38449b49: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83697: [clang][cli] Port Frontend option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b84efa00040: [clang][cli] Port Frontend option flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308597. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308596. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. I wanted to defer the resolution of the todos after all existing patches (https://reviews.llvm.org/search/query/wPZcRaH7zHgu/#R) are upstreamed to avoid conflicts when rebasing and refactoring. Looking at the patches more closely, only two of them seem to be

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90887/new/ https://reviews.llvm.org/D90887 ___ cfe-commits mailing list

[PATCH] D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91296/new/ https://reviews.llvm.org/D91296 ___ cfe-commits mailing list

[PATCH] D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90889/new/ https://reviews.llvm.org/D90889 ___ cfe-commits mailing list

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90888/new/ https://reviews.llvm.org/D90888 ___ cfe-commits mailing list

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311527. jansvoboda11 added a comment. Rebase, remove `InlineMaxStackDepth` initialization from `AnalyzerOptions.h` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84186/new/ https://reviews.llvm.org/D84186

[PATCH] D84188: [clang][cli] Port FileSystem options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16aa00b62285: [clang][cli] Port FileSystem options to new option parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311545. jansvoboda11 added a comment. Revert ObjCAutoRefCount option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files:

[PATCH] D84185: Better defaults for MarshallingInfoString

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84185/new/

[PATCH] D84188: [clang][cli] Port FileSystem options to new option parsing system

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Changes involved moving `working_directory` and `working_directory_EQ` back to their original lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 added a comment. Thanks for catching these! Comment at: clang/include/clang/Driver/Options.td:1292-1303 def fdwarf_exceptions : Flag<["-"], "fdwarf-exceptions">, Group, - Flags<[CC1Option]>, HelpText<"Use DWARF style exceptions">; + Flags<[CC1Option]>,

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311542. jansvoboda11 added a comment. Revert exceptions flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 added a comment. Ready for a review. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:287 +static void +denormalizeString(SmallVectorImpl , const char *Spelling, + CompilerInvocation::StringAllocator SA, unsigned, T &) { We

[PATCH] D84185: [clang][cli] Better defaults for MarshallingInfoString

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2fc85c69b3f: [clang][cli] Better defaults for MarshallingInfoString (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84186: Convert Analyzer option string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Herald added a subscriber: steakhal. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93216: [clang][cli] Squash multiple -fxxx-exceptions flags into single -exception-model=xxx option

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added subscribers: dang, mstorsjo, sbc100, dschuff, emaste. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This patch enables

[PATCH] D93215: [clang][cli] Squash exception model in LangOptions into one member

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a subscriber: dschuff. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This squashes multiple members in LangOptions into one.

[PATCH] D93216: [clang][cli] Squash multiple -fxxx-exceptions flags into single -exception-model=xxx option

jansvoboda11 updated this revision to Diff 311585. jansvoboda11 added a comment. Remove accidental comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93216/new/ https://reviews.llvm.org/D93216 Files:

[PATCH] D93216: [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception-model=xxx option

jansvoboda11 updated this revision to Diff 311589. jansvoboda11 added a comment. Add possible values to HelpText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93216/new/ https://reviews.llvm.org/D93216 Files:

[PATCH] D93214: [clang][cli] Create accessors for exception models in LangOptions

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This abstracts away the members that are being replaced in a follow-up patch. Repository:

[PATCH] D84187: [clang][cli] Port DependencyOutput string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311861. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84187/new/ https://reviews.llvm.org/D84187 Files:

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311872. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84668/new/ https://reviews.llvm.org/D84668 Files:

[PATCH] D84190: [clang][cli] Port FrontendOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311865. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84190/new/ https://reviews.llvm.org/D84190 Files:

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311915. jansvoboda11 added a comment. Fix: avoid template instantiations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84668/new/ https://reviews.llvm.org/D84668 Files:

[PATCH] D84669: WIP [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

jansvoboda11 updated this revision to Diff 311919. jansvoboda11 added a comment. Rebase, move options back to their original lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84669/new/ https://reviews.llvm.org/D84669 Files:

[PATCH] D84668: Port TargetOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84669: Port CodeGenOpts simple string flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84669/new/

[PATCH] D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system

jansvoboda11 added a comment. Committing with whitespace fix and with `std::string` constructors removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84670/new/ https://reviews.llvm.org/D84670 ___

[PATCH] D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaec2991d083a: [clang][cli] Port LangOpts simple string based options to new option parsing… (authored by jansvoboda11). Repository: rG LLVM

[PATCH] D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1b3f82e5137: [clang][cli] Port PreprocessorOpts simple string based options to new option… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84669: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95d3cc67caac: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff4b76d74f38: [clang][cli] Port TargetOpts simple string based options to new option parsing… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcaeb56503ec8: [clang][cli] Convert Analyzer option string based options to new option parsing… (authored by jansvoboda11). Repository: rG LLVM

[PATCH] D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4511aec2bf4: [clang][cli] Port HeaderSearch simple string options to new option parsing… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84190: [clang][cli] Port FrontendOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG333d41e9eb8b: [clang][cli] Port FrontendOpts simple string based options to new option… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84189: Let denormalizer decide how to render the option based on the option class

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84189/new/

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]legacy-pass-manager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10f40576f7b4: [clang][cli] Dont always emit -f[no-]legacy-pass-manager (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6baa9769ed57: [clang][cli] Add flexible TableGen multiclass for boolean options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 added a comment. I was, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://reviews.llvm.org/D92775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f26a6de489e: Reland [clang][cli] CompilerInvocationTest: add tests for boolean options (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

jansvoboda11 added a comment. > (Or maybe OptOutFFLag could reject an option beginning with `"no-"`?) I think this is reasonable. I'll reach out to the mailing list to see if there's a way to add assertions to TableGen that would catch this. > Thanks! Sorry for the breakage. No problem.

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadf3c27742ed: [clang][cli] Revert accidental access-control flag rename (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. If both flags created through

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 updated this revision to Diff 311134. jansvoboda11 added a comment. This revision is now accepted and ready to land. Add forgotten CC1Option check in parsing macro, extract denormalizer changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. @Bigcheese, can you please go through this again and let me know it it looks good to you now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93008/new/

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267 - ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager"))); + ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1); ASSERT_THAT(GeneratedArgs,

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 added a comment. This is now ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 ___ cfe-commits mailing list

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 311182. jansvoboda11 added a comment. This revision is now accepted and ready to land. Rebase, fix tests and update them to use the new `-f[no-]legacy-pass-manager`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 311183. jansvoboda11 added a comment. Remove comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. @dexonsmith could you look at this again? I've now reworked the pass manager tests. They now work regardless of the `LLVM_ENABLE_NEW_PASS_MANAGER` value and use the new `-f[no-]legacy-pass-manager` flags.

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311166. jansvoboda11 added a comment. Rebase, migrate more options, switch to using BoolOption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files:

[PATCH] D92857: [clang][cli] [clang][cli] Don't always emit -f[no-]legacy-pass-manager

jansvoboda11 updated this revision to Diff 311201. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org/D92857 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84018/new/

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311226. jansvoboda11 added a comment. Rebase, undo unecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84018/new/ https://reviews.llvm.org/D84018 Files:

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change `makeFlagToValueNormalizer` so that one specialization converts all integral/enum

[PATCH] D93631: [clang][cli] Implement `getAllArgValues` marshalling

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This infrastructure can be used ~30

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:55 + +MATCHER_P2(ContainsN, InnerMatcher, N, + describeContainsN(InnerMatcher, N, negation)) { I'm not sure where custom Google Test matchers go. I

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows us to verify that we don't emit options multiple times. In most cases, that

[PATCH] D84675: [clang][cli] Streamline MarhsallingInfoFlag description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27b7d646886d: [clang][cli] Streamline MarshallingInfoFlag description (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93540: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a85526728c9: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84189: [clang][cli] Let denormalizer decide how to render the option based on the option class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70410a264949: [clang][cli] Let denormalizer decide how to render the option based on the… (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added a comment. @SjoerdMeijer If you're not comfortable reviewing this, do you know of anyone who might want to take a look? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3080 } Opts.setFPExceptionMode(FPEB); SjoerdMeijer wrote:

[PATCH] D84187: Port DependencyOutput string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84187/new/

[PATCH] D84190: Port FrontendOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 312192. jansvoboda11 added a comment. Rebase, move options to their original lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84671/new/ https://reviews.llvm.org/D84671 Files:

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the `-f[no-]trapping-math` flags from

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added a reviewer: SjoerdMeijer. jansvoboda11 added a subscriber: SjoerdMeijer. jansvoboda11 added a comment. Tagging @SjoerdMeijer, as these flags were pulled into the `-cc1` command-line in his patch: D23840 . Repository: rG LLVM Github Monorepo

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3080 } Opts.setFPExceptionMode(FPEB); The parsing of `OPT_ftrapping_math` and `OPT_fno_trapping_math` is immediately overwritten here. Repository: rG LLVM

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 312205. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84672/new/ https://reviews.llvm.org/D84672 Files:

[PATCH] D84672: Port PreprocessorOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95114f21f5bf: [clang][cli] Do not marshall only CC1Option flags in BoolOption (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93094: [clang][cli] Prevent double denormalization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2661bed185e: [clang][cli] Prevent double denormalization (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG741978d727a4: [clang][cli] Port CodeGen option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

jansvoboda11 updated this revision to Diff 313309. jansvoboda11 added a comment. Extract SFINAE check into function again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93628/new/ https://reviews.llvm.org/D93628 Files:

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbef9eb84b2fb: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:176 +static auto makeFlagToValueNormalizer(T Value) { + return makeFlagToValueNormalizer(uint64_t(Value)); } dexonsmith wrote: > (not a behaviour change but) I wonder if

[PATCH] D93631: [clang][cli] Implement `getAllArgValues` marshalling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63a24816f561: [clang][cli] Implement `getAllArgValues` marshalling (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84673: Port DiagnosticOpts to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/

[PATCH] D93679: [clang[cli] Port getAllArgumentValues to the marshalling infrastructure

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is needed for a future patch, where we start using normalizers in contexts where no

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 313337. jansvoboda11 added a comment. Rebase, undo NFC changes. Replace the previous diagnostic option tagging system implemented in TableGen with less intrusive backend check. Extract prep patches. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added a comment. I still need to figure out why Clang built in release mode replaces spaces in an error message by newlines and indents: $ ./build.noindex/debug/bin/clang -c clang/test/Driver/fmessage-length.c -fmessage-length=nan clang-12: error: invalid

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary for a future patch, where we start using these macros in multiple

[PATCH] D93699: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D93698: [clang][cli] Port a CommaJoined option to the marshalling infrastructure

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 updated this revision to Diff 313335. jansvoboda11 added a comment. Add newline at the end of file, simplify macro forwarding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 313347. jansvoboda11 added a comment. Remove unnecessary if braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D93700: [clang][cli] Report the actual argument parsing result

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93700 Files:

[PATCH] D93699: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Duplicate of D93679 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93699/new/ https://reviews.llvm.org/D93699

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]experimental-new-pass-manager

jansvoboda11 updated this revision to Diff 311190. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org/D92857 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp

<    1   2   3   4   5   6   7   8   9   10   >