[PATCH] D150319: [clang][deps] Always use -fmodules-validate-once-per-build-session

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner

[PATCH] D150320: [clang][deps] Avoid relocatable modules checks

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, `ASTReader`

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69 + /// The preprocessing mode used for scanning. + ScanningMode Mode; + /// The output format. benlangmuir wrote: > Why drop `const`?

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When Clang loads a PCM

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are situations wh

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1787 case LMM_NoDirectory: return nullptr; We should probably `break` for `LMM_AlreadyLoaded` instead of returning null. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 9c254184 `ASTWriter`

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43 // CHECK-NEXT: "context-hash": "{{.*}}", -// CHECK-NEXT: "module-name": "FW2_Private" +// CHECK-NEXT: "module-name": "FW2"

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3646 // file. SmallVector IIs; for (const auto &ID : PP.getIdentifierTable()) ributzka wrote: > Would it make sense to reduce the size of the SmallVector too? Tha

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf60cc473b82b: [clang][modules] NFC: Only sort interesting identifiers (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D150615: [clang][deps] Do not cache PCM files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On incremental scan, caching an out

[PATCH] D150615: [clang][deps] Do not cache PCM files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94d22b09bbb2: [clang][deps] Do not cache PCM files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/optimize-system-warnings.m:19 +// CHECK:], +// CHECK-NEXT: "name": "A" +// CHECK-NEXT: }, I'd like to see a check line that would fail if the scanner reports another v

[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/ClangScanDeps/optimize-system-warnings.m:19 +// CHECK:], +// CHECK-NEXT: "name": "A" +// CHECK-NEXT: },

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905 + if (BriefResult) { +llvm::outs() << "num modules: " << FD->getNumModules() << '\n'; +return HadErrors; akyrtzi wrote: > jansvoboda11 wrote: > > This assum

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Note that I think we should consider renaming the `-format` flag in the future. Ideally, it should reflect the fact that the scanner is doing different work, not just formatt

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

jansvoboda11 added a comment. Can you explain why we need to keep separate `PendingImportedModulesSema` now? In what situation will it end up aggregating more than one `PendingImportedModules`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148176/

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. That makes sense to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148176/new/ https://reviews.llvm.org/D148176

[PATCH] D138224: WIP: AST{Reader,Writer} alternative

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Using `CompilerInstance` as the module storage dramatically increases memory usage (peak ~30GB) of `clang-scan-deps` when scanning LLVM. (Memory mapping serialized files peaks at ~300MB.) Repository: rG LLVM Github Monorepo

[PATCH] D137259: [clang][modules][deps] WIP: In-memory module transfer

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Using `CompilerInstance` as the module storage dramatically increases memory usage (peak ~30GB) of `clang-scan-deps` when scanning LLVM. (Memory mapping serialized files peaks at ~300MB.) Repository: rG LLVM Github Monorepo

[PATCH] D147815: [clang][deps] Print timing information

This revision was automatically updated to reflect the committed changes. Closed by commit rGe766e3afedeb: [clang][deps] Print timing information (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D147815?vs=511802&id=515401#toc Repository: rG LLVM Github Monorepo

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 updated this revision to Diff 515455. jansvoboda11 added a comment. This revision is now accepted and ready to land. Move from `llvm::StringSwitch` back to binary search on sorted vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 added a comment. Sorting at compile-time would be nicer, but I don't have the bandwidth to implement something like that. I'll leave a FIXME in case someone wants to pick it up. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

This revision was automatically updated to reflect the committed changes. Closed by commit rG53a4a2b45bb2: [clang] NFCI: Optimize storage and lookup of analyzer options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D137258?vs=515455&id=515828#toc Repository: r

[PATCH] D145197: [clang][deps] NFC: Refactor and comment ModuleDeps sorting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b80f00bac6a: [clang][deps] NFC: Refactor and comment ModuleDeps sorting (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149802: [clang][modules] Avoid unnecessary writes of .timestamp files

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese, gribozavr. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang curren

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. Regarding the failing `Modules/crash-vfs-umbrella-frameworks.m` test, this is my understanding after debugging it. Whenever we find that `A.framework/Frameworks/B.framework` is a symlink, we treat `B` as a separate to

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 updated this revision to Diff 529367. jansvoboda11 added a comment. Fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151855/new/ https://reviews.llvm.org/D151855 Files: clang/include/clang/Lex/HeaderSearch.h clang/in

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 added a comment. In D151855#4403879 , @benlangmuir wrote: >> I think it should be fine to allow dropping the >> A.framework/Frameworks/B.framework directory from the reproducer VFS > > I think technically this is wrong, since if you're miss

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 added a comment. In D151855#4403934 , @jansvoboda11 wrote: > In D151855#4403879 , @benlangmuir > wrote: > >>> I think it should be fine to allow dropping the >>> A.framework/Frameworks/B.framework

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 updated this revision to Diff 531245. jansvoboda11 marked 3 inline comments as done. jansvoboda11 added a comment. Remove accidental diff with `--crash` in test, add file header, continue being defensive in `CXLoadedDiagnostic.cpp`. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added inline comments. Comment at: clang/test/Modules/crash-vfs-umbrella-frameworks.m:13 // RUN: env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \ -// RUN: not %clang -nostdinc -fsyntax-only %s \ +// RUN: not --crash %clang -nostdinc -fsyntax-only %s \

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bca6f452f53: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2) (authored by jansvoboda11). Repository: rG LLVM Github Mo

[PATCH] D151922: [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dee56aed735: [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()` (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D151922?vs=527582&id=531660#toc Rep

[PATCH] D151927: [clang] Deprecate `DirectoryEntry::getName()`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG462bda1d562a: [clang] Deprecate `DirectoryEntry::getName()` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5788ff8dc1: [clang][index] NFCI: Make `CXFile` a `FileEntryRef` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added a comment. In D151938#4426106 , @Jake-Egan wrote: > Hi, there's a test failure on AIX, could you take a look please? > > https://lab.llvm.org/buildbot/#/builders/214/builds/8005/steps/6/logs/FAIL__Clang__index-with-module_m Thanks for

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5660 +"-header-include-filtering=" + +std::string(D.CCPrintHeadersFiltering ? "on" : "off"))); } Let's change "on" to something that won't interfere with pote

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:161 + case HIF_Textual: { +assert(!DepOpts.HeaderIncludeFiltering && + "header filtering is currently always disabled when output format is" ahatanak wrote: >

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thank you for working through this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.llvm.org/D137996

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

jansvoboda11 added a comment. Nice. It would be nice to have tests for this, though. Also, do you think this should be configurable on the command line? I'm thinking about users that are trying to debug their own modular code, but don't really care what happens in the SDK. Repository: rG LL

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

jansvoboda11 accepted this revision. jansvoboda11 added subscribers: vsapsai, Bigcheese. jansvoboda11 added a comment. This revision is now accepted and ready to land. In D139653#3982272 , @kastiglione wrote: >> Also, do you think this should be configur

[PATCH] D140175: [clang][deps] Remove support for the deprecated driver API

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This API is no longer n

[PATCH] D140176: [clang][deps] NFC: Split out the module-based API from the TU-based API

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For users of the C++ AP

[PATCH] D140177: [clang][deps] Give the fake file a unique name in by-module-name scans

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When scanning dependenc

[PATCH] D140177: [clang][deps] Give the fake file a unique name in by-module-name scans

jansvoboda11 updated this revision to Diff 483567. jansvoboda11 added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140177/new/ https://reviews.llvm.org/D140177 Files: clang/lib/Tooling/DependencyScanning/DependencyScann

[PATCH] D140176: [clang][deps] NFC: Split out the module-based API from the TU-based API

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:111 + /// information needed for explicit build. + llvm::Expected + getModuleDependencies(StringRef ModuleName, artemcm wrote: > The existi

[PATCH] D117309: [clang] NFC: Remove unused `DirectoryLookup`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b21e074dbdf: [clang] NFC: Remove unused `DirectoryLookup` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D117312: [clang][lex] NFC: Simplify calls to `LookupFile`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG105c913156e9: [clang][lex] NFC: Simplify calls to `LookupFile` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117566: [clang][lex] Introduce `DirectoryLookupIterator`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: ahoppen. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `const DirectoryLookup *` out-parameter of `{HeaderSearch,Preprocessor}::LookupFile()` is assigned

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 updated this revision to Diff 400852. jansvoboda11 added a comment. Rebase on top of D117566 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116750/new/ https://reviews.llvm.org/D116750 Files: clang

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:415 StringRef Filename, SourceLocation IncludeLoc, bool isAngled, - const DirectoryLookup *FromDir, const DirectoryLookup **CurDir, + maybe_search_dir_iterator FromDir, maybe_s

[PATCH] D117119: [clangd][clang-tidy] Remove uses of `std::vector`

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6fb636667b8: [clangd][clang-tidy] Remove uses of `std::vector` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117119/new/

[PATCH] D117566: [clang][lex] Introduce `DirectoryLookupIterator`

jansvoboda11 updated this revision to Diff 401137. jansvoboda11 added a comment. Fix comment typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117566/new/ https://reviews.llvm.org/D117566 Files: clang/include/clang/Lex/HeaderSearch.h clang/in

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 updated this revision to Diff 401171. jansvoboda11 marked 7 inline comments as done. jansvoboda11 added a comment. Update comments, remove `std::atomic<>`, merge `getOrEmplaceContentsForUID` into `getOrEmplaceEntryForUID`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:132-134 + /// Non-owning pointer to the file contents. This can be shared between + /// multiple entries (e.g. between a symlink and its target). + st

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:264 + if (Module || !AllowSearch || !HSOpts->ImplicitModuleMaps) { +noteModuleLookupUsage(Module, ImportLoc); return Module; ja

[PATCH] D117566: [clang][lex] Introduce `SearchDirIterator`

jansvoboda11 updated this revision to Diff 401640. jansvoboda11 added a comment. Rename the new iterator type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117566/new/ https://reviews.llvm.org/D117566 Files: clang/include/clang/Lex/HeaderSearch

[PATCH] D115935: [clang][deps] NFC: Simplify handling of cached FS errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGced077e1ba52: [clang][deps] NFC: Simplify handling of cached FS errors (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D114966: [clang][deps] Ensure filesystem cache consistency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5daeada33051: [clang][deps] Ensure filesystem cache consistency (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc2a1372704: [clang][deps] Handle symlinks in minimizing FS (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D114971

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 added a comment. @vsapsai do you have any further concerns? My only intended change at this point is Duncan's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114095/new/ https://reviews.llvm.org/D114095

[PATCH] D117115: [llvm][ADT] Implement `BitVector::{pop_,}back`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG622354a52207: [llvm][ADT] Implement `BitVector::{pop_,}back` (authored by jansvoboda11). Herald added subscribers: cfe-commits, carlosgalvezp, usaxen

[PATCH] D118109: [clang] Replace `std::vector` use in Syntax

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM Programmer’s Manual strongly discourages the use of `std::vector` and suggests `llvm::BitVecto

[PATCH] D118150: [clang] Fix serialized diagnostics edge-cases

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang frontend sometimes fails on the following assertion when launched wit

[PATCH] D118150: [clang] Fix serialized diagnostics edge-cases

jansvoboda11 added inline comments. Comment at: clang/test/Misc/serialized-diags-emit-header-module-misconfig.c:2 +// RUN: rm -rf %t && mkdir %t +// RUN: not %clang_cc1 -emit-header-module %s -o %t/out.pcm -serialize-diagnostic-file %t/diag 2>&1 | FileCheck %s +

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/headerwithdirname.cpp:16 -// CHECK: headerwithdirname_input.o +// CHECK: headerwithdirname_input{{.*}}{{.o|.s}} // CHECK-NEXT: headerwithdirname_input.cpp Why is `{{.*}}` necessary? Rep

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 updated this revision to Diff 402968. jansvoboda11 added a comment. 1. Move `HeaderSearch::getFileInfo()` call into `Preprocessor::markIncluded()`. 2. Switch from bitvector to vector of file IDs in AST files. 3. Remove unnecessary usages of `auto`. Repository: rG LLVM Github Monor

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 added a comment. In D114095#3263086 , @vsapsai wrote: > My understanding was that we were going with ID vectors approach and not with > bitvectors, and the current code still uses bitvectors. Also I have a minor > readability concern about

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

jansvoboda11 added a comment. I don't have any suggestions here except for running the patch through `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117830/new/ https://reviews.llvm.org/D117830 __

[PATCH] D118109: [clang][syntax] Replace `std::vector` use

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG600c6714ac77: [clang][syntax] Replace `std::vector` use (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118150: [clang] Fix serialized diagnostics edge-cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76cb4cd074a6: [clang] Fix serialized diagnostics edge-cases (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf72027233044: [clang][lex] Include tracking: simplify and move to preprocessor (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CH

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 403263. jansvoboda11 added a comment. Rebase, update unnecessary `auto`, run `clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files: clang/includ

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks for the explanation and update. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118152/new/ https://reviews.llvm.org/D118

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

jansvoboda11 added inline comments. Comment at: clang/test/Modules/cxx20-multiple-partitions.cpp:48 +#else +#error "no TU set" +#endif Instead of splitting the file with preprocessor, you could use the `split-file` utility (introduced in D83834). Repository:

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

jansvoboda11 added a comment. The performance implications are pretty interesting! Have you tried avoiding the copy altogether by just storing the reference? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D12033

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

jansvoboda11 added a comment. In D120334#3338314 , @yurai007 wrote: > In D120334#3337961 , @jansvoboda11 > wrote: > >> The performance implications are pretty interesting! Have you tried avoiding >> the copy alt

[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Abandoning, since we have a better solution: disable implicit module maps in explicit modules builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113775/new/ https://reviews.llv

[PATCH] D113880: [clang][modules] Infer framework modules in explicit builds

jansvoboda11 updated this revision to Diff 410785. jansvoboda11 edited the summary of this revision. jansvoboda11 added a comment. Remove changes related to dependency scanning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113880/new/ https://revie

[PATCH] D113880: [clang][modules] Infer framework modules in explicit builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27d9a58407c4: [clang][modules] Infer framework modules in explicit builds (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118986: [clang][deps] Return the whole TU command line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19017c2435d7: [clang][deps] Return the whole TU command line (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D118986

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM too if the performance remains the same as with the original revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 _

[PATCH] D120463: [clang][modules] NFC: Simplify and clarify test

jansvoboda11 created this revision. jansvoboda11 added reviewers: ilyakuteev, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplifies a test that checks only used module map files are repor

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: ilyakuteev, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D106876 , PCM files don't report modul

[PATCH] D120465: [clang][deps] Generate necessary "-fmodule-map-file=" arguments, disable implicit module maps

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D113473 , we don't report any module map files vi

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

jansvoboda11 updated this revision to Diff 411044. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118915/new/ https://reviews.llvm.org/D118915 Files: clang/include/clang/Tooling/DependencyScanning/DependencySc

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With explicit modules build, the '-fmodules-cache-path=' argument is unused. This patch r

[PATCH] D120426: [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120426/new/ https://reviews.llvm.org/D120426 ___

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

jansvoboda11 added inline comments. Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:36-38 +#if __has_include("d.h") // This should use 'd.modulemap' in order to determine that 'd.h' + // doesn't exist for 'c' because of its '[no_undecla

[PATCH] D120465: [clang][deps] Generate necessary "-fmodule-map-file=" arguments, disable implicit module maps

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:112 void dependencies::detail::collectPCMAndModuleMapPaths( llvm::ArrayRef Modules, dexonsmith wrote: > Should this be renamed? Yes, that would mak

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:36 + llvm::erase_if(Args, [](const std::string &Arg) { +return Arg.find("-fmodules-cache-path=") == 0; + }); dexonsmith wrote: > Is that the only

[PATCH] D120463: [clang][modules] NFC: Simplify and clarify test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG242b24c18491: [clang][modules] NFC: Simplify and clarify test (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb45888e959ad: [clang][modules] Report module maps affecting `no_undeclared_includes` modules (authored by jansvoboda11). Repository: rG LLVM Githu

[PATCH] D120465: [clang][deps] Generate necessary "-fmodule-map-file=" arguments, disable implicit module maps

jansvoboda11 updated this revision to Diff 413384. jansvoboda11 added a comment. Review feedback (add TODO & rename function) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120465/new/ https://reviews.llvm.org/D120465 Files: clang/include/clang/T

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

jansvoboda11 updated this revision to Diff 413386. jansvoboda11 added a comment. Herald added a project: All. Rebase on top of D120465 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118915/new/ https://reviews.llvm

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

jansvoboda11 updated this revision to Diff 413387. jansvoboda11 added a comment. Update TODO instead of removing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120474/new/ https://reviews.llvm.org/D120474 Files: clang/lib/Tooling/DependencySca

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

jansvoboda11 added a comment. In D120464#3363258 , @Orlando wrote: > Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this > commit on the `llvm-clang-x86_64-sie-win` builder: > https://lab.llvm.org/buildbot/#/builders/216/builds/92

[PATCH] D101051: [clang][deps] Only generate absolute paths when asked to

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add option to `clang-scan-deps` to enable/disable generation of command-line arguments with absolute

[PATCH] D101051: [clang][deps] Only generate absolute paths when asked to

jansvoboda11 updated this revision to Diff 339944. jansvoboda11 added a comment. Improve naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101051/new/ https://reviews.llvm.org/D101051 Files: clang/include/clang/Tooling/DependencyScanning/Depe

<    9   10   11   12   13   14   15   16   17   18   >