[PATCH] D42844: [OpenCL] Add test for atomic pointers.

Fznamznon added a comment. Yes, we don't have anything OpenCL specific for atomic pointers. But we have OpenCL specific in pointers and atomics separately and we have address spaces. Why not to test all at once? Repository: rC Clang https://reviews.llvm.org/D42844 ___

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. SYCL runtime is supposed to use sycl_kernel attribute to mark functions in the single source which are supposed to be compiled for the device. Compiler is supposed to understa

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. Hi all, I assume that something to mark the code which is supposed to be offloaded already is implemented for OpenMP and CUDA. For example I found CUDA-specific CUDADevice attribute. I can't just use CUDA-specific attributes for SYCL but I think that these resources

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1000 +def SYCLDevice : InheritableAttr { + let Spellings = [GNU<"sycl_device">]; + let Subjects = SubjectList<[Function, Var]>; aaron.ballman wrote: > Is there a reason to not also i

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. In D60455#1459935 , @Anastasia wrote: > I was just wondering since SYCL is intended to be a single source C++ for > OpenCL and this attribute is for internal use is it possible to just reuse > existing OpenCL kernel attribute?

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 194878. Fznamznon added a comment. Applied comments from @aaron.ballman and @keryell - Introduce a C++11 and C2x style spelling in the clang namespace I didn't find path to add two namespaces to attribute (like [[clang::sycl::device]] so [[clang::sycl_dev

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added inline comments. Comment at: clang/test/SemaSYCL/device-attrubutes.cpp:8-11 +__attribute((sycl_kernel)) void foo(); +__attribute((sycl_device)) void foo1(); +[[clang::sycl_kernel]] void foo2(); +[[clang::sycl_device]] void foo3(); bader wrote: > T

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 195128. Fznamznon added a comment. Applied comments from @bader Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 195134. Fznamznon added a comment. Applied comment from @bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. In D60455#1467018 , @Anastasia wrote: > Just to understand how this will work. I would imagine you can have a device > function definition preceding its use. When the function is being parsed it's > not known yet whether it wil

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:286 +help. + }]; +} Anastasia wrote: > keryell wrote: > > aaron.ballman wrote: > > > I'm still not entirely certain how I would know what to mark and how. > > > From the descript

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added inline comments. Comment at: clang/test/SemaSYCL/device-attributes-on-non-sycl.cpp:2 +// RUN: %clang_cc1 -fsyntax-only -fsycl-is-device -verify %s +// Now pretend that we're compiling a C++ file. There should be warnings. +// RUN: %clang_cc1 -fsyntax-only -verify

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. In D60455#1467279 , @aaron.ballman wrote: > > I'm still wondering what the actual semantics are for the attribute. Right > now, these are being parsed and ignored -- are there future plans here? Yes, we are going to teach

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. In D60455#1470318 , @keryell wrote: > It would be better to rename `clang/test/SemaSYCL/device-attrubutes.cpp` to > `clang/test/SemaSYCL/device-attributes.cpp` It's already renamed in the latest patch. Repository: rG LLVM

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. I tried to reuse OpenCL kernel attribute with "__kernel" keyword in our current SYCL implementation. PR with this try is here - https://github.com/intel/llvm/pull/97 Now It looks feasible but with a couple notes: From SYCL specification "SYCL is designed to be as clos

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} Anastasia wrote: > Undocumented -> SYCLKernelDocs Oh, Thank you for that! Comment at: clang/

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:24 +} +// CHECK: define spir_func void @{{.*}}foo +// CHECK: define linkonce_odr spir_func i32 @{{.*}}bar Anastasia wrote: > Fznamznon wrote: > > Anastasia wrote: > > > I can

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 203785. Fznamznon added a comment. Applied comments from @Anastasia - Added link to documentation for `sycl_device` attribute - Removed redundant comment from test @Anastasia, do you have additional comments? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added a comment. @aaron.ballman , please let me know if you have additional comments/suggestions. If not, could you please accept this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/test/SemaSYCL/device-attributes.cpp:3 + +[[clang::sycl_kernel]] int gv2 = 0; // expected-warning {{'sycl_kernel' attribute only applies to functions}} +__attribute((sycl_kernel)) int gv3 = 0; // expected-warning {{'sycl_kernel'

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 205663. Fznamznon added a comment. Appled part of comments from @aaron.ballman: - Fixed grammar and code style in all places except sycl_kernel docs - Added a lit test which checks that sycl_device attribute implicitly added to proper declarations Reposi

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:263-264 +entry point to device code i.e. will be called by host in run time. +Here is a code example of the SYCL program, which demonstrates the need for +this attribute: +.. code-block:: c++ -

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 205813. Fznamznon added a comment. Updated `sycl_kernel` attribute documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/A

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 205831. Fznamznon added a comment. Fixed a couple coding style issues, renamed markDevice function with markSYCLDevice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D6045

[PATCH] D63710: [SYCL] Re-use OpenCL sampler in SYCL device mode

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan, yaxunl. Herald added a project: clang. Fznamznon added reviewers: bader, Anastasia. sampler_t type name is replaced with __ocl_sampler_t to avoid potential collisions with user types. Selectively enabled a

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 206861. Fznamznon added a comment. Added warning diagnostic for `sycl_kernel` attribute. Now if the `sycl_kernel` attribute applied to a function which doesn't meet requirements for OpenCL kernel generation, attribute will be ignored and diagnostic will b

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 206873. Fznamznon added a comment. Minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/At

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 200513. Fznamznon added a comment. Herald added a subscriber: mgorny. Added semantics for new attributes - Added semantics for new attributes. Now complier can separate SYCL device code from host code using new arrtributes. - Removed spelling for sycl_dev

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 200658. Fznamznon added a comment. Minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Sema/Se

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} bader wrote: > Anastasia wrote: > > Ok, I thought the earlier request was not to add undocumented attributes >

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/test/SemaSYCL/device-attributes-on-non-sycl.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -fsycl-is-device -verify %s +// Now pretend that we're compiling regular C++ file without SYCL mode enabled. Anastasia wrote: >

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 201641. Fznamznon added a comment. Applied comments from @Anastasia - Added documentation for sycl_kernel function - Added comments to Sema.h - Added -std=c++11 to test run lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266066. Fznamznon added a comment. Herald added a subscriber: sstefan1. Re-implemented diagnostic itself, now only usages of declarations with unsupported types are diagnosed. Generalized approach between OpenMP and SYCL. Repository: rG LLVM Github Monor

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon added a comment. The tests are failing because calling function with unsupported type in arguments/return value is diagnosed as well, i.e. : double math(float f, double d, long double ld) { ... } // `ld` is not used inside the `math` function #pragma omp target map(r) { r += m

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266877. Fznamznon marked 2 inline comments as done. Fznamznon added a comment. Applied comments from Johannes. Fixed failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llv

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1727 + + QualType Ty = D->getType(); + auto CheckType = [&](QualType Ty) { jdoerfert wrote: > Nit: Move below `CheckType` to avoid shadowing and con

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

Fznamznon added a comment. In D77918#2060446 , @jdoerfert wrote: > I think this will be fixed by D74387 , we > should include the tests somewhere though. D74387 includes a test case with

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266942. Fznamznon marked an inline comment as done and an inline comment as not done. Fznamznon added a comment. Included test cases from Johannes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ htt

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon added a comment. In D74387#2063423 , @ABataev wrote: > Seems to me, this patch crashes > `llvm-project/openmp/libomptarget/test/mapping/declare_mapper_api.cpp`. It seems this patch caused asking size of dependent type, AST context doesn't see

[PATCH] D80829: [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

Fznamznon created this revision. Herald added subscribers: cfe-commits, sstefan1, Anastasia, ebevhan, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Fznamznon added reviewers: ABataev, bader. Do not ask size of type if it is dependent. ASTContext doesn't seem

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon added a comment. Fix is here D80829 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 ___ cfe-commits mailing list c

[PATCH] D80829: [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

Fznamznon added a comment. I don't have rights to merge. Could someone submit it, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80829/new/ https://reviews.llvm.org/D80829 ___ cfe-commits mailin

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. Herald added a subscriber: yaxunl. In D74387#1950593 , @jdoerfert wrote: > This is needed for OpenMP as well. Does it make sense to include it in this > patch or in another one? I thought OpenMP already has diagnostics for uns

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1965634 , @jdoerfert wrote: > In D74387#1964483 , @Fznamznon wrote: > > > In D74387#1950593 , @jdoerfert > > wrote: > > > > > This is ne

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1967386 , @jdoerfert wrote: > In D74387#1967289 , @Fznamznon wrote: > > > In D74387#1965634 , @jdoerfert > > wrote: > > > > > In D74387#

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1970374 , @jdoerfert wrote: > In D74387#1969891 , @Fznamznon wrote: > > > In D74387#1967386 , @jdoerfert > > wrote: > > > > > In D74387#

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1974981 , @jdoerfert wrote: > As I mentioned before. As long as the type is not "used" you can treat it as > a sequence of bytes just as well. So we can lower `__float128` to `char [16]` > with the right alignment. SP

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1831 "OpenMP device compilation mode is expected."); + // TODO: Do not check outside of functions for now as the targetDiag below + // requires one. Please ignore my comm

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon added a subscriber: ABataev. Fznamznon added a comment. @jdoerfert , @ABataev , if OpenMP needs same diagnostic as well, I can generalize it between SYCL and OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://review

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon created this revision. Herald added subscribers: cfe-commits, sstefan1, Anastasia, ebevhan, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Fznamznon added reviewers: erichkeane, bader. Fznamznon added a subscriber: ABataev. Fznamznon added a comment. @jdoerfer

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon updated this revision to Diff 270135. Fznamznon added a comment. Fixed code style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org/D81641 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaExpr.cp

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:216 + if (getLangOpts().SYCLIsDevice) +if (auto VD = dyn_cast(D)) + if (VD->getTLSKind() != VarDecl::TLS_None) riccibruno wrote: > Nit:

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon updated this revision to Diff 271133. Fznamznon marked an inline comment as done. Fznamznon added a comment. Generalized diagnostic between SYCL and OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon added a comment. In D81641#2088446 , @jdoerfert wrote: > OpenMP has the same restriction (no surprise I guess). Thanks for the ping! > > I think we do not emit diagnosis right now: https://godbolt.org/z/srDkXZ > I think we also should diagnose t

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon added a comment. Seems that `test/OpenMP/nvptx_target_codegen.cpp` is completely not formatted. If I apply suggestion from pre-merge checks, this will look like a big unrelated to this patch change and it will contradict with the whole file style. Repository: rG LLVM Github Monorep

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon updated this revision to Diff 271327. Fznamznon edited the summary of this revision. Fznamznon added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org/D81641 Files: clang/lib/Sema/Sem

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. Okay, seems like OpenMP needs unsupported types diagnosing as well. I'm trying to adapt this patch for OpenMP, but it doesn't work out of the box because it diagnoses memcpy like operations, so with the current patch the code like this will cause diagnostics: stru

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. Herald added a reviewer: aaron.ballman. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 ___ cfe-commits mailing list cfe-commit

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#2023200 , @jdoerfert wrote: > In D74387#1992682 , @Fznamznon wrote: > > > Okay, seems like OpenMP needs unsupported types diagnosing as well. I'm > > trying to adapt this patch

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

Fznamznon added a comment. Hi there, This change seems to be causing assertion failure in clang when a struct contains a _BitInt with length longer than 128 - https://godbolt.org/z/4jTrW4fcP . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/n

[PATCH] D122494: Do not treat use of variable from attribute arguments as ODR use

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Attribute arguments are always compile-time expressions that need to be evaluated. So, it is not necessary to treat attr

[PATCH] D118837: Methods visited for a special class must have an identifier.

Fznamznon added a comment. Herald added a project: All. Was this one submitted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118837/new/ https://reviews.llvm.org/D118837 ___ cfe-commits mailing list cfe

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon added a comment. > I misread what was done with addrspace_cast, that new operator only allows > conversions that are otherwise also allowed. Based on that, this change does > actually align with what was done for OpenCL mode, it does not restrict > anything that is allowed in OpenCL m

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon created this revision. Fznamznon added a reviewer: bader. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cee9608982a: [SYCL] Disallow explicit casts between mismatching address spaces (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. In D157879#4655321 , @rsmith wrote: > This change has introduced a false positive for anonymous union members: > > struct A { > int m; > union { int n = 0; }; > }; > > A a = A{.m = 0}; > > now produces a fal

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1798 + FunctionDecl *FD = + isa(C) ? cast(C) : dyn_cast(D); auto CheckType = [&](QualType Ty) { So, we assume that lexical context is a function and if it is not, we assume that the va

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon created this revision. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds diagnosing on attempt to use zero length arrays, pointers, refs, arrays of them

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. @jdoerfert , @yaxunl , please let me know if similar thing would be useful for OMP/HIP/CUDA as well. I can generalize it by using `targetDiag`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.ll

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. In D114080#3137430 , @Naghasan wrote: > Why the need for this restriction ? Zero length arrays are not supported by pure C++. It is an extension supported by clang. They are also not allowed in OpenCL and SPIR-V, and I even th

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. > I agree, but having a field defined is different from it being used. It is > actually not uncommon to see SYCL functor passed with many unused fields > (Eigen is good example). Are you saying that it is better to diagnose just used fields? I believe it is safer to d

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon updated this revision to Diff 390346. Fznamznon marked an inline comment as done. Fznamznon added a comment. Apply suggestion from @bader Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 Files:

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon marked an inline comment as not done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:68-75 +bool ErrorFound = false; +if (isZeroSizedArray(*this, TypeToCheck)) { + SYCLDiagIfDeviceCode(UsedAt, diag::err_sycl_zero_array_size); +

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. In D114080#3158323 , @erichkeane wrote: > I note that this is missing a test, otherwise I don't see any issues with it > from my end. There is a test SemaSYCL/zero-length-arrays.cpp. For some reason after I updated this revi

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon updated this revision to Diff 390376. Fznamznon added a comment. An attempt to fix review page Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 Files: clang/include/clang/Basic/DiagnosticSemaKi

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. In D114080#3158368 , @Fznamznon wrote: > In D114080#3158323 , @erichkeane > wrote: > >> I note that this is missing a test, otherwise I don't see any issues with it >> from my end. > >

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For simple derived type ConstantEmitter returns a struct of the same size but different type which is then stored field-

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. Unit tests fail seems unrelated. I'm seeing the same test fail for a commit that is already in main https://github.com/llvm/llvm-project/commit/f1f583347d00aad378eb0128e72d3d2e8be5174b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. In D142534#4079958 , @shafik wrote: > I think having a link to the github issue in the summary allows for the issue > be closed automatically when you commit. Is this correct @aaron.ballman I > have been doing this for a while

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure it is at least 8 bits. Fixes #59801 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142550 F

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); This is not four bools. Repository: rG LLVM Github Mon

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); erichkeane wrote: > tbaeder wrote: > > Fznamznon wrote: >

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492125. Fznamznon added a comment. Adjust the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/test/SemaCXX/vector-bool.cpp Index: clang/test/S

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); Fznamznon wrote: > erichkeane wrote: > > tbaeder wrote: >

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492151. Fznamznon added a comment. Add a case with vector of length 33 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/lib/AST/ASTContext.cpp clang

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); erichke

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492362. Fznamznon added a comment. Add more sizes to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); erichke

[PATCH] D142550: Fix sizeof of boolean vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f4b2fe21dd: [clang] Fix sizeof of boolean vector (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon updated this revision to Diff 492485. Fznamznon added a comment. Rebase and apply nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https://reviews.llvm.org/D142534 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGe

[PATCH] D142757: [clang][driver] Do not warn about position of `/clang:-xc` in cl mode

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. In CL mode values of `/clang:` arguments end up at the end of arguments list which makes the warning always emit

[PATCH] D142757: [clang][driver] Do not warn about position of `/clang:-xc` in cl mode

Fznamznon updated this revision to Diff 493256. Fznamznon added a comment. Emit an error if `/clang:-x` passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/lib/Driver/Driver.cpp clang

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 493326. Fznamznon added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Drive

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 493576. Fznamznon added a comment. Apply suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"); } MaskRay wrote: > Fz

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:60 `Issue 59446 `_. +- Fix confusing warning message when `/clang:-x` is passed in clang-cl driver + mode and emit an error which suggests using `/TC` o

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. @MaskRay , thanks for the suggestions. Applied. Please let me know that it is ok now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 __

  1   2   3   4   5   >