[PATCH] D56323: Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: cfe-commits. LegalizeAdulthood updated this revision to Diff 180274. LegalizeAdulthood added a comment. Fix typo in id - Add readability-simplify-boolean-expr test cases for member variables Fixes #40179 https://revi

[PATCH] D56323: Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood updated this revision to Diff 180275. LegalizeAdulthood added a comment. Fix typo in id CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp test/clang-tidy/readability-

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood updated this revision to Diff 180276. LegalizeAdulthood added a comment. No, really, fix typo in id Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 Files: clang-tidy/readability/SimplifyB

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

This revision was automatically updated to reflect the committed changes. Closed by commit rL350426: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types (authored by aaronenyeshi, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a reviewer: serge-sans-paille. Break up the huge main() function Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56343 Files: test/clang-tidy

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood updated this revision to Diff 180349. LegalizeAdulthood added a comment. Extract Function try_run CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/D56343 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check_clang_

[PATCH] D56341: [python] Make the collections import future-proof

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56341/new/ https://reviews.llvm.org/D56341

[PATCH] D56341: [python] Make the collections import future-proof

This revision was automatically updated to reflect the committed changes. Closed by commit rC350467: [python] Make the collections import future-proof (authored by serge_sans_paille, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56341/new/ https://

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood added a comment. I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood marked 4 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:464 bool Value, StringRef Id) { - auto SimpleThen = binaryOperator( -

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood marked 5 inline comments as done. LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/readability-simplify-bool-expr-members.cpp:4 +struct X { + explicit operator bool(); +}; JonasToth wrote: > LegalizeAdulthood wrote: > > Jona

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood updated this revision to Diff 180379. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 Files: clang-tidy/readab

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood marked 10 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:386 - bool BoolValue = Bool->getValue(); + const bool BoolValue = Bool->getValue(); JonasToth wrote

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180380. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files: clang-tidy/readab

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. In D56323#1347450 , @JonasToth wrote: > Did you check if the changes actually fix the problematic behaviour? Did you > run it over any project and did the code-transfor

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180384. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files: clang-tidy/readab

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:719 +bool Negated, const SwitchCase *SwitchCase) { + assert(SwitchCase != nullptr); + riccibruno wrot

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180385. LegalizeAdulthood added a comment. No really, update from review comments `:)` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. Uh... I'm developing on Windows, which doesn't have a solution for generating compile_commands.json, so I can't easily test this on the entire clang codebase. I will test on a source file based on the original bug report. CHANGES SINCE LAST ACTION https://

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. I managed to do some limited testing on the original source file from the bug report in lldb and verified that the correct fix was applied there. I also tried a few other files and verified no false positives. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. libprotobuf still builds cleanly with just the one expected warning..despite adding over 500 [[nodiscards]] F7800873: image.png I'll continue to look at other projects, but I'm happy at present that this gives us a good starti

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

serge-sans-paille added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:103 + return (has_check_fixes, has_check_messages, has_check_notes, \ +check_fixes_prefixes, check_messages_prefixes, check_notes_prefixes) Such a long list of returne

[PATCH] D56134: [AST] Store some data of CXXNewExpr as trailing objects

This revision was automatically updated to reflect the committed changes. Closed by commit rL350527: [AST] Store some data of CXXNewExpr as trailing objects (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56134

[PATCH] D56365: [X86] Use funnel shift intrinsics for the VBMI2 vshld/vshrd builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350555: [X86] Use funnel shift intrinsics for the VBMI2 vshld/vshrd builtins. (authored by ctopper, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56365/new/

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

This revision was automatically updated to reflect the committed changes. Closed by commit rC350585: Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56405?vs=180532&id=180584#toc Repo

[PATCH] D56429: fix python3 compability issue

roxma created this revision. roxma added reviewers: ilya-biryukov, mgorny. Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: serge-sans-paille. The file contents could be of str type. Should use byte length instead of str length, otherwise utf-8 encoded files may not get pr

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read() Why did you re

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 180625. MyDeveloperDay added a comment. Sorry to add another revision but, rerunning no-discard checker on LLVM code base threw up other [[nodiscard]] placements which whilst they MAY be correct, I don't think we should handle in this first pass. - c

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:1 +//===--- AvoidUnderscoreInGoogletestNameCheck.cpp - clang-tidy-===// +// nit: space after tidy and before --- Comment a

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

MyDeveloperDay added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:1 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + nit: is there a reason here why you say C++14 when the code checks for C++11?

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

MyDeveloperDay added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:1 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + bernhardmgruber wrote: > MyDeveloperDay wrote: > > nit: is there a reason here

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:45 +std::string(Message) + +" (no FixIt provided, function argument list end is inside macro)"); +return {}; bernhardmgruber wrote: > JonasT

[PATCH] D56050: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350622: [Sema] Diagnose array access preceding the array bounds even when the base type… (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC350625: [AST] Pack CXXDependentScopeMemberExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D56367?vs=180407&id=180651#toc Repository: rC Clang CHANGES

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1349709 , @JonasToth wrote: > No problem, thats why we test on real projects first, because there is always > something hidden in C++ :) > > Is there a test for the lambdas? test/clang-tidy/modernize-use-nodis

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. In D55433#1349709 , @JonasToth wrote: > No problem, thats why we test on real projects first, because there is always > something hidden in C++ :) > > Is there a test for t

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 180687. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Address review comments - add more lambda tests - add nested lambda test - remove hasParent() call, (seems isConversionOperator()) seems to detect the CXXMethods

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1349709 , @JonasToth wrote: > No problem, thats why we test on real projects first, because there is always > something hidden in C++ :) > > Is there a test for the lambdas? test/clang-tidy/modernize-use-nodis

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P", +

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P", +

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:64 + Check->diag(TestCaseNameToken->getLocation(), + "avoid using \"_\" in test case name \"%0\" according to " + "Googletest FAQ")

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rC350703: Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo. (authored by stulova, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55948/new/ https:/

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC350714: [Driver] Fix libcxx detection on Darwin with clang run as ./clang (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56446?vs=180691&id=180822#toc Reposi

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1350999 , @JonasToth wrote: > LGTM! > You verified that your fixes, fix the issues in LLVM? But it looks good to > go. They look good, you asked before... > P.S. did you request commit rights already? I do no

[PATCH] D56368: [AST] Store the results in OverloadExpr in a trailing array

This revision was automatically updated to reflect the committed changes. Closed by commit rL350732: [AST] Store the results in OverloadExpr in a trailing array (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC350741: [AST] Move back BasePathSize to the bit-fields of CastExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D56358?vs=180377&id=180854#toc Repository:

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

This revision was automatically updated to reflect the committed changes. Closed by commit rC350758: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D55928?vs=179078&id=18090

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350759: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop… (authored by gbercea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

serge-sans-paille added a comment. @Romain-Geissler-1A sure thing. Can you rebase your patch on master first? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54071/new/ https://reviews.llvm.org/D54071 ___ cfe-commits m

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

MyDeveloperDay added a comment. nit's come from running running validate_check.py on the rst file from D55523: [clang-tidy] Linting .rst documentation $ ../clang-tidy/validate_check.py --rst abseil-duration-conversion-cast.rst Checking abseil-duration-conversion

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

This revision was automatically updated to reflect the committed changes. Closed by commit rC350856: Split -Wdelete-non-virtual-dtor into two groups (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56405?vs=180690&id=181081#toc Repository: rC Clang CHAN

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 created this revision. joedaniels29 added reviewers: erik.pilkington, rjmccall. Currently to get a nonlazy class in objective c, you need to define a +load method. Because we do other work when we realize a class, other than just call that load method, it would be ideal to have an

[PATCH] D56042: [analyzer] pr38838, pr39976: Fix a crash on emitting diagnostics before destructor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350907: [analyzer] pr38838, pr39976: Fix crash on diagnosing before implicit destructor. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, erichkeane wrote: > zsrkmyn wrote: > > zs

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, erichkeane wrote: > zsrkmyn wrote: > > er

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rL371530: Don't emit .gnu_pubnames when tuning for LLDB. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, erichkeane wrote: > zsrkmyn wrote: > > er

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn updated this revision to Diff 219568. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/ https://reviews.llvm.org/D67058 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/attr-cpuspecific.c clang/test/CodeGen/attr-target-mv-func-ptrs.c clang/test/CodeGen

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn marked 18 inline comments as done. zsrkmyn added a comment. All done IMO. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/ https://reviews.llvm.org/D67058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D67395: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this patch, i've seen a number of PRs raise to this effect.. this looks to be a great start in this area LGTM Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. Up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371658: [analyzer] NFC: Re-implement stack hints as a side map in BugReport. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67418: [analyzer] NFC: Move PathDiagnostic::resetDiagnosticLocationToMainFile to bug reporter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371660: [analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371659: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

This revision was automatically updated to reflect the committed changes. Closed by commit rL371719: [clang-format] Add new style option IndentGotoLabels (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

This revision was automatically updated to reflect the committed changes. Closed by commit rL371720: [clang-format] [PR43100] clang-format C# support does not add a space between… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

MyDeveloperDay added a comment. Does this need landing? given that you have a number of patches in flight perhaps it would be good to request commit access Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 __

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

MyDeveloperDay added a comment. > Yes, it would be good if it is landed. And can I know the procedure for > getting commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL372008: [clangd] Simplify semantic highlighting visitor (authored by ibiryukov, committed by ). Herald added subscribers: llvm-commits, usaxena95. Herald added a project: LLVM. Changed prior to commit:

[PATCH] D67629: [clang-format] Fix C# breaking before function name when using Attributes

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, klimek. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. This is a fix for https://bugs.llvm.org/show_bug.cgi?id=4 This comes with 3 main parts - C# attributes cause function name

[PATCH] D67065: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL372078: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly (authored by kito, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67066: [RISCV] Add option aliases: -mcmodel=medany and -mcmodel=medlow

This revision was automatically updated to reflect the committed changes. Closed by commit rL372080: [RISCV] Add option aliases: -mcmodel=medany and -mcmodel=medlow (authored by kito, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay added a comment. Thank you for this patch This LGTM, ensure you comment out the failing unit tests and add a FIXME to the test as to why they don't currently work (or fix them if possible), the tests need to keep passing or others will not know they haven't broken things. Normal

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay added a comment. when/if you commit can you abandon D6833: Clang-format: Braces Indent Style Whitesmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___

[PATCH] D67660: [clang-format]

MyDeveloperDay created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D67660 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatTokenLexer.h clang/lib/Format/TokenAnnotator.cpp clang/u

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, klimek, russellmcc, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. clang-format 8.0 crashes with SIGFPE (floating point exception) when formatting following file: app.cpp: voi

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:660 case '\t': -Column += Style.TabWidth - Column % Style.TabWidth; +Column += Style.TabWidth - (Column ? Column % Style

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

MyDeveloperDay updated this revision to Diff 220571. MyDeveloperDay added a comment. I should have known it was more involved. v % 0 and v / 0 are both undefined behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67670/new/ https://reviews.llvm.org/D67670 Files: clang/lib/Format

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

This revision was automatically updated to reflect the committed changes. Closed by commit rL372183: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C… (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___ cfe-commits mailing list cfe-com

[PATCH] D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL372201: [Support] Replace function with function_ref in writeFileAtomically. NFC (authored by ibiryukov, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llv

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Meinersbur any feedback on this update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 ___ cfe-commits mailing list cfe-com

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, krasimir, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=41899 auto lambda = [&a = a]() { a = 2; }; is formatted as auto la

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

This revision was automatically updated to reflect the committed changes. Closed by commit rL372246: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

This revision was automatically updated to reflect the committed changes. Closed by commit rL372247: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL372249: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

This revision was automatically updated to reflect the committed changes. Closed by commit rL372294: [CLANG][BPF] change __builtin_preserve_access_index() signature (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60748: Fix i386 struct and union parameter alignment

LiuChen3 updated this revision to Diff 220793. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/x86_32-align-linux.c clang/test/CodeGen/x86_32-align-linux.cpp clang/test/CodeGen/x86

[PATCH] D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. This is to address a request made in https://bugs.llvm.org/show_bug.cgi?id=43144 Add the ability to not have a space before and

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

MyDeveloperDay added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:555 + StringRef FileName = File->tryGetRealPathName(); + if (FileName.empty()) { +FileName = File->getName(); elide the {} Repository: rCTE Cl

[PATCH] D32435: clang-cl: Add support for /permissive-

Trass3r added a comment. Has this ever gotten anywhere? I think the correct mapping would be something like -fno-ms-compatibility -fno-delayed-template-parsing, not sure about -fms-volatile -fms-extensions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32435/new/ https://reviews.llvm.o

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 221166. Tyker marked 24 inline comments as done. Tyker added a comment. Fixed most changes requested by @aaron.ballman test are currently no valid anymore see comments for why. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.l

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:275 - /// Used to cleanups APValues stored in the AST. - mutable llvm::SmallVector APValueCleanups; - aaron.ballman wrote: > Why are you getting rid of this? It seems like we would st

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 221169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:176 + (DataSize - sizeof(MemberPointerBase)) / sizeof(CXXRecordDecl *); + typedef CXXRecordDecl *PathElem; union { Tyker wrote: > aaron.ballman wro

[PATCH] D67843: DisableFormat also now disables SortIncludes

MyDeveloperDay added a comment. I assume the intention was that users could have DisableFormat=true and SortIncludes=true when they want to sort the includes but not perform any additional formatting in the code. I think by making this change you make it impossible to run clang-format through

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

This revision was automatically updated to reflect the committed changes. Closed by commit rL372497: Clang-format: Add Whitesmiths indentation style (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

<    22   23   24   25   26   27   28   29   30   31   >