[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

pirama updated this revision to Diff 124417. pirama added a comment. Normalize falkor and saphira as well. https://reviews.llvm.org/D40476 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/as-mcpu.c Index: test/Driver/as-mcpu.c ==

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rL319077: Switch CPU names not recognized by GNU assembler (authored by pirama). Repository: rL LLVM https://reviews.llvm.org/D40476 Files: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/test/Dri

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

pirama added a comment. Thanks for the review. Now let's just hope the windows bots stay happy :) Repository: rL LLVM https://reviews.llvm.org/D40476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes

pirama abandoned this revision. pirama added a comment. Thanks for the clarification Richard and Eli. I agree that leaving the status quo will match the intent of the macro. I'll abandon this. Repository: rC Clang https://reviews.llvm.org/D50683 _

[PATCH] D51068: [Android] Default to -fno-math-errno

pirama created this revision. pirama added reviewers: srhines, enh. Android's libm does not set errno. Repository: rC Clang https://reviews.llvm.org/D51068 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/fast-math.c Index: test/Driver/fast-math.c

[PATCH] D51068: [Android] Default to -fno-math-errno

pirama added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:913 +return false; + return Generic_ELF::IsMathErrnoDefault(); +} I tried to be defensive here in case the default changes in the future. I can simplify to just return true here if t

[PATCH] D51068: [Android] Default to -fno-math-errno

This revision was automatically updated to reflect the committed changes. Closed by commit rL340424: [Android] Default to -fno-math-errno (authored by pirama, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51068 Files: cfe/trunk/lib/Dr

[PATCH] D53850: Declares __cpu_model as hidden symbol

pirama edited reviewers, added: echristo, craig.topper; removed: pirama. pirama added subscribers: srhines, pirama, cfe-commits. pirama added a comment. Adding reviewers suggested by 'arc cover'. https://reviews.llvm.org/D53850 ___ cfe-commits maili

[PATCH] D50112: [Android] Increase default new alignment for Android

pirama created this revision. pirama added a reviewer: rsmith. Android's memory allocators also guarantee 8-byte alignment for 32-bit architectures and 16-byte alignment for 64-bit. Repository: rC Clang https://reviews.llvm.org/D50112 Files: lib/Basic/TargetInfo.cpp test/Preprocessor/ini

[PATCH] D50112: [Android] Increase default new alignment for Android

This revision was automatically updated to reflect the committed changes. Closed by commit rC338603: [Android] Increase default new alignment for Android (authored by pirama, committed by ). Changed prior to commit: https://reviews.llvm.org/D50112?vs=158402&id=158574#toc Repository: rC Clang

[PATCH] D50199: [MinGW] Predefine UNICODE if -municode is specified during compilation

pirama added a comment. In https://reviews.llvm.org/D50199#1186164, @rnk wrote: > Does this do anything other than -DUNICODE? Maybe just translate it at the > driver level and skip the -cc1 flag? It seems odd to include predefined macros at the driver, which AFAIK is just a bridge to the fron

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 159330. pirama added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D37302 Files: lib/Headers/float.h test/Headers/float.c Index: test/Headers/float.c === --- test/Head

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama added a comment. Sorry this fell of my radar. I've rebased the patch. Since this has been inactive for a while, lets wait for a couple of days to see if there are any other comments. If there are no objections, I'll submit this on Wednesday. Repository: rC Clang https://reviews.ll

[PATCH] D50359: Add a new library, libclang-cxx

pirama created this revision. Herald added a subscriber: mgorny. The current libclang.so exports only the symbols required for the stable C api. This is opposed to libLLVM.so, which exports all the symbols from the LLVM libraries, including those from the C++ API. This patch adds libclang-cxx.so

[PATCH] D50359: Add a new library, libclang-cxx

pirama added a comment. This implements the new library proposed in http://lists.llvm.org/pipermail/cfe-dev/2018-August/058736.html. Repository: rC Clang https://reviews.llvm.org/D50359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

This revision was automatically updated to reflect the committed changes. Closed by commit rC339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL (authored by pirama, committed by ). Changed prior to commit: https://reviews.llvm.org/D37302?vs=159330&id=159778#toc Repository: rC Clang h

[PATCH] D50467: [SEMA] add more -Wfloat-conversion to compound assigment analysis

pirama added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10411 +->getAs(); + if (!ResultBT || !(RBT && RBT->isFloatingPoint())) return; + Add a comment explaining this conditional as well? > Return if source and target types

[PATCH] D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes

pirama created this revision. pirama added reviewers: rsmith, srhines. Android uses jemalloc allocator, which returns 8-byte-aligned pointers for allocations smaller than 8 bytes for 64-bit architectures. Set NewAlign conservatively to 8 bytes. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D132984: Set HOME for tests that use module cache path

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fe475756b26: Set HOME for tests that use module cache path (authored by ccross, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132984/n

[PATCH] D157331: [clang] Implement C23

pirama added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8618-8619 + "operand argument to %select{overflow builtin|checked integer operation}0 " + "must be an integer type %select{|other than plain 'char', 'bool', bit-precise, " + "or an enum

[PATCH] D158476: [driver] Search for compatible Android runtime directories

pirama accepted this revision. pirama added a comment. LGTM from the Android platform/NDK side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 ___ cfe-commits

[PATCH] D157331: [clang] Implement C23

pirama added a comment. @aaron.ballman do you have additional comments or does this patch looks good to merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

pirama added a comment. @alxu Just realized you don't have commit access. Do you want one of us to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753 ___

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

pirama added a reviewer: nickdesaulniers. pirama added a subscriber: nickdesaulniers. pirama added a comment. @nickdesaulniers I presume this is still necessary? See https://reviews.llvm.org/D53463 for why we added this. (The Android kernel build does not use the Android triple.) Repository:

[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

pirama edited reviewers, added: srhines; removed: pirama. pirama added a comment. Will defer to Dan's review. I think these changes are safe for the Android platform (where we only use lld). The NDK only supports lld but that does not preclude external users from using other linkers. Reposit

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

pirama added subscribers: pirama, srhines, kongyi. pirama added a comment. Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters. (Curiously, this verification only fails with ThinLTO). // with -flto=full or without -flto=thin, below command

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

pirama accepted this revision. pirama added a subscriber: srhines. pirama added a comment. This revision is now accepted and ready to land. Thanks for the cleanup here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/new/ https://reviews.llvm.

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5b387988bd4: Revert "[CodeGen] Mark fma as const for Android" (authored by alxu, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/

<    1   2