[PATCH] D67200: Add -static-openmp driver option

This revision was automatically updated to reflect the committed changes. Closed by commit rL371437: [Driver] Add -static-openmp driver option (authored by pirama, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67200: Add -static-openmp driver option

pirama updated this revision to Diff 219200. pirama edited the summary of this revision. pirama added a comment. Test -static, -static-openmp interaction. Added these only for iomp5 to avoid test-case explosion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67364: [Driver] Handle default case in refactored addOpenMPRuntime

This revision was automatically updated to reflect the committed changes. Closed by commit rL371444: [Driver] Handle default case in refactored addOpenMPRuntime (authored by pirama, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67364: [Driver] Handle default case in refactored addOpenMPRuntime

pirama created this revision. pirama added reviewers: srhines, danalbert. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Appease failed builds (due to -Werror and -Wswitch) where OMPRT_Unknown is not handled in the switch statement (even

[PATCH] D67364: [Driver] Handle default case in refactored addOpenMPRuntime

pirama updated this revision to Diff 219413. pirama added a comment. Check for OMPRT_Unknown instead of a default case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67364/new/ https://reviews.llvm.org/D67364 Files:

[PATCH] D67200: Add -static-openmp driver option

pirama created this revision. pirama added reviewers: Hahnfeld, danalbert, srhines, joerg. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. This option forces linking with the static OpenMP host runtime (similar to -static-libgcc and

[PATCH] D65000: [ARM] Set default alignment to 64bits

pirama accepted this revision. pirama added a comment. LGTM for Android. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list

[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

pirama created this revision. pirama added reviewers: beanz, mgorny. Herald added a project: clang. Herald added a subscriber: cfe-commits. In libclang-cpp, export only symbols from the clang namespace or clang_* (functions for the C interface). This fixes the use case where a tool depends on

[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

pirama added a comment. In D78033#1978612 , @beanz wrote: > I think this has some unintended consequences. If your tool wants to use > libLLVM and libClang you really need libClang to be linked against libLLVM, > otherwise you're actually just hiding

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added a comment. In D101878#2740133 , @curdeius wrote: > LGTM but let's wait a day or two before landing, so that others can chime in. > Btw, do you have commit rights? If no, please provide "Name " for >

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343194. pirama added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/docs/ReleaseNotes.rst

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343171. pirama added a comment. Remove debug print(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/tools/clang-format/git-clang-format Index:

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added inline comments. Comment at: clang/tools/clang-format/git-clang-format:345 + for filename in list(dictionary.keys()): +print(os.getcwd()) +if os.path.islink(filename): curdeius wrote: > Is this print

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fd0a010a1ed: [git-clang-format] Do not apply clang-format to symlinks (authored by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama created this revision. pirama added reviewers: MyDeveloperDay, srhines. pirama requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes PR46992. Git stores symlinks as text files and we should not format them even if they have

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 342927. pirama added a comment. Leave two empty lines after filter_symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files:

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

pirama added a reviewer: nickdesaulniers. pirama added a subscriber: nickdesaulniers. pirama added a comment. @nickdesaulniers I presume this is still necessary? See https://reviews.llvm.org/D53463 for why we added this. (The Android kernel build does not use the Android triple.)

[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

pirama edited reviewers, added: srhines; removed: pirama. pirama added a comment. Will defer to Dan's review. I think these changes are safe for the Android platform (where we only use lld). The NDK only supports lld but that does not preclude external users from using other linkers.

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5b387988bd4: Revert [CodeGen] Mark fma as const for Android (authored by alxu, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

pirama added subscribers: pirama, srhines, kongyi. pirama added a comment. Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters. (Curiously, this verification only fails with ThinLTO). // with -flto=full or without -flto=thin, below

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

pirama added a comment. @alxu Just realized you don't have commit access. Do you want one of us to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

pirama accepted this revision. pirama added a subscriber: srhines. pirama added a comment. This revision is now accepted and ready to land. Thanks for the cleanup here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/new/

[PATCH] D157331: [clang] Implement C23

pirama added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8618-8619 + "operand argument to %select{overflow builtin|checked integer operation}0 " + "must be an integer type %select{|other than plain 'char', 'bool', bit-precise, " + "or an

[PATCH] D157331: [clang] Implement C23

pirama added a comment. @aaron.ballman do you have additional comments or does this patch looks good to merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331

[PATCH] D158476: [driver] Search for compatible Android runtime directories

pirama accepted this revision. pirama added a comment. LGTM from the Android platform/NDK side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 ___ cfe-commits

[PATCH] D132984: Set HOME for tests that use module cache path

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fe475756b26: Set HOME for tests that use module cache path (authored by ccross, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2