https://github.com/shafik commented:
Thank you for this PR. This change should have some tests to verify the
behavior is correct. I am a little surprised that this does not change any
existing tests but maybe we don't have good test coverage.
https://github.com/llvm/llvm-project/pull/80244
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/82407
>From 5fcaeaddccc0f7e370bf7bebce113d8d52e1b1bd Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Tue, 20 Feb 2024 11:22:39 -0800
Subject: [PATCH] [Clang][Sema] Fix incorrect rejection default construction of
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/82407
>From 5fcaeaddccc0f7e370bf7bebce113d8d52e1b1bd Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Tue, 20 Feb 2024 11:22:39 -0800
Subject: [PATCH] [Clang][Sema] Fix incorrect rejection default construction of
https://github.com/shafik commented:
Hello, the diff is only showing a single whitespace change which from the title
does not seem the intent.
https://github.com/llvm/llvm-project/pull/80063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/78742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18,6 +19,40 @@ enum x // expected-warning
{{enumeration values exceed rang
{ y = -9223372036854775807LL-1, // expected-warning {{ISO C restricts
enumerator values to range of 'int'}}
z = 9223372036854775808ULL };// expected-warning {{ISO C
https://github.com/shafik commented:
I think a more appropriate title would be "Fix for overflow in enumerators"
https://github.com/llvm/llvm-project/pull/78742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,15 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+
+template < class T, class V > struct A
+{
+A ();
+A (A &);
+A (A < V,T >);
+// expected-error@-1 {{copy constructor must pass its first argument by
reference}}
+};
+
+void f ()
+{
+A (A < int,
https://github.com/shafik commented:
This also needs a release note.
https://github.com/llvm/llvm-project/pull/81251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik wrote:
@cor3ntin the fix looks like the one you recommended but that is quite a lot of
tests that fail.
https://github.com/llvm/llvm-project/pull/81251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -120,6 +120,10 @@ Non-comprehensive list of changes in this release
New Compiler Flags
--
+- ``-Wmissing-designated-field-initializers``, grouped under
``-Wmissing-designated-field-initializers``.
shafik wrote:
CC @AaronBallman
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/82407
>From 5fcaeaddccc0f7e370bf7bebce113d8d52e1b1bd Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Tue, 20 Feb 2024 11:22:39 -0800
Subject: [PATCH] [Clang][Sema] Fix incorrect rejection default construction of
shafik wrote:
Can you explain which cases the `if (!ArraySize)` condition was catching before
and why the change does not effect those cases? My fear is that we are breaking
other cases but we don't have test coverage for those cases and we are missing
those breaks.
@@ -0,0 +1,19 @@
+// RUN: %clang++ -S -emit-llvm -o - %s | FileCheck %s
+#include
+
+// CHECK: call void @llvm.memset.p0.i64(ptr align 1 %x, i8 0, i64 8, i1 false)
+// CHECK: call void @llvm.memset.p0.i64(ptr align 16 %x, i8 0, i64 32, i1
false)
+template
shafik wrote:
Thank you for this fix.
Can you put more details in your summary. The approach I like to take is 1.
what the problem is 2. what is the approach of the fix 3. any other important
details.
https://github.com/llvm/llvm-project/pull/83124
@@ -100,6 +100,12 @@ void AttributePool::takePool(AttributePool ) {
pool.Attrs.clear();
}
+void AttributePool::takeFrom(ParsedAttributesView , AttributePool ) {
+ assert( != this && "AttributePool can't take attributes from itself");
+ llvm::for_each(List.AttrList,
https://github.com/shafik commented:
Note, I opened an issue for this here:
https://github.com/llvm/llvm-project/issues/83385
https://github.com/llvm/llvm-project/pull/83611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik requested changes to this pull request.
We need a minimal reproducer here. Looking at the bug report it is not clear to
me if this is the correct fix or not. After we have a reproducer we would need
a test added to the PR and a release note.
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
I think this makes sense but I would like another set of eyes.
https://github.com/llvm/llvm-project/pull/83688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -5042,7 +5042,7 @@ void RecordDecl::completeDefinition() {
// Layouts are dumped when computed, so if we are dumping for all complete
// types, we need to force usage to get types that wouldn't be used
elsewhere.
- if (Ctx.getLangOpts().DumpRecordLayoutsComplete)
+
https://github.com/shafik commented:
Thank you for this fix. I am happy the changes were not too different from my
suggestion. Sometimes problems end up being more difficult then they seem
initially.
https://github.com/llvm/llvm-project/pull/83152
@@ -16538,6 +16538,17 @@ void Sema::DiagnoseAlwaysNonNullPointer(Expr *E,
}
}
+ // Complain if we are converting a lambda expression to a boolean value
+ if (const auto *MCallExpr = dyn_cast(E)) {
+if (const auto *MRecordDecl = MCallExpr->getRecordDecl();
+
@@ -16538,6 +16538,17 @@ void Sema::DiagnoseAlwaysNonNullPointer(Expr *E,
}
}
+ // Complain if we are converting a lambda expression to a boolean value
+ if (const auto *MCallExpr = dyn_cast(E)) {
+if (const auto *MRecordDecl = MCallExpr->getRecordDecl();
+
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik requested changes to this pull request.
I don't believe this is the right approach.
I can only replicate one of the issues: https://godbolt.org/z/7dee3a3cY
I spent some time looking at it and it is quite gnarly but we need to
understand better what is going on.
https://github.com/shafik approved this pull request.
LGTM, any objections @tbaederr
https://github.com/llvm/llvm-project/pull/76646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/76646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -35,11 +41,14 @@ class field_test {
int x;
field_test(field_test&& other) {
x = std::move(x); // expected-warning{{explicitly moving}}
+x = static_cast(x); // expected-warning{{explicitly moving}}
shafik wrote:
Can you add some tests where we
shafik wrote:
Adding @AaronBallman and @erichkeane for a wider audience
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -17615,31 +17615,28 @@ class SequenceChecker : public
ConstEvaluatedExprVisitor {
return VisitExpr(CCE);
// In C++11, list initializations are sequenced.
-SmallVector Elts;
-SequenceTree::Seq Parent = Region;
-for
https://github.com/shafik approved this pull request.
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
LGTM after addressing comment.
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
https://github.com/llvm/llvm-project/pull/83611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
LGTM but I would like Tom or Aaron to also take a look
https://github.com/llvm/llvm-project/pull/93216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -467,15 +467,18 @@ class Parser : public CodeCompletionHandler {
/// Flags describing a context in which we're parsing a statement.
enum class ParsedStmtContext {
+/// This context permits declarations in language modes where declarations
+/// are not
https://github.com/shafik approved this pull request.
Thank you for the fix. Can you please a little more details to your summary so
that folks reading git log have more context.
This also needs a release note.
Please also add that this also fixes:
shafik wrote:
Can you also confirm this fixes:
https://github.com/llvm/llvm-project/issues/70191
https://github.com/llvm/llvm-project/pull/93079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/92721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Can you add some details to the summary. What was the original code doing wrong
and the proposed new approach.
https://github.com/llvm/llvm-project/pull/92721
___
cfe-commits mailing list
@@ -11298,8 +11298,14 @@ static void DiagnoseBadConversion(Sema ,
OverloadCandidate *Cand,
Expr *FromExpr = Conv.Bad.FromExpr;
QualType FromTy = Conv.Bad.getFromType();
QualType ToTy = Conv.Bad.getToType();
- SourceRange ToParamRange =
- !isObjectArgument ?
https://github.com/shafik commented:
This makes sense given the pain we are seeing here.
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -36,7 +36,7 @@ namespace InExpr {
// These are valid expressions.
foo(0);
+foo(0); // expected-warning {{comparisons like 'X<=Y<=Z' don't have
their mathematical meaning}}
foo(false);
shafik wrote:
It is a shame we don't catch this one
@@ -947,6 +947,26 @@ void TextNodeDumper::dumpDeclRef(const Decl *D, StringRef
Label) {
});
}
+void TextNodeDumper::dumpTemplateArgument(const TemplateArgument ) {
+ llvm::SmallString<128> Str;
+ {
+llvm::raw_svector_ostream SS(Str);
+TA.print(PrintPolicy, SS,
@@ -2995,13 +2996,23 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec ,
ParsedType ObjectType,
SS, ObjectType, ObjectHadErrors,
TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), Id, IdLoc,
EnteringContext, Result, TemplateSpecified);
-else if
https://github.com/shafik commented:
LGTM w/ a few nitpicks
https://github.com/llvm/llvm-project/pull/92113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/92113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -451,6 +463,25 @@ static_assert(!__is_nothrow_constructible(D4, int), "");
#endif
} // namespace cwg1350
+namespace cwg1352 { // cwg1352: 3.0
+struct A {
+#if __cplusplus >= 201103L
+ int a = sizeof(A);
shafik wrote:
I think it might be worth it to see
@@ -86,6 +86,23 @@ struct A {
};
}
+namespace cwg1458 { // cwg1458: 3.1
+#if __cplusplus >= 201103L
+struct A;
+
+void f() {
+ constexpr A* a = nullptr;
+ constexpr int p = &*a;
+ // expected-error@-1 {{cannot initialize a variable of type 'const int' with
an rvalue of
@@ -451,6 +463,25 @@ static_assert(!__is_nothrow_constructible(D4, int), "");
#endif
} // namespace cwg1350
+namespace cwg1352 { // cwg1352: 3.0
+struct A {
+#if __cplusplus >= 201103L
+ int a = sizeof(A);
shafik wrote:
It also mentions in the body of
https://github.com/shafik commented:
LGTM, curious why you skipped some and not others from that telecom. Likely
folks won't be able to check out the DRs until after St Louis.
https://github.com/llvm/llvm-project/pull/94167
___
cfe-commits mailing
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/94288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -373,6 +373,98 @@ namespace cwg1837 { // cwg1837: 3.3
#endif
}
+namespace cwg1862 { // cwg1862: no
+template
+struct A {
+ struct B {
+void e();
+ };
+
+ void f();
+
+ struct D {
+void g();
+ };
+
+ T h();
+
+ template
+ T i();
+};
+
+template<>
@@ -121,6 +145,21 @@ derived d2(42, 9);
#endif
}
+namespace cwg1945 { // cwg1945: no
+template struct A {
+ class B {
+class C {};
+ };
+};
+class X {
+ static int x;
+ // FIXME: this is ill-formed, because A::B::C does not end with a
simple-template-id
+ template
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/94288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
LGTM
https://github.com/llvm/llvm-project/pull/94288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
https://github.com/llvm/llvm-project/pull/94288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Thank you for the fix!
https://github.com/llvm/llvm-project/pull/93460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2791,6 +2791,12 @@ bool ASTContext::hasUniqueObjectRepresentations(
return hasUniqueObjectRepresentations(getBaseElementType(Ty),
CheckIfTriviallyCopyable);
+ if (Ty->isVoidType())
shafik wrote:
It is not
https://github.com/shafik created
https://github.com/llvm/llvm-project/pull/95474
P2280R4 allows the use of references in pointers of unknown origins in a
constant expression context but only in specific cases that could be constant
expressions.
We track whether a variable is a constexpr
@@ -3420,6 +3441,15 @@ static bool evaluateVarDeclInit(EvalInfo , const
Expr *E,
}
Result = VD->getEvaluatedValue();
+
+ // P2280R4 If we don't have a value because this is a reference that was not
+ // initialized or whose lifetime began within E then create a value
https://github.com/shafik commented:
LGTM after addressing coloring issues.
https://github.com/llvm/llvm-project/pull/94876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/97322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
Thank you for the fix! LGTM
https://github.com/llvm/llvm-project/pull/97322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik wrote:
Looks like this is ready to land, if you have reached out to the Fuchsia and XL
folks you should be good.
https://github.com/llvm/llvm-project/pull/90462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
shafik wrote:
Is this ready to land?
https://github.com/llvm/llvm-project/pull/90387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
https://github.com/llvm/llvm-project/pull/95399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/95399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -241,6 +238,13 @@ TPLa a;
} // namespace Thirteen
+namespace Fourteen {
+template
+int A = T();
+
+using enum A; // expected-error {{A is not an enumerated type}}
+} // namespace Fourteen
shafik wrote:
What does `Fourteen` stand for here or is it just a
@@ -148,13 +148,10 @@ template struct C {
enum class D { d,
e,
f };
- using enum D;
-
- static constexpr int W = int(f) + I;
+ using enum D; // expected-error {{using-enum cannot name a dependent type}}
shafik wrote:
It
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Thank you for this fix. It needs a release note and your summary should have
some more details on what the cause of the bug is and how your PR fixes it.
efriedma-quic's comment provides a good framework for explaining the cause.
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
shafik wrote:
I think this may be a more appropriate place for the test:
https://github.com/llvm/llvm-project/blob/main/clang/test/SemaCXX/anonymous-union.cpp
We usually wrap tests from
@@ -1392,7 +1392,8 @@ class CXXRecordDecl : public RecordDecl {
bool allowConstDefaultInit() const {
return !data().HasUninitializedFields ||
!(data().HasDefaultedDefaultConstructor ||
- needsImplicitDefaultConstructor());
+
shafik wrote:
You reapplied this here:
https://github.com/llvm/llvm-project/commit/1595988ee6f9732e7ea79928af8a470ad5ef7dbe
but it has caused a regression:
https://github.com/llvm/llvm-project/issues/97646
https://github.com/llvm/llvm-project/pull/90500
https://github.com/shafik deleted
https://github.com/llvm/llvm-project/pull/95474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -249,13 +249,15 @@ class APValue {
struct NoLValuePath {};
struct UninitArray {};
struct UninitStruct {};
+ struct ConstexprUnknown {};
template friend class clang::serialization::BasicReaderBase;
friend class ASTImporter;
friend class ASTNodeImporter;
@@ -249,13 +249,15 @@ class APValue {
struct NoLValuePath {};
struct UninitArray {};
struct UninitStruct {};
+ struct ConstexprUnknown {};
template friend class clang::serialization::BasicReaderBase;
friend class ASTImporter;
friend class ASTNodeImporter;
shafik wrote:
I don't think the build error is related to this change.
https://github.com/llvm/llvm-project/pull/98439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/96228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Thank you for this fix!
https://github.com/llvm/llvm-project/pull/98439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik wrote:
> The sad part is that MSVC and some old versions of GCC don't like `template`
> being added here :(
It looks like the description provides a workaround for gcc but a bug report
against MSVC should be filed if we don' have one already.
https://github.com/shafik requested changes to this pull request.
It looks like we are using the same pattern that fix is using in
`ASTStmtReader::VisitRequiresExpr` which gives me some comfort but I am not
happy that we have a relatively complex and easy to get wrong operation
repeated in
@@ -0,0 +1,18 @@
+// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s
shafik wrote:
I think this is a better location for the test:
https://github.com/llvm/llvm-project/blob/main/clang/test/CXX/class/class.compare/class.compare.default/p1.cpp
We normally
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/96228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Thank you for the fix.
I am curious what specifically about this code triggers the crash. We do have a
test w/ a defaulted outside the class. So there is another condition needed to
trigger this. It looks like removing `constexpr` from `operator==(d h, g
shafik wrote:
There are several test failures that look related to this change, please check
them out.
https://github.com/llvm/llvm-project/pull/96228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/98788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Quick drive by comment
https://github.com/llvm/llvm-project/pull/98788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2157,17 +2157,19 @@ CXXDeductionGuideDecl *CXXDeductionGuideDecl::Create(
ASTContext , DeclContext *DC, SourceLocation StartLoc,
ExplicitSpecifier ES, const DeclarationNameInfo , QualType T,
TypeSourceInfo *TInfo, SourceLocation EndLocation, CXXConstructorDecl
https://github.com/shafik requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11846,19 +11854,21 @@ static void DiagnoseFailedEnableIfAttr(Sema ,
OverloadCandidate *Cand) {
}
static void DiagnoseFailedExplicitSpec(Sema , OverloadCandidate *Cand) {
- ExplicitSpecifier ES = ExplicitSpecifier::getFromDecl(Cand->Function);
+ assert(Cand->Function &&
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/95474
>From 69b09ea5b0f0a1c5419c488ade29b6fedc6de773 Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Thu, 13 Jun 2024 14:20:50 -0700
Subject: [PATCH] [Clang] Implement P2280R4 Using unknown pointers and
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11846,19 +11854,21 @@ static void DiagnoseFailedEnableIfAttr(Sema ,
OverloadCandidate *Cand) {
}
static void DiagnoseFailedExplicitSpec(Sema , OverloadCandidate *Cand) {
- ExplicitSpecifier ES = ExplicitSpecifier::getFromDecl(Cand->Function);
+ assert(Cand->Function &&
501 - 600 of 625 matches
Mail list logo
