[PATCH] D38186: Add the new -Wnull-pointer-arithmetic warnings to the release notes

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks, it makes sense! Landed in r314387 https://reviews.llvm.org/D38186 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer.

sylvestre.ledru added a comment. For the record, this found 5 actual useless variables in Firefox code. Repository: rL LLVM https://reviews.llvm.org/D38678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D34329: [clang-diff] Initial implementation.

sylvestre.ledru added a comment. Herald added subscribers: llvm-commits, kadircet, mgrang. @arphaman @johannes Is that normal that clang-diff isn't installed by cmake? (like clang-format?) Repository: rL LLVM https://reviews.llvm.org/D34329 ___

[PATCH] D43630: [Driver] Fix search paths on x32

sylvestre.ledru added a comment. @jrtc27 are you going to take care of the tests? Thanks Repository: rC Clang https://reviews.llvm.org/D43630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Looks good, thanks. Repository: rC Clang https://reviews.llvm.org/D42593 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D30863: [clang-format] make docs/tools/{dump_format_style.py, dump_ast_matchers.py} flake8 compliant

sylvestre.ledru added a comment. @klimek ping? https://reviews.llvm.org/D30863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru added a comment. I added two more reviewers as we would like to get that in trunk before 6.0 branches. https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

sylvestre.ledru added a comment. It missed the 6.0 branching. Will you try to get it on this branch? Thanks Repository: rC Clang https://reviews.llvm.org/D41538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D41808: Rename clang link from clang-X.Y to clang-X

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: tstellar. Herald added a subscriber: mgorny. As we are only doing X.0.Z releases (not using the minor version), there is no need to keep -X.Y in the version. So, instead, I propose the following: Instead of having clang-7.0

[PATCH] D42624: [clang-tidy] Add a utility Matcher to match the next statement within a statement sequence

sylvestre.ledru added a comment. @aaron.ballman Hello, Do you think it is ready to land? Thanks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D30863: [clang-format] make docs/tools/{dump_format_style.py, dump_ast_matchers.py} flake8 compliant

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Looks like it doesn't interest anyone to use coding style on it. https://reviews.llvm.org/D30863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D41808: Rename clang link from clang-X.Y to clang-X

sylvestre.ledru updated this revision to Diff 139100. sylvestre.ledru marked an inline comment as done. sylvestre.ledru added a reviewer: dim. https://reviews.llvm.org/D41808 Files: CMakeLists.txt Index: CMakeLists.txt === --- CM

[PATCH] D12921: clang-format: Support 'template<>' (no space).

sylvestre.ledru added a comment. This was merged here: https://reviews.llvm.org/D23317 we can close this review https://reviews.llvm.org/D12921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D52173: Python bindings TypeError in reparse method

sylvestre.ledru added a comment. Herald added a subscriber: arphaman. I am sorry but I am not the right reviewer for that. Sorry! Repository: rC Clang https://reviews.llvm.org/D52173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D53410: Add missing PATH_MAX for GNU Hurd support

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: rnk. Herald added a subscriber: krytarowski. If you have a better place to put them, don't hesitate to let me know :) Patch by Svante Signell & myself Repository: rC Clang https://reviews.llvm.org/D53410 Files: lib/B

[PATCH] D53520: Update the example of BS_Stroustrup to match what is done by clang-format

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: krasimir. reported here https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911561 clang-format-7 -style="{BreakBeforeBraces: Stroustrup}" wasn't doing the same as the doc Repository: rC Clang https://reviews.llvm.org/D53

[PATCH] D53520: Update the example of BS_Stroustrup to match what is done by clang-format

sylvestre.ledru updated this revision to Diff 170723. sylvestre.ledru added a comment. Remove the desc update Repository: rC Clang https://reviews.llvm.org/D53520 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h

[PATCH] D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror

sylvestre.ledru added a comment. Please add some tests Repository: rC Clang https://reviews.llvm.org/D53807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: ddunbar. It has been introduced in 2011 for gcc compat: https://github.com/llvm-mirror/clang/commit/95a907fc0f2f717dca38a379c1d2353bfea06d4f it is probably time to remove it to remove the confusion. Repository: rC Clang

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

sylvestre.ledru added a comment. Did you test all url? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56946/new/ https://reviews.llvm.org/D56946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. @ddunbar is that ok with you? Thanks See https://bugs.llvm.org/show_bug.cgi?id=38836 https://bugs.launchpad.net/ubuntu/+source/llvm-defaults/+bug/1810860 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llv

[PATCH] D33440: clang-format: better handle statement macros

sylvestre.ledru added a comment. @Typz I think this should be part of the release notes for v8. This is changing the output on some code base and this is a new feature. By the way, an example in the doc would be great (including with the configuration) merci! Repository: rL LLVM CHANGES S

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llvm.org/D56803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D34329: [clang-diff] Initial implementation.

sylvestre.ledru added a comment. @johannes Someone asked for that in Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907269 Repository: rL LLVM https://reviews.llvm.org/D34329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

sylvestre.ledru added a comment. Can be done in a new commit but I think this should be mentioned in the clang release notes. Repository: rC Clang https://reviews.llvm.org/D52034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. @ddunbar ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llvm.org/D56803 ___ cfe-co

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: atanasyan. Herald added subscribers: llvm-commits, Sanitizers, jdoerfert, delcypher, arichardson, dberris, kubamracek, sdardis. Herald added projects: LLVM, Sanitizers. sylvestre.ledru added a comment. Not sure what I am doi

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru added a comment. Not sure what I am doing but it fixes the issue Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702 ___ cfe-commits mailing list cfe-

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru updated this revision to Diff 191999. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Herald added a subscriber: jdoerfert. Svn version Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru updated this revision to Diff 192001. sylvestre.ledru added a comment. Remove unrelated changes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 Files: include/clang/Format/Format.h include/clang/Toolin

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru updated this revision to Diff 192002. sylvestre.ledru added a comment. Try again Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 Files: include/clang/Format/Format.h include/clang/Tooling/Inclusions/In

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru added a comment. @atanasyan ok with you? Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru added a comment. I agree that 104 looks strange... but it worked. As I said, I am no expert in mips64el. :/ Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702 __

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru added a comment. Debian testing you can see the full log here: https://buildd.debian.org/status/fetch.php?pkg=llvm-toolchain-8&arch=mips64el&ver=1%3A8~%2Brc5-1&stamp=1552412165&raw=0 Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. @rnk btw, do you think it should be added to the clang release notes? Comment at: lib/Driver/Driver.cpp:1631 -// introduce a non-pedantically GCC compatible mode to Clang in which we -// provide sensible definitions for -dumpversion, __V

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru updated this revision to Diff 192159. sylvestre.ledru marked 3 inline comments as done. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Improve the test (thanks rnk) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru updated this revision to Diff 192160. sylvestre.ledru added a comment. Remove the empty directories Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llvm.org/D56803 Files: lib/Driver/Driver.cpp test/Driver/immediate-op

[PATCH] D60050: Spelling correction for docs for cppcoreguidelines-owning-memory

sylvestre.ledru added a comment. If you have permissions on the repo, no need for a review for such change! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60050/new/ https://reviews.llvm.org/D60050 ___ c

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added inline comments. Comment at: docs/ClangFormat.rst:171 + +:program:`clang-format` is integrated into CLion as an alternative code +formatter. It is disabled by default and can be turned on in Maybe add a link to CLion here? I didn't know what

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. works for me, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added a comment. Sure, i will do it for you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added a comment. You are welcome, thanks for your contribution! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: yaxunl, Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch have been applied to Debian packages for a few months without any regression. Patch by Rebecca N. Palmer Repository: rC

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D60380 Files: docs/CommandGuide/clang.rst Index: docs/CommandGuide/clang.rst ===

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru added a comment. I won't have time to write the test for that (and would not know where to start). I am just the messenger :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru added a comment. To be clear, this isn't about format stability and distributing but making sure that two same runs of clang produces the same output. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379 ___

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

sylvestre.ledru added a comment. I took the liberty to add that in the release notes of clang https://reviews.llvm.org/rG5f163c7e2e62 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 _

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru added a comment. @atanasyan, I tried with -DCMAKE_C_FLAGS="-mabi=32" -DCMAKE_CXX_FLAGS="-mabi=32" but it still fails with: cd /<>/build-llvm/projects/compiler-rt/lib/sanitizer_common && /usr/bin/g++-8 -DHAVE_RPC_XDR_H=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FO

[PATCH] D52151: Also manages clang-X as tool for scan-build

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: jroelofs. This will make scan-build-7 clang-7 -c foo.c &> /dev/null Repository: rC Clang https://reviews.llvm.org/D52151 Files: tools/scan-build/bin/scan-build Index: tools/scan-build/bin/scan-build

[PATCH] D52153: scan-build: Add support of the option --exclude like in scan-build-py

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: jroelofs. Herald added a subscriber: whisperity. sylvestre.ledru edited the summary of this revision. To exclude thirdparty code. To test: With /tmp/foo.c void test() { int x; x = 1; // warn } $ scan-

[PATCH] D52153: scan-build: Add support of the option --exclude like in scan-build-py

sylvestre.ledru updated this revision to Diff 165691. sylvestre.ledru added a comment. Fix the indentation Repository: rC Clang https://reviews.llvm.org/D52153 Files: tools/scan-build/bin/scan-build Index: tools/scan-build/bin/scan-build ==

[PATCH] D52151: Also manages clang-X as tool for scan-build

sylvestre.ledru added a comment. @kristina sorry, I missed your comment. I just followed what we are doing with gcc. Do you want me to update it? Repository: rC Clang https://reviews.llvm.org/D52151 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: ecbeckmann. Herald added a subscriber: mgorny. When building clang in stage2, when -DCMAKE_BUILD_TYPE=RelWithDebInfo is set, the developer can expect that the stage2 clang is built using the same mode. Especially as the perfo

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Do you have permissions on the repo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Any news on this? cc @djasper Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37531: Add an usage example of BreakBeforeBraces

sylvestre.ledru created this revision. https://reviews.llvm.org/D37531 Files: docs/ClangFormatStyleOptions.rst Index: docs/ClangFormatStyleOptions.rst === --- docs/ClangFormatStyleOptions.rst +++ docs/ClangFormatStyleOptions.rst

[PATCH] D37531: Add an usage example of BreakBeforeBraces

sylvestre.ledru updated this revision to Diff 114136. sylvestre.ledru added a comment. Herald added a subscriber: klimek. Thanks. I need more coffee. https://reviews.llvm.org/D37531 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h

[PATCH] D37558: Refresh the clang format options doc with the recent changes

sylvestre.ledru created this revision. Looks like we are out of sync between the doc and the code. https://reviews.llvm.org/D37558 Files: docs/ClangFormatStyleOptions.rst Index: docs/ClangFormatStyleOptions.rst === --- docs/Clan

[PATCH] D37795: SplitEmptyFunction should be true in the Mozilla coding style

sylvestre.ledru created this revision. Herald added a subscriber: klimek. As defined here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes See for the downstream bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1399359 https://reviews.llvm.org/D377

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang. gcov / gcda-based profiling crashes when shared libraries are unloaded Patch by Benoit Belley and tested by Marco Castelluccio for Firefox See https://bugs.llvm.org/show_bug.cgi?id=27224 & https://bugzilla.mozilla.or

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

sylvestre.ledru added a comment. For the record, Firefox was using this trick. This patch is breaking a ci build (clang trunk + warning as errors) More information here: https://bugzilla.mozilla.org/show_bug.cgi?id=1402362 Repository: rL LLVM https://reviews.llvm.org/D37042 __

[PATCH] D38186: Add the new -Wnull-pointer-arithmetic warnings to the release notes

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang. https://reviews.llvm.org/D38186 Files: ReleaseNotes.rst Index: ReleaseNotes.rst === --- ReleaseNotes.rst +++ ReleaseNotes.rst @@ -78,6 +78,12 @@ wh

[PATCH] D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON

sylvestre.ledru added a comment. For the record, this is the same approach as in https://reviews.llvm.org/rL240104 https://reviews.llvm.org/D38228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON

sylvestre.ledru created this revision. Herald added subscribers: ilya-biryukov, mgorny. https://reviews.llvm.org/D38228 Files: clangd/tool/CMakeLists.txt Index: clangd/tool/CMakeLists.txt === --- clangd/tool/CMakeLists.txt +++ cl

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: rnk. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. Just like in https://reviews.llvm.org/D56803 for -dumpversion Repository: rC Clang https://reviews.llvm.org/D63048 Files: lib/Frontend/Init

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. yeah thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379 ___ cfe-commits mailing list cfe-commits@

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. indeed, closing Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702 ___ cfe-commits mailing

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203693. sylvestre.ledru added a comment. update of the release notes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreproce

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. In D63048#1535222 , @xbolva00 wrote: > Btw, what about this code > > // Currently claim to be compatible with GCC 4.2.1-5621, but only if we're > // not compiling for MSVC compatibility > Builder.defineMacro("__GNUC_M

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203695. sylvestre.ledru added a comment. Fix the typo (thanks hubert) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreproc

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203700. sylvestre.ledru added a comment. fix rst syntax Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreprocessor.cpp te

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru marked an inline comment as done. sylvestre.ledru added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:610 + Builder.defineMacro("__VERSION__", "\"" CLANG_VERSION_STRING + " Compatible " + Twine(getClangFullCPPVersion()) + +

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. I will wait for @dexonsmith 's opinion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. In D64062#1581290 , @rnk wrote: > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. As you wish. clang --version seems an alternative and dumpversion never //worked// for clang. so, I don't expect soft

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 209473. sylvestre.ledru added a comment. Keep -dumpversion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/ClangCommandLineReference.rst docs/LanguageExtension

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 209474. sylvestre.ledru added a comment. Actually remove it Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/LanguageExtensions.rst docs/ReleaseNotes.rst lib/

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru added a comment. @rnk Should be good this time :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru added a comment. Thanks @rnk :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D64687: [clang] Revert "Remove __VERSION__"

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. I went ahead and committed your revert in r365992. Thanks! Next time, please remove the clang/ from your patch arc could not apply it: Committing 'D64687: [clang] Revert "R

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru reopened this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. @rnk looks like it is too risky to remove it. What about changing it from #define __VERSION__ "4.2.1 Compatible Clang 7.0.1 (tags/RELEASE_701/final)" to #define __VERSIO

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 209715. sylvestre.ledru added a comment. Implement the change (just update __VERSION__) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/LanguageExtensions.rst

[PATCH] D64278: Rename libclang_shared to libclang-cpp

sylvestre.ledru added a comment. @beanz By the way, maybe we should add this in the 9 release notes? Thanks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mail

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

sylvestre.ledru added a comment. You should also probably add a note in the release notes (maybe for the others changes too) thanks for the work btw! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

sylvestre.ledru added a comment. FYI, I had similar patches for Linux/Debian packaging. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___ cfe-commits mailing list cfe

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. @dexonsmith ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. @rnk how do you feel about removing both? I can take care of that if you want Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. For now, it isn't part of the debian packaging. https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/snapshot/debian/rules#L563 it is removed as packaging phase as I have been told it isn't ready. Anyway, the lib should not keep this name. By definition, on

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: rnk, dexonsmith. Herald added subscribers: cfe-commits, arphaman, fedor.sergeev, aheejin, dschuff. Herald added a project: clang. It has been introduced in 2011 for gcc compat: https://github.com/llvm-mirror/clang/commit/95a9

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. Actually, I don't think removing -dumpversion is a great idea. it will remove the capability of clang to be a dropped in replacement. I see a lot of occurrences: https://github.com/search?q=%22-dumpversion%22&type=Code https://codesearch.debian.net/search?q=%22-d

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. Actually, not sure it is a good idea to remove them: https://reviews.llvm.org/D64062#1566460 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. This isn't firefox per say but thirdparty apps. If you feel confident, sure, we can land that and see what happens :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062

[PATCH] D64278: Rename libclang_shared to libclang-cpp

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: beanz, tstellar. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. sylvestre.ledru edited the summary of this revision. Fix bug 42475 Repository: rC Clang https://reviews.llvm.org/D64278 Files

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. @rnk is it good for you ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D64278: Rename libclang_shared to libclang-cpp

sylvestre.ledru added a comment. @beanz works for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 208619. sylvestre.ledru added a comment. Update of the release note. thanks to @rnk for the suggestion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/ClangComma

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Sure, done in r365445 thanks for your work! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. @VelocityRa could you please add it to the release notes? https://github.com/llvm-mirror/clang/blob/master/docs/ReleaseNotes.rst I can commit the change if you need Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://r

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. @rnk Works for you? I would like to land that before the 9 branch. Thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mail

[PATCH] D64278: Rename libclang_shared to libclang-cpp

sylvestre.ledru added a comment. I would like to land that before the 9 branch. @tstellar do you sign off on this change? Thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 _

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. @beanz @tstellar I am wondering what to do wrt apt.llvm.org should it be part of libclang or create a libclang++ package what do you think? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909

  1   2   3   4   5   >