[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

sylvestre.ledru added a comment. Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81272/new/ https://reviews.llvm.org/D81272

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

sylvestre.ledru added a comment. Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

sylvestre.ledru added a comment. @MarcusJohnson91 I know it is confusing but we don't use the Mozilla coding style. We are using the Google style. You can use the code snippet that I provided here: https://bugs.llvm.org/show_bug.cgi?id=47589 it is easy to reproduce even without argument or conf

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

sylvestre.ledru added a comment. I guess it isn't possible to write tests for this? Does it have an impact on cross compile ? Also, please fix the clang-format warning! Comment at: clang/lib/Driver/Distro.cpp:227 + if (!HostTriple.isOSLinux() && onRealFS) +Type = Distro:

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru added a comment. @serge-sans-paille ok to push this? :) merci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing list cfe-com

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 313271. sylvestre.ledru added a comment. Error only on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d59c8fdb955: -fstack-clash-protection: Return an actual error when used on unsupported OS (authored by sylvestre.ledru). Repository: rG LLVM Gith

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru added a comment. Thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

sylvestre.ledru added a comment. FWIW, I am doing this change already in Debian & Ubuntu ( https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/10/debian/clang-tidy-X.Y.links.in#L2 ) By the way, while you are working on it, why not removing the python extension when installing? We don'

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

sylvestre.ledru requested changes to this revision. sylvestre.ledru added a comment. This revision now requires changes to proceed. Thanks. Could you please also update the release notes for 12? And if you are motivated, this script should be documented (or at least mentioned in the doc a bit mo

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Sounds great. You might want to ask feedback to other reviews too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90972/new/ ht

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

sylvestre.ledru added a comment. I am not 100% that it is thanks to this patch but reformatting Firefox code with clang-format 11 significantly improves the readability of the usage of ternary operators. See: https://phabricator.services.mozilla.com/D90795 Thanks for the change! Repository:

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

sylvestre.ledru added a comment. @JakeMerdichAMD @MyDeveloperDay Do you know if the regression has been fixed? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

sylvestre.ledru added a comment. @JakeMerdichAMD as the regression caused by this change is way more significant than the initial bug, I am planning to revert this patch in the next few days (both in master and 11). Please let me know if you have any objection. Repository: rG LLVM Github Mon

[PATCH] D89270: [clang-tidy] Add an example for misc-unused-alias-decls

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: gribozavr. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. sylvestre.ledru requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89270 Files: c

[PATCH] D89270: [clang-tidy] Add an example for misc-unused-alias-decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002968a32046: [clang-tidy] Add an example for misc-unused-alias-decls (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. sylvestre.ledru requested review of this revision. This reverts commit b2eb439317576ce718193763c12bff9fccdfc166 . Cau

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:12255 Alignment); - - // Bug 25167 lebedev.ri wrote: > Passing-by comment: you probably want to keep the tests though? Sure, i will keep that and add a test

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru updated this revision to Diff 298639. sylvestre.ledru added a comment. Add the test which was failing + add the previous tests (but disabled) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/new/ https://reviews.llvm.org/D89464

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. sylvestre.ledru requested review of this revision. $ clang-12: error: -fstack-clash-protection is not supported on Windows or Mac OS X

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308160. sylvestre.ledru added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308290. sylvestre.ledru added a comment. Fix the error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308402. sylvestre.ledru added a comment. Herald added subscribers: llvm-commits, pengfei. Herald added a project: LLVM. extend the test (thanks serge) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

sylvestre.ledru added a comment. Thanks for doing that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9e789447f14: Revert "[clang-format] Fix AlignConsecutive on PP blocks" (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/ne

[PATCH] D89859: Remove .svn from exclude list as we moved to git

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny. Herald added a reviewer: bollu. Herald added projects: clang, LLDB, LLVM. sylvestre.ledru requested review of this revision. Herald

[PATCH] D89859: Remove .svn from exclude list as we moved to git

sylvestre.ledru added a comment. ed if you want to approve it ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89859/new/ https://reviews.llvm.org/D89859 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D89859: Remove .svn from exclude list as we moved to git

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0784e17f1b4a: Remove .svn from exclude list as we moved to git (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89481: [scan-build] Fix clang++ pathname again

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Looks good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89481/new/ https://reviews.llvm.org/D89481 ___ cfe-commit

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Much better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88084/new/ https://reviews.llvm.org/D88084

[PATCH] D78807: Fix gendered documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG43e451f9f316: Fix gendered documentation (authored by pedro.gonnet, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru closed this revision. sylvestre.ledru added a comment. it landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109023/new/ https://reviews.llvm.org/D109023 ___ cfe-commits mailing list cf

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

sylvestre.ledru updated this revision to Diff 373804. sylvestre.ledru added a comment. Herald added a project: clang. Rebase of the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53014/new/ https://reviews.llvm.org/D53014 Files: clang/CMake

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeccd477ce312: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables (authored by sylvestre.ledru). Repository: rG LLVM Githu

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru added a comment. it landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109642/new/ https://reviews.llvm.org/D109642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. https://github.com/llvm/llvm-project/blob/release/13.x/clang/docs/ReleaseNotes.rst#new-compiler-flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109642/new/ https://review

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. Building with this patch Debian packages is failing with: "/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0/build-llvm/tools/clang/stage2-bins/bin/clang++" -DHAVE___CXA_THREAD_ATEXIT_IMPL -DLI

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. > How was the toolchain in > /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0 > > /build-llvm > built? Only using PROJECTS

[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110521/new/ https://reviews.llvm.org/D110521 __

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. @phosek It was probably my fault (mix of different in-tree / out of tree builds) Quick question, why the path to `__config_site` contains this triple `x86_64-pc-linux-gnu` (in `/usr/lib/llvm-14/include/x86_64-pc-linux-gnu/c++/v1/__config_site`) when it is usually:

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

sylvestre.ledru added a comment. just to make sure I understand, it will also update the install or "just" the dumpmachine option ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

sylvestre.ledru added a comment. Herald added a subscriber: ormris. I think this change broke apt.llvm.org > [100%] Linking CXX shared library ../../lib/libLLVM-13.so > cd "/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307/build-llvm/tools/llvm-shlib" && /usr/bin/cmake -E cmak

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

sylvestre.ledru added a comment. > I think this change broke apt.llvm.org Confirmed: reverting this change fixed the link issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94333/new/ https://reviews.llvm.org/D94333 _

[PATCH] D107887: scan-build-py: Force the opening in utf-8

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: phosek, isthismyaccount, aabbaabb. Herald added a subscriber: whisperity. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It fails on ubuntu bionic othe

[PATCH] D107887: scan-build-py: Force the opening in utf-8

sylvestre.ledru updated this revision to Diff 366937. sylvestre.ledru added a comment. Replace " => ' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107887/new/ https://reviews.llvm.org/D107887 Files: clang/tools/scan-build-py/lib/libscanbuild/re

[PATCH] D107887: scan-build-py: Force the opening in utf-8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70b06fe8a186: scan-build-py: Force the opening in utf-8 (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D112519: parallel-libs: remove some artifacts

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: dblaikie, jlebar. sylvestre.ledru requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. As mentioned in https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b#commitcomment-60741407 This change is breaking build of compiler-rt on Ubuntu bionic and others on amd64: "/build/llvm-toolchain-snapshot-14~++2029100719

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Full log: https://llvm-jenkins.debian.net/view/Debian%20sid/job/llvm-toolchain-binaries/architecture=amd64,distribution=unstable,label=amd64/104/consoleFull CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 _

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Actually, it breaks on all Debian. Could you please revert it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

sylvestre.ledru added a comment. Maybe add it to the release notes too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 ___ cfe-commits mailing list cfe-commits

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. I am not sure why you are pinging this review often?! Maybe chat with people who gave you feedback before directly?! Myself I wasted so much time because of D107799 that I am very reluctant to enable LLVM_ENABLE_PER_TARGET_RUN

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks for carrying about the doc! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. np, let me land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D136424: Update links to googletest documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb814d85e5b9d: Update links to googletest documentation (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://revi

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. pushed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. oh, crappy, i forgot to update the author of the patch :( really sorry about that... :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 __

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. yeah, happy to do that if the author wants :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. ouf, thanks :) I am sure the doc has plenty of other issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits m

[PATCH] D131565: [cmake] Fix tablegen exports

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f555a52e033: [cmake] Fix tablegen exports (authored by nikic, committed by sylvestre.ledru). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added subscribers: bmahjour, kadircet, arphaman. Herald added a project: All. sylvestre.ledru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald a

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru updated this revision to Diff 486546. sylvestre.ledru added a comment. add the missing {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/ https://reviews.llvm.org/D141047 Files: clang/cmake/modules/AddGRPC.cmake cmake

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3081dc6fe8: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too (authored by sylvestre.ledru). Repository: rG LLVM Github

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

sylvestre.ledru added a comment. Maybe add it to the release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D125860: [clang] Only use major version in resource dir

sylvestre.ledru added a comment. i hope not too many people rely on it. LGTM but please add it to the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 ___ cfe-commits mailing list cfe-co

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru added a comment. thanks. reverting is fine :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/ https://reviews.llvm.org/D141047 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126672/new/ https://reviews.llvm.org/D126672 _

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. With this patch, it started to fail with: It would be nice to have a better error message suggesting what to do -- Performing Test HAVE_DECL_STRERROR_S -- Performing Test HAVE_DECL_STRERROR_S - Failed CMake Error at /build/source/flang-rt/unittests/CMakeList

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. Thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. In D154869#4652703 , @DanielCChen wrote: > Sorry about the breakage This is why we have CI ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.ll

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

sylvestre.ledru added a comment. I reverted the patch for causing https://github.com/llvm/llvm-project/issues/63974 https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D153989: [compiler-rt] Move crt into builtins

sylvestre.ledru added a comment. Seems that it caused: https://github.com/llvm/llvm-project/issues/63799 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 ___ cfe

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

sylvestre.ledru added a comment. @baloghadamsoftware @Szelethus it would be great to have the name of the checkers in the error message The error is "error: checker cannot be enabled with analyzer option 'aggressive-binary-operation-simplification' == false" and I had to look at this patch to un

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sylvestre.ledru added subscribers: hans, sylvestre.ledru. sylvestre.ledru added a comment. @MyDeveloperDay @hans what about adding this to the release notes? I was trying clang-format 10 on Firefox code base and I noticed this change which isn't documented in https://prereleases.llvm.org/10.0.0/r

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

sylvestre.ledru added subscribers: hans, sylvestre.ledru. sylvestre.ledru added a comment. @krasimir @MyDeveloperDay @hans Looks like it is a regression from https://reviews.llvm.org/D72911 and the fix isn't in 10.0rc2. Should we take it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

sylvestre.ledru added a comment. Did you see some significant perf improvements for Chromium? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

sylvestre.ledru added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. In D68720#1733839 , @serge-sans-paille wrote: > @sylvestre.ledru did the testing and benchmarking on firefox (see > https://bugzilla.mozilla.org/show_bug.cgi?id=1588710#c12), everything seems > ok, let's move forward?

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

sylvestre.ledru added a comment. fyi, +x permissions was added to clang/lib/Format/Format.cpp I reverted the change in a4a7c1259e8a8f2d11fa29686a6c2834948c1358 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

sylvestre.ledru added a comment. Would be nice to add this to the release notes too ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://reviews.llvm.org/D6920 ___ cfe-commits mailing lis

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sylvestre.ledru added a comment. @kristina can we land this patch ? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D71199: [clang-tidy] New check readability-prefer-initialization-list

sylvestre.ledru added a comment. > affects positively its performance. Interesting! Do you have some numbers you could share? thanks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 ___

[PATCH] D71745: clang-tidy doc: Move from a long list of checkers to tables

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Done here: https://reviews.llvm.org/D36051 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71745/new/ https://reviews.llvm.org/D71745 ___

[PATCH] D71745: clang-tidy doc: Move from a long list of checkers to tables

sylvestre.ledru created this revision. Herald added subscribers: cfe-commits, whisperity. Herald added a reviewer: jdoerfert. Herald added a project: clang. sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Done here: https://reviews.llvm.org/D36051 Currently, the list is

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234841. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Herald added a reviewer: jdoerfert. Herald added a project: clang. Move to the table idea... Two years after :) Repository: rG LLVM Github Monorepo CHANG

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. F0342: Screenshot_2019-12-20 clang-tidy - Clang-Tidy Checks — Extra Clang Tools 10 documentation.png here is the result Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/n

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. In D36051#1792684 , @Eugene.Zelenko wrote: > May be also split table by checks groups? Maybe? I would like to see this patch land first and iterate then on it. :) This patch is already a significant improvement over the

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234890. sylvestre.ledru added a comment. Remove artifacts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files: clang-tools-extra/docs/clang-tidy/checks/list

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. > But please, let's make that table heading nice. `Severity` is capitalised, > `name` is not, "has an autofix" sounds weird... Maybe "offers fixes" instead? Good point, thanks :) Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234911. sylvestre.ledru added a comment. Add a comment about codechecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files: clang-tools-extra/docs/clang-t

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. In D36051#1792909 , @whisperity wrote: > I am a little bit conflicted about the //Severity// column. While I know our > people put a great deal of effort into keeping this classification sane, what > was put into CodeChec

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234918. sylvestre.ledru added a comment. Fix a rst warning + update the clang link "Clang Static Analyzer" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234972. sylvestre.ledru added a comment. alias => aliases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files: clang-tools-extra/docs/clang-tidy/checks/list

[PATCH] D36051: Move from a long list of checkers to tables

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd2c9c9157b05: Move from a long list of checkers to tables (authored by sylvestre.ledru). Repository: rG LLVM Github Mon

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

sylvestre.ledru added a comment. Is this failure expected? https://bugs.llvm.org/show_bug.cgi?id=44370 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 ___ cfe-commits mailing l

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:75 `bugprone-sizeof-expression `_, , "high" + `bugprone-spuriously-wake-up-functions `_, , "" `bugprone-string-constructor `_, "Yes", "high" Could you

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:198 cppcoreguidelines-avoid-magic-numbers (redirects to readability-magic-numbers) + cppcoreguidelines-avoid-non-const-global-variables cppcoreguidelines-c-copy-assign

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sylvestre.ledru added a comment. @hans done here: https://github.com/llvm/llvm-project/commit/50eedc134a219ef6d2345e4efc5471a2e3824223 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.llvm.org/D69573

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sylvestre.ledru updated this revision to Diff 249595. sylvestre.ledru added a co

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru updated this revision to Diff 249595. sylvestre.ledru added a comment. Add a link to the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75985/new/ https://reviews.llvm.org/D75985 Files: clang-tools-extra/docs/clangd/SimpleExam

<    1   2   3   4   5   >