tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153468/new/
https://reviews.llvm.org/D153468
tejohnson added inline comments.
Comment at: clang/test/CodeGen/verify-each.c:5
+// RUN: %clang_cc1 -O2 -o /dev/null -triple x86_64-unknown-linux-gnu
-emit-llvm-bc %s -fdebug-pass-manager 2>&1 | FileCheck %s --check-prefix=NO
+// NO-NOT: Verifying
+
Huh, really
tejohnson added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1065
+ if (CodeGenOpts.FatLTO) {
+// Set EnableSplitLTOUnit, since the config above won't
+if (!TheModule->getModuleFlag("EnableSplitLTOUnit"))
Can you expand the comment a
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/test/Driver/fatlto.c:1
+
Is this empty file meant to contain something?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152741/new/
https://reviews.llvm.org/D152741
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG176889868024: [MemProf] Control availability of hot/cold
operator new from LTO link (authored by tejohnson).
Changed prior to commit:
tejohnson created this revision.
tejohnson added a reviewer: aeubanks.
Herald added subscribers: ormris, steven_wu, hiraditya, emaste.
Herald added a project: All.
tejohnson requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added projects: clang, LLVM.
I
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa40b0c3e77a2: [WPD] Update llvm.public.type.test after
importing functions (authored by tejohnson).
Repository:
rG LLVM Github Monorepo
CHANGES
tejohnson updated this revision to Diff 521340.
tejohnson marked an inline comment as done.
tejohnson added a comment.
Address comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150326/new/
https://reviews.llvm.org/D150326
Files:
tejohnson marked an inline comment as done.
tejohnson added inline comments.
Comment at: llvm/test/ThinLTO/X86/public-type-test.ll:31
; HIDDEN-NOT: call {{.*}}@llvm.public.type.test
; HIDDEN: call {{.*}}@llvm.type.test
aeubanks wrote:
> should this be
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e280c47588b: [MemProf] Update hot/cold information after
importing (authored by tejohnson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
tejohnson created this revision.
tejohnson added a reviewer: davidxl.
Herald added subscribers: ormris, steven_wu, hiraditya.
Herald added a project: All.
tejohnson requested review of this revision.
Herald added projects: clang, LLVM.
Herald added a subscriber: cfe-commits.
The support added by
601 - 612 of 612 matches
Mail list logo