[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 408295. sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

sstwcw abandoned this revision. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16854 + // that things still get aligned. + Alignment.ColumnLimit = 20; EXPECT_EQ("inta(int x,\n" HazardyKnusperkeks wrote: > I disagree. Li

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// HazardyKnusperkeks wrote: > sstwcw wrote: > > HazardyKnusperkeks wrote: > > > sstwcw wrote: > > > > HazardyKnusperkeks wrote: > > > > >

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16872 + // that things still get aligned. + Alignment.ColumnLimit = 20; EXPECT_EQ("inta(int x,\n" sstwcw wrote: > curdeius wrote: >

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw added a comment. @curdeius That would be great. Comment at: clang/include/clang/Format/Format.h:163 + /// \endcode + bool AlignCompoundAssignments; + curdeius wrote: > HazardyKnusperkeks wrote: > > MyDeveloperDay wrote: > > > This option is not indepen

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGc261f78d05de: [clang-format] Refactor determineStarAmpUsage NFC (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https://revi

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG43c146c96d8e: [clang-format] Take out common code for parsing blocks NFC (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D121757?vs=420653&id=426277#toc Repository: rG LLVM Gi

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current way of counting whitespace would co

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw added a comment. This revision depends on D124748 , but somehow it doesn't show up when I open the parent revision dialog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw updated this revision to Diff 443605. sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128712/new/ https://reviews.llvm.org/D128712 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnot

[PATCH] D128713: [clang-format] Handle Verilog user-defined primitives

sstwcw updated this revision to Diff 443607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128713/new/ https://reviews.llvm.org/D128713 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/UnwrappedLinePar

[PATCH] D128714: [clang-format] Handle Verilog case statements

sstwcw updated this revision to Diff 443608. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128714/new/ https://reviews.llvm.org/D128714 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/Format.cpp clang/lib/Format/FormatToken.h

[PATCH] D128709: [clang-format] Handle Verilog attributes

sstwcw updated this revision to Diff 443611. sstwcw added a comment. - don't check peeked token for null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128709/new/ https://reviews.llvm.org/D128709 Files: clang/lib/Format/TokenAnnotator.cpp clan

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw updated this revision to Diff 443791. sstwcw added a comment. - take out check - use boolean as boolean Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128712/new/ https://reviews.llvm.org/D128712 Files: clang/lib/Format/FormatToken.h cla

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4072 +Keywords.kw_randsequence)) { +AddLevels += Style.IndentCaseLabels; +nextToken(); HazardyKnusp

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

sstwcw added a comment. Are there any problems with this revision? The ones that depend on it are approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126845/new/ https://reviews.llvm.org/D126845 __

[PATCH] D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2732 +parseBlock(/*MustBeDeclaration=*/true, AddLevels, /*MunchSemi=*/true, + /*KeepBracces=*/true, ManageWhitesmithsBraces); Repository: rG LLVM Github Mo

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw updated this revision to Diff 429530. sstwcw added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124748/new/ https://reviews.llvm.org/D124748 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Fo

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw marked 8 inline comments as done. sstwcw added a comment. This patch is not NFC. But there would not be change in behavior if the input is valid C as far as I know. input: #define LIST \ `ENTRY \ `ENTRY output before, note extra line: #define LIST

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 429532. sstwcw added a comment. - add tests and remove __LINE__ and __FILE__ special cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/D124749 Files: clang/lib/Format/Fo

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1105 + static const llvm::Regex VerilogToken( + "^(\'|``?|((\r?\n|\r)|[^[:space:]])*)"); + HazardyKnusperkeks wrote: > Consider a raw string, for a better reading. You m

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw added a comment. The two parents of this revision change the same file, so the build bot says patch does not apply. Does that mean I have to submit the parent patches with less context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 470015. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittest

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5196-5206 + std::function FormatBadBranches = + [&](std::string Prefix, unsigned Lines) { +const std::string Directives[] = {"", "#if X\n", "#els

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 470016. sstwcw added a comment. - Merge - use ArrayRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Fo

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 470623. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittest

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5196-5206 + std::function FormatBadBranches = + [&](std::string Prefix, unsigned Lines) { +const std::string Directives[] = {"", "#if X\n", "#els

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5be1550f140: [clang-format] Don't crash on malformed preprocessor conditions (authored by sstwcw). Changed prior to commit: https://reviews.llvm.

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw added a comment. This patch fixes the regression caused by 2183fe2 while introducing a new regression. But in my opinion the new regression is less of a problem than the old one. Therefore I think it is okay. Take t

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw accepted this revision. sstwcw added a comment. This revision is now accepted and ready to land. Thanks for fixing the problem I caused. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw added a comment. It just occurred to me that klimek is the one who added all this stuff. Why didn't you include him as a reviewer? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe-com

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2183fe2160fb: [clang-format] Parse the else part of `#if 0` (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D133647?vs=459305&id=460729#toc Repository: rG LLVM Github Monorepo

[PATCH] D133954: [clang-format] Fix template arguments in macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5964223d99a: [clang-format] Fix template arguments in macros (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D133954?vs=460446&id=460730#toc Repository: rG LLVM Github Monore

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

sstwcw added a comment. Did you leave out `clang/include/clang/Format` and `clang/unittests/Format`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329 ___ cfe-com

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, sammccall. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw added a comment. See https://github.com/llvm/llvm-project/issues/58188#issuecomment-1270355888. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 ___ cfe-c

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw updated this revision to Diff 465772. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 Files: clang/lib/Format/UnwrappedLineParser.cpp Index: clang/lib/Format/UnwrappedLineParser.cpp =

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw added a comment. The problem that remains is this, as I explained in the issue. The second branch of the second block is not indented. #if 1 { #endif #if X x; #else x; #endif } I didn't add a test case because I was not expecting this patch to be committed as there

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, sammccall. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 2183fe2

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a project: clang-format. sstwcw added a comment. Should I add a test with comments to be aligned like in the bug report? I was not sure because I didn't find an existing test for alignment of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw abandoned this revision. sstwcw added a comment. I am closing it now there is D135740 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 ___

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previousl

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467829. sstwcw added a comment. - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/Unwrap

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a comment. In D135740#3858782 , @MyDeveloperDay wrote: > Did you test this with nested #if #endif? No. I added the tests now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ http

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 467832. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittest

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467833. sstwcw added a comment. - correct spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw abandoned this revision. sstwcw added a comment. It does some more than D137052 . But the addition stuff is not very important and no one can review it. So I am closing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

sstwcw added a comment. Here is one problem: clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1, IndentWidth: 4, IndentCaseLabels: true}' actual: #define X \ switch (x) {

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

sstwcw updated this revision to Diff 494303. sstwcw added a comment. - add parentheses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142891/new/ https://reviews.llvm.org/D142891 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/White

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:839-846 return Style.AlignConsecutiveAssignments.AlignCompound ? C.Tok->getPrecedence() == prec::Assignment - :

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

sstwcw updated this revision to Diff 494839. sstwcw added a comment. - add parentheses - rename field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142891/new/ https://reviews.llvm.org/D142891 Files: clang/lib/Format/TokenAnnotator.cpp clang/l

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcad708b9a1ec: [clang-format] Recognize Verilog non-blocking assignment (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D126934: [clang-format] NFC Sort names of format token types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f69f7ea9af4: [clang-format] NFC Sort names of format token types (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

sstwcw updated this revision to Diff 439981. sstwcw added a comment. - address comments - add token annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126845/new/ https://reviews.llvm.org/D126845 Files: clang/lib/Format/FormatToken.h

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

This revision was automatically updated to reflect the committed changes. Closed by commit rG370bee480139: [clang-format] Fix whitespace counting stuff (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124748/new/ https://reviews.l

[PATCH] D123450: [clang-format] Parse Verilog if statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed2e68c9ae5: [clang-format] Parse Verilog if statements (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D123450?vs=435777

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e32ff106e74: [clang-format] Handle Verilog preprocessor directives (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://

[PATCH] D128607: [clang-format] NFC Fix uninitialized memory problem

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The setLength function checks for the token kin

[PATCH] D128607: [clang-format] NFC Fix uninitialized memory problem

sstwcw added a comment. This problem was found by the build bot after I pushed the buggy code. https://lab.llvm.org/buildbot#builders/5/builds/25268 It looks like uninitialized memory was not checked when I ran `ninja check-clang-format` locally. Am I missing some configuration? Repository:

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:179 + verifyFormat("`x = (`x1 + `x2 + x);"); + // Lines starting with a preprocessor directive should not be indented. + std::string Directives[] = {

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 433614. sstwcw added a comment. - use raw string for regex - use default style in test - remove parentheses - use seek now that skipOver no longer exists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw updated this revision to Diff 433626. sstwcw added a comment. - add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124748/new/ https://reviews.llvm.org/D124748 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatT

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1889 TokenCount = Line->Tokens.size(); - if (TokenCount == 1 || - (TokenCount == 2 && Line->Tokens.front().Tok->is(tok::comment))) { --

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 433702. sstwcw added a comment. - add comment and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/D124749 Files: clang/lib/Format/FormatToken.h clang/lib/Format/For

[PATCH] D126934: [clang-format] NFC Sort names of format token types

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Suggested by HazardyKnusperkeks in D126845

[PATCH] D126934: [clang-format] NFC Sort names of format token types

sstwcw updated this revision to Diff 435760. sstwcw added a comment. use case-insensitive sorting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126934/new/ https://reviews.llvm.org/D126934 Files: clang/lib/Format/FormatToken.h Index: clang/lib

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435771. sstwcw marked 2 inline comments as done. sstwcw added a comment. add MacroBlockBegin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangF

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435773. sstwcw added a comment. use isVerilog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rst clang/include/clang/Format/Format.h

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435774. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/l

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435777. sstwcw added a comment. - add brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rst clang/include/clang/Format/Format.h

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 435788. sstwcw added a comment. - add `kw_` prefix to symbols treated as keywords - use lambda instead of breaking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/D124749 File

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:1142 +VerilogExtraKeywords = +std::unordered_set({kw_always, + kw_always_comb, Now that I ad

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked an inline comment as done. sstwcw added a comment. Are there any more problems? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-commits ma

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 542916. sstwcw added a comment. - Add comment explaining the replacements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.r

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. @owenpan What do you think about this revision especially the replacement part? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 547619. sstwcw added a comment. Add support for breaking strings with + in C# and others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangForma

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In D154093#4544496 , @owenpan wrote: > In D154093#4542339 , @sstwcw wrote: > >> @owenpan What do you think about this revision especially the replacement >> part? > > See D154093#4544495 <

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. @MyDeveloperDay Can you take a look at the last test in FormatTestCSharp.Attributes? I tried to enable breaking string literals by default. The long string got broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 547767. sstwcw marked 2 inline comments as done. sstwcw added a comment. - Add tests for code in JavaScript template strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D15

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:221 TEST_F(FormatTestCSharp, CSharpFatArrows) { - verifyFormat("Task serverTask = Task.Run(async() => {"); + verifyIncompleteFormat("Task serverTask = Task.Run(async() => {"); verifyFormat

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 547770. sstwcw added a comment. - Add tests for code in JavaScript template strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyl

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In D154093#4644727 , @alexfh wrote: > This patch makes clang-format produce invalid JS/TS code > > In D154093#4644512 , @eaeltsin > wrote: > >> This introduces an invalid TS transformation

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw added a comment. See the updated summary. There does not seem to be an issue on GitHub when I searched. I simply noticed it when reading the code in order to understand how strings got broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:223 - if (SpaceOffset != 0) -return BreakableToken::Split(SpaceOffset + 1, 0); + if (NewLine != 0) +return BreakableToken::Split(NewLine, 0); ---

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 536531. sstwcw added a comment. - Add tests for newline outside of column limit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToke

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 536555. sstwcw added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clan

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked 2 inline comments as done. sstwcw added a comment. In D154093#4466246 , @HazardyKnusperkeks wrote: > I'd really prefer you put what you need to modify `mutable` instead of > removing the `const` from everything else. But that's just my opi

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:1914 ///const char* x = - /// "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; + ///"veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; /// \endcode -

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 537190. sstwcw added a comment. - Add tests for other escape sequences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToken.cpp c

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw marked an inline comment as done. sstwcw added a comment. In D154091#4470158 , @MyDeveloperDay wrote: > What would happen in a \r\n example If the entire `\r\n` part fits on the first line, the break is after `\r\n`. If only the part up to `\r`

[PATCH] D154467: [clang-format] Add Verilog suffixes to the scripts

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw added a comment. It won't break the string inside an escape sequence. But escape sequences like `\040`, `\x20`, and `\u0020` don't get recognized as whitespace. Comment at: clang/lib/Format/BreakableToken.cpp:199 +if (EscapeSequence && Advance == 2) { + swit

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 537701. sstwcw added a comment. - Add tests for non-whitespace sequences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. If it is expected that the method does not modify the field, and the expectation is not fulfilled, I prefer to make it clear rather than to pretend that the method works as expected. Can you help me come up with an alternative? Braces need to be added around the string

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 537975. sstwcw marked an inline comment as done. sstwcw added a comment. - Drop the line in the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

sstwcw added a comment. Did you forget about GNU statement expressions? if (({ foo(); bar(); })) { } Comment at: clang/docs/ReleaseNotes.rst:804 - Add ``KeepEmptyLinesAtEOF`` to keep empty lines at end of file. +- Add ``RemoveParenthese`` to remove r

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540611. sstwcw edited the summary of this revision. sstwcw added a comment. - Add back the const qualifiers for methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093

<    1   2   3   >