@@ -107,6 +107,24 @@
///The 2nd source tile. Max size is 1024 Bytes.
#define _tile_cmmrlfp16ps(dst, a, b) __builtin_ia32_tcmmrlfp16ps(dst, a, b)
+/// Perform matrix multiplication of two tiles containing complex elements and
AaronBallman wrote:
Is this
@@ -533,6 +533,8 @@ __rdtscp(unsigned int *__A) {
/// \see __rdpmc
#define _rdpmc(A) __rdpmc(A)
+;
AaronBallman wrote:
This is quite surprising; I'm guessing this is so that the previous comment
does not associate with the function declared below, but this
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Because doxygen supports documenting macros
(https://www.doxygen.nl/manual/commands.html#cmddef), I am worried how often
this will cause us to associate comments incorrectly on the declaration.
I wonder if we should be a bit smarter and check for
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
@llvm/pr-subscribers-clang
Author: hdoc (hdoc)
Changes
### Background
It's surprisingly common for C++ code in the wild to conditionally show/hide
declarations to Doxygen through the use of preprocessor directives. One
especially common
hdoc wrote:
@AaronBallman this one is ready for review :)
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hdoc ready_for_review
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Is this still in Draft status or should this be marked as ready for review?
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hdoc wrote:
>From my reading of the Doxygen documentation it seems like anything goes
>except putting the doc comment inside the actual body of a function. That
>being said, I think that change is out of the scope of this PR because it
>would likely require modifications to the Clang
Boddlnagg wrote:
Regarding the positioning of Doxygen comments, I just saw this and was
wondering if it's possible to also support parsing of Doxygen comments that
come after the signature, which happens to be the preferred style in our
codebase ...
```c++
static int doSomething(int foobar)
@@ -62,6 +62,8 @@
///The 2nd source tile. Max size is 1024 Bytes.
#define _tile_cmmimfp16ps(dst, a, b) __builtin_ia32_tcmmimfp16ps(dst, a, b)
+;
hdoc wrote:
This has been fixed in the latest commit, where the internal function is
documented with a
hdoc wrote:
Ping
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hdoc updated https://github.com/llvm/llvm-project/pull/88367
>From 61612c5f340e25198deaf68e6904323955efe489 Mon Sep 17 00:00:00 2001
From: hdoc
Date: Thu, 11 Apr 2024 01:54:18 -0700
Subject: [PATCH 1/2] Attach comments to decl even if preproc directives are in
between
---
https://github.com/hdoc updated https://github.com/llvm/llvm-project/pull/88367
>From 61612c5f340e25198deaf68e6904323955efe489 Mon Sep 17 00:00:00 2001
From: hdoc
Date: Thu, 11 Apr 2024 01:54:18 -0700
Subject: [PATCH] Attach comments to decl even if preproc directives are in
between
---
@@ -62,6 +62,8 @@
///The 2nd source tile. Max size is 1024 Bytes.
#define _tile_cmmimfp16ps(dst, a, b) __builtin_ia32_tcmmimfp16ps(dst, a, b)
+;
hdoc wrote:
This is a workaround to a Clang issue where doc comments cannot be associated
with macros in
https://github.com/hdoc edited https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/hdoc created https://github.com/llvm/llvm-project/pull/88367
# Background
It's surprisingly common for C++ code in the wild to conditionally show/hide
declarations to Doxygen through the use of preprocessor directives. One
especially common version of this pattern is
18 matches
Mail list logo
