Fwd: ssh clone config

On Tue, Jan 14, 2014 at 10:09 PM, Doug Carter wrote: > I'd like to create > a some ssl clone text that can be copy/pasted like github does it: > > g...@git.foo.com:repo.git > > Is there a way to do this and not include any URLs? Yes, using the 'clone-prefix' and/or 'clone-url' settings in cgitr

Re: cgit-lua: to jit or not to jit

One more thing for luajit vs. lua - If you ship a plugin (.so, .dll, .dylib) using luajit, then the host application might not always work with it. If I'm not mistaken the lower 2GB (or 4GB?) must be allocated to luajit, (so even in 64-bit app, it needs the lower 32-bit address space - for lua allo

authentication support: work has begun!

Hi folks, While still a horrendous mess, I've begun work adding authentication support, using our nice new lua filter system. A sample script looks like this [at the moment]: http://git.zx2c4.com/cgit/tree/filters/simple-authentication.lua?h=jd/authentication The full commit of this attrocity l

Re: lua vs luajit vs both

On Tue, Jan 14, 2014 at 07:06:34PM +0100, Jason A. Donenfeld wrote: > > > > On Tue, Jan 14, 2014 at 10:08 AM, John Keeping wrote: > > It was more of a "there doesn't seem much overhead to supporting both, > > since the API is the same". I think the Makefile should take an > > approach more like

Re: [PATCH] filter: refactor cgit_new_filter()

On Tue, Jan 14, 2014 at 09:54:21PM +0100, Jason A. Donenfeld wrote: > On Tue, Jan 14, 2014 at 9:39 PM, John Keeping wrote: > > I like the simplification, but I'm not sure the result is better. Even > > without the rest we should replace the strncmp with prefixcmp though. > > Agreed. > > > > Ther

[PATCH 3/3] t0111: Check all arguments

In the filter checks, check whether all arguments are passed properly instead of validating the buffer/stdin only. Signed-off-by: Lukas Fleischer --- tests/filters/capitalize-buffer.lua | 3 +++ tests/filters/capitalize-stdin.sh | 1 + tests/t0111-filter.sh | 4 ++-- 3 files chan

[PATCH v2 2/3] t0111: Add basic tests for Lua filters

Signed-off-by: Lukas Fleischer --- tests/filters/capitalize-buffer.lua | 14 tests/setup.sh | 9 + tests/t0111-filter.sh | 65 +++-- 3 files changed, 57 insertions(+), 31 deletions(-) create mode 100644 tests/filter

[PATCH v2 1/3] t0111: Prepare for other filter prefixes

* Validate the email filter by manipulating stdin. Additional checks for all the arguments can be added in a later patch. * Add the exec prefix to all informational messages. * Rename the filter repository to filter-exec. The Git repository itself is not renamed since it can be shared amongst

ssh clone config

Hi All, Sorry if this is already an answered question, but I've been through the docs and the mailing list archives but couldn't find anything. I have a local, in house gitolite repo with the latest cgit up and running. Since it's private and open to all engineers, I'd like to create a some ssl

Re: [PATCH] filter: refactor cgit_new_filter()

On Tue, Jan 14, 2014 at 9:39 PM, John Keeping wrote: > I like the simplification, but I'm not sure the result is better. Even > without the rest we should replace the strncmp with prefixcmp though. Agreed. > > There's actually no reason we couldn't mutate "cmd" here, which would > simplify it a

Re: cgit-lua: to jit or not to jit

On Tue, Jan 14, 2014 at 12:50 PM, Coda Highland wrote: > On Tue, Jan 14, 2014 at 12:41 PM, Eric Wing wrote: >>> But perhaps there >>> are some obvious downsides to this approach that I also am missing. >> >> Here are a few more potential downsides not mentioned so far. >> >> One is that iOS and W

Re: cgit-lua: to jit or not to jit

On Tue, Jan 14, 2014 at 12:41 PM, Eric Wing wrote: >> But perhaps there >> are some obvious downsides to this approach that I also am missing. > > Here are a few more potential downsides not mentioned so far. > > One is that iOS and Windows Store policies disallow JIT. While you can > disable this

Re: cgit-lua: to jit or not to jit

> But perhaps there > are some obvious downsides to this approach that I also am missing. Here are a few more potential downsides not mentioned so far. One is that iOS and Windows Store policies disallow JIT. While you can disable this part in LuaJIT, most of the performance advantages disappear

Re: [PATCH] filter: refactor cgit_new_filter()

On Tue, Jan 14, 2014 at 02:00:48PM +0100, Jason A. Donenfeld wrote: > From: Lukas Fleischer > > Use prefixcmp() as a preparation for using strip_prefix() later. Also, > interpret the command as a file name if it contains a colon but none of > the filter prefixes matches instead of bailing out and

[PATCH 1/2] t0111: Prepare for other filter prefixes

Rename the filter repository to filter-exec. The Git repository itself is not renamed since it can be shared amongst all filter types. Signed-off-by: Lukas Fleischer --- tests/setup.sh| 2 +- tests/t0111-filter.sh | 22 +++--- 2 files changed, 12 insertions(+), 12 deleti

[PATCH 2/2] t0111: Add basic tests for Lua filters

Signed-off-by: Lukas Fleischer --- tests/filters/capitalize-buffer.lua | 14 ++ tests/setup.sh | 9 + tests/t0111-filter.sh | 32 3 files changed, 55 insertions(+) create mode 100644 tests/filters/capitalize

Re: cgit-lua: to jit or not to jit

* Jason A. Donenfeld: > On Tue, Jan 14, 2014 at 3:10 AM, demetri wrote: >> 1) PUC Lua works on more machines/architectures (though Mike has >> substantially closed the gap for most architectures people care about in a >> non-embedded non-mobile environment) > > Do you know what the gap is? > > Lu

Re: lua vs luajit vs both

> On Tue, Jan 14, 2014 at 10:08 AM, John Keeping wrote: > It was more of a "there doesn't seem much overhead to supporting both, > since the API is the same". I think the Makefile should take an > approach more like this though: > > ifdef NO_LUA > CGIT_CFLAGS += -DNO_LUA

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

On Tue, Jan 14, 2014 at 6:58 PM, Christian Hesse wrote: > Looks good to me. > > Though this may result in images that do not fit font size if dpi is a lot > more or less than 96 as René pointed. Anybody want to try with a fancy retina iPad or the like?

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

"Jason A. Donenfeld" on Tue, 2014/01/14 18:51: > On Tue, Jan 14, 2014 at 6:35 PM, Christian Hesse wrote: > > Probably the only way to not have this is to use pixel only for images. > > Want a patch? > > I think I have it handled. Would you look at git.zx2c4.com/cgit/log/ > and tell me if that lo

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

On Tue, Jan 14, 2014 at 6:35 PM, Christian Hesse wrote: > Probably the only way to not have this is to use pixel only for images. > Want a patch? I think I have it handled. Would you look at git.zx2c4.com/cgit/log/ and tell me if that looks better to you? _

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

Am 14.01.2014 18:35, schrieb Christian Hesse: > "Jason A. Donenfeld" on Tue, 2014/01/14 18:23: >> On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse wrote: >>> Looks better, though not perfect. >>> At least firefox still scales the image a bit. >> >> Can you investigate the whole "px to pt" situati

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

"Jason A. Donenfeld" on Tue, 2014/01/14 18:23: > On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse wrote: > > Looks better, though not perfect. > > At least firefox still scales the image a bit. > > Can you investigate the whole "px to pt" situation, line-height, and > the best way to manage this

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse wrote: > Looks better, though not perfect. > At least firefox still scales the image a bit. Can you investigate the whole "px to pt" situation, line-height, and the best way to manage this? ___ CGit maili

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

"Jason A. Donenfeld" on Mon, 2014/01/13 15:24: > On Mon, Jan 13, 2014 at 3:18 PM, Christian Hesse wrote: > > Your avatar (and mine as well) are fine when scaled down. But if there is > > no avatar on gravatar you get the "arcade-style pixelated faces", which > > look very fuzzy when scaled by the

Re: [PATCH 1/1] filter: fix lua function name

Wow you're quick. I pushed and then [improperly] rebased within a matter of 15 seconds. But I guess you caught this anyway. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] fix email-gravatar.lua for lua 5.2

"Jason A. Donenfeld" on Tue, 2014/01/14 13:48: > Merged, thanks. > > What exactly is the reason for this change in Lua 5.2? No idea. Just noticed it is broken and fixed it. ;) -- Schoene Gruesse Chris O< ascii ribbon campaign stop html mail - www.asci

[PATCH 1/1] filter: fix lua function name

--- filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filter.c b/filter.c index 44af434..0cce7bb 100644 --- a/filter.c +++ b/filter.c @@ -319,7 +319,7 @@ static int close_lua_filter(struct cgit_filter *base) error_lua_filter(filter); ret =

Re: cgit-lua: to jit or not to jit

On Tue, Jan 14, 2014 at 4:51 AM, Andrew Starks wrote: > > I also just remembered this: > > https://github.com/jmckaskill/luaffi > > Which is a luajit compatible FFI extension for Lua 5.1 and Lua 5.2, but 5.2 > is listed as beta. It might be worth a shot, if it lets you gain some of > those conveni

[PATCH] filter: refactor cgit_new_filter()

From: Lukas Fleischer Use prefixcmp() as a preparation for using strip_prefix() later. Also, interpret the command as a file name if it contains a colon but none of the filter prefixes matches instead of bailing out and adding a special check for Windows. Signed-off-by: Lukas Fleischer --- John

Re: [PATCH/RFC] tests/: Add t0111-filter.sh

Terrific! I was hoping something like this would come about. Looking forward to seeing the lua side of things. There's another change I'm going to be pushing later today that involves being able to do meaningful things with the cgit_filter_close() exit code. I'll then be using this to /maybe/ impl

Re: [PATCH 1/1] fix html syntax in email-gravatar.*

Good catch with &. Merged. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] fix UTF-8 with email-gravatar.py

Ahhh Python... *sigh* Merged. Thanks for this. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] fix email-gravatar.lua for lua 5.2

Merged, thanks. What exactly is the reason for this change in Lua 5.2? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: Idle time in project overview

On Tue, Jan 14, 2014 at 11:50:23AM +0100, Stefan Tatschner wrote: > I don't know if it is a bug or a feature but I think on this nice > mailing list I could ask without being shot or mutilated. :) > > If I have a git repository with multiple branches and I push to another > branch as 'master' the

[PATCH 1/1] fix html syntax in email-gravatar.*

* make ampersand a html entity * add required alt attribute * add required img end tag --- filters/email-gravatar.lua | 2 +- filters/email-gravatar.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/filters/email-gravatar.lua b/filters/email-gravatar.lua index 9feb611..22f

[PATCH/RFC] tests/: Add t0111-filter.sh

This adds basic tests for all types of exec filters. Signed-off-by: Lukas Fleischer --- This only includes tests for exec filters so far. I will send another patch for Lua filters once this one is merged. tests/filters/capitalize-argv1.sh | 3 +++ tests/filters/capitalize-stdin.sh | 3 +++ te

Idle time in project overview

I don't know if it is a bug or a feature but I think on this nice mailing list I could ask without being shot or mutilated. :) If I have a git repository with multiple branches and I push to another branch as 'master' the idle time on the project overview is not updated. I think this behaviour is

Re: [PATCH v3 2/2] filters: Choose 'trac' theme in pygments

Am 14.01.2014 02:33, schrieb Jason A. Donenfeld: > Personally, I think the trac colors are a bit ugly. I like pastie > best. But this is just preference. I personally also like the 'default' theme it is pretty much the same as 'pastie' but it does not add a background color to strings. This backgr

[PATCH 1/1] fix email-gravatar.lua for lua 5.2

--- filters/email-gravatar.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filters/email-gravatar.lua b/filters/email-gravatar.lua index 982e030..9feb611 100644 --- a/filters/email-gravatar.lua +++ b/filters/email-gravatar.lua @@ -7,7 +7,7 @@ --

[PATCH 1/1] fix UTF-8 with email-gravatar.py

--- filters/email-gravatar.py | 4 1 file changed, 4 insertions(+) diff --git a/filters/email-gravatar.py b/filters/email-gravatar.py index f90b87d..5d08ea8 100755 --- a/filters/email-gravatar.py +++ b/filters/email-gravatar.py @@ -20,6 +20,7 @@ import sys import hashlib +import codecs

Re: lua vs luajit vs both

On Tue, Jan 14, 2014 at 02:02:40AM +0100, Jason A. Donenfeld wrote: > I've gone ahead and merged the lua work to master, for testing and > subsequent cleanup before release. > > Regarding "to jit or not to jit", I currently have this fancy autodetection > logic: > http://git.zx2c4.com/cgit/commit/

Re: cgit-lua: to jit or not to jit

On 14 Jan 2014 03:52, "Andrew Starks" wrote: > > > > On Monday, January 13, 2014, Jason A. Donenfeld wrote: >> >> On Tue, Jan 14, 2014 at 3:37 AM, Andrew Starks wrote: >> > >> > I don't have LuaJit installed and would not install it (and migrate >> > everything I do over to it) just to use a libr