Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

On Tue, Mar 08, 2016 at 03:54:22PM +0100, Christian Hesse wrote: > John Keeping on Tue, 2016/03/08 14:36: > > On Tue, Mar 08, 2016 at 03:26:23PM +0100, Christian Hesse wrote: > > > John Keeping on Tue, 2016/03/08 14:11: > > > > On Tue, Mar 08, 2016 at

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

On Tue, Mar 08, 2016 at 04:01:59PM +0100, Christian Hesse wrote: > John Keeping on Tue, 2016/03/08 14:59: > > On Tue, Mar 08, 2016 at 03:54:22PM +0100, Christian Hesse wrote: > > > John Keeping on Tue, 2016/03/08 14:36: > > > > On Tue, Mar 08, 2016 at

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

John Keeping on Tue, 2016/03/08 14:59: > On Tue, Mar 08, 2016 at 03:54:22PM +0100, Christian Hesse wrote: > > John Keeping on Tue, 2016/03/08 14:36: > > > On Tue, Mar 08, 2016 at 03:26:23PM +0100, Christian Hesse wrote: > > > > John Keeping

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

John Keeping on Tue, 2016/03/08 14:36: > On Tue, Mar 08, 2016 at 03:26:23PM +0100, Christian Hesse wrote: > > John Keeping on Tue, 2016/03/08 14:11: > > > On Tue, Mar 08, 2016 at 02:51:46PM +0100, Christian Hesse wrote: > > > > From: Christian Hesse

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

John Keeping on Tue, 2016/03/08 14:11: > On Tue, Mar 08, 2016 at 02:51:46PM +0100, Christian Hesse wrote: > > From: Christian Hesse > > > > Signed-off-by: Christian Hesse > > Is this solving a particular problem or did you just notice that

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

On Tue, Mar 08, 2016 at 02:51:46PM +0100, Christian Hesse wrote: > From: Christian Hesse > > Signed-off-by: Christian Hesse Is this solving a particular problem or did you just notice that the return value is ignored? I don't think returning when this fails is

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

Are repos without .git/config necessarily invalid? zx2c4@thinkpad ~ $ mkdir abcd zx2c4@thinkpad ~ $ cd abcd zx2c4@thinkpad ~/abcd $ git init Initialized empty Git repository in /home/zx2c4/abcd/.git/ zx2c4@thinkpad ~/abcd $ touch file zx2c4@thinkpad ~/abcd $ git add file zx2c4@thinkpad ~/abcd $