Re: [PATCH v2] ui-shared: split repository link into directories

2016-04-28 Thread Petr Vorel
Dear John, > > We may just have to bail out of this feature if the two variables differ. > Is it really the best way from UI/UX POV? Inconsistency isn't nice :-(. I'd > like to try > to have this feature either on or off for each repository. You were right, it doesn't make much sense to split lin

Traveling

2016-04-28 Thread Jason A. Donenfeld
Hey guys, I'm in Greece then Japan traveling until the first week of July. I'll have a few days in between to merge things, hopefully. Anyway, I'm here reading your emails and patches. Jason ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.

Re: [PATCH v2] ui-shared: split repository link into directories

2016-04-28 Thread Petr Vorel
Dear John, thanks for comments and tips. > I think we should have a configuration option for this as it changes the > behaviour. However, I'm not sure what the patch below does because... Not a problem, I'll can add config value into v3. > I'm guessing you intended to allow the repository at

Re: [PATCH] ui-shared: split repository link into directories

2016-04-28 Thread Petr Vorel
Dear John, Please, have a look at v2 (just minor cleanup), I'll answer there. Kind regards, Petr ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] ui-shared: split repository link into directories

2016-04-28 Thread John Keeping
On Thu, Apr 28, 2016 at 10:37:29PM +0200, Petr Vorel wrote: > Signed-off-by: Petr Vorel > --- > The only missing feature from gitweb: clickable any directory in between. It's > very handy, if you have lots of repos (local AOSP repositories). > If you don't like it hardcoded, I can prepare patch wi

[PATCH v2] ui-shared: split repository link into directories

2016-04-28 Thread Petr Vorel
Signed-off-by: Petr Vorel --- The only missing feature from gitweb: clickable any directory in between. It's very handy, if you have lots of repos (local AOSP repositories). If you don't like it hardcoded, I can prepare patch with configuration option. v2: minor cleanup --- ui-shared.c | 16 +

[PATCH] ui-shared: split repository link into directories

2016-04-28 Thread Petr Vorel
Signed-off-by: Petr Vorel --- The only missing feature from gitweb: clickable any directory in between. It's very handy, if you have lots of repos (local AOSP repositories). If you don't like it hardcoded, I can prepare patch with configuration option. --- ui-shared.c | 19 ++- 1