Re: [PATCH 3/3] Add support for git's mailmap.

2016-08-29 Thread Jason A. Donenfeld
I like this series; thanks for polishing it. I'll review and merge shortly. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v5 1/1] ui-shared: allow to split the repository link

2016-08-29 Thread Jason A. Donenfeld
It looks mostly good to me. I'll get this in the next release. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v5 1/1] ui-shared: allow to split the repository link

2016-08-29 Thread Petr Vorel
Dear Jason, any objections to this patch? Anything I can do for it to be merged? https://lists.zx2c4.com/pipermail/cgit/2016-May/003052.html https://lists.zx2c4.com/pipermail/cgit/2016-May/003038.html Kind regards, Petr > Teach cgit split the repository link in the top of repository "summary"

[PATCH 3/3] Add support for git's mailmap.

2016-08-29 Thread Jason A. Smith
If a mailmap file is present in the repo, it will be used to coalesce commits by the same person, just like git does. When no mailmap file is found then it functions as before. Signed-off-by: Jason A. Smith --- cgit.h | 3 +++ parsing.c | 21 + ui-atom.c | 20

[PATCH 2/3] Remove angle brackets from {author,committer}_email

2016-08-29 Thread John Keeping
This matches the internal representation in libgit.a, so it will make it much easier to use Git's mailmap code. The change in ui-atom.c isn't strictly necessary since the code copes with email addresses both with and without angle brackets, but it's a nice simplification since we know that the e

[PATCH 1/3] filter: introduce cgit_open_email_filter() wrapper

2016-08-29 Thread John Keeping
We provide email addresses to the email filter surrounded by angle brackets, but we will soon remove these in our internal representation. Introduce a wrapper so that we only have to add them in one place. Signed-off-by: John Keeping Signed-off-by: Jason A. Smith --- cgit.h | 2 ++ filte

Re: [PATCH 3/3] Add support for git's mailmap.

2016-08-29 Thread John Keeping
On Mon, Aug 29, 2016 at 11:18:16AM -0400, Jason A. Smith wrote: > On 08/26/2016 07:13 PM, John Keeping wrote: > > On Fri, Aug 26, 2016 at 05:30:32PM -0400, Jason A. Smith wrote: > >> > >> Sorry for the extra email noise, but while fixing these I found two more > >> cgit_open_filter() function calls

Re: [PATCH 3/3] Add support for git's mailmap.

2016-08-29 Thread Jason A. Smith
On 08/26/2016 07:13 PM, John Keeping wrote: On Fri, Aug 26, 2016 at 05:30:32PM -0400, Jason A. Smith wrote: Sorry for the extra email noise, but while fixing these I found two more cgit_open_filter() function calls that should probably be changed to cgit_open_email_filter() in the first patch: