Re: css: highlight even table rows

2016-10-01 Thread Jason A. Donenfeld
Honestly I thought it was really ugly at first. But then I tried it out on git.zx2c4.com and forgot about it, and now after looking at it for a bunch of months, I don't mind it. So apparently you and kernel.org both like this. So maybe I should merge it. Does anybody have any objections due to

Re: [PATCH] cgit: ignore SIGPIPE

2016-10-01 Thread Jason A. Donenfeld
Hey John, I see the utility of this with something like a highlight filter gone bad. But is it safe to do this in the context of an authentication filter? What's the failure behavior like once this patch is applied? Jason ___ CGit mailing list

Re: [PATCHv2 0/2] Collapsible Section Support

2016-10-01 Thread Jason A. Donenfeld
Hey Andy, One issue with this is -- isn't this the sort of thing that would be better taken care of with css3 or css+javascript? That is to say you list the children of some elements as being display:none until they're clicked, and then upon click you make it visible? This seems like it'd be a

Re: [PULL] Various patches from the list

2016-10-01 Thread Jason A. Donenfeld
Hey John, I merged all of this except the last two commits, which I'd like to discuss a bit more. Those live in jk/collapsible-sections. I'll chime in on the other thread about that. Thanks, Jason ___ CGit mailing list CGit@lists.zx2c4.com

[PATCH] cgit: ignore SIGPIPE

2016-10-01 Thread John Keeping
We check the return value from write() and die with an error message, so the only effects of using the default SIGPIPE handler is to suppress the error message and change the exit status. Web servers tend to ignore the exit code, so it is likely to be more helpful to administrators if we print

Re: SIGPIPE from syntax highlighting filter if highlight is not available

2016-10-01 Thread John Keeping
On Thu, Sep 29, 2016 at 04:38:41PM +0200, Vadim Zeitlin wrote: > As this is the first time I'm posting here, let me start by thanking you > for developing cgit! I'm using it since quite some time under Debian > (currently Jessie) and it works very well but recently I've mistakenly > removed