Re: [PATCHv2 0/2] Collapsible Section Support

2016-10-12 Thread Andy Doan
Any opinions on this? On 10/03/2016 03:52 PM, Andy Doan wrote: > On 10/03/2016 10:56 AM, Jason A. Donenfeld wrote: >> Also, to clarify -- >> >> The patch for cgit for this should probably be just adding >> id="section_name" to the various divs. Then users' stylesheets and js >> files can contain

Re: RFC: don't cache objects larger than X

2016-10-12 Thread Konstantin Ryabitsev
On Wed, Oct 12, 2016 at 01:22:34PM +0200, Jason A. Donenfeld wrote: > I face this same problem, in fact. Unless somebody beats me to it, I'd > be interested in giving this a stab. > > One issue is that cache entries are currently "streamed" into the > cache files, as they're produced. It's not

Build failed in Jenkins: cgit-master-get-git #51 - origin/master - 1b46645

2016-10-12 Thread Pelagic Jenkins (Public)
See Changes: [Jason] Use skip_prefix() to get rid of magic constants -- [...truncated 672 lines...] CC t/helper/test-line-buffer.o LINK t/helper/test-line-buffer CC

Build failed in Jenkins: cgit-master #49 - origin/master - 5fe88a9

2016-10-12 Thread Pelagic Jenkins (Public)
See Changes: [mail] cgit: replace 'unsigned char sha1[20]' with 'struct object_id oid' [mail] ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid' [mail] ui-commit: replace 'unsigned char sha1[20]' with

Build failed in Jenkins: cgit-master #50 - origin/master - 1b46645

2016-10-12 Thread Pelagic Jenkins (Public)
See Changes: [Jason] Use skip_prefix() to get rid of magic constants -- [...truncated 575 lines...] 184 translated messages, 46 fuzzy translations, 77 untranslated messages. Generating

Build failed in Jenkins: cgit-master-get-git #50 - origin/master - 5fe88a9

2016-10-12 Thread Pelagic Jenkins (Public)
See Changes: [mail] cgit: replace 'unsigned char sha1[20]' with 'struct object_id oid' [mail] ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid' [mail] ui-commit: replace 'unsigned char sha1[20]'

[PATCH 1/1] ui-blog: fix oid handling

2016-10-12 Thread Christian Hesse
From: Christian Hesse We have to use a pointer for walk_tree_ctx->matched_oid. This fixes faulty commit 6e4b7b6776eb994e795fa38b2619db6c55e10ecc (ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid'). Signed-off-by: Christian Hesse --- ui-blob.c

Re: [PATCH 2/3] shared: remove unused function strrpart()

2016-10-12 Thread Jason A. Donenfeld
LGTM. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] ui-log: fix data corruption

2016-10-12 Thread Jason A. Donenfeld
So what's the verdict here? Do we have a double free or not? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: RFC: don't cache objects larger than X

2016-10-12 Thread Jason A. Donenfeld
I face this same problem, in fact. Unless somebody beats me to it, I'd be interested in giving this a stab. One issue is that cache entries are currently "streamed" into the cache files, as they're produced. It's not trivially possible to know how big it's going to be beforehand. This means that

Re: [PATCH 1/3] ui-repolist: fix memory leak

2016-10-12 Thread Jason A. Donenfeld
Nice find, thanks. Queue 'er up. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 3/3] shared: remove unused function strlpart()

2016-10-12 Thread Jason A. Donenfeld
Also looks good. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit