Re: [PATCH v8 1/1] ui-shared: allow to split the repository link

Hi John, > It's the return value of cgit_repourl() that needs to be freed, not the > name. You'll need a new local variable for the result of calling > cgit_repourl() which then needs to be freed in the loop. Thanks! Fixed in v9. I ignored t0103-log.sh test failures you mentioned while

[PATCH v9 1/1] ui-shared: allow to split the repository link

Teach cgit split the repository link in the top of repository "summary" view. This emulates the same behaviour as it's in gitweb. This behaviour is not implemented for repositories which have "repo.name" set different than "repo.url". Signed-off-by: Petr Vorel Cc: "Jason

Re: [PATCH v8 1/1] ui-shared: allow to split the repository link

On Sun, Mar 12, 2017 at 06:56:03PM +0100, Petr Vorel wrote: > > Teach cgit split the repository link in the top of repository "summary" > > view. This emulates the same behaviour as it's in gitweb. > > > This behaviour is not implemented for repositories which have > > "repo.name" set different

Re: [PATCH v8 1/1] ui-shared: allow to split the repository link

Hi, > Teach cgit split the repository link in the top of repository "summary" > view. This emulates the same behaviour as it's in gitweb. > This behaviour is not implemented for repositories which have > "repo.name" set different than "repo.url". > Signed-off-by: Petr Vorel

Re: [PATCH] filter: set environment variable PYTHONIOENCODING to utf-8

On Sun, Mar 12, 2017 at 10:01:10AM -0700, Jason A. Donenfeld wrote: > Sorry for the delay. I'm currently on the road traveling and won't be > properly back at my desk until the end of next week. > > However, my initial reaction is that hard coding various > interpreter-specific environment

Re: [PATCH v7 1/1] ui-shared: allow to split the repository link

Hi John, > > Thanks for your review John. Are we there yet? :-) > I just noticed one more thing... > > + html_link_open(cgit_repourl(name), NULL, NULL); > The value returned by cgit_repourl() should be freed. Thanks for info, fixed in v8. Kind regards, Petr

Re: [PATCH] filter: set environment variable PYTHONIOENCODING to utf-8

Hey guys, Sorry for the delay. I'm currently on the road traveling and won't be properly back at my desk until the end of next week. However, my initial reaction is that hard coding various interpreter-specific environment variables in cgit itself is not correct, and that this is something

[PATCH v8 1/1] ui-shared: allow to split the repository link

Teach cgit split the repository link in the top of repository "summary" view. This emulates the same behaviour as it's in gitweb. This behaviour is not implemented for repositories which have "repo.name" set different than "repo.url". Signed-off-by: Petr Vorel Cc: "Jason

[PATCH 3/3] html: remove unused functions

The previous commit removed the only use of these functions, so let's remove them. Signed-off-by: John Keeping --- html.c | 20 html.h | 2 -- 2 files changed, 22 deletions(-) diff --git a/html.c b/html.c index e7e6e07..e4dbb05 100644 --- a/html.c +++

[PATCH 2/3] ui-{repolist,atom}: fix repository URL escaping

Remove cgit_repourl() and replace it with a new function that prints a suitable escaped version of the repository URL designed for use in an attribute value. There are only two places that use this at the moment and both want the value to be used in attribute context. We could introduce new

[PATCH 1/3] tests: document handling of repository names with spaces

t0103-log.sh has a test to check that we don't properly escape spaces in repository URLs, but no other tests do. It turns out that the handling of this case in the index page is broken, so mark this as test_expect_failure while adding successful tests for all other pages. Signed-off-by: John

Re: [PATCH v7 1/1] ui-shared: allow to split the repository link

On Tue, Feb 21, 2017 at 12:36:04AM +0100, Petr Vorel wrote: > Teach cgit split the repository link in the top of repository "summary" > view. This emulates the same behaviour as it's in gitweb. > > This behaviour is not implemented for repositories which have > "repo.name" set different than

[PULL] Collected patches

Hi Jason, My changes are a collection of bugfixes, including a series fixing an URL-parsing issue I found by running AFL. I've picked up Roy's patch as well because I think it's in decent shape and it makes it easier to write Python filters that do the right thing with non-ASCII content. -- >8

Re: [PATCH v7 1/1] ui-shared: allow to split the repository link

On Tue, Feb 21, 2017 at 12:36:04AM +0100, Petr Vorel wrote: > Teach cgit split the repository link in the top of repository "summary" > view. This emulates the same behaviour as it's in gitweb. > > This behaviour is not implemented for repositories which have > "repo.name" set different than

Re: cgit and symlinks

On Thu, Mar 09, 2017 at 08:58:43AM +0100, MonkZ wrote: > Am 09.03.2017 um 01:15 schrieb John Keeping: > > On Wed, Mar 08, 2017 at 02:28:11PM +0100, MonkZ wrote: > >> > >> > >> Am 08.03.2017 um 13:30 schrieb John Keeping: > >>> On Wed, Mar 08, 2017 at 12:38:38PM +0100, MonkZ wrote: > Am