Re: Go - Serving modules

2023-01-12 Thread Gianni Ceccarelli
On Wed, 11 Jan 2023 20:50:35 -0500 Levi Durfee wrote: > I'm using scan-path to find the repositories. Then you can set per-repository options inside each repo ``config`` file (I manage those via ``gitolite``, but you can just edit them). So for a repo at ``/var/lib/gitrepos/foo-go.git``, you'd

Re: Go - Serving modules

2023-01-06 Thread Gianni Ceccarelli
On 2023-01-06 Levi Durfee wrote: > I noticed on git.zx2c4.com that there is the "go-import" meta tag. You > can view the source of https://git.zx2c4.com/wireguard-go to see the > meta tag. > > I tried replicating this using the "head-include" config option, but I > don't see a way to specify any

Re: Greater use of the HTML title (for tabs and title bars) in cgit

2022-11-06 Thread Gianni Ceccarelli
On 2022-11-06 John Keeping wrote: > > * the branch (not main) > > Git commits are not associated with a branch, so unless we have an > h=... query argument I don't see any way to derive the correct value > to display for a branch. We could do the equivalent of ``git branch --contains

Re: Truncated output when writing to a pipe using sendfile

2022-05-07 Thread Gianni Ceccarelli
On 2022-05-07 Filips R wrote: > Looks like the sendfile call comes from cache.c:95 - > https://git.zx2c4.com/cgit/tree/cache.c?h=v1.2.3=55fa25adb097d2681607d8b0f51a0c393cc9af1a#n95 > > senfile(2) says that a successful call may write fewer bytes than > requested; the caller should be prepared to

Re: Weird interactions betwen cache and module-link

2022-03-26 Thread Gianni Ceccarelli
ic module-links from working when cache was enabled, since the cache repo config didn't include them. Signed-off-by: Gianni Ceccarelli --- cgit.c | 4 1 file changed, 4 insertions(+) diff --git a/cgit.c b/cgit.c index 08d81a1..ae3a66e 100644 --- a/cgit.c +++ b/cgit.c @@ -810,6 +810,10 @@ st

Re: Weird interactions betwen cache and module-link

2022-03-25 Thread Gianni Ceccarelli
This patch seems to fix the problem. diff --git c/cgit.c w/cgit.c index 08d81a1..d30e259 100644 --- c/cgit.c +++ w/cgit.c @@ -810,6 +810,10 @@ static void print_repo(FILE *f, struct cgit_repo *repo) fprintf(f, "repo.extra-head-content=%s\n", repo->extra_head_content); if

Weird interactions betwen cache and module-link

2022-03-25 Thread Gianni Ceccarelli
Hello! I use git submodules pretty often, and I like that cgit allows me to link them to their proper repository. For example, https://www.thenautilus.net/cgit/env-sensor/tree/ or https://www.thenautilus.net/cgit/lego-piano/tree/ You may have noticed that at least one of those pages does not

Re: [PATCH] Handle tags outside of refs/tags gracefully.

2021-01-05 Thread Gianni Ceccarelli
On 2021-01-05 Ulrich Spörlein wrote: > Yes, but `git log` will show all of them, it doesn't care :) (and so > does cgits log handler ... but then you get 404s when clicking them). Thank you for confirming. That's exactly what I wrote two messages ago: >> Now CGit shows the

Re: [PATCH] Handle tags outside of refs/tags gracefully.

2021-01-05 Thread Gianni Ceccarelli
On 2021-01-05 John Keeping wrote: > I think something like option 2 is the right answer here, since that > brings us closer to Git's behaviour. ``git tag`` never looks anywhere but under ``refs/tags/``. Not even ``git tag --contains`` will show annotated tags that are only referenced outside

Re: [PATCH] Handle tags outside of refs/tags gracefully.

2021-01-05 Thread Gianni Ceccarelli
I have found an annoying case… In the repository created as per my previous message, I did:: $ git tag -a foo $ git rev-parse refs/tags/foo > .git/refs/weird/annotated $ git push origin refs/weird/*:refs/weird/* This creates an "annotated tag", which is an object in the store, not just a

Re: [PATCH] Handle tags outside of refs/tags gracefully.

2020-12-29 Thread Gianni Ceccarelli
On Tue, 2020-12-29 at 12:37:43 +0100, Jason A. Donenfeld wrote: > This is for the tag UI, though. Aren't tags supposed to live in > refs/tags/ by definition? Yes. The "git tag" manpage says: >> Add a tag reference in refs/tags/, unless -d/-l/-v is given to >> delete, list or verify tags On

Re: Possible case-sensitivity issue in module-link

2020-08-29 Thread Gianni Ceccarelli
On 2020-08-29 John Keeping wrote: > Yes, Git's config parsing converts all keys to lowercase (see > git/config.c::get_value() and its caller). > > Does the patch below fix the bug? It does, thank you! -- Dakkar - GPG public key fingerprint = A071 E618 DD2C 5901 9574

Possible case-sensitivity issue in module-link

2020-08-29 Thread Gianni Ceccarelli
Hello! I use cgit on my own site https://www.thenautilus.net/cgit/ Some of my repositories contain submodules, for example https://www.thenautilus.net/cgit/Sietima/tree/docs/presentation/ https://www.thenautilus.net/cgit/thermostat/tree/ https://www.thenautilus.net/cgit/thermostat/tree/sensor/