Good find! Thanks. Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
Interesting how "sha1" is being replaced with "oid". I wonder if git
upstream plans on moving to a different hash function.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Applied, thanks.
John - if you want to submit a more comprehensive patch on top, be my guest.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hi folks,
Krzysztof Katowicz-Kowalewsk has contacted me about two XSS security
vulnerabilities he's found in cgit. Upon investigation the problem
looks a bit deeper than he initially reported, and I found a few more
related vulnerabilities, and I think it generally deserves a bit of
discussion for
Hey folks,
People have started poking me for a new release soon. I'd like to do
this as soon as we get all those Coverity fixes done. I'll get back on
that this week. Feel free to chip in or reforward any patches I missed
last round.
Jason
___
CGit mail
Thanks, applied.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Python 2 works fine. But thanks for that catch with input already
defaulting to stdin. Applied that optimization.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Mon, Oct 12, 2015 at 1:05 PM, Christian Hesse wrote:
>> [0] http://www.pell.portland.or.us/~orc/Code/discount/
>
> BTW, this brings a shared library libmarkdown.so. We could link cgit against
> that and handle markdown without external command.
Definitely not. In the first case, I wouldn't wan
Oh. Right. That's the slow script I replaced, preferring instead markdown_py:
https://www.archlinux.org/packages/community/any/python-markdown/
That's the package you want.
I should include some documentation for this.
I will also soon recode that script to be pure python, instead of bash
shellin
What package is that from? Link to upstream?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Feel free to submit a patch with some notice about that and/or some
autodetection logic for markdown/markdown_py. If not, I'll do it on Monday.
On Oct 11, 2015 12:08 PM, "Christian Hesse" wrote:
> Christian Hesse on Sun, 2015/10/11 12:06:
> > Hello everybody,
> >
> > commit 'filters: Simplify co
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
My guess is the fact that sometimes that function returned a const
values and other times an allocated value tripped it up. It's flow
graph can only be so big...
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
Also - no coverity-id on this one too.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Again, nice normalization here. Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
No coverity-id on this commit. Did you find this one yourself?
In either case, merged. Thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
This is a good normalization to make. I vaguely remember when adding
this function that I was thinking, "hm, that's not right, but it's not
like we care about memory leaks anyway so...". Thanks for fixing my
laziness.
Merged.
___
CGit mailing list
CGit@l
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
>From the FAQ:
Due to high levels of activity, the number of weekly builds per
project are as follows:
Up to 12 builds per week, with a maximum of 3 builds per day, for
projects with fewer than 100K lines of code
Up to 8 builds per week, with a maximum of 2 builds per day, for
projects with 100K
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Great! Thanks. Merged. We'll see what happens.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Alright -- I've filtered out all the git findings. This leaves us with
a much more manageable 31 findings.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
The majority of them are from git. There's a way to organize the code
into modules so that we don't have to look at the git bugs though.
I'll investigate this tomorrow, unless someone beats me to it.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists
Hey Ferry,
As you probably noticed, I've added cgit to Coverity's scanner. I'm
still waiting for them to "approve" it as an authentic grass-fed
no-GMO open source project, but once that happens, we'll have a host
of bugs to inspect.
It appears they've got some scripts and things for automating th
Thanks, merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Mon, Aug 17, 2015 at 3:05 PM, Ferry Huberts wrote:
> Seems you're happy with my jenkins :-)
Man --- it's awesome, super cool.
> push -f is rather evil, as you know.
> There is no need to hide mistakes, and therefore no need to push -f
> Everybody makes mistakes.
Yea, I know. My fingers were
Forgot a !
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Mon, Aug 17, 2015 at 3:00 PM, Christian Hesse wrote:
>
>> Also, I wound up rewriting the mimetype-from-file function to be a lot
>> more clear and less error prone:
>> http://git.zx2c4.com/cgit/tree/shared.c#n564
>
> Looks like that broke it for me... I will take a look at what goes wrong.
Sor
Hah. Beat ya to it though!
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hi Christian,
I've merged your series. Thanks a lot for that.
Also, I wound up rewriting the mimetype-from-file function to be a lot
more clear and less error prone:
http://git.zx2c4.com/cgit/tree/shared.c#n564
I also expanded the send-plain list to include video/:
http://git.zx2c4.com/cgit/tree
Excellent! This is a very wanted tweak indeed, and it's finally possible
thanks to the rework merged today that moves layout into each function.
Awesome.
I'm on a camping trip this weekend, so I'll get to merging this late on
Sunday or Monday morning.
On Aug 14, 2015 11:16 PM, "Christian Hesse" w
Thanks guys!
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hi John,
Thanks for this series. The approach to caching seems like a decent
tradeoff. I'd be interested in hearing dissenting opinions on this
though. It's not to late to come up with something better before
release time.
The set looks good, and I've gone ahead and merged it to master. This
also
Merged, thanks Christian.
John -- feel free to resubmit v2 of that branch when you're ready.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Thanks for the fix John. All set now.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
John -- why are their circumstances in which your config.mak.uname isn't
created?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Excellent series, thank you.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Do you have a clever tool of computing these automatically, or is this work
by hand?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Wouldn't it be better to just use a relative URL?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hey Daniel,
Can you hop on IRC and debug this interactively with me?
#cgit on freenode. I'm zx2c4.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Thanks, applied.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
This series broke the tests. Send a fix?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Relying on an installed git does impose an additional deployment
requirement we didn't have before. Previously git was just required
for running the tests (developers), but not for deployment.
I'll wait to receive some other opinions on the topic of relying on
having the executables around.
Alter
Thanks for rebasing this. Merged to master for some testing.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Applied with some modifications -- \& goes to \\& because of shell single
quote.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Presumably that document's concern about apos is outdated, and it's kosher
in modern browsers?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Invaluable as always, Christian. Thanks. Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
http://git.zx2c4.com/cgit/commit/?id=dc41a0018058c81ee9a0a2dc6e89f737d7c1c966
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged. I'll review the backlog of the rest of the ML soon enough.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Lost in the noise.
I need to allocate some time in the next few weeks to sift through the ML
and apply all the patches and merge a change of my own I've sitting on for
a bit.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listi
Hi folks,
I'd like some review of a few branches that have been sitting for a
while, and perhaps a rebased version:
jk/http-status-codes: Should be pretty much okay and ready to merge,
but John -- anything that needs to be done here?
jk/follow-renames: This is old, but a good idea. Can you get t
Hi folks,
All our links were already pointing to /about/, but it was still
possible to load the same content at /about. This posed a problem for
using relative links inside markdown or wiki pages. This commit adds
support for a 301 redirect:
http://git.zx2c4.com/cgit/commit/?id=d7034806a4b1279f62
On Wed, Aug 12, 2015 at 3:03 PM, John Keeping wrote:
> This is an attempt at adding "blame" support to CGit. Because git.git
> doesn't include the blame implementation in libgit.a, I decided to
> simply invoke git-blame(1) and parse its porcelain output.
Could you possibly just do:
#include "gi
You might want to add this to
http://git.zx2c4.com/cgit/about/faq
git checkout wiki
vim faq
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Seems most straight forward to just copy git's behavior elsewhere to
cgit -- i.e. originator's timestamp.
Though, if git itself is configurable via local-time, then we too should be.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailm
Merged, thanks.
I'll be out of town for a week. When I return, some more merging should
occur.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Anybody have any objections to this? In some cases it's slightly more
verbose, but otherwise, I can't see any downsides.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
I've put them in this branch with a few fixes:
http://git.zx2c4.com/cgit/log/?h=jk/http-status-codes
Feel free to send diffs I should squash into any of these commits.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgi
On Sun, Apr 5, 2015 at 5:54 PM, John Keeping wrote:
>
> +void cgit_print_error_page(int code, const char *msg, const char *fmt,
> ...)
> +{
> + va_list ap;
> + ctx.page.status = 404;
> + ctx.page.statusmsg = "Not found";
>
Shouldn't status = code here, not hardcoded 404?
___
Thanks, merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi folks,
CGit 0.11.2 is now available, with numerous bug fixes.
== CGit on the Web ==
* homepage: http://git.zx2c4.com/cgit/about/
* git repository: http://git.zx2c4.com/cgit/
* git clone: git://git.zx2c4.com/cgit
* mailing list: cgit@lists.zx2c4
Oh, hah, my pipermail does the same. That's annoying. I'll change up the
release announcement next time to avoid that.
On Mar 9, 2015 11:32 PM, "Jason A. Donenfeld" wrote:
>
> On Mar 9, 2015 9:49 PM, "John Keeping" wrote:
> > It turns out that GMa
On Mar 9, 2015 9:49 PM, "John Keeping" wrote:
> It turns out that GMane mangles the list address in the message,
Better archives:
http://lists.zx2c4.com/pipermail/cgit/
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/c
On Mar 8, 2015 12:35 AM, "Todd Zullinger" wrote:
> But while we're on the subject, are there PGP signatures available for
the cgit tarballs themselves?
I include a sha256 of the tarball in the announcement emails. Those emails
are pgp signed. My pgp key is embedded in the repo, as well, and it's
Great idea. Merged. Thanks John.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi folks,
CGit 0.11.1 is now available, with some important bug fixes, as well as
tweaks done for the new gitweb.gentoo.org site.
== CGit on the Web ==
* homepage: http://git.zx2c4.com/cgit/about/
* git repository: http://git.zx2c4.com/cgit/
* git
This commit breaks ui-tag. The first few lines of tag messages are cut off.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
The one behind this:
http://git.zx2c4.com/json/projects
and
http://git.zx2c4.com/json/random-code
It's like 20 lines long and sort of trivial, not worth cleaning up for release.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/li
Hi guys,
The Gentoo infra team has been sending me bug reports that I've been
fixing in the master branch. Gentoo is in the process of rolling out a
cgit instance on http://gitweb.gentoo.org/ , which is actually some
pretty significant progress for the project, considering CVS is still
used for al
This would indeed be quite nice. I'll look into it for 0.12.
Currently I'm just running a python web app on top of it to do the trick.
Not great, but it gets the job done.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo
Thanks! Merged. It would be nice to see a test case built out of the
example you gave in the commit message.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
That's a pretty super dense commit, but it looks good to me after a read
through. I'm going to merge this, but if somebody else wants to give it a
pair of eyes, that'd be welcomed.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/
Feel free to send a patch, John.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi folks,
CGit 0.11.0 is now available, with lots of bug fixes, and some nice new
nobs to turn, all rebased on the latest Git 2.3.0.
== CGit on the Web ==
* homepage: http://git.zx2c4.com/cgit/about/
* git repository: http://git.zx2c4.com/cgit/
*
Good thinkin, Lincoln.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
http://git.zx2c4.com/cgit/commit/?id=d28bf255cd5ae2e73911975fc77f9b0a84c61a78
Fixed.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged thanks.
Still no luck with the other bug. Working on it now.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
zx2c4@thinkpad ~ $ git clone http://git.zx2c4.com/cgit
Cloning into 'cgit'...
error: Unable to find 59d05d38a587430748a47ac3b28916fd6b5c52be under
http://git.zx2c4.com/cgit
Cannot obtain needed object 59d05d38a587430748a47ac3b28916fd6b5c52be
while processing commit 32dbeaee7f76df2175363629d8bb20bb7
Merged, thanks.
Release coming soon!
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Looks good. Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Seems perfect to me. Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Wed, Jan 28, 2015 at 2:16 PM, Christian Hesse wrote:
> "Jason A. Donenfeld" on Wed, 2015/01/28 13:46:
>
> > If there are any patches I've missed recently, please poke me.
>
> How about the kernel.org's libravatar script and css?
>
I actually stea
Hi folks,
It's been a while since the last release. The next one is going to be out
when git 2.3.0 comes out, as Christian has been working on support for the
alphas.
If there are any patches I've missed recently, please poke me.
Jason
___
CGit mailing
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Mon, Jan 19, 2015 at 6:13 PM, Lukas Fleischer
wrote:
>
> Please check my reply to v2 of Florian's patch, almost everything in
> http-backend.c is static which makes this difficult. We would need to
> convince Junio (the current Git maintainer) to make those functions
> public and probably send
Do we really want to be enabling git-receive-pack? Seems like in its
present form, this could lead to some unexpected security results...
More generally, is this the right approach? Since we're linking against
git's sources anyway, couldn't any enhanced functionality be included
within cgit by cal
On Mon, Dec 29, 2014 at 5:56 PM, Florian Pritz wrote:
>
> +http-backend-path::
> + Path to the git-http-backend smart HTTP backend binary.
> +http-backend-path=/usr/lib/git-core/git-http-backend
>
Instead of all this, why not just a:
execlp("git", "git", "http-backend", NULL);
This leaves
Works well, thanks John. Applied and pushed.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
301 - 400 of 708 matches
Mail list logo