Re: [PATCH] Simplify http_parse_querystring()

2016-09-29 Thread Jason A. Donenfeld
This looks sane to me. It results in more allocations, but I think that's a moot point compared to the nice code simplifications and deduplication. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH] Simplify http_parse_querystring()

2016-09-29 Thread Lukas Fleischer
Instead of reimplementing URL parameter parsing from scratch, use url_decode_parameter_name() and url_decode_parameter_value() which are already provided by Git. Also, change the return type of http_parse_querystring() to void since its only caller already ignores the return value. Signed-off-by: