Re: [PATCH] cache: Tolerate short writes in print_slot

2022-05-07 Thread Jason A. Donenfeld
On Sat, May 7, 2022 at 11:32 PM Hristo Venev wrote: > I submitted it earlier today. > > https://lists.zx2c4.com/pipermail/cgit/2022-May/004723.html Thanks. Went to spam because the DKIM signature failed. Jason

Re: [PATCH] cache: Tolerate short writes in print_slot

2022-05-07 Thread Jason A. Donenfeld
Hi Hristo, On Thu, Oct 7, 2021 at 5:45 PM Hristo Venev wrote: > I will fix this in v2. I'm finally culling patches for cgit. Did you want to submit a v2 of this patch? Jason

Re: [PATCH] cache: Tolerate short writes in print_slot

2021-10-07 Thread Hristo Venev
On Thu, 2021-10-07 at 10:35 +0100, John Keeping wrote: > Have you seen these errors in practice, or is this just theoretical? > > In recent (since v2.6.33) versions of Linux, all files should support > sendfile(), especially since we expect out_fd to be a socket or pipe. Even though I haven't

Re: [PATCH] cache: Tolerate short writes in print_slot

2021-10-07 Thread John Keeping
On Fri, Sep 10, 2021 at 05:18:41PM +0300, Hristo Venev wrote: > sendfile() can return after a short read/write, so we may need to call > it more than once. Furthermore, not all files support sendfile(), so we > may need to fall back to read/write. Have you seen these errors in practice, or is

[PATCH] cache: Tolerate short writes in print_slot

2021-09-10 Thread Hristo Venev
sendfile() can return after a short read/write, so we may need to call it more than once. Furthermore, not all files support sendfile(), so we may need to fall back to read/write. On the read/write path, use write_in_full which deals with short writes. Signed-off-by: Hristo Venev --- cache.c |