Re: [PATCH 0/4] adding color to ui-blame

2017-10-15 Thread Jason A. Donenfeld
Hi Jeff, Oh, cool. What's your idea for accomplishing that? Planning on putting it through the filter, buffering it, and then spitting it back out in equal sized chunks, hoping the filter doesn't add extra new lines? Jason ___ CGit mailing list CGit@lis

Re: [PATCH 0/4] adding color to ui-blame

2017-10-15 Thread Jeffrey Smith
That seems like it could be valuable work, but FWIW I have been working on a different solution to adding syntax highlighting to the blame page. I hope to have it ready (at least a prototype) in the next day or two. On Oct 15, 2017 11:47 AM, "Jason A. Donenfeld" wrote: > Right, we may very well

Re: [PATCH 0/4] adding color to ui-blame

2017-10-15 Thread Jason A. Donenfeld
Right, we may very well need a more capable model. One approach would be to get rid of all the exec stuff, and instead have plugins, that can register themselves in all sorts of places. A plugin would define a series of hooks and filters, which would be directly called at the right time. We'd expa

Re: [PATCH 0/4] adding color to ui-blame

2017-10-14 Thread John Keeping
On Sat, Oct 14, 2017 at 04:17:46PM +0200, Jason A. Donenfeld wrote: > This patch set is currently broken, because in the exec filter, > processes like to buffer their output. The result is that the text winds > up at the bottom: > > https://git.zx2c4.com/cgit/blame/cache.c > > If anybody ha

[PATCH 0/4] adding color to ui-blame

2017-10-14 Thread Jason A. Donenfeld
This patch set is currently broken, because in the exec filter, processes like to buffer their output. The result is that the text winds up at the bottom: https://git.zx2c4.com/cgit/blame/cache.c If anybody has some ideas on how we might enact a flush operation, please pipe up (hah). Jas