Re: [PATCH 0/5] Add ui-blame

2017-10-03 Thread Jeffrey Smith
Jason, I looked at that at one point, and as I recall, it was not going to work because, as things currently stand, the source code gets broken up into chunks. I will take a look at it again, but the only way that comes to mind will require some creativity with style-sheets and such. On Tue,

Re: [PATCH 0/5] Add ui-blame

2017-10-03 Thread Jason A. Donenfeld
Merged to master. Working quite nicely: https://git.zx2c4.com/cgit/blame/ui-shared.c Jeff -- do we want to be passing this through the source code filter to get highlighted lines? ___ CGit mailing list CGit@lists.zx2c4.com

Re: [PATCH 0/5] Add ui-blame

2017-10-03 Thread John Keeping
On Tue, Oct 03, 2017 at 01:29:59AM +0200, Christian Hesse wrote: > Jeffrey Smith on Mon, 2017/10/02 17:35: > > From what I can see, it appears that it is in ch/for-jason. > > > > Also, I noticed a typo in my html_ntxt patch: > > ssize_t slen = (size_t) len; > >should be >

Re: [PATCH 0/5] Add ui-blame

2017-10-02 Thread Christian Hesse
Jeffrey Smith on Mon, 2017/10/02 17:35: > From what I can see, it appears that it is in ch/for-jason. > > Also, I noticed a typo in my html_ntxt patch: > ssize_t slen = (size_t) len; >should be > ssize_t slen = (ssize_t) len; > > Do I need to resend, or can someone fix

Re: [PATCH 0/5] Add ui-blame

2017-10-02 Thread Jeffrey Smith
>From what I can see, it appears that it is in ch/for-jason. Also, I noticed a typo in my html_ntxt patch: ssize_t slen = (size_t) len; should be ssize_t slen = (ssize_t) len; Do I need to resend, or can someone fix that one up for me? -- Jeff On Mon, Oct 2, 2017 at 12:34 AM, Christian

Re: [PATCH 0/5] Add ui-blame

2017-10-01 Thread Christian Hesse
"Jason A. Donenfeld" on Mon, 2017/10/02 03:17: > Jeff -- thanks for your hard work on this. Another thanks from me! > John -- thanks for the review. Same here... You beat me doing the review. > If you'd like to put this in a > for-jason branch, I'll get to merging it soon. I