Re: [PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

2016-05-12 Thread Jason A. Donenfeld
On Wed, May 11, 2016 at 7:50 PM, Juuso Lapinlampi wrote: > - cgit_print_docstart(); > - cgit_print_pageheader(); > + cgit_print_layout_start() > va_start(ap, fmt); You forgot a semicolon. Please test your commits before you submit. Otherwise you waste everyone's time. F

Re: [PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

2016-05-12 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

2016-05-11 Thread John Keeping
On Wed, May 11, 2016 at 05:50:09PM +, Juuso Lapinlampi wrote: > --- > This may be a little controversial, but right now is there a reason not > to do this? No, I think this makes sense (although again we need your signed-off-by). Reviewed-by: John Keeping > ui-shared.c | 6 ++ > 1 file

[PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

2016-05-11 Thread Juuso Lapinlampi
--- This may be a little controversial, but right now is there a reason not to do this? ui-shared.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui-shared.c b/ui-shared.c index 9a38aa9..d9541f0 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -792,13 +792,11 @@ void cgit