Re: [PATCH v3 2/4] ui-patch.c: Use log_tree_commit() to generate diffs

2013-08-20 Thread Jason A. Donenfeld
http://git.zx2c4.com/cgit/patch/?id=wip&id2=master This appears to work! Apparently some tests need to be updated: not ok 7 - generate patch for initial commit # # cgit_query "url=foo/patch&id=$root" >tmp # not ok 8 - find `cgit` signature # # tail -1 tmp | grep "^cg

Re: [PATCH v3 2/4] ui-patch.c: Use log_tree_commit() to generate diffs

2013-08-20 Thread Jason A. Donenfeld
Great. This series is now in wip. Test test test! ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH v3 2/4] ui-patch.c: Use log_tree_commit() to generate diffs

2013-08-20 Thread Lukas Fleischer
Instead of using our own formatting, use log_tree_commit() from Git to create patches. This removes unnecessary duplicate code and also fixes a bug with e-mail address formatting that existed in our own implementation. Signed-off-by: Lukas Fleischer --- This should work with noplainemail. We shou