Hi all,
Here's a pretty simple patch for #1109. This simply catches any
exceptions that occur during retrieval of http locations (it already
handles svn and local files differently: there it checks first whether
the source exists before creating the target dir), and then removes
the directory if
On Mon, Jul 21, 2014 at 09:37:07PM +0200, Peter Bex wrote:
> I've tested the patch, and it indeed seems to fix this particular
> situation. Somehow I thought this would break dynamically linked
> builds, as there's no libchicken.dll, only cygchicken-0.dll. However,
> *somehow* dynamic binaries ar
On Sun, Aug 3, 2014 at 3:35 PM, Peter Bex wrote:
> On Sun, Aug 03, 2014 at 03:20:50PM +0200, Michele La Monaca wrote:
>> Another twist. Basically the same patch but with a more robust path
>> manipulation strategy.
>
> Yeah, I was wondering why you were using string-append and friends
> to manipul
On Sun, Aug 03, 2014 at 03:32:15PM +0200, Peter Bex wrote:
> I've also tested the code on Windows. Here's the new version.
By the way, with this change actually _fixing_ stuff instead of
just removing the procedure altogether, I think this patch *should*
go into the stability branch.
Cheers,
Pet
On Sun, Aug 03, 2014 at 03:20:50PM +0200, Michele La Monaca wrote:
> Another twist. Basically the same patch but with a more robust path
> manipulation strategy.
Yeah, I was wondering why you were using string-append and friends
to manipulate paths :)
I don't understand why you treat the extensio
On Sun, Aug 03, 2014 at 11:04:21AM +0200, Michele La Monaca wrote:
> On Sun, Aug 3, 2014 at 3:01 AM, Mario Domenech Goulart
> wrote:
> > ...
> > If I understand correctly, at this point the code is subject to race
> > conditions, which is one of the things mkstemp prevents.
>
> Yes, actually a st
Another twist. Basically the same patch but with a more robust path
manipulation strategy.
Regards,
Michele
On Sun, Aug 3, 2014 at 11:04 AM, Michele La Monaca
wrote:
> On Sun, Aug 3, 2014 at 3:01 AM, Mario Domenech Goulart
> wrote:
>> ...
>> If I understand correctly, at this point the code is
On Sun, Aug 3, 2014 at 3:01 AM, Mario Domenech Goulart
wrote:
> ...
> If I understand correctly, at this point the code is subject to race
> conditions, which is one of the things mkstemp prevents.
Yes, actually a stupid one which can be avoided, I think. Attached a
revisited patch which should a
