Re: [Chicken-hackers] [MEGA-PATCH] Modularise the compiler!

2014-09-13 Thread Peter Bex
On Thu, Sep 04, 2014 at 01:02:18AM +0200, Felix Winkelmann wrote: Hello! I have signed off a squash commit of all your changes and pushed it to a new branch (chicken-5). I have a proposal for more meaningful module names, though, and I will post a patch in the next days. Thanks for

[Chicken-hackers] [PATCH(5)] Add allocation size helpers C_SIZEOF_STRUCT and C_SIZEOF_CLOSURE

2014-09-13 Thread Peter Bex
Hi all, While working on the numbers egg, I noticed we don't have a size calculation macro for record types and closures. Attached is a patch to add these. Please note that the size calculation of the closure in C_call_with_cthulhu was wrong, as well as the allocation in handle_interrupt

Re: [Chicken-hackers] [MEGA-PATCH] Modularise the compiler!

2014-09-13 Thread Felix Winkelmann
I did wonder why you squashed the commits; like I said, I put a lot of effort into making them self-contained (and every single commit compiles and passes the testsuite). By squashing them, it becomes one big blob commit. If this commit introduces a bug, git bisect will be mostly useless,

Re: [Chicken-hackers] [PATCH(5)] Add allocation size helpers C_SIZEOF_STRUCT and C_SIZEOF_CLOSURE

2014-09-13 Thread Felix Winkelmann
While working on the numbers egg, I noticed we don't have a size calculation macro for record types and closures. Attached is a patch to add these. Please note that the size calculation of the closure in C_call_with_cthulhu was wrong, as well as the allocation in handle_interrupt (including

Re: [Chicken-hackers] [PATCH(5)] Removed #+debugbuild map-se duplication and corrected typo in modules.scm

2014-09-13 Thread Felix Winkelmann
From: Arthur Maciel arthurmac...@gmail.com Subject: [Chicken-hackers] [PATCH(5)] Removed #+debugbuild map-se duplication and corrected typo in modules.scm Date: Sat, 13 Sep 2014 17:08:58 -0300 Dear chickeneers, This is just a cosmetic patch to correct a typo and remove a function definition

Re: [Chicken-hackers] [PATCH(5)] Add allocation size helpers C_SIZEOF_STRUCT and C_SIZEOF_CLOSURE

2014-09-13 Thread Peter Bex
On Sat, Sep 13, 2014 at 11:30:20PM +0200, Felix Winkelmann wrote: Ok. The former really allocates a slot too much, but that makes no difference besides wasting a word in the nursery. Not too much of a problem, but it would increase the minor GC frequency, even if by a little bit. The latter

Re: [Chicken-hackers] [PATCH(5)] Add allocation size helpers C_SIZEOF_STRUCT and C_SIZEOF_CLOSURE

2014-09-13 Thread Peter Bex
BTW, has this patch not been pushed yet? -- http://www.more-magic.net ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers