Re: [Chicken-hackers] [PATCH][5] Some FFI improvements

2017-05-31 Thread lemonboy
Hello folks, I've just discovered some nasty regressions caused by the second patch so please hold on before applying it; I'm also withdrawing the third patch as I've managed to get the scrutinizer to infer the correct types for the ffi stubs with just a minimal amount of changes, I need to test

Re: [Chicken-hackers] [PATCH][5] Some FFI improvements

2017-05-30 Thread LemonBoy
On 05/29, Peter Bex wrote: > On Sun, May 28, 2017 at 11:29:06PM +0200, lemonboy wrote: > > Hello hackers, > > Hi Lemonboy, > > Thanks (again!) for your patches. You're really putting in quite > the effort. > Thanks for the kind words :) > I have two comments about the patch, and a more generic

Re: [Chicken-hackers] [PATCH][5] Some FFI improvements

2017-05-29 Thread Peter Bex
On Sun, May 28, 2017 at 11:29:06PM +0200, lemonboy wrote: > Hello hackers, Hi Lemonboy, Thanks (again!) for your patches. You're really putting in quite the effort. > I'll be brief: > - The first patch fixes a problem where we'd fail to consider the > internal defines as toplevel ones, >

[Chicken-hackers] [PATCH][5] Some FFI improvements

2017-05-28 Thread lemonboy
Hello hackers, I'll be brief: - The first patch fixes a problem where we'd fail to consider the internal defines as toplevel ones, leading to a compiler error. - The second patch complements the first by rejecting more `define-` forms in non-toplevel contexts. - The third one is slightly beefier