Re: [Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-16 Thread felix . winkelmann
> > > On Apr 15, 2016, at 18:46, felix.winkelm...@bevuta.com wrote: > > > > Another dirty solution would be to add a hack to those tools that invoke > > uninstalled > > programs via system(3) to invoke "env DYLD_LIBRARY_PATH=... " > > instead. > > > > In limited testing the env approach seems

Re: [Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-15 Thread Jim Ursetto
> On Apr 15, 2016, at 18:46, felix.winkelm...@bevuta.com wrote: > > Another dirty solution would be to add a hack to those tools that invoke > uninstalled > programs via system(3) to invoke "env DYLD_LIBRARY_PATH=... " > instead. > In limited testing the env approach seems to work. But, I ca

Re: [Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-15 Thread felix . winkelmann
> > But I don’t think there is any way to override the shell called via system(3) > as a workaround, nor should there be. > > A possibly better solution would be to include the absolute path to > libchicken.dylib > in the test version of that library, or in the tested binaries using > install_n

Re: [Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-15 Thread Jim Ursetto
> On Apr 15, 2016, at 02:21, Peter Bex wrote: > >> just to let "make check" >> work on an OS as deliberately broken as OS X. Isn't there some other way? > > We could add a note to the README stating you have to disable this > broken feature. That would be just like on Windows, where we have a

Re: [Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-15 Thread Peter Bex
On Fri, Apr 15, 2016 at 09:14:25AM +0200, felix.winkelm...@bevuta.com wrote: > > This is an initial patchset for #1277 on which I invite comments. > > Note that I'm currently revamping the chicken-5 egg setup stuff, which means > that > shell command execution will be significantly changed in tha

Re: [Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-15 Thread felix . winkelmann
> This is an initial patchset for #1277 on which I invite comments. Note that I'm currently revamping the chicken-5 egg setup stuff, which means that shell command execution will be significantly changed in that part (and will probably not need such a change as you here propose.) I must say tha

Re: [Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-14 Thread Jim Ursetto
Already found a bug in the Windows code of course. This patch replaces the setup-api 0003 patch from the last message. I will try to get a Windows VM running so I can test this myself. On Thu, Apr 14, 2016 at 3:22 PM, Jim Ursetto wrote: > This is an initial patchset for #1277 on which I invi

[Chicken-hackers] [PATCH] #1277 make check failure on OS X 10.11

2016-04-14 Thread Jim Ursetto
This is an initial patchset for #1277 on which I invite comments. The problem was correctly diagnosed in that OS X 10.11 blacklists certain environment variables such as DYLD_LIBRARY_PATH from being passed to trusted binaries, and /bin/sh is trusted. This prevents `make check` from working. The