[Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread Oleg Kolosov
Hello, seeing the patches flowing, I’ve decided to give it a try too, and push few things related to the MS Visual Studio support. This one is pretty harmless, just to check the process out. I have patched few other things in the core (like cond fixes, nan/inf handling, removed gcc specifics, a

Re: [Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread Peter Bex
On Sun, Oct 19, 2014 at 06:02:45PM +0400, Oleg Kolosov wrote: > Hello, seeing the patches flowing, I’ve decided to give it a try too, and > push few things related to the MS Visual Studio support. > > This one is pretty harmless, just to check the process out. Hello Oleg, Thanks for the patch,

Re: [Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread Oleg Kolosov
On 19 Oct 2014, at 18:17, Peter Bex wrote: > > On Sun, Oct 19, 2014 at 06:02:45PM +0400, Oleg Kolosov wrote: >> Hello, seeing the patches flowing, I’ve decided to give it a try too, and >> push few things related to the MS Visual Studio support. >> >> This one is pretty harmless, just to check

Re: [Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread Peter Bex
On Sun, Oct 19, 2014 at 07:24:23PM +0400, Oleg Kolosov wrote: > On 19 Oct 2014, at 18:17, Peter Bex wrote: > > Thanks for the patch, it looks good. I've pushed it to master and > > chicken-5. Please note that this is not the best test for the process, > > because we normally require double sign-

Re: [Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread Oleg Kolosov
On 19 Oct 2014, at 19:32, Peter Bex wrote: > > On Sun, Oct 19, 2014 at 07:24:23PM +0400, Oleg Kolosov wrote: >> >> Do you mean that I should sign-off by myself and ask somebody on IRC to >> review and sign-off too? I’ve looked on http://wiki.call-cc.org/contribute - >> it says “send them to th

Re: [Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread John Cowan
Peter Bex scripsit: > I'd hesitate to apply them, because we wouldn't be able to maintain > them. We'd need msvc support so we can verify things still work if > we change things up. Do you think you could write a Windows Makefile > which uses the msvc compiler? That is what CMake does anyway: i

Re: [Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread Felix Winkelmann
> I agree. The current Chicken build system is admirable in its simplicity. > There is no reason why a Windows make file and associated .h file couldn't > be bundled with Chicken after being generated offline by CMake. I don't think CMake is intended to be used this way - there may be system-spec

Re: [Chicken-hackers] [PATCH] Add missing "C_" prefix to a snprintf calls in a tcp module

2014-10-19 Thread Oleg Kolosov
On 19 Oct 2014, at 21:23, John Cowan wrote: > > Peter Bex scripsit: > >> I'd hesitate to apply them, because we wouldn't be able to maintain >> them. We'd need msvc support so we can verify things still work if >> we change things up. Do you think you could write a Windows Makefile >> which us