Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-26 Thread Peter Bex
On Sun, Mar 17, 2013 at 03:18:49PM +0100, Jörg F. Wittenberger wrote: > I'm not sure either. > > Just I'm currently suffering from tcp-connect issues I have > not yet been able to track down. At one hand it seems > to block the whole threading system to the point of > unusable while tcp-connect c

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-18 Thread Jim Ursetto
On Mar 18, 2013, at 5:50 AM, Florian Zumbiehl wrote: > [Jim wrote:] >> I was hoping you would just confirm you are experiencing the same problem >> before I spend more time on it. > > So, you want me to verify that your patch does not help? I am slightly > confused ... Sorry, that sentence was a

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-18 Thread Felix
From: Florian Zumbiehl Subject: Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts Date: Mon, 18 Mar 2013 11:50:46 +0100 > Hi, > >> On Mar 17, 2013, at 1:58 AM, Florian Zumbiehl wrote: >> >> > If you cannot be sufficiently sure >> > that your approa

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-18 Thread Florian Zumbiehl
Hi, > On Mar 17, 2013, at 1:58 AM, Florian Zumbiehl wrote: > > > If you cannot be sufficiently sure > > that your approach is correct to be willing to build a full fix on it > > without testing first, I would consider that a sign that the approach is > > too fragile to rely on, at least without

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-17 Thread Jim Ursetto
On Mar 17, 2013, at 1:58 AM, Florian Zumbiehl wrote: > If you cannot be sufficiently sure > that your approach is correct to be willing to build a full fix on it > without testing first, I would consider that a sign that the approach is > too fragile to rely on, at least without a good reason. I

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-17 Thread Jörg F . Wittenberger
MHO - since the whole thing does'nt really work.) On Mar 16 2013, Felix wrote: From: Florian Zumbiehl Subject: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts Date: Sat, 16 Mar 2013 17:56:41 +0100 Add (declare (disable-interrupts)) to tcp so that errno doesn't get changed at in

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-17 Thread Jörg F . Wittenberger
On Mar 17 2013, Florian Zumbiehl wrote: Somehow, this feels to me like you are applying test driven development techniques to concurrency correctness. Are you sure that your reasoning is correct and reliable and future-proof? Are the assumptions you make about the compiler true now for sure and

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-16 Thread Florian Zumbiehl
Hi, > I'm positive the race conditions have to do with errno, > which is incompatible with SRFI-18 threads. For example > in the connect loop, there are two possible context > switches in which errno can get overwritten: > > 1) On entrance to (fail), prior to ##sys#update-errno > 2) Inside (fail

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-16 Thread Jim Ursetto
+ host port) (let ((err (get-socket-error s))) (cond ((fx= err -1) (##net#close s) On Mar 16, 2013, at 4:37 PM, Felix wrote: > From: Florian Zumbiehl > Subject: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts > Date: Sat, 16 Mar 2013 17:56

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-16 Thread Felix
From: Florian Zumbiehl Subject: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts Date: Sat, 16 Mar 2013 17:56:41 +0100 > Add (declare (disable-interrupts)) to tcp so that errno doesn't get changed at > inappropriate points during execution. > --- > > I don't really

[Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-16 Thread Florian Zumbiehl
Add (declare (disable-interrupts)) to tcp so that errno doesn't get changed at inappropriate points during execution. --- I don't really have a clue whether this is the correct way to do it, but the code that was breaking before is not breaking anymore with this patch applied ... tcp.scm |1