Re: [PATCH] Fix #1757 by not merging module environment into the syntactic environments of reexported macros

2021-07-31 Thread Peter Bex
On Sat, Jul 31, 2021 at 04:05:52PM +1200, Evan Hanson wrote: > I was wondering whether there are any implications in changing the order > of the `sexports` field of the module, now that we're putting all > "normal" syntax exports before any re-exported ones. However, after a > bit of digging, I don

Re: [PATCH] Fix #1757 by not merging module environment into the syntactic environments of reexported macros

2021-07-30 Thread Evan Hanson
On 2021-07-14 12:45, Peter Bex wrote: > Here's a reasonably straightforward patch (I hope) for #1757. > Commit should speak for itself, even if the stuff itself is > a bit tricky. It really is, this took some time to understand... But it does seem like the right thing, now that you've spelled it o

[PATCH] Fix #1757 by not merging module environment into the syntactic environments of reexported macros

2021-07-14 Thread Peter Bex
Hi all, Here's a reasonably straightforward patch (I hope) for #1757. Commit should speak for itself, even if the stuff itself is a bit tricky. I'm not 100% sure about the other places where "sexps" is used, if we should use the local macros only there, or not. All the tests seem to work if we k