[chromium-dev] Re: Concerning HelpWanted tags

There's actually a lot of useful things in this email for someone to learn if they're seeking to become a more regular contributor. On Thu, Apr 30, 2009 at 10:29 PM, Mohamed Mansour wrote: > I usually browse the issue tracker for HelpWanted tags, and try to solve > those bugs. It would be great i

[chromium-dev] Re: Discussion to take over #chrome on irc

On Thu, Apr 30, 2009 at 10:35 PM, Jason A. Spiro wrote: > Some people don't even know what Chromium is, and want to just type > "/join #chrome" on Freenode and have it work. I don't want those people in #chromium either. IRC is absolutely the wrong method for support. Encouraging that makes ev

[chromium-dev] Concerning HelpWanted tags

Hi Chromium, I usually browse the issue tracker for HelpWanted tags, and try to solve those bugs. It would be great if more HelpWanted tags would be tagged, so we can have more variety of bugs to fix. It would be nice if anyone in the team could go through them and decide whether that bug is _reall

[chromium-dev] Re: Discussion to take over #chrome on irc

On Thu, Apr 30, 2009 at 9:42 PM, Mohamed Mansour wrote: > Hi Chromium users, there has been some discussion on IRC regarding > redirecting users from #chrome to #chromium, etc. Please take a look at > http://code.google.com/p/chromium/issues/detail?id=7776 for the feature > request. > > As user o

[chromium-dev] Discussion to take over #chrome on irc

Hi Chromium users, there has been some discussion on IRC regarding redirecting users from #chrome to #chromium, etc. Please take a look at http://code.google.com/p/chromium/issues/detail?id=7776 for the feature request. As user on irc (Jason Spiro) stated that would you (Chromium) would like to t

[chromium-dev] Re: CoInitialize gone from the renderer

On Thu, Apr 30, 2009 at 3:13 PM, Peter Kasting wrote: > On Thu, Apr 30, 2009 at 1:50 PM, cpu wrote: >> >> In http://src.chromium.org/viewvc/chrome?view=rev&revision=14983 I >> removed a CoInitialize()/CoUnInitialize() pair in the renderer process >> of your favorite browser. > > Does this make s

[chromium-dev] Re: depricating CppBindingClass

On Thu, Apr 30, 2009 at 9:46 AM, Marshall Greenblatt wrote: > > > Speaking of V8 APIs, I notice that v8::FunctionTemplate::New() takes a > Handle |data| attribute as the second parameter. Is it correct to > assume that this Handle can later be retrieved by the > InvocationCallback function via a

[chromium-dev] Re: CoInitialize gone from the renderer

On Thu, Apr 30, 2009 at 1:50 PM, cpu wrote: > In http://src.chromium.org/viewvc/chrome?view=rev&revision=14983 I > removed a CoInitialize()/CoUnInitialize() pair in the renderer process > of your favorite browser. Does this make starting a renderer process any faster? PK --~--~-~--~--

[chromium-dev] Clobber your Window build.

Once again, I've checked in an IDL change. And as you may remember, we don't track this dependency very well in Windows build. Thus, please clobber your local build after syncing :) :DG< --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegr

[chromium-dev] Re: BUG= formatting

I'm not likely to want to type bugs.chromium.org every time ;-) -Ben On Thu, Apr 30, 2009 at 2:06 PM, Wan-Teh Chang wrote: > On Thu, Apr 30, 2009 at 1:50 PM, Ben Goodger (Google) > wrote: >> >> Hint: >> >> If you write your changelist bug line like this: >> >> http://crbug.com/7991 >> >> inst

[chromium-dev] Re: BUG= formatting

On Thu, Apr 30, 2009 at 1:50 PM, Ben Goodger (Google) wrote: > > Hint: > > If you write your changelist bug line like this: > > http://crbug.com/7991 > > instead of like this: > > BUG=7991 > > your bug line will be linkified and clickable in numerous places (like > the buildbot pages, Rietveld, t

[chromium-dev] BUG= formatting

Hint: If you write your changelist bug line like this: http://crbug.com/7991 instead of like this: BUG=7991 your bug line will be linkified and clickable in numerous places (like the buildbot pages, Rietveld, the issue tracker, etc). -Ben --~--~-~--~~~---~--~

[chromium-dev] CoInitialize gone from the renderer

In http://src.chromium.org/viewvc/chrome?view=rev&revision=14983 I removed a CoInitialize()/CoUnInitialize() pair in the renderer process of your favorite browser. This should be the last one of them. COM should now be unusable from the renderer. As far as I can see, this was a leftover and we d

[chromium-dev] Re: Today we run zero LayoutTests in chrome

In retrospect, this would probably be better as a V8 extension behind a command-line flag. That's probably what Darin meant to begin with. ;-) Erik On Thu, Apr 30, 2009 at 1:32 PM, Erik Kay wrote: > If anyone is interested in doing this extension work, come find myself or > Aaron. It's gettin

[chromium-dev] Re: Today we run zero LayoutTests in chrome

If anyone is interested in doing this extension work, come find myself or Aaron. It's getting easier to add extension APIs. We'd be happy to show you how. Erik On Thu, Apr 30, 2009 at 11:37 AM, Darin Fisher wrote: > I think if we should definitely make it possible to run layout tests in > Chro

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

The story is even simpler for localStorage. Everything is fairly self contained and the only way it cares about the main thread is in asserts to verify SQLite is not used on the main thread. My guess is that the story for what's considered the main thread will change for each API much like the spl

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

On Thu, Apr 30, 2009 at 12:26 PM, Michael Nordman wrote: > On Thu, Apr 30, 2009 at 11:40 AM, Darin Fisher wrote: >> On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman wrote: >>> >>> On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman >>> wrote: >>> > >>> > + chromium-dev >>> > >>> >> Can you please e

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

On Thu, Apr 30, 2009 at 11:40 AM, Darin Fisher wrote: > On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman wrote: >> >> On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman >> wrote: >> > >> > + chromium-dev >> > >> >> Can you please explain what you think has changed since such decisions >> >> were ma

[chromium-dev] Re: Today we run zero LayoutTests in chrome

It doesn't take much of layoutTestController to run most of the LayoutTests. At one point, I had a student implement the low hanging fruit as a Firefox extension. Adam On Thu, Apr 30, 2009 at 11:37 AM, Darin Fisher wrote: > I think if we should definitely make it possible to run layout tests

[chromium-dev] Re: Today we run zero LayoutTests in chrome

Making layoutTestController a loadable module (which ideally upstream DRT and our test_shell or chrome could share) would be ideal IMO. -eric On Thu, Apr 30, 2009 at 11:37 AM, Darin Fisher wrote: > I think if we should definitely make it possible to run layout tests in > Chrome.  However, suppo

[chromium-dev] Re: Need help in finding a performance problem...

As an intermediate point of reference, looking at the calls to RenderWidget::DidInvalidateRect() and tracing the cases where the new rect doesn't intersect with the current paint_rect, I get the following results: Without the resizer rect: (0, 0, 743, 633) not in (0, 0, 0, 0) (362, 8, 1, 1) not in

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman wrote: > > On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman > wrote: > > > > + chromium-dev > > > >> Can you please explain what you think has changed since such decisions > were made (or why it's time to revisit such decisions)? > > > > I don't thi

[chromium-dev] Re: Today we run zero LayoutTests in chrome

I think if we should definitely make it possible to run layout tests in Chrome. However, supporting all of layout test controller will be a considerable amount of work, and I think we always want to maintain the simpler test_shell environment for exercising webkit divorced from the rest of chrome

[chromium-dev] Re: depricating CppBindingClass

+1, though this means the final nail in the coffin for chrome+jsc since the layout test controller is written using CppBindingClass. -Darin On Tue, Apr 28, 2009 at 6:15 PM, Mike Belshe wrote: > I've felt this way for a while, and I figured I'd throw it out to see if we > all agree. > I'm hoping

[chromium-dev] 2.0.177.1 Released to Dev Channel

Google Chrome 2.0.177.1 has been released to the Dev channel. It includes a number of fixes and a couple UI tweaks. For example, if you have searched from wikipedia.org in the past, start typing wikipedia.org in the omnibox, press the Tab key then a search term and suggestions and past searches wi

[chromium-dev] Re: depricating CppBindingClass

On Thu, Apr 30, 2009 at 1:51 PM, Matt Perry wrote: > On Wed, Apr 29, 2009 at 6:47 PM, Marshall Greenblatt < > magreenbl...@gmail.com> wrote: > >> 3. Is there a way to specify native getter/setter functions for a property >> defined on the JS side? For instance, "myobject.foo = bar" would somehow

[chromium-dev] Re: Need help in finding a performance problem...

Salut Adam, this is a theory that I'm currently validating... And I will try to change the IPC message code to confirm that it will resolve the problem... So I guess you don't see any problem in this approach... So if I succeed, now I know who to ask for a code review :-) Thanks! BYE MAD On

[chromium-dev] Re: Need help in finding a performance problem...

Salut Aaron, no, this is not recent... This is something that was encountered a while back and put on a shelf because it wasn't critical... I'm now taking it off the shelf and trying to put an end to it :-) Thanks! BYE MAD On Thu, Apr 30, 2009 at 1:56 PM, Aaron Boodman wrote: > Was this a r

[chromium-dev] Re: Need help in finding a performance problem...

Was this a recent regression? I made some changes in that area recently to support transparent webviews. I tried not to change anything in the case where transparency is not needed, but I imagine this could have been me. Here is the change: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/

[chromium-dev] Re: depricating CppBindingClass

On Wed, Apr 29, 2009 at 6:47 PM, Marshall Greenblatt wrote: > 3. Is there a way to specify native getter/setter functions for a property > defined on the JS side? For instance, "myobject.foo = bar" would somehow > call a natively defined "setFoo" function with the "bar" argument. If this > isn'

[chromium-dev] Re: Need help in finding a performance problem...

On Thu, Apr 30, 2009 at 7:51 AM, Marc-Andre Decoste wrote: >    An alternative could be to send a bitmap the size of the union rect, but > only paint the individual rects in it, and extract them individually on the > other side of the IPC... But I wonder if it would be worth the added > complexit

[chromium-dev] Re: Need help in finding a performance problem...

Thanks Mike, Others can correct me if I'm wrong, but we do indeed call Layout on the webwidget (which will do the recursive layout of all frames, from the main_frame() down through its children) before actually painting from within RenderWidget::DoDeferredPaint(). And about the list of indiv

[chromium-dev] Re: Setting Default Search Engine

Hi, Chromium doesn't support "window.external.AddSearchProvider" , it supports the OpenSearch specification. And your right, it doesn't work for slashdot.org, you can create a new bug request issue here: http://code.google.com/p/chromium/issues/entry

[chromium-dev] Re: Tech talk videos

Thanks for putting these up! Thanks for all the presenters! On Wed, Apr 29, 2009 at 9:04 PM, Jeremy Orlow wrote: > Just wanted to let everyone know that we posted videos of 5 tech talks > related to Chromium. There's a blog post on the Chromium Blog ( > http://blog.chromium.org/2009/04/chromi

[chromium-dev] Re: depricating CppBindingClass

On Wed, Apr 29, 2009 at 10:48 PM, Aaron Boodman wrote: > On Wed, Apr 29, 2009 at 7:41 PM, Mike Belshe wrote: > > On Wed, Apr 29, 2009 at 6:47 PM, Marshall Greenblatt > >> 3. Is there a way to specify native getter/setter functions for a > property > >> defined on the JS side? For instance, "myo

[chromium-dev] Re: depricating CppBindingClass

On Wed, Apr 29, 2009 at 10:41 PM, Mike Belshe wrote: > On Wed, Apr 29, 2009 at 6:47 PM, Marshall Greenblatt < > magreenbl...@gmail.com> wrote: > >> Hi All, >> >> I'm excited about using v8::Extension instead of CppBoundClass but the >> JavaScript side of v8::Extension (via the |source| argument)

[chromium-dev] Re: How can I run TestShell in Xcode on MacOS

When in doubt, read the website: http://code.google.com/p/chromium/wiki/MacBuildInstructions TVL On Wed, Apr 29, 2009 at 9:53 PM, daniel wrote: > > Hi, > > How can I run TestShell in Xcode on MacOS? Which xcode project I > should use? > > I find these: > ./src/base/base.xcodeproj > ./src/breakp

[chromium-dev] Re: How can I run TestShell in Xcode on MacOS

src/webkit/tools/test_shell/test_shell.xcodeproj On Wed, Apr 29, 2009 at 9:53 PM, daniel wrote: > How can I run TestShell in Xcode on MacOS? Which xcode project I > should use? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Dev