[chromium-dev] Re: Cannot use "gcl change", svn fails. Any help is appreciated ...

On Wed, May 27, 2009 at 11:23 AM, Mohamed Mansour wrote: > Hi, > Today I am trying to submit another patch, and it is not allowing me to do > that, it somewhat fails. I am trying to do the following: > > gcl change 11435 > > > It brings up notepad and I add my stuff as I normally do. Then I save a

[chromium-dev] Re: UI_test.exe fails to complete (please help)

thanx wan, after setting chromium as the def browser i now only have 1 test that fails [ RUN ] UnloadTest.BrowserCloseTabWhenOtherTabHasListener ..\..\browser\unload_uitest.cc(349): error: Value of: popup_title Actual: L"" Expected: std::wstring(L"popup") Which is: L"popup" [ FAILED ] Un

[chromium-dev] Re: UI_test.exe fails to complete (please help)

i have the missing info the test which requires a manual "leave this page" click by me is UnloadTest.BrowserCloseTwoSecondBeforeUnload --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or un

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

*A totally uninformed comment* If a hardlink is an issue due to package manager, why not use a shell script? Could bash not be present on a system with X installed? That'd be surprising. $ cat /usr/bin/chrome #!/bin/sh # Call the right version here: /usr/bin/chrome2.0.1.2 $* No need for zygote wit

[chromium-dev] Re: Cannot use "gcl change", svn fails. Any help is appreciated ...

Hi, The thing that puzzles me is that gclient sync works fine in both platforms, and the initial "gcl change " works fine. It only fails if I lint, change, or upload that CL. I guess I will just keep a single source, and use gclient/gcl only in linux (while I could build in windows and linux),. -

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

[and now to the list, grr] The problem with that, and with the hard link, is that the package manager cleans up the old version when the update happens, so it's no longer available to run. (And if we tried to keep them around, we'd have a garbage collection problem.) It just doesn't fit well, t

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

On Wed, May 27, 2009 at 7:11 AM, Dan Kegel wrote: > The problem with that, and with the hard link, is that the > package manager cleans up the old version > when the update happens, so it's no longer available > to run.  (And if we tried to keep them around, we'd > have a garbage collection probl

[chromium-dev] Re: reminder: don't use CHECK()

I attempted to add to http://sites.google.com/a/chromium.org/dev/developers/coding-style but !...@#@!...@#! sites in its typically infuriating way made it so I couldn't add text after the last bit I added -- clicking the "unindent" button would move my cursor a paragraph up -- so I will leave it a

[chromium-dev] Documentation about Linux crash dumping

I wrote up how crash dumping on Linux currently works (with cross-process dumping etc): http://code.google.com/p/chromium/wiki/LinuxCrashDumping AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change emai

[chromium-dev] Re: reminder: don't use CHECK()

Thanks for trying I want to amend what you wrote since it doesn't really capture the common usage of CHECK to help track down crashers, etc. Also, the statement that we should always recover from a failed DCHECK seems very wrong to me. I don't think it is a good idea to try to recover from al

[chromium-dev] Re: reminder: don't use CHECK()

On Wed, May 27, 2009 at 11:42 AM, Darin Fisher wrote: > Also, the statement that we should always recover from a failed DCHECK > seems very wrong to me. > I agree, we should almost never recover from a DCHECK. 90+% of the time, DCHECK is better than "if (condition) { NOTREACHED(); try_to_contin

[chromium-dev] Re: reminder: don't use CHECK()

On Tue, May 26, 2009 at 11:31 PM, Brett Wilson wrote: > Don't bother doing an assertion when the next line will crash anyway: > DCHECK(foo); > foo->DoSomething(); > will normally crash pretty obviously dereferencing a NULL pointer > (even though it will be inside DoSomething). Well, that all

[chromium-dev] Re: reminder: don't use CHECK()

On Wed, May 27, 2009 at 11:56 AM, Amanda Walker wrote: > I'd be much happier if DCHECK exited immediately rather than relying on the > code to crash, or we insisted that code using DCHECK *always* attempt to > recover. > Yeah, it seems that relying on the code to crash by itself after a DCHECK i

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

On Tue, May 26, 2009 at 1:06 PM, Adam Langley wrote: > On Tue, May 26, 2009 at 12:00 PM, Dan Kegel wrote: >> http://codereview.chromium.org/115773 is my try at >> fixing http://crbug.com/11841 ("autoupdate broke my browser", >> familiar to anyone who's used Firefox on Linux). > > Zygotes ... mig

[chromium-dev] Re: reminder: don't use CHECK()

It is a nice idea to try to recover from all DCHECKs, but what happens is that you end up with excessive and redundant checking at runtime. It leads to bloat, complexity, and degrades readability (obscuring the code). Those are not good things for a codebase. To be clear, I think we should always

[chromium-dev] Re: reminder: don't use CHECK()

On Wed, May 27, 2009 at 11:56 AM, Amanda Walker wrote: > On Tue, May 26, 2009 at 11:31 PM, Brett Wilson wrote: >> >> Don't bother doing an assertion when the next line will crash anyway: >>  DCHECK(foo); >>  foo->DoSomething(); >> will normally crash pretty obviously dereferencing a NULL pointer

[chromium-dev] Re: reminder: don't use CHECK()

On Wed, May 27, 2009 at 3:20 PM, Darin Fisher wrote: > I think if we require everyone to handle every failed DCHECK, then what we > will really do is compel people to write fewer DCHECKs, which means that we > will lose some of the documentation benefits. That seems undesirable to me. > I agree

[chromium-dev] Important: User visible UI changes must be discussed with the UI folk

This has happened a couple of times now. If you're adding any visible user interface, even if it's just a checkbox to the advanced page of Options, you must discuss it with: myself (ben@) Glen Murphy (glen@) Nick Baum (nickbaum@) Brian Rakowski (brian@) first. If you don't, it's highly likely th

[chromium-dev] chrome://downloads/ behaviour (some suggestions and a bug, i think)

for the last few days (and for sure on 3.0.183.0 (16994)) you stopped showing the DL speed on that tab (unless the size of the download is not known) i actually like the consistent look of FF with the / () feel also, as this issue reports, http://code.google.com/p/chromium/issues/detail?id=12610

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any

[chromium-dev] How can i listen for page load complete event

Hi, In chromium how can I listen for page load complete event (i.e the whole page (including iframe/frame) is done loading and CSS is parsed and built /JS are executed). Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.

[chromium-dev] Chromium 1 process per tab architecture

Hi, My understanding is chromium has 1 process per tab architecture. My question is does chromium has the capability/functionality to: 1. if a process/tab runs away (in an infinite loop and taking all cpu) or hangs (block waiting for something for some reason, chromium will kill that process/tab? 2

[chromium-dev] Are we now using Visual Studio 2008?

I've been working on a private branch for a while now and recently did a sync. When I try to open chrome.sln in VS 2005, it complains that it can't parse version numbers. Apparently the project files have been upgraded to 9.0? Did I miss the announcement that we were going to VS 2008? --~--~--

[chromium-dev] Re: Are we now using Visual Studio 2008?

On Wed, May 27, 2009 at 1:36 PM, Book'em Dano wrote: > Did I miss the announcement that we were going to VS > 2008? Not that I know of. Perhaps your local copy is modified somehow? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googleg

[chromium-dev] Re: Are we now using Visual Studio 2008?

The version of chrome.sln on the trunk (http://src.chromium.org/viewvc/ chrome/trunk/src/chrome/chrome.sln?view=markup) contains Microsoft Visual Studio Solution File, Format Version 9.00 This would seem to indicate VS 2008, no? On May 27, 1:43 pm, Peter Kasting wrote: > On Wed, May 27, 2009 at

[chromium-dev] Re: Are we now using Visual Studio 2008?

On Wed, May 27, 2009 at 1:46 PM, Book'em Dano wrote: > > The version of chrome.sln on the trunk (http://src.chromium.org/viewvc/ > chrome/trunk/src/chrome/chrome.sln?view=markup) contains > Microsoft Visual Studio Solution File, Format Version 9.00 snip> > > This would seem to indicate VS 2008, n

[chromium-dev] Re: Are we now using Visual Studio 2008?

GYP detects if you have VS2008 installed and defaults to that over 2005. To force 2005 set this in your environment before building: GYP_MSVS_VERSION=2005 If you don't have 2008 installed: * close visual studio (important) * revert changes to build files you might have locally * gclient sync * gc

[chromium-dev] Re: Chromium 1 process per tab architecture

See http://dev.chromium.org/developers/design-documents/multi-process-architecture and http://dev.chromium.org/developers/design-documents/process-models These are on http://dev.chromium.org/ by clicking on For Developers and then

[chromium-dev] Re: Are we now using Visual Studio 2008?

So sverrir's suggestion is right idea. Currently gyp is detecting and emitting 2005/2008 based on what you have installed. Once chrome.sln is eaten this should allow people to use either, but currently if you have 2008 installed it changes lower level stuff but the checked in sln is still at 2005.

[chromium-dev] Re: reminder: don't use CHECK()

On Wed, May 27, 2009 at 11:42 AM, Darin Fisher wrote: > The fear of crashing is overblown.  Information about bad states is far more > valuable. > > I'd much rather read blog comments from users saying that Chrome crashes too > much than hear about hangs, dead clicks, or other misbehaving non-cra

[chromium-dev] Re: chrome://downloads/ behaviour (some suggestions and a bug, i think)

>From what I understand from your email, you're asking for consensus about the following aspects of download progress, please correct me if I'm wrong or if there are additional issues: * DL speed isn't reported for items of a known size (regression) - [yoav: is there a bug open for this?] * Change

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

So do we send a CL to all of you guys or just one? Assuming all of you touched it. -- Mohamed Mansour On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) wrote: > > Also FYI, > > If you're just porting existing UI to a different platform, no need to > discuss with us. Same thing if it's a plat

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

It would save effort if you discussed the changes you plan to make before writing code. Otherwise just drop us an email and point to the CL (screenshots help, as not all of the team are engineers). On Wed, May 27, 2009 at 2:19 PM, Mohamed Mansour wrote: > So do we send a CL to all of you guys or

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

I want to stress this point. It's always best to discuss any change in Chrome code with others before you invest a lot of time on it. You will doubtless get helpful feedback and there's a high likelihood you'll save a lot of time. -Ben On Wed, May 27, 2009 at 2:23 PM, Glen Murphy wrote: > > It

[chromium-dev] Re: chrome://downloads/ behaviour (some suggestions and a bug, i think)

Jeremy, you got my points right however issue 4718, seems to have been solved in my eyes by looking at static std::wstring FormatTimeImpl(const TimeDelta& delta, FormatType format_type) and by running 3.0.183.0 (16972) and actually downloading a file but the w

[chromium-dev] Fixing our keyboard handling act on OSX

Hi All, We currently fudge our keyboard handling on OSX, we interpret command key shortcuts ourselves and thus miss out on quite a few Cocoa text handling niceities. We also don't support IMEs. Relevant bugs: http://crbug.com/10862 - OS X: Can't use command-key shortcuts with foreign keyboard lay

[chromium-dev] Re: Are we now using Visual Studio 2008?

You said Currently gyp is detecting and emitting 2005/2008 based on what you have installed. When you say gyp, I'm assuming you mean that some program is interpreting the *.gyp files (e.g. chrome.gyp) and then using these files to generate the project files? What program is doing this and how do

[chromium-dev] Re: Are we now using Visual Studio 2008?

They use http://code.google.com/p/gyp/ it generates the projects for you. GYP automatically detects 2005/2008 based on what you have installed. If you want to force it to use a specific environment, you can do what sverrir stated, set your environment variable GYP_MSVS_VERSION=2005, which works gr

[chromium-dev] Re: Chromium 1 process per tab architecture

Those documents are certainly the best place to go to understand the process architecture (since it's not strictly process-per-tab, but that is an easy way to think about it). I think the answers to your specific questions are (1) yes, Chromium will prompt you if a rendering engine process becomes

[chromium-dev] Re: Are we now using Visual Studio 2008?

It gets run automatically on a gclient sync when gyp files have changed. You can run it explicitly with: gclient runhooks --force -BradN On Wed, May 27, 2009 at 5:13 PM, Mohamed Mansour wrote: > They use http://code.google.com/p/gyp/ it generates the projects for you. > GYP automatically detects

[chromium-dev] Unittesting python

Do we have any unittest support for python in the chromium code base? I did a find ./ -name '*test*.py' and didn't find much. I'm writing a tool to auto-gen some stub code, and didn't see a clear test framework to hook into. -Albert --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Chromium 1 process per tab architecture

On Wed, May 27, 2009 at 5:15 PM, Charles Reis wrote: > Those documents are certainly the best place to go to understand the process > architecture (since it's not strictly process-per-tab, but that is an easy > way to think about it). > I think the answers to your specific questions are (1) yes,

[chromium-dev] Re: Unittesting python

Usually we use the default unittest framework that comes with python http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/scripts/master/unittests/ http://src.chromium.org/viewvc/chrome/trunk/src/PRESUBMIT_unittest.py?view=markup gclient also has a bunch of tests: http://code.google.com/p/g

[chromium-dev] Where is the integration point betwee chromium and V8

Hi, i am trying to understand how chromium passes JS script node/JS file to v8 engine for execution. So i setup breakpoints in Xcode with test)shell xcode project opened: Compiler::Compile Compiler::CompileEval Compiler::CompileLazy And then I 'build and go (debug)' to get a TestShell. It did st

[chromium-dev] Question about Multi-process Architecture document

I am reading the Chroimum Multi-process Architecture document. http://dev.chromium.org/developers/design-documents/multi-process-architecture In the architecture diagram, it has component like RenderProcess RenderProcessHost RenderViewHost RenderView But when i do a 'find' to look for the code f

[chromium-dev] Re: Question about Multi-process Architecture document

Try render_process.cc, render_process_host.cc, etc. RenderView.cpp is something entirely different. Adam On Wed, May 27, 2009 at 11:20 PM, Daniel Dreiberg wrote: > > I am reading the Chroimum Multi-process Architecture document. > http://dev.chromium.org/developers/design-documents/multi-proc

[chromium-dev] Re: Where is the integration point betwee chromium and V8

Hi, There must be something wrong with your setting of break points. There is only on way of getting JavaScript code into V8 from a client application, and that is through the static method v8::Script::Compile in the public API. This method is defined in api.cc where it in turn calls v8::internal: