[chromium-dev] Re: chrome-bisect.py: Mac Chrome Continuous Build Archive Bisecting

2009-06-05 Thread Evan Martin
Robert's script bisects over binaries, while git bisects over source. Since our tree takes so long to build, git bisect hasn't been too helpful in my experience. On Fri, Jun 5, 2009 at 10:56 PM, Jeremy Moskovich wrote: > That's great and I don't mean to belittle the awesomeness of this in any way

[chromium-dev] Re: chrome-bisect.py: Mac Chrome Continuous Build Archive Bisecting

2009-06-05 Thread Jeremy Moskovich
That's great and I don't mean to belittle the awesomeness of this in any way but: git has built-in support for this along with many other advantages over SVN, I use git along with the gitx gui on OSX and it's greatly increased my productivity. It would make me much happier if more people on the te

[chromium-dev] chrome-bisect.py: Mac Chrome Continuous Build Archive Bisecting

2009-06-05 Thread Robert Sesek
Tonight I wrote a Python script called chrome-bisect.py that performs a binary search on the Mac continuous build archive. It takes a starting known-good and bad revision and then downloads, unzips, and opens the archived builds for you. You can then test the running build and report back to chrom

[chromium-dev] Re: Print Settings Mockup

2009-06-05 Thread Mohamed Mansour
I really like the mock-up, when can you do one for Settings? If we are going to include settings to this page (such as margins, headers, footers, etc), does that mean it would be per page? I was thinking of global printer settings which will be persistent. I don't know how that will fit this mock-u

[chromium-dev] Re: Fixing our keyboard handling act on OSX

2009-06-05 Thread Zhe Su
Hi, I'm interested in working with you on the IME support issue, especially on Linux. I just read attached document, and following are some of my questions and information: 1. How about the support of "on-the-spot" mode (preedit/composition) and surrounding text? Which require more events than k

[chromium-dev] Re: Collapsed view of our waterfall

2009-06-05 Thread Mohamed Mansour
I always use that view as well :) for over a month. Nice job Nicolas! -- Mohamed Mansour On Fri, Jun 5, 2009 at 8:12 PM, Nicolas Sylvain wrote: > > > On Fri, Jun 5, 2009 at 4:29 PM, Ben Goodger (Google) wrote: > >> >> It'd be cool if it at least had a URL so one could bookmark it. > > > It sets

[chromium-dev] Re: Collapsed view of our waterfall

2009-06-05 Thread Nicolas Sylvain
On Fri, Jun 5, 2009 at 4:29 PM, Ben Goodger (Google) wrote: > > It'd be cool if it at least had a URL so one could bookmark it. It sets a cookie. You don't have to set it everytime. But yeah, a flag would be nice too. Nicolas > > > -Ben > > On Fri, Jun 5, 2009 at 4:27 PM, Eric Roman wrote: >

[chromium-dev] Re: Collapsed view of our waterfall

2009-06-05 Thread Ben Goodger (Google)
It'd be cool if it at least had a URL so one could bookmark it. -Ben On Fri, Jun 5, 2009 at 4:27 PM, Eric Roman wrote: > > Sweetness! > I didn't know about that either. > > /me votes for making collapsed view the default since one generally > doesn't want to see the descriptions unless something

[chromium-dev] Re: Collapsed view of our waterfall

2009-06-05 Thread Eric Roman
Sweetness! I didn't know about that either. /me votes for making collapsed view the default since one generally doesn't want to see the descriptions unless something broke. On Fri, Jun 5, 2009 at 4:16 PM, Finnur Thorarinsson wrote: > It seems that every week I get around 2-3 people walking past

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread nakro
Peter, hope its not a double post, i did nuke my debug folder and i had VS close while i did the gclient revert and sync and all the rest of them --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email opt

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread nakro
yes peter, i did, in windows "jargon" i "rd /q /d Debug" and VS was as close as can be again, i do not wish you waste your time, all i want to hear is that one of you has 2008SP1 and can(!) compile it, and then i will know it is not some GYP problem, but my machine --~--~-~--~~---

[chromium-dev] Collapsed view of our waterfall

2009-06-05 Thread Finnur Thorarinsson
It seems that every week I get around 2-3 people walking past my monitors asking "Whoa! How did you get this cool view of the build tree waterfall?!" What they are referring to is the *merged* view of Nicolas' awesome waterfall console view (the one that doesn't contain all the changelist descript

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread Peter Kasting
On Fri, Jun 5, 2009 at 4:14 PM, nakro wrote: > and i did > gclient revert > gclient sync --force > gclient runhooks --force But did you do "rm -rf Debug Release"? That's usually the right answer for build failures. That and "You didn't have VS open while syncing, did you" PK --~--~-

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread nakro
i have 17796 (from 2 hours back) but the problems started today or yesterday i only take from http://build.chromium.org/buildbot/continuous/LATEST/REVISION but anyways it should have compiled do you have VS2008SP1 and you can compile ? if so, i know that something in my installation is wrong (ev

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread Nicolas Sylvain
People were getting the same error when we introduced tcmalloc a long time ago. (40 days ago). the fix was this one : http://codereview.chromium.org/92037 It required a clobber build... When is the last time you synced? Nicolas On Fri, Jun 5, 2009 at 3:58 PM, nakro wrote: > > for chrome_dll

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread nakro
Thanx elliot, but this is why i specified i use 2008, and i know you have no build bots for it 2005 is not an option for me, i am "stuck" with 2008 pro, and again, i don't wish to waste your time on helping me fix it, just to know if i am the only one so i know where to look for the problems --~-

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread Elliot Glaysher (Chromium)
Works for me. Synced yesterday. MSVS2005. -- Elliot On Fri, Jun 5, 2009 at 3:58 PM, nakro wrote: > > for chrome_dll.vcproj : > >>tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc already defined >>in libcmt.lib(malloc.obj) > and many others related to libcmt . > > i really want

[chromium-dev] Build errors with VS2008SP1

2009-06-05 Thread nakro
for chrome_dll.vcproj : >tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc already defined >in libcmt.lib(malloc.obj) and many others related to libcmt . i really want to know if i am the only one getting this because if so, this means something is very wrong with my config (i d

[chromium-dev] Re: Buffed-data-source Question

2009-06-05 Thread Andrew Scherkus
BufferedDataSource acts as a sliding window and only buffers a portion of the media file in memory. Hope that helps, Andrew On Fri, Jun 5, 2009 at 3:50 AM, mr wrote: > > Does buffered data source cache entire media data, e.g. a 2GB file? or > just part of it? > > BR > Mary > > > > > --~--~-

[chromium-dev] Re: Is there a way to change the order in which individual unit tests are run?

2009-06-05 Thread Evan Martin
/me is impressed at your VB skillz On Fri, Jun 5, 2009 at 12:48 PM, Marc-Antoine Ruel wrote: > > Or you can use this sick macro: > http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros#Run_the_currently_selected_google_test > > On Fri, Jun 5, 2009 at 3:44 PM, Pam Greene wrote: >> Reo

[chromium-dev] Re: Is there a way to change the order in which individual unit tests are run?

2009-06-05 Thread Marc-Antoine Ruel
Or you can use this sick macro: http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros#Run_the_currently_selected_google_test On Fri, Jun 5, 2009 at 3:44 PM, Pam Greene wrote: > Reordering is awkward (basically, edit the source file to reorder or disable > some), but you can run only t

[chromium-dev] Re: Is there a way to change the order in which individual unit tests are run?

2009-06-05 Thread Pam Greene
Reordering is awkward (basically, edit the source file to reorder or disable some), but you can run only the CommandLine tests by appending this to your (hah) command line: --gtest_filter=CommandLine.* In VS, go to the project properties for base_unittests, pick Debugging, and put that in as the

[chromium-dev] Permissive code review try job status

2009-06-05 Thread Marc-Antoine Ruel
You may have realized that the try job status may now be green even if some tests failed. The reason is simple; http://since chromium-status.appspot.com/lkgr is only looking at some steps (namely unit_tests), it didn't make sense to blame the user for failed steps that may be red on the trunk. Thi

[chromium-dev] Is there a way to change the order in which individual unit tests are run?

2009-06-05 Thread Book'em Dano
As an example, let's say I'm making some changes to CommandLine. As part of these changes, I'm wanting to run base_unittests. However, it's super annoying that I have to wait a few minutes while the other unit tests within this suite are run before the CommandLine unit test is hit. Is there a way

[chromium-dev] Build Bots

2009-06-05 Thread Thomas Van Lenten
Just a quick heads up, a new block of Mac Mini's are now online on both the main waterfall and the fyi waterfall. We now have builders/testers for a bunch of configs, as well as some jobs split between machines. Hopefully this will lower the Mac cycle times. This also gets the perf data we collec

[chromium-dev] Re: New views::Menu API

2009-06-05 Thread Elliot Glaysher (Chromium)
I wasn't happy doing a direct port of the old Menu to GTK. This sounds a lot better. -- Elliot On Fri, Jun 5, 2009 at 12:34 AM, Ben Goodger (Google) wrote: > > As part of the TOOLKIT_VIEWS work some of the long time deficiencies > of the existing views::Menu API have come to a head. I think it

[chromium-dev] Re: Fixing our keyboard handling act on OSX

2009-06-05 Thread Avi Drissman
Very interesting writeup. Some thoughts: You don't touch on how Safari on the Mac handles this case. It seems to overlap with some of the work that Jeremy was doing based on his discoveries in WebKit's WebHTMLView.mm. Where does its _interceptEditingKeyEvent get called? Synthesizing CHAR events i

[chromium-dev] Re: Fixing our keyboard handling act on OSX

2009-06-05 Thread Evan Martin
For what it's worth, the current Linux key-handling code was not written too carefully -- we've kinda tweaked it until it seemed to work without analyzing what Windows does too carefully. Your document is very helpful, and we'll certainly take any recommendations you have on how to fix it since y

[chromium-dev] Re: chrome crashes - please help

2009-06-05 Thread Jim Roskind
+1 Please do not remove it. It is VERY valuable for development and debugging across renderer and browser. IMO, it should be maintained at least enough to mostly run (at least past startup as shown above). If this startup failure can be reproduced, it should be filed as a bug and fixed. I have l

[chromium-dev] Re: chrome crashes - please help

2009-06-05 Thread Evan Martin
On Fri, Jun 5, 2009 at 7:37 AM, Marc-Antoine Ruel wrote: > --single-process is not maintained and its tests have been downgraded to the > "For Your Information" waterfall > at http://build.chromium.org/buildbot/waterfall.fyi/waterfall > We'd probably accept patches to simply remove it or to fix it

[chromium-dev] Re: New views::Menu API

2009-06-05 Thread Evan Martin
One thing to consider is if there's any reasonable point to "cut" the API such that more menu code can be shared across platforms. It's pretty trivial to just build a simple menu (like the right-click context one for pages) directly on Linux (and surely Mac), but duplicating that sort of modely c

[chromium-dev] Re: Fixing our keyboard handling act on OSX

2009-06-05 Thread Nico Weber
Hi, re "Type ctrl-a on hebrew keyboard": On OS X, ctrl-a usually does not select all text (that's what cmd-a does) but goes to the beginning of the current line, as in emacs. But that can be overridden ( http://www.hcs.harvard.edu/~jrus/site/cocoa-text.html ). Nico 2009/6/5 Hironori Bono (坊野 博典

[chromium-dev] Re: chrome crashes - please help

2009-06-05 Thread Marc-Antoine Ruel
On Fri, Jun 5, 2009 at 6:10 AM, mailandr...@gmail.com wrote: > > Hi, > > I am getting following error when i run the chrome.exe in --single- > process switch mode. > > [5272:5864:264167375:FATAL:render_widget_host_view_win.cc(557)]Check > failed: render_widget_host_->process()->channel() > > after

[chromium-dev] Buffed-data-source Question

2009-06-05 Thread mr
Does buffered data source cache entire media data, e.g. a 2GB file? or just part of it? BR Mary --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.c

[chromium-dev] chrome crashes - please help

2009-06-05 Thread mailandr...@gmail.com
Hi, I am getting following error when i run the chrome.exe in --single- process switch mode. [5272:5864:264167375:FATAL:render_widget_host_view_win.cc(557)]Check failed: render_widget_host_->process()->channel() after pressing ok i get the message as, "Whoa! Chromium has crashed. Restart now?"

[chromium-dev] How does V8 cache for compiled script being used

2009-06-05 Thread Lucius Fox
Hi, >From this earlier message, it was mentioned that v8 has cache for compiled script. Does that mean chromium uses this v8 compiled script cache? If yes, does that mean each render process has it own cache? or all render process shared 1 cache? And does the content of the compiled script cache

[chromium-dev] New views::Menu API

2009-06-05 Thread Ben Goodger (Google)
As part of the TOOLKIT_VIEWS work some of the long time deficiencies of the existing views::Menu API have come to a head. I think it may finally be time to revisit this. The system of menu delegates, controllers, and such like are very confusing. We have an API that on one hand provides a model-l