[chromium-dev] buildbot failure in Chromium on Modules Linux, revision 27949

2009-10-03 Thread buildbot
Automatically closing tree for "compile" on "Modules Linux" http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux/builds/11700 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20Linux --=> Automatically closing tree for "compile" on "Modules Linux" <=-- R

[chromium-dev] [Linux] How did I just fix the build?

2009-10-03 Thread Peter Kasting
I checked in a commit this morning (27949) which caused linking errors for Linux. I got "undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups" in a function which had already been using that constant successfully. The commit that fixed these was: http://src.chromium.org/viewvc/c

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Dan Kegel
On Sat, Oct 3, 2009 at 10:19 AM, Peter Kasting wrote: > I checked in a commit this morning (27949) which caused linking errors for > Linux.  I got "undefined reference to > BlockedPopupContainer::kImpossibleNumberOfPopups" in a function which had > already been using that constant successfully. >

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Dan Kegel
On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel wrote: >> "undefined reference to >> BlockedPopupContainer::kImpossibleNumberOfPopups" Aha. It's a bug in our code. chrome/browser/blocked_popup_container.cc needs to follow through and actually declare storage for that variable. --~--~-~--~

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Antoine Labour
On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel wrote: > > On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel wrote: > >> "undefined reference to > >> BlockedPopupContainer::kImpossibleNumberOfPopups" > > Aha. It's a bug in our code. chrome/browser/blocked_popup_container.cc > needs to follow through and

[chromium-dev] buildbot failure in Chromium on Chromium Linux, revision 27953

2009-10-03 Thread buildbot
Automatically closing tree for "compile" on "Chromium Linux" http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux/builds/6486 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Linux --=> Automatically closing tree for "compile" on "Chromium Linux" <=--

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-03 Thread Ben Laurie
On Fri, Oct 2, 2009 at 4:20 PM, Dan Kegel wrote: > On Fri, Oct 2, 2009 at 4:02 PM, Jacob Mandelson wrote: >> Which reads like "all or nothing" to me, though I could imagine a (perverse?) >> implementation with each writer having a send buffer lower layer pulling >> data from multiple writers' se

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-03 Thread Ben Laurie
On Fri, Oct 2, 2009 at 2:34 PM, Adam Langley wrote: > On Fri, Oct 2, 2009 at 2:30 PM, Adam Langley wrote: >> There was some concern that a renderer could use sendto on a >> SOCK_DGRAM to direct packets to other destinations. However, when >> created with socketpair, this isn't an issue as I reca

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Peter Kasting
On Sat, Oct 3, 2009 at 11:59 AM, Antoine Labour wrote: > On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel wrote: > >> >> On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel wrote: >> >> "undefined reference to >> >> BlockedPopupContainer::kImpossibleNumberOfPopups" >> >> Aha. It's a bug in our code. chrome

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Jacob Mandelson
On Sat, Oct 03, 2009 at 04:25:08PM -0700, Peter Kasting wrote: > On Sat, Oct 3, 2009 at 11:59 AM, Antoine Labour wrote: > > On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel wrote: > >> On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel wrote: > >> >> "undefined reference to > >> >> BlockedPopupContainer::kI

[chromium-dev] UTF8 and Skia

2009-10-03 Thread Aaron Boodman
I'm trying to use SkCanvas::drawText() with mulitbyte UTF-8 characters, but they always come out rendered as a square box placeholder glyph. I've walked into the code and I can see that Skia is indeed parsing the UTF-8 correctly, and it comes up with the correct code point. And in SkGlyphCache, it

[chromium-dev] Re: UTF8 and Skia

2009-10-03 Thread Peter Kasting
On Sat, Oct 3, 2009 at 6:29 PM, Aaron Boodman wrote: > Does anyone know what might cause this? > CC+brettw PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://

[chromium-dev] Re: Extracting Webkit Test Shell and its dependencies

2009-10-03 Thread Pierre-Antoine LaFayette
I wanted to create a source tree separate from chrome that contains the test_shell project and any other projects it needs within chromium, nothing more. E.g. base, net, webkit etc. Wasn't sure if there is an easy way to figure out all the other projects it depends on. Actually I realized that what

[chromium-dev] Re: Extracting Webkit Test Shell and its dependencies

2009-10-03 Thread Juan Baez
The best way to figure out what projects depends on what is through the GYP project files. Look at test_shell.gyp under "./chromiumtrunk/src/webkit/tools/test_shell," it should tell you exactly what it depends on. You could also create your project and add this in your GYP file: 'depe

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Antoine Labour
On Sat, Oct 3, 2009 at 4:25 PM, Peter Kasting wrote: > On Sat, Oct 3, 2009 at 11:59 AM, Antoine Labour wrote: > >> On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel wrote: >> >>> >>> On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel wrote: >>> >> "undefined reference to >>> >> BlockedPopupContainer::kImpos

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Peter Kasting
On Sat, Oct 3, 2009 at 8:49 PM, Antoine Labour wrote: > On Sat, Oct 3, 2009 at 4:25 PM, Peter Kasting wrote: > >> You're missing the point. >> > > I don't think I am. > I'm just trying to help... I've encountered this situation many times, with > the same exact behavior, I'm trying to tell you a

[chromium-dev] Re: UTF8 and Skia

2009-10-03 Thread Adam Langley
On Sat, Oct 3, 2009 at 6:29 PM, Aaron Boodman wrote: > I double-checked that the font I'm using actually contains these > characters (by rendering them using HTML). When rendering via HTML a browser will use any font on the system which provides those codepoints. I'm not sure how one could use H

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-03 Thread Adam Langley
On Sat, Oct 3, 2009 at 3:22 PM, Ben Laurie wrote: > Why doesn't the sandbox prevent this? The SUID sandbox doesn't work that way. To be clear, the correct solution on FreeBSD is to use SOCK_DGRAM. Please don't rewrite the sandbox IPC scheme to have framing. It's a very minor security issue and