[chromium-dev] Re: converting Windows build to SCons

There are some dependency scans you can skip if you're hacking away in a single file:http://www.scons.org/doc/0.96.96/HTML/scons-user/x933.html I've found they cut down the start up time significantly, but need to be used with caution. On Fri, Nov 14, 2008 at 11:23 AM, Darin Fisher <[EMAIL PROTEC

[chromium-dev] Extending Value with std::string support

Since std::wstring isn't always necessary, I'm looking at adding std::string support to Value (base/values.h). There are four ways to go about it, in order of increasing number of changes: 1) Overload CreateStringValue, GetAsString, etc.. to also accept std::string. Add TYPE_UTF8_STRING to ValueT

[chromium-dev] Re: Extending Value with std::string support

that returns TYPE_UTF16_STRING On Mon, Dec 8, 2008 at 6:07 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > On Mon, Dec 8, 2008 at 5:28 PM, Andrew Scherkus <[EMAIL PROTECTED]>wrote: > >> 1) Overload CreateStringValue, GetAsString, etc.. to also accept >> std::s

[chromium-dev] Re: Extending Value with std::string support

> wrote: > > On Mon, Dec 8, 2008 at 6:41 PM, Andrew Scherkus <[EMAIL PROTECTED]> > > wrote: > >> > >> Darin touched upon this, who said to document that std::string should > >> refer to UTF-8 strings. > >> How about: > >> - CreateStri

[chromium-dev] Re: Extending Value with std::string support

On Mon, Dec 8, 2008 at 8:53 PM, Brett Wilson <[EMAIL PROTECTED]> wrote: > > On Mon, Dec 8, 2008 at 8:32 PM, Andrew Scherkus <[EMAIL PROTECTED]> > wrote: > > Somewhat in line with the Google style guide, the overloaded > > CreateStringValue/GetString do accompli

[chromium-dev] Re: Extending Value with std::string support

Changing the callers would be a much bigger job. If switching to std::string is something we're really interested in, then I'd view this patch as a stepping stone towards reaching that goal. I've got a change ready, but it gives you a good idea on who's using StringValue right now: http://coderev

[chromium-dev] Re: Extending Value with std::string support

Looking through some of the code again it gets a bit scary when there's code checking for TYPE_WSTRING but not the other. So how about: CreateStringValue accepts std::string and std::wstring SetString accepts std::string and std::wstring GetString can return std::string or std::wstring and uses laz

[chromium-dev] Re: Bookmark Added! GUI redesign ideas

I do like how the horizontal versions give you extra typing room and have a bit of the "long horizontal look" of the tab bar, omnibox bar and bookmark bar. Just my $0.02! Andrew On Tue, Dec 9, 2008 at 6:30 PM, Brett Wilson <[EMAIL PROTECTED]> wrote: > > Hi Simon, > > Thanks for the thoughtful m

[chromium-dev] Re: code style verification/formatting tool

Awesome! I love lint! On Wed, Dec 17, 2008 at 10:36 AM, Mohamed Mansour wrote: > Would be nice to make a gcl lint feature :) > gcl lint [mychangelist] before we submit it to codereview > > > On Wed, Dec 17, 2008 at 1:33 PM, Marc-Antoine Ruel wrote: > >> >> Yep, that's simple and neat >> >> On We

[chromium-dev] Re: Getting started, getting blocked...

Just to confirm, today I checked out two new clients on two fresh machines (Mac, Windows) and haven't had issues. Sounds like a gclient issue to me (either the configuration or the script itself). On Fri, Dec 19, 2008 at 1:09 PM, Mark Larson (Google) wrote: > > > On Fri, Dec 19, 2008 at 13:01, J

[chromium-dev] Skia YUV support

Anyone a Skia expert and know if it supports YUV? >From poking around it looks like SkBitmap assumes planar RGB and SkColorMatrix has a YUV -> RGB matrix but I can't find any examples of how to use it. Thanks, Andrew --~--~-~--~~~---~--~~ Chromium Developers mailin

[chromium-dev] Re: UTF8

I've been doing some of the wstring -> string conversions Peter mentioned. I changed Value to use UTF-8 strings, and as a result all classes that depend on it are in the process of being updated. See: http://groups.google.com/group/chromium-dev/browse_thread/thread/53b7fef96ca24212 For the most p

[chromium-dev] Re: gcl warnings about missing build system updates

The git tools are written in Python and currently re-use parts of depot_tools. 2009/1/22 Pam Greene > Sounds good. Can they call Python modules? Most of the relevant pieces > should be callable externally. > > - Pam > > 2009/1/22 Evan Martin > > It would be nice if these lint-y sorts of tools c

[chromium-dev] Re: Sending FDs between processes in the face of the OS X Sandbox.

Great! I'm really interested in using shared FDs. Just to clarify, we're unsure whether this works for Linux? Thanks again, Andrew On Mon, Jan 26, 2009 at 2:17 PM, Jeremy Moskovich wrote: > There's been discussion recently about sending FDs between processes so > that renderer processes can acc

[chromium-dev] Re: Responsibility reviewing patches with multiple reviewers

I think specifying the reviewer's responsibility in the description/message is a good start. It might also help when requesting specific feedback about design details as opposed to checking code style. Andrew On Tue, Jan 27, 2009 at 10:13 PM, Amanda Walker wrote: > > On Wed, Jan 28, 2009 at 1:0

[chromium-dev] Screengrabs of CSS + form elements

There was a panel at SXSW last week on web form elements and the joys/pains of styling and designing pages with HTML form elements. You can view the slides here: http://www.slideshare.net/teleject/web-form-design-elements Of particular interest are the screen grabs where WebKit appears different

[chromium-dev] Re: Screengrabs of CSS + form elements

ugh about the native widget set on > Windows to offer ideas on implementation differences. > > Does this make sense, or did I miss your point? > > jrg > > > On Mon, Mar 23, 2009 at 2:35 PM, Andrew Scherkus wrote: > >> There was a panel at SXSW last week on web fo

[chromium-dev] Re: src/media/

Hi peng! I'm one of the programmers working on that code. You can see how it's used by looking at the renderer process: /src/renderer/webmediaplayer_delegate_impl.cc /src/renderer/media/audio_renderer_impl.cc /src/renderer/media/data_source_impl.cc /src/renderer/media/video_renderer_impl.cc We're

[chromium-dev] Re: Buildbot "Dev View" is now the default

Sweet -- I love developer view! One question: what does the "personalized for..." text box do? Whatever I enter into it seems to throw a server side exception. Thanks, Andrew On Sat, Apr 18, 2009 at 2:33 PM, Nicolas Sylvain wrote: > Hello, > Since almost everyone prefers the new buildbot dev v

[chromium-dev] Re: Getting LOG(INFO) to print

I might have missed this memo, but why are we splitting documentation across dev.chromium.org and code.google.com? Andrew On Wed, Apr 22, 2009 at 11:37 AM, Evan Martin wrote: > > Since Pinkerton just lost some hours to this and I did again: > The secret to getting LOG(INFO) to show is to pass --

[chromium-dev] Re: Why are pref keys wchar_t's?

I once went on a mission to change Value to use UTF-8 strings, and hilariously enough after doing a few of those changes we ended up with string16. Maybe I'll go on another crusade to change Value to use string16... Anyway, the tricky part is that it's the Dictionary Value type forcing wstring. I

[chromium-dev] Passing PlatformGraphicsContext from WebKit to Chrome code

WebKit's MediaPlayerPrivate interface is a bit backwards where they pass in a GraphicsContext: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/MediaPlayer.h?view=markup We currently forward the MediaPlayerPrivate::paint(GraphicsContext* p, const IntRec

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

On Tue, May 5, 2009 at 9:49 PM, Albert J. Wong (王重傑) wrote: > On Tue, May 5, 2009 at 9:38 PM, Amanda Walker wrote: > >> Ah, I see. Hmm, going in that direction (from a GraphicsContext back >> up to the PlatformCanvas that wraps it) is an interesting question >> (the rest of our rendering code go

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

for the Mac >> platform. >> -Darin >> >> >> On Wed, May 6, 2009 at 10:40 AM, Darin Fisher wrote: >> >>> Please see WebCanvas in the WebKit API. It was designed for this. >>> -Darin >>> >>> >>> On Tue, May 5, 2009 at 5:

[chromium-dev] Re: seeking input: GYP how-to questions

I like "best practices" or "gotcha" sections, especially when there are multiple ways to accomplish the same task. For example, what's the best way to limit files to each platform? Include them all then exclude with a regexp, include the common files then include the platform-specific ones, or wh

[chromium-dev] Re: Linux build now depends on alsa

Hooray!! Getting closer... Andrew On Thu, May 21, 2009 at 1:27 PM, Albert J. Wong (王重傑) wrote: > As of r16639, the linux build now requires ALSA to build. > src/build/install-build-deps.sh has been updated with the dependency. > Please run that if the compiler starts complaining that alsa/asoun

[chromium-dev] Re: media player - can't open movie from: error

Currently you need to build your own FFmpeg binaries and have them present alongside the exe. You need to use mingw to build FFmpeg. The version we use and instructions can be found here: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/mingw/ And our FFmpeg source code can be found h

[chromium-dev] Re: media player - can't open movie from: error

t; > Mary > > On May 31, 10:33 pm, Andrew Scherkus wrote: > > Currently you need to build your own FFmpeg binaries and have them > present > > alongside the exe. > > You need to use mingw to build FFmpeg. The version we use and > instructions > > can be

[chromium-dev] Re: media player - can't open movie from: error

On Mon, Jun 1, 2009 at 7:33 AM, avcoder wrote: > > > > On May 29, 5:36 pm, mr wrote: > > Hi > > > > I compiled the media project, and run player. > > How do you compile the player? > > I open chrome.sln by VS2005, It seems that media_player.vcproj is not > included in chrome.sln > > I get a lot

[chromium-dev] Re: Buffed-data-source Question

BufferedDataSource acts as a sliding window and only buffers a portion of the media file in memory. Hope that helps, Andrew On Fri, Jun 5, 2009 at 3:50 AM, mr wrote: > > Does buffered data source cache entire media data, e.g. a 2GB file? or > just part of it? > > BR > Mary > > > > > --~--~-

[chromium-dev] Re: FYI: Layout test failures for and if you don't have FFmpeg dlls

On Fri, Jun 12, 2009 at 4:50 PM, Eric Seidel wrote: > > Can we do something nice like WebKit does and copy the dlls (from the > installed Chrome or wherever) to next to the build test_shell before > running? Recalling from memory... you should be able to specify a gyp dependency on /third_party

[chromium-dev] Errors updating depot_tools

Posting so others can benefit. Last week I started getting this error and haven't been able to find a way to get around it: $ gclient sync svn: Working copy 'C:\cygwin\home\scherkus\depot_tools' locked svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details) svn: Working copy

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

I'll see if I can repro this again before filing a bug, but similar to what Daniel and John reported, when I right click on test_shell and say Build it builds the minimal set required to fully build+link test_shell.exe However when I set test_shell as the start-up project and launch the debugger, V

[chromium-dev] Re: V8 Generated Constructors

My only quick suggestion would be: did you try a clobber build? My experience with bindings is they never seem to incrementally build or link very well :( On Thu, Jun 18, 2009 at 4:05 PM, kylep wrote: > > Ok, so. So far I've created a new file > V8HTMLAudioElementConstructor.cpp and modeled it o

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

we have some overspecified dependencies as well. > > -BradN > > > On Thu, Jun 18, 2009 at 3:49 PM, Andrew Scherkus wrote: > >> I'll see if I can repro this again before filing a bug, but similar to >> what Daniel and John reported, when I right click on test_shell and s

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

ike test_shell now have complicated names >> like "test_shell (webkit\tools\test_shell\test_shell)", and I haven't >> been able to manage supplying those on the command line. >> >> Is there a way we can get back our nice project names "test_shell", >

[chromium-dev] Re: HTML 5 and Codec in Chromium Build 3.0.191.0 (0)

Assuming Windows, you'll need to have built FFmpeg as well (our mac/linux support is a little unstable at the moment). Chromium will not enable and unless the DLLs are alongside chrome.exe. You can find instructions on how to build FFmpeg here: http://src.chromium.org/viewvc/chrome/trunk/deps/t

[chromium-dev] Re: Some projects are always out of date

I have a changelist in the works that should prevent ffmpeg_binaries from showing up. Andrew On Sun, Jul 5, 2009 at 9:50 PM, Bradley Nelson wrote: > In the case of cygwin and lastchange I think know what's going on, and > unfortunately these currently expect to always get built. > The cygwin case

[chromium-dev] Clobber third_party/ffmpeg/binaries before syncing

I just checked in a Chromium-specific version of FFmpeg that only includes Ogg+Theora+Vorbis support. If you previously had any binaries located in third_party/ffmpeg/binaries, you may have to clobber that entire directory and force sync: rm -rf third_party/ffmpeg/binaries svn co third_party/ffmpe

[chromium-dev] Re: Clobber third_party/ffmpeg/binaries before syncing

ed conditional DEPS entries to pull these > depending on platform. (See the references to cygwin in src/DEPS, for > example.) Does that make sense here? Makes sense to me. I guess I'd have to move them outside of /src though... maybe to /deps Andrew > > > On Mon, Jul

[chromium-dev] Watchlist matching any part of a path

Quick question because I have no clue where/how watchlists are implemented... According to the watchlist file, brettw is watching "base" from /src. kylep sent me a code review that only modifies touches files in /src/media/base, however brettw got added to the cc list. Is this intended behavior

[chromium-dev] Re: Chromium HTML 5 Integration using avcodec.dlls

Before we jump into debugging, where did you get your FFmpeg source code? The version and building instructions we use are documented here: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/ http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/mingw/ Andrew On Thu, Jul

[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit

Since Subversion checkouts are hermetic, you can save yourself a ton time if you manually move your LayoutTest directory to the new location before running gclient sync. On Mon, Jul 13, 2009 at 5:05 PM, Peter Kasting wrote: > On Mon, Jul 13, 2009 at 1:45 PM, Victor Wang wrote: > >> LayoutTests h

[chromium-dev] Re: LayoutTest unexpected success

Right now there's a bunch of unexpected passing media layout tests, but they should start failing again as soon as the WebKit builder bot is clobbered (we're temporarily expecting them to fail until we sort out some issues). Andrew On Tue, Jul 14, 2009 at 5:50 PM, Drew Wilson wrote: > > > On Tue

[chromium-dev] Confusing test coverage numbers

So I checked in a change that did some refactoring and added unit tests for two classes that were previously not tested: http://src.chromium.org/viewvc/chrome?view=rev&revision=20836 According to the coverage graphs, that change actually brought both the source code and test code coverage *down*.

[chromium-dev] Re: Confusing test coverage numbers

m of the link says that "coverage information was generated > Wednesday". Your checkin was Thursday. Would that have something to do > with it? > > - nick > > On Thu, Jul 16, 2009 at 12:43 PM, Andrew Scherkus > wrote: > >> So I checked in a change that

[chromium-dev] Re: Confusing test coverage numbers

an action was enough info for croc to learn the filename and > "stick", but since you reverted it didn't compile or get run. > > Let's wait one more run and see if things fix themselves. > > Ping again if the problem continues. > > jrg > > > On

[chromium-dev] Re: [PATCH] Recent modification in chromium media project breaks audio rendering, data size is always zero

Thanks for spotting this! Figures it happened in one of the files I didn't write a unit test for :) Fix is up for review: http://codereview.chromium.org/155703 Andrew On Fri, Jul 17, 2009 at 10:19 AM, Jeremy Orlow wrote: > Hi ffmpeg, :-) > Chromium doesn't accept patches like this. It's poss

[chromium-dev] Re: better commit descriptions WAS: Proposal for adding ChangeLog files to Chromium

Even though git-cl doesn't have presubmit checks per se, I do like how it forces your first line to <= 100 characters (rietveld limitation, I believe). gcl gets around this issue by truncating your description and adding an ellipsis. On Wed, Jul 22, 2009 at 2:52 PM, Darin Fisher wrote: > On Wed

[chromium-dev] Re: avoiding compile failures on buildbot

On a related note, Frank (cc'd) ran into an issue where the mac try bots have a less-strict compiler warning error than the build bots, which led to a broken build once he checked in: http://codereview.chromium.org/155834 Probably a simple config tweak somewhere, but interesting nonetheless. Andr

[chromium-dev] Re: avoiding compile failures on buildbot

t; On Thu, Jul 23, 2009 at 2:00 AM, Andrew Scherkus > wrote: > > On a related note, Frank (cc'd) ran into an issue where the mac try bots > > have a less-strict compiler warning error than the build bots, which led > to > > a broken build once he checked in: http://

[chromium-dev] Re: gyp Make breakage workaround

In command form: cd /path/to/chrome/src ./tools/gyp/gyp_chromium build/all.gyp On Fri, Jul 24, 2009 at 6:54 PM, Albert J. Wong (王重傑) wrote: > It seems like there's some bad interaction between gclient and gyp's make > build generator that got uncovered when the gyp DEPS were rolled to r555. > Th

[chromium-dev] Re: Make PostTask virtual?

I think it'd interesting to try. I imagine we'd need some helper gmock actions to take care of executing/deleting tasks. Out of curiosity, would adding a HasPendingTasks() method solve your current testing issue? On Tue, Aug 4, 2009 at 6:28 AM, Marc-Antoine Ruel wrote: > > I'm slightly against.

[chromium-dev] Re: How not to spend the day getting depot_tools, cygwin & svn to play nicely...

My experience with this is that it's either all-or-nothing when it comes to using cygwin tools. My main git-svn checkout was created using cygwin svn+python, so I now need to comment out the lines in gclient that tries to run the .bat file :\ Overall I think I'm happier with my all-cygwin client.

[chromium-dev] Re: How not to spend the day getting depot_tools, cygwin & svn to play nicely...

This thread couldn't have been more appropriately timed. I ran into the Error 34 issue again checking out a fresh client :\ Never again... http://codereview.chromium.org/164281 On Mon, Aug 10, 2009 at 11:17 AM, Jens Alfke wrote: > > On Aug 7, 2009, at 5:25 PM, Peter Kasting wrote: > > Yep. Y

[chromium-dev] Re: build error, libavcodec.so.52

We shuffled these around on Friday such that these binaries now live in /deps/third_party/ffmpeg and are pulling in via DEPS. Try: rm -rf src/third_party/ffmpeg/binaries rm .gclient_entries gclient sync --force On Mon, Aug 10, 2009 at 5:04 PM, Paweł Hajdan Jr. wrote: > Just got this error: > scon

[chromium-dev] Re: How not to spend the day getting depot_tools, cygwin & svn to play nicely...

FYI the issue should resolve itself next time you run "gclient sync" with cygwin svn:http://src.chromium.org/viewvc/chrome?view=rev&revision=23035 Let me know if you run into any issues. On Mon, Aug 10, 2009 at 3:34 PM, Andrew Scherkus wrote: > This thread couldn't have b

[chromium-dev] [HTML5] Please add HTML5 to your bugs

Jon and I were going through the video bugs this morning and realized that there is no way to easily view all HTML5-related bugs. For example video is using label:Video, workers are using label:Workers, but (to pick on Jeremy) DOM Storage uses no extra label and owner:jor...@chromium.org might not

[chromium-dev] Re: [HTML5] Please add HTML5 to your bugs

perhaps HTML5 is the wrong > name for this? Maybe "OWP" would be better since HTML5 is only a subset of > OWP?-Darin > > On Fri, Aug 14, 2009 at 4:19 PM, Andrew Scherkus wrote: > >> Jon and I were going through the video bugs this morning and realized that >> the

[chromium-dev] Re: Testing HTML5 Video tag in chromium

Right. Chromium only supports the Ogg container with Vorbis audio and Theora video. On Tue, Aug 18, 2009 at 5:43 PM, loligoth wrote: > > you mean Ogg/Theora right? I think Ogg/Vorbis is an auido codec, not a > video codec. > > On Aug 4, 9:55 am, Albert J. Wong (王重傑) wrote: > > This has come up

[chromium-dev] Coverage server reporting 403

Every so often I like peeking at the test coverage stats, but I'm seeing 403 Forbidden at the moment:http://build.chromium.org/buildbot/coverage/ Andrew --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change ema

[chromium-dev] Re: Coverage server reporting 403

Great -- thanks! Andrew On Wed, Aug 19, 2009 at 4:07 PM, Bev Cristobal wrote: > Hi Andrew. > > This has been fixed. > > - Bev > > On Wed, Aug 19, 2009 at 2:00 PM, Andrew Scherkus wrote: > >> Every so often I like peeking at the test coverage stats, but I'm se

[chromium-dev] Overloading operator<< for TimeDelta

Any opposition to globally declaring an operator<< ostream overload for TimeDelta in base/time.h? According to style guide it needs to be fully justified, but it'd be nice to use DCHECK_xx/EXEPCT_xx/ASSERT_xx with TimeDeltas. Andrew --~--~-~--~~~---~--~~ Chromium D

[chromium-dev] Re: Overloading operator<< for TimeDelta

mes seconds, sometimes milliseconds, I doubt that we want >> microseconds :-/. >> >> Explicit conversion as suggested doesn't seem that painful IMO. >> >> Jim >> >> >> On Thu, Aug 20, 2009 at 4:02 PM, Peter Kasting wrote: >> >>> On

[chromium-dev] Re: Overloading operator<< for TimeDelta

; level, and more likely you'd want something like; >> >> EXPECT_LT((kEpected - foo).InMilliseconds(), 20). >> >> ...but if you really wanted the example you cited, the first line seems >> relatively short. >> >> Jim >> >> On Thu, Aug 20, 2009

[chromium-dev] Re: [chromium-reviews] Re: WebKit deps roll 47797:47804

The media tests are highly platform specific at the moment due to differences in codec support. Keeping them lumped together under one bug works for me. Andrew On Thu, Aug 27, 2009 at 1:55 PM, Dimitri Glazkov wrote: > > Tests only pass if they are actually not loading any media. Which is a > num

[chromium-dev] Re: Linux HTML5, List of Libraries

We use FFmpeg for HTML5 audio/video. I haven't fully tested a 64-bit build of it under Linux yet. If you're interested in building the libraries you can read through the instructions: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/README.chromium?revision=25428&view=markup <

[chromium-dev] Re: JSNES: A NES emulator that runs well in Chrome

Queue complaints about :P On Thu, Sep 17, 2009 at 10:35 AM, Aaron Boodman wrote: > I was stoked to play SMB III, but without music it isn't the same :-/. > - a > > On Thu, Sep 17, 2009 at 10:14 AM, Peter Kasting wrote: > >> http://benfirshman.com/projects/jsnes/ >> "I highly recommend you use G

[chromium-dev] Re: Problem with gyp every time v8 updates their branch

One more data point: happens to me on windows and linux: $ cd src/v8 $ svn st ? tools/gyp/v8_nosnapshot.mk ? tools/gyp/v8_snapshot.mk ? tools/gyp/v8.mk ? tools/gyp/js2c.mk ? tools/gyp/v8_shell.mk ? tools/gyp/mksnapshot.mk ? tools/gyp/v8_base.mk On Wed, Sep 23, 2

[chromium-dev] Re: gclient hang

For those that use third_party/WebKit as a full WebKit checkout, you'll need to add the following line to your .gclient: "src/third_party/WebKit/WebKit/chromium": None, Andrew On Fri, Sep 25, 2009 at 11:51 AM, Marc-Antoine Ruel wrote: > > Yep, I specified one directory too deep. > > On Fri, Sep

[chromium-dev] Re: gclient hang

hromium.org/dev/developers/contributing-to-webkit > > > On Fri, Sep 25, 2009 at 12:14 PM, Andrew Scherkus > wrote: > >> For those that use third_party/WebKit as a full WebKit checkout, you'll >> need to add the following line to your .gclient: >> "src/t

[chromium-dev] Re: how to trigger a non-success status for URLRequest in unittests?

I'm not familiar with the code either, but if people are fine making URLRequest::status() virtual, you can use gmock and be done. I have a hunch there might be some push back :) If you're really interested in deterministic results, the longer way looks like you'd call RegisterRequestInterceptor()

[chromium-dev] Re: browser_tests hang on Win7

I've read somewhere before that you should do as little as possible inside DllMain. Something like this comes to mind: http://blogs.msdn.com/oldnewthing/archive/2007/09/04/4731478.aspx Is it worth trying to defer calling OleInitialize?

[chromium-dev] Unimplemented GraphicsContextSkia functions

I'm doing some UI refactoring to use GraphicsContext but noticed drawPath() is unimplemented (causes linker error). What's a good practice to implementing something no one has ever used before? Do we strive to be pixel perfect to GraphicsContextCG's implementation? I don't want to cause develope

[chromium-dev] Re: Unimplemented GraphicsContextSkia functions

On Wed, Sep 30, 2009 at 12:38 AM, Brett Wilson wrote: > On Wed, Sep 30, 2009 at 12:18 AM, Andrew Scherkus > wrote: > > I'm doing some UI refactoring to use GraphicsContext but noticed > > drawPath() is unimplemented (causes linker error). > > What's a good pra

[chromium-dev] Re: Unimplemented GraphicsContextSkia functions

The UI is a decent amount of custom drawing code inside RenderThemeChromium[Skia/Mac] and maintaining both versions is painful. > Or, were you planning on moving portions of rendering > into WebMediaPlayerClientImpl? > > -Darin > > On Wed, Sep 30, 2009 at 12:18 AM, Andrew Sch

[chromium-dev] Re: Label changes on the issue tracker

On Thu, Oct 1, 2009 at 1:22 PM, Anthony LaForge wrote: > A bit of fall cleaning. In order to clean-up the issue tracker labels a > bit and make some of the feature areas a bit more clear, I've made the > following changes: > >- Type-Task, Type-Review, and Type-Other have been removed >-

[chromium-dev] Re: [LTTF] Can someone look at some broad failure categories?

On Tue, Oct 6, 2009 at 1:07 PM, Peter Kasting wrote: > This is your friendly Chromium sheriff. I've been adding tons of > suppressions to test_expectations.txt over the last two days and they mainly > fall into three buckets. Could someone take a look at these, please, since > there are so many

[chromium-dev] Re: detecting tabs using a lot of CPU?

It'd be nice to have a non-distracting visual indicator, but to play the devil's advocate... What about intentionally CPU intensive sites that use , , WebGL? What about scenarios where it's a plugin that's gone haywire? Could this be accomplished by an extension that displays a little CPU graph?

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

On Wed, Oct 7, 2009 at 11:34 AM, Albert J. Wong (王重傑) wrote: > We just noticed that the Chromium Helper.app cannot locate the ffmpeg > binaries (libav*.dylib) in Mac Chromium. This leads to the video feature > being disabled. :( > Where should the ffmpeg binaries go? Should they be put alongside

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

On Wed, Oct 7, 2009 at 12:17 PM, Mark Mentovai wrote: > > Which processes need to load these libraries? > Render process. > Are these libraries loaded at launch time or by dlopen? > dlopen() > > Mark > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing

[chromium-dev] Re: Chrome Layout Tests Task Force status updates 10/6

The thing about the media layout tests is ~2 weeks ago all of them were failing. We've flipped switched to get them running and even after disabling a bunch due to flakiness we're still ahead -- just need to keep up the fixes. Andrew On Wed, Oct 7, 2009 at 9:36 AM, Peter Kasting wrote: > BTW, I

[chromium-dev] Re: [LTTF] Flaky tests and setTimeout

This might only apply to the media layout tests, but I'll give the heads up anyway... We found flakiness even when using load if the test is explicitly trying to test for stalled/progress/abort events before the load is completed: http://svn.webkit.org/repository/webkit/trunk/LayoutTests/media/vide

[chromium-dev] Re: [LTTF] Flaky tests and setTimeout

On Tue, Oct 13, 2009 at 3:55 PM, Ojan Vafai wrote: > On Tue, Oct 13, 2009 at 3:50 PM, Andrew Scherkus wrote: > >> What's happening is loadstart fires and the video reloads which should >> cause an abort event. For some reason load will occasionally fire after >&g

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

Hrmm... it looks your script assumes depot_tools is in your PATH -- if it can't find it the script crashes. Trying to figure out a workaround. If all else fails I can always give in and add depot_tools to my PATH :) On Wed, Oct 14, 2009 at 11:08 PM, Aaron Boodman wrote: > > Hooray, this is awes

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

On Thu, Oct 15, 2009 at 11:03 AM, Chase Phillips wrote: > Hi Andrew, > > On Wed, Oct 14, 2009 at 11:31 PM, Andrew Scherkus > wrote: > >> Hrmm... it looks your script assumes depot_tools is in your PATH -- if it >> can't find it the script crashes. > > >

[chromium-dev] Re: LTTF helping the GTTF make cycle times *minutes* faster

I'll take on the media ones. On Thu, Oct 15, 2009 at 6:38 PM, Ojan Vafai wrote: > There are a lot of tests that consistently (i.e. not flaky) timeout. They > eat up significant percentage (~10%!) of the cycle time for the test bots > (e.g., >1 minute on Windows release). If LTTF folk focus some

[chromium-dev] Re: LTTF helping the GTTF make cycle times *minutes* faster

Interesting development with the media timeout failures. Whenever you start skipping some, different media layout tests start timing out! Looks like there's some nasty threading/racing issue at play... http://code.google.com/p/chromium/issues/detail?id=25094 On Fri, Oct 16, 2009 at 3:45 PM, Erik

[chromium-dev] WebKit gardening and media layout tests

If you roll WebKit DEPS and media layout tests start failing, don't fret! Mark them as PASS FAIL and assign them to bug 13907. Don't worry about specifying the operating system or release/debug -- our code is mostly platform agnostic so if it flakily fails on one bot, it's only a matter of time be

[chromium-dev] Flaky layout tests and WebKit Linux (dbg)(3)

I've been trying to get the media layout tests passing consistently, but WebKit Linux (dbg)(3) takes an absurdly longer time to run tests and I don't know why. For example: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=video-played To keep

[chromium-dev] Re: Flaky layout tests and WebKit Linux (dbg)(3)

2009 at 12:02 PM, Nicolas Sylvain wrote: > > > On Fri, Oct 23, 2009 at 11:59 AM, Andrew Scherkus > wrote: > >> I've been trying to get the media layout tests passing consistently, but >> WebKit Linux (dbg)(3) takes an absurdly longer time to run tests and I don

[chromium-dev] Re: Flaky layout tests and WebKit Linux (dbg)(3)

On Fri, Oct 23, 2009 at 12:28 PM, Nicolas Sylvain wrote: > > > On Fri, Oct 23, 2009 at 12:21 PM, Andrew Scherkus > wrote: > >> I've never witnessed these tests taking an extra 10-20 seconds on my local >> machine, no. >> >> I don't doubt that some

[chromium-dev] Re: Flaky layout tests and WebKit Linux (dbg)(3)

On Sat, Oct 24, 2009 at 6:35 PM, Nicolas Sylvain wrote: > > > On Fri, Oct 23, 2009 at 2:16 PM, Andrew Scherkus wrote: > >> On Fri, Oct 23, 2009 at 12:28 PM, Nicolas Sylvain >> wrote: >> >>> >>> >>> On Fri, Oct 23, 2009 at 12:21 PM, Andrew

[chromium-dev] NXCOMPAT, DYNAMICBASE and you

I'm preparing to land a change to the Chromium XP and Google Chrome FYI build bots that make sure all Windows DLL and EXE files were built with /NXCOMPAT and /DYNAMICBASE. You can read about these neat security features here: http://blogs.msdn.com/vcblog/archive/2009/05/21/dynamicbase-and-nxcompat

[chromium-dev] Re: git users and svn:eol-style

I believe git-svn is incapable of handling svn properties. I usually do a follow-up TBR CL using svn to set properties, which is annoying. git-cl relies on git-svn to do the actual committing, so I think we'd be patching up git-svn to support properties. On Thu, Oct 29, 2009 at 5:13 PM, John Abd

[chromium-dev] Re: git users and svn:eol-style

On Thu, Oct 29, 2009 at 5:31 PM, Evan Martin wrote: > > On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin wrote: > > If you add the junk to your ~/.subversion/config that's specified on this > page > > http://dev.chromium.org/developers/coding-style > > then git will do the right thing as well. (I

[chromium-dev] Re: Which editor do you recommend on Mac OS X?

TextMate is pretty solid and very customizable. I wonder if we can get gyp to generate .tmproj files :P I also like it's "command line tool" mate for opening files from the Terminal. On Tue, Nov 3, 2009 at 9:56 AM, Paweł Hajdan Jr. wrote: > Recently I started working more and more on Mac OS X,

[chromium-dev] Re: Changes to using threads in the browser process

Very cool! Could this idea be done in the render process? We try to keep the media processing code off the render thread but we've been bitten using cached MessageLoops which have been destructed (usually on tab close when the render thread goes away). On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El

[chromium-dev] Re: Tech talk topics

Something that would have been immensely helpful to me when I started was a talk explaining the interaction between the javascript bindings, HTMLFooElement classes and RenderFoo classes. I'd volunteer, but I still don't know enough about this stuff myself -- other than when Foo == Media :) Andrew

Re: [chromium-dev] More sheriffs?

(resending to chromium-dev) Sheriffing the PST time zone is usually the worst. We could experiment with tweaking the scheduling algorithm to have two PST sheriffs and one non-PST sheriff per shift. Other than that -- fixing flaky tests would go a long way to making the job easier. Right now out

  1   2   >