Re: [chromium-dev] Keyboard codes to use for a chrome extension api that enables automation?

2010-01-15 Thread James Su
What's the motivation of implementing such tests as extensions? The automation framework already supports simulating keyboard events, can we just use it for such kind of tests? Regards James Su 2010/1/16 Dominic Mazzoni > The problem I have with using only explicitly defined action f

Re: [chromium-dev] "make all" doesn't work.

2009-12-03 Thread James Su
"make chrome" works as expected, it builds out the chrome binary. But "make" or "make all" doesn't work at all. - James Su 2009/12/4 Craig Schlenter > Hi > > One known problem with the make build is that you sometimes have to > run it twice to reb

Re: [chromium-dev] "make all" doesn't work.

2009-12-03 Thread James Su
Unfortunately, it doesn't work. Actually, "make" == "make all". - James Su 2009/12/4 Craig Schlenter > I think you don't need to specify a target to build everything i.e. > just type make and it should work. > > --Craig > > On Fri, Dec 4, 2009 a

[chromium-dev] "make all" doesn't work.

2009-12-03 Thread James Su
of gyp? Or I missed something? - James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Access keys are broken in 4.0

2009-11-12 Thread James Su
The accesskey logic is inside webkit, do we need discuss this issue with webkit developers? This part is actually marked as FIXME in webkit code, maybe they also want to fix it and already have some ideas. Regards James Su 2009/11/13 Peter Kasting > On Thu, Nov 12, 2009 at 4:37 PM, James

Re: [chromium-dev] Is it possible to configure/build chromium (linux) completely out of the source tree?

2009-11-12 Thread James Su
to build. > > maruel is really eager to get #2 working on windows for the trybots. A few > stumbling blocks remain there. I think the other platforms work though. Let > me know. > > -BradN > > On Wed, Nov 11, 2009 at 5:45 PM, James Su wrote: > >> Hi all, >>

Re: [chromium-dev] Access keys are broken in 4.0

2009-11-12 Thread James Su
This is caused by the fix of http://crbug.com/21624. In that issue, we agreed to let browser accelerators have higher priority than web accesskeys. Regards James Su 2009/11/13 Jeff Mikels > I don't know if people consider this a problem or not, but 4.0 > introduced new behavior for

[chromium-dev] What's the relationship between toolkit_views and chromeos gyp variables?

2009-11-11 Thread James Su
always use the native gtk implementation? And I'm also wondering the situation of linux views implementation, will it eventually replaces the native gtk implementation? Regards James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email option

Re: [chromium-dev] Is it possible to configure/build chromium (linux) completely out of the source tree?

2009-11-11 Thread James Su
Thanks, I'll have a try. - James Su 2009/11/12 Bradley Nelson > You have two options. > Both _may_ be working on linux, there is an outstanding issue to fix a > problem (at least on windows) in the second: > 1. You could muck with gyp_chromium locally and change it so -S

[chromium-dev] Is it possible to configure/build chromium (linux) completely out of the source tree?

2009-11-11 Thread James Su
ource tree untouched? Regards James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

[chromium-dev] Re: A question regarding to the keyboard event flow in the browser process.

2009-11-09 Thread James Su
em to the BrowserWindow object for real handling. Though I'm not sure if my understanding is correct or not, I'm going to implement this logic to see if it works. If you or somebody else have different understanding, please feel free to tell me. Regards James Su 2009/11/10 Nico Weber &

[chromium-dev] Re: A question regarding to the keyboard event flow in the browser process.

2009-11-09 Thread James Su
Is anybody familiar this part? - James Su 2009/11/6 James Su > (Ask this question again, in case you know the answer but missed this > thread.) > > Thanks for your clear explanation. Now I have some questions regarding to > the keyboard event flow: As I understand, a keyb

[chromium-dev] Re: Failed to run "gclient runhooks --force".

2009-11-08 Thread James Su
Thanks. I'll try. James Su 2009/11/9 Dan Kegel > On Sun, Nov 8, 2009 at 6:27 PM, James Su wrote: > > I tried to run "gclient runhooks --force" in a new copy of chromium > code, > > but got following error: > > If nobody gives better advice, I'd

[chromium-dev] Re: Failed to run "gclient runhooks --force".

2009-11-08 Thread James Su
I tried to find it in chromium-discuss group but found nothing related. Can you please give me a link? Thanks James Su 2009/11/9 Abubakar > the chromium-discuss group (chromium-disc...@googlegroups.com) has this > discussed several times I think, so if u head to google groups for th

[chromium-dev] Failed to run "gclient runhooks --force".

2009-11-08 Thread James Su
eg.gyp while loading dependencies of src/media/media.gyp while loading dependencies of src/chrome/chrome.gyp while loading dependencies of src/build/all.gyp while trying to load src/build/all.gyp' failed to run command: /usr/bin/python src/build/gyp_chromium Anyone know how to solve it? My system

[chromium-dev] Re: Preventing keypress after accellerator?

2009-11-07 Thread James Su
2009/11/8 Peter Kasting > On Fri, Nov 6, 2009 at 6:51 PM, James Su wrote: > >> One example: the default behavior of Ctrl+M keypress event is >>>> "insertNewLine", and it'll always be performed in editor_client_impl.cc if >>>> the keypress eve

[chromium-dev] Re: Preventing keypress after accellerator?

2009-11-05 Thread James Su
then let's think about how to deal with them. Regards James Su 2009/11/6 Erik Arvidsson > On Thu, Nov 5, 2009 at 17:58, James Su wrote: > >> You may refer to following bug reports: >> http://crbug.com/21624 >> http://crbug.com/21471 >> >> 2009/11/6 Erik Arv

[chromium-dev] A question regarding to the keyboard event flow in the browser process.

2009-11-05 Thread James Su
browser window, so should the TabContentsDelegate object always take charge of the unhandled keyboard event? Is it appropriate for the TabContentsView object to handle the event instead (like the current code does)? Regards James Su 2009/11/5 Ben Goodger (Google) - 隐藏引用文字 - As Mohammed notes, th

[chromium-dev] Re: Preventing keypress after accellerator?

2009-11-05 Thread James Su
You may refer to following bug reports: http://crbug.com/21624 http://crbug.com/21471 2009/11/6 Erik Arvidsson > We have code to suppress the keypress event if keydown triggered a browser > accelerator both inside and outside of WebKit. I don't understand why we > want to prevent a keypress afte

[chromium-dev] Is there any document describing the overall architecture of the browser process?

2009-11-04 Thread James Su
which both implement TabContentsDelegate interface. And how does an external tab work? 3. Does a TabContentsView always associate to a Browser? I'm wondering if there is any document to help me understand these aspects? I searched on dev.chromium.org but found nothing related.

[chromium-dev] chromium with "toolkit_views=1" crashes when inputting anything in location entry.

2009-10-14 Thread James Su
when OS_CHROMEOS is defined, and seems that it's defined when using "toolkit_views=1". However, there are many places call WidgetGtk::GetThemeProvider() and access the theme provider without check, thus cause crash. I'm wondering if it's a bug

[chromium-dev] Error when trying to build chromium with toolkit_views=1.

2009-10-13 Thread James Su
n I get it? Regards James Su --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] How to print out log message on Windows?

2009-09-28 Thread James Su
Hi, I'd like to print some log information when running Chromium on Windows. But when I ran chrome --log-level=0 in a shell, nothing was printed out. What should I do then? Regards James Su --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromiu

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-26 Thread James Su
2009/9/26 Jacob Mandelson > > On Sat, Sep 26, 2009 at 11:40:07AM -0400, Mohamed Mansour wrote: > > Hi all, (need UI team feedback and other keyboard guru's) > > We need a more coherent story for accessing various toolbars. The current > > toolbars that exist right now are: > > > >- Toolbar >

[chromium-dev] Re: Is it possible to customize CXXFLAGS and CFLAGS when generating make file or invoking make?

2009-09-22 Thread James Su
Thanks, I'll try. James Su 2009/9/22 Dan Kegel > On Tue, Sep 22, 2009 at 12:07 AM, James Su wrote: > > I'd like to compile chromium with some special CFLAGS/CXXFLAGS, how can > I > > do? I'm using make build on 64bit Linux. > > Yes, e.g. creat

[chromium-dev] Is it possible to customize CXXFLAGS and CFLAGS when generating make file or invoking make?

2009-09-22 Thread James Su
Hi, I'd like to compile chromium with some special CFLAGS/CXXFLAGS, how can I do? I'm using make build on 64bit Linux. Regards James Su --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email o

[chromium-dev] Re: Is there any good tool on Linux to browser and cross reference chromium source code?

2009-09-16 Thread James Su
I just found DXR <http://dxr.proximity.on.ca/dxr/index.html>, which is awesome. Might be worth to have a try. Regards James Su 2009/9/17 Evan Martin > I'd like to set up a web-based code browser on chromium.org, but I > played around with a couple and wasn't too

[chromium-dev] Is there any good tool on Linux to browser and cross reference chromium source code?

2009-09-15 Thread James Su
Hi, I'm currently using cscope + vim, but it's so slow and hard to use. Is there any better choice? Regards James Su --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or u

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread James Su
/logs/stdio The EscapeToDefaultMatch is expected to fail, because I haven't submit the CL to fix this issue yet. Them I'm wondering if it's still true that trybot doesn't support such kind of interactive tests? Regards James Su 2009/9/11 James Su > Good news. I&#

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread James Su
Good news. I'll try it tomorrow. Will interactive_ui_tests runs on trybot (maybe in the future) ? Regards James Su 2009/9/11 Jay Campan > > Oh, I found it. So I'm wondering why not just move browser_focus_uitest > into > > browser_tests? Is it because the trybot limi

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread James Su
Oh, I found it. So I'm wondering why not just move browser_focus_uitest into browser_tests? Is it because the trybot limitation (no active desktop)? If it's the case, then what should I do for my test? Moving it into interactive_ui_tests is apparently not a right solution. Regards James

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread James Su
tween browser_focus_uitest and my test in simulating key events. Regards James Su 2009/9/10 Scott Violet > To add to what Eric says this is part of the reason for the > interactive ui tests. Interactive ui tests run logged in so that you > can generate key/mouse events and have ever

[chromium-dev] What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread James Su
ontents::DidNavigate [0x1062DF98+248] (c:\chromium\src\chrome\browser\tab_contents\tab_contents.cc:1953) RenderViewHost::OnMsgNavigate [0x105710EB+459] (c:\chromium\src\chrome\browser\renderer_host\render_view_host.cc:955) ... Is it a bug of chrome or something

[chromium-dev] Windows trybot issue.

2009-09-09 Thread James Su
) sync_integration_tests - 1 error(s), 0 warning(s) 1 build system warning(s): - PDB instance limit is enabled -- Done -- Build: 219 succeeded, 1 failed, 0 skippedprogram finished with exit code 1 Regards James Su

[chromium-dev] Is it possible to download the binary built by trybot?

2009-09-01 Thread James Su
Hi, I'm currently working on a CL to add some ui tests which are supposed to run without problem on both Linux and Window, but it failed on windows trybot. I'm currently have no Windows machine to build the windows binary. So I'm wondering if there is any way to download the binary built by trybo

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread James Su
Oh yes, you are right. So it might be safe to remove selectAll(). Regards James Su 2009/8/14 Marshall Greenblatt > On Thu, Aug 13, 2009 at 1:07 PM, Darin Fisher wrote: > >> Hmm... take a look at EditorCommands.cpp. The executeSelectAll method >> just calls frame->s

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread James Su
If I understand correctly, selectAll() and executeCommand("SelectAll") are different. The first one selects all text in the frame, while the second one selects all text in an editor (input box). Regards James Su 2009/8/14 Darin Fisher > Yeah, I agree. Those are problems. Howeve

[chromium-dev] Re: I'm setting up my chromium account.

2009-08-03 Thread James Su
Thanks for your suggestion. I just followed the second approach. Regards James Su 2009/8/4 Mohamed Mansour > Hi, > If your source contents don't change, you can just copy the gcl_info > directory (chrome\src\.svn\gcl_info) and it will keep the change lists > intact. > >

[chromium-dev] I'm setting up my chromium account.

2009-08-03 Thread James Su
Hi, I'm so happy that I just got my chromium account, and going to rebuild my local source tree with writable svn repository. But I have some pending CLs in my old readonly source tree, so I'm wondering is it possible to migrate those CLs to a new source tree? Regard

[chromium-dev] Error building chromium revision 22144.

2009-08-03 Thread James Su
s/Script/SConscript.py", line 259: exec _file_ in call_stack[-1].globals File "/usr/local/google/home/suzhe/chrome/src/skia/skia.scons", line 246: config = configurations[env['CONFIG_NAME']] Regards James Su --~--~-~--~~~---~--~~ Chromiu