[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux

2009-07-30 Thread Evan Martin
We build on a recent Fedora and Ubuntu in an attempt to find compile errors between gcc versions, but the bots frequently are red. Still suspect we should turn off -Werror unless gcc_version == known_version_used_by_developers http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Ch

[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux

2009-07-30 Thread Dan Kegel
That's the third such cl I've seen. Conclusion: tiny fixes like that should be committed as tbr to avoid duplication of effort. On Jul 30, 2009 12:44 PM, "Wan-Teh Chang" wrote: On Thu, Jul 30, 2009 at 12:13 PM, LivioSoares wrote: > > > Hi, > > I'm running... Thanks a lot for the patch. I thi

[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux

2009-07-30 Thread Wan-Teh Chang
On Thu, Jul 30, 2009 at 12:13 PM, LivioSoares wrote: > > >  Hi, > >  I'm running Debian, with GCC 4.3.3 and am current getting a > compilation error while compiling Chromium: > > cc1plus: warnings being treated as errors > chromium/src/net/base/net_util.cc: In function > 'bool::IsIDNComponentSafe(